D26749: WIP: Support NDK r20 and Qt 5.14

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Seems ready to land to me. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol,

D26749: WIP: Support NDK r20 and Qt 5.14

apol added inline comments. INLINE COMMENTS > vkrause wrote in Android.cmake:173 > I actually didn't test 64bit ARM here, only armv7 and x86, both work. What > does break for you there? I'm not sure what was going on, seems to work now. REPOSITORY R240 Extra CMake Modules BRANCH master

D25315: KDirModel: implement showing a root node for the requested URL

rrosch added a comment. Crash: kf5.kio.kdirmodel: Items emitted in directory QUrl("file:///home/myuser/") but that directory isn't in KDirModel! Root directory: QUrl("file:///home/myuser/") KCrash: Application 'konqueror' crashing... This happens right after pressing F9 to

D26211: Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 76705. ahmadsamir added a comment. - Move the QRegularExpression definition out of the for loop, more efficient as it'll reused - match() always allocates a QRegularExpressionMatch anyway, so move it inside the while loop - Make the first ()

D26211: Port QRegExp to QRegularExpression

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Actually, one can re-use this regex for all files by moving it before the scope of the loop, or? The match on the other side is allocated per match() call, I would just move

D27693: Add syntax highlighting for Java Properties

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for this addition and the MIT licensing! REPOSITORY R216 Syntax Highlighting BRANCH add-java-properties REVISION DETAIL https://phabricator.kde.org/D27693 To: nibags,

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0daf938b0660: TypeScript: add private fields and type-only imports/exports, and some fixes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D27693: Add syntax highlighting for Java Properties

This revision was automatically updated to reflect the committed changes. Closed by commit R216:4a0a0e56cd86: Add syntax highlighting for Java Properties (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, let's merge this. Thanks for all the work on that! REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D27692 To:

D25315: KDirModel: implement showing a root node for the requested URL

dfaure updated this revision to Diff 76701. dfaure retitled this revision from "KDirModel: implement showing "/" as a root node, optionally" to "KDirModel: implement showing a root node for the requested URL". dfaure edited the summary of this revision. dfaure removed a subscriber: rrosch.

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27692 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh,

D27741: KCodecs: Convert license statements to SPDX expressions

cordlandwehr retitled this revision from "Convert license statements to SPDX expressions" to "KCodecs: Convert license statements to SPDX expressions". REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D27741 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack,

D27738: KCoreAddons: Convert license statements to SPDX expressions

cordlandwehr retitled this revision from "Convert license statements to SPDX expressions" to "KCoreAddons: Convert license statements to SPDX expressions". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27738 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n,

D27742: Solid: Convert license headers to SPDX expressions

cordlandwehr retitled this revision from "Convert license headers to SPDX expressions" to "Solid: Convert license headers to SPDX expressions". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27742 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27742: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as required by REUSE specification.

D27742: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27742 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D27741 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27741: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX expressions and add license files as required by REUSE specification.

D25123: New yakuake logo/icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0a5c9abac1ff: New yakuake logo/icon (authored by mglb, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25123?vs=75148=76687 REVISION

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 153 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/153/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 29 Feb 2020 15:28:41 + Build duration: 2 min 34 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 261 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/261/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 29 Feb 2020 15:28:41 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 147 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/147/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 29 Feb 2020 15:28:40 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT

D25123: New yakuake logo/icon

ngraham added a task: T10243: Some KDE applications could use better icons. REPOSITORY R266 Breeze Icons BRANCH yakuake REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein, ndavis, mweepigeon Cc: mweepigeon, davidre, GB_2, ndavis, ognarb, ngraham, hein,

D25123: New yakuake logo/icon

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH yakuake REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein, ndavis, mweepigeon Cc: mweepigeon, davidre, GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, numerodix,

D25123: New yakuake logo/icon

mweepigeon accepted this revision. mweepigeon added a comment. Looks great to me! REPOSITORY R266 Breeze Icons BRANCH yakuake REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein, ndavis, mweepigeon Cc: mweepigeon, davidre, GB_2, ndavis, ognarb, ngraham,

D25123: New yakuake logo/icon

ngraham added a comment. @mglb ping REPOSITORY R266 Breeze Icons BRANCH yakuake REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake, hein, ndavis Cc: davidre, GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, numerodix, vmarinescu, ryanmccoskrie,

D25315: KDirModel: implement showing "/" as a root node, optionally

dfaure added a comment. In D25315#619727 , @rrosch wrote: > > Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL. > > KDirModel takes care of that. > > Ah ok,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 443 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/443/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 29 Feb 2020 14:10:39 + Build duration: 15 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 318 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/318/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 29 Feb 2020 14:10:39 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 309 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/309/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 29 Feb 2020 14:10:39 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27731 To: dfaure, apol, ahmadsamir, meven, rrosch Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27528: Adapt action numbering in Android to work like in KNotifications

cacahueto added a comment. I have tried all the suggested commands, none of them worked. I opened a new merge request where everything is correct: https://phabricator.kde.org/D27740 Can you delete this merge request or tell me how I can do it? Sorry for the questions, but I have

D27740: Adapt action numbering in Android to work like in KNotifications

cacahueto created this revision. cacahueto added reviewers: Frameworks, nicolasfella, vkrause. Herald added a project: Frameworks. cacahueto requested review of this revision. REVISION SUMMARY KNotifications assigns the ID 0 to the default action on a notification (the one when the

D27528: Adapt action numbering in Android to work like in KNotifications

cacahueto updated this revision to Diff 76684. cacahueto added a comment. Adapt action numbering in Android to work like in KNotifications Summary: KNotifications assigns the ID 0 to the default action on a notification (the one when the notification itself is selected). Additional

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir updated this revision to Diff 76682. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Tweak commit message REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27735?vs=76671=76682 BRANCH l-font-sytleName (branched from

D27738: Convert license statements to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D27738 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27738: Convert license statements to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX expressions and add license files as required by REUSE specification.

D27640: templates: Convert license statements to SPDX headers

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a08449a9a2cb: templates: Convert license statements to SPDX headers (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Wow that Qt bug report has really extensive investigation, very impressive. The fix looks ok to me (without being an expert on the topic, it does seem to match what that bug report is

D27640: templates: Convert license statements to SPDX headers

cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH templatesusespdxlicensestyle REVISION DETAIL https://phabricator.kde.org/D27640 To: kossebau, #plasma, cordlandwehr Cc: kde-frameworks-devel, LeGast00n,

D27640: templates: Convert license statements to SPDX headers

kossebau marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27640 To: kossebau, #plasma, cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

kossebau updated this revision to Diff 76679. kossebau added a comment. Update license keys to what KAboutLicense currently supports REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27640?vs=76343=76679 BRANCH

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. Caveat: setting the general font to e.g. "Noto Sans" and then restarting the fonts KCM; opening the general font selection dialog, "Semi condensed" is selected instead of Regular. That looks like a bug in the static method nearestExistingFont() from

D27640: templates: Convert license statements to SPDX headers

kossebau added a comment. In D27640#619817 , @cordlandwehr wrote: > My only question is, how is the X-KDE-PluginInfo-License value is evaluated? Are we free to write any value? Or do we have to extend some mechanism? I would be great to also

D27243: KQuickCharts: Convert license headers to SPDX statements

This revision was automatically updated to reflect the committed changes. Closed by commit R1049:b294f7fb337e: KQuickCharts: Convert license headers to SPDX statements (authored by cordlandwehr). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. So, how to move forward with this change? The two open discussion points are: - How to handle COPYING files? --> IMO this is a general question that I want to address in a global change when we updated all the license headers. For this I created a task to

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. Konsole's workaroun: https://phabricator.kde.org/R319:41693fe9ee263f8f2281852a740ee52d55f003ef KTextEditor workaround: https://phabricator.kde.org/R39:4d91fa7e918d983e6569798dfe20c7c9faf4bb9e REPOSITORY R237 KConfig REVISION DETAIL

D27601: KConfig: Convert to SPDX license statements

cordlandwehr marked 3 inline comments as done. cordlandwehr added a comment. Reverted license change for the XSD file. Right now I do not see any equivalent in the SPDX registry. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27601 To: cordlandwehr Cc: ognarb,

D27601: KConfig: Convert to SPDX license statements

cordlandwehr updated this revision to Diff 76675. cordlandwehr added a comment. Reverting DTD license change REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27601?vs=76403=76675 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27601 AFFECTED

D25517: Add an option to extract image data and add front cover property

astippich added a comment. Ping! At least a reply would be nice REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D27640: templates: Convert license statements to SPDX headers

cordlandwehr added a comment. Looks good to me and I agree that it is a good idea to consistently license everything as LGPL-2.1-or-later. My only question is, how is the X-KDE-PluginInfo-License value is evaluated? Are we free to write any value? Or do we have to extend some mechanism? I

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir added a comment. Some relevant info: https://bugreports.qt.io/browse/QTBUG-63792?focusedCommentId=377225=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-377225 https://codereview.qt-project.org/c/qt/qtbase/+/181645/ REPOSITORY R237 KConfig REVISION

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, davidedmundson, cfeck, ervin. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If the styleName property is set for a QFont, using setBold(true) would lead to Qt

D26342: Allow overriding to disable auto language detection

mludwig added a comment. In D26342#619785 , @aacid wrote: > without having used Sonnet much, this seems the wrong API to me. > > Are you saying that it can happen that you tell Sonnet "use this language" and it goes and say "nah i'll ignore

D26342: Allow overriding to disable auto language detection

aacid added a comment. without having used Sonnet much, this seems the wrong API to me. Are you saying that it can happen that you tell Sonnet "use this language" and it goes and say "nah i'll ignore you and do my thing". It seems to me that what would make sense is that the "use