D29201: KCMUtils: Add option to append service file to list of arguments

alex added a comment. > Would it make sense to always pass it? Would it regress in any way? It would make sense, but it would change the existing behavior. If you use the method setConfigurationArguments then you expect your argument list to be the list of arguments you specified + an

D29223: Update Taiwanese holidays

nhiga added a comment. Some historical arrangements of some holidays (e.g. Children's Day between 1998-2010) are currently ignored, but I believe this is less important. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim,

D29223: Update Taiwanese holidays

nhiga marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause,

D29223: Update Taiwanese holidays

nhiga updated this revision to Diff 81833. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29223?vs=81321=81833 REVISION DETAIL https://phabricator.kde.org/D29223 AFFECTED FILES holidays/holidays.qrc holidays/plan2/holiday_tw_zh holidays/plan2/holiday_tw_zh-tw To: nhiga,

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. This will make our configure steps readable again. Thanks! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29396 To: xuetianweng,

D29223: Update Taiwanese holidays

weisi added a comment. Thanks! Looks good :) REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh, ngraham, bruns,

D29223: Update Taiwanese holidays

nhiga added a comment. > On the Spring festival 春節 of 2020, the publicholidays.tw page and the official source listed on that page both showed Jan 23 to 29 as the days off. I think both of us can be correct: - I referred to this document by Ministry of the Interior, R. O. C.

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

xuetianweng created this revision. xuetianweng added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. xuetianweng requested review of this revision. REVISION SUMMARY cmake introduced a new

D29201: KCMUtils: Add option to append service file to list of arguments

apol added a comment. I have the feeling there's a missing piece here. Would it make sense to always pass it? Would it regress in any way? At the very least, on the API documentation, explain why one would want that. REPOSITORY R295 KCMUtils REVISION DETAIL

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure updated this revision to Diff 81830. dfaure marked an inline comment as done. dfaure added a comment. Multiple fixes thanks to review comments; didn't remove the fast path yet (a unittest needs fixup) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure marked 2 inline comments as done. dfaure added inline comments. INLINE COMMENTS > broulik wrote in openurljob.cpp:261 > I know what you always say when I say what I always say, but why not just > always stat/mimetype job? LOL we're like an old couple, the explicit discussion doesn't

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? lol, turns out that

D29347: KAuthorized: export method to reload restrictions

mdawson added a comment. One suggestion for this change: Instead of exporting a method that takes no parameters and always loads from configuration file, why not make a new method with the implementation that takes in a given KConfigGroup. That way unit tests can pass in a KConfigGroup

D29390: Respect QIcon::fallbackSearchpaths()

kossebau added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > I just realized that function is private, not really easy to use :/ > > anyhow do you think we should remove svgz? > > Also i think using > > const QStringList extensions = { QStringLiteral(".png"), >

D29391: Introduce setWindow and CloseWhenWindowActivated

kossebau added inline comments. INLINE COMMENTS > knotification.h:582 > > +/** Sets the window associated with this notification. > + * This is relevant when using the CloseWhenWindowActivated flag. And some remarks from a local API docs pedant :) Please place the text not on the

D29390: Respect QIcon::fallbackSearchpaths()

aacid added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > Would it make sense trying to use QIconLoader::lookupFallbackIcon ? This way > we "upstream" Qt behaviour? For example you're supporting svgz while Qt > doesn't. Which would mean different

D29390: Respect QIcon::fallbackSearchpaths()

aacid added inline comments. INLINE COMMENTS > kiconloader.cpp:1142 > +for (const QString : fallbackPaths) { > +const QStringList extensions = QStringList() << > QStringLiteral(".png") << QStringLiteral(".svg") << QStringLiteral(".svgz") > << QStringLiteral(".xpm"); > +

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure added a comment. In D29385#662439 , @feverfew wrote: > Ahhh yes correct. Seeming as these jobs are now async (unlike KRun IIRC?), it isn't a problem that `resultingArguments` makes several blocking calls to the KIOFuse daemon?

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > Generally +1 > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? I'll

D29391: Introduce setWindow and CloseWhenWindowActivated

broulik added a comment. Generally +1 The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? Not a fan of the timer. Also, we might want to deprecate the `QWidget` one now? REPOSITORY R289

D29021: Remove checks for notification service and fallback to KPassivePopup

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a5f0b1f7c812: Remove checks for notification service and fallback to KPassivePopup (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a replacement for CloseOnWidgetActivated that

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

feverfew added a comment. In D29385#662435 , @dfaure wrote: > In D29385#662422 , @feverfew wrote: > > > Quick question, how does this affect D23384 ? Previously

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi added a comment. I agree with the general idea in D29223 and feel D29223 is in a better shape than this diff. However, I think some festivals referred to in this diff (not mentioned in the law - 紀念日及節日實施辦法

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure added a comment. In D29385#662422 , @feverfew wrote: > Quick question, how does this affect D23384 ? Previously KRun used KIO::DesktopExecParser::resultingArguments() which handled the conversion of

D29223: Update Taiwanese holidays

weisi added a comment. I prefer this diff to the changes I took in D29373 . I wish I had seen this diff earlier. Would you also indicate the plan for the festivals specified as "2020" in this diff for future years? For example, could you add the 2021

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

feverfew added a comment. Quick question, how does this affect D23384 ? Previously KRun used KIO::DesktopExecParser::resultingArguments() which handled the conversion of URLs to local KIOFuse URLs if needed, but now I believe this new API doesn't?

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella created this revision. nicolasfella added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When an icon isn't found within a theme we are supposed to

D29372: Taiwan: Use "zh_TW" language code

weisi added a comment. I think the approach in D29223 (renaming the file also) is more preferred. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: nhiga, cgiboudeaux, kde-frameworks-devel,

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

broulik added inline comments. INLINE COMMENTS > broulik wrote in openurljob.cpp:274 > I know what you always say when I say what I always say but can we use a > mimetype job here? :) Seems I forgot to remove this when I added the comment above instead :) REPOSITORY R241 KIO REVISION

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

broulik added a comment. Cool! INLINE COMMENTS > openurljob.cpp:261 > + > +void KIO::OpenUrlJobPrivate::determineLocalMimeType() > +{ I know what you always say when I say what I always say, but why not just always stat/mimetype job? > openurljob.cpp:274 > +QMimeDatabase db; > +

Re: Adding a patch to 5.70

Thank you, David! On Sun, May 3, 2020 at 7:08 PM David Faure wrote: > On Sunday, May 3, 2020 6:31:44 PM CEST Filip Fila wrote: > > Dear Frameworks maintainers, > > > > Would it be possible to add this (https://phabricator.kde.org/D29352) > patch > > to the 5.70 release? > > > > The change

Re: Adding a patch to 5.70

Thanks everyone! Nate On 5/3/20 11:08 AM, David Faure wrote: On Sunday, May 3, 2020 6:31:44 PM CEST Filip Fila wrote: Dear Frameworks maintainers, Would it be possible to add this (https://phabricator.kde.org/D29352) patch to the 5.70 release? The change concerns not breaking third-party

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure updated this revision to Diff 81814. dfaure marked 2 inline comments as done. dfaure added a comment. Adjusments based on Friedrich's initial review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29385?vs=81802=81814 BRANCH 2020_05_openurljob

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure marked 5 inline comments as done. dfaure added a comment. In D29385#662336 , @svuorela wrote: > I've been looking at it for a while, and after trying to decipher the long lambdas, which might have been better as named functions, I think

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz, davidedmundson Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

svuorela added a comment. I've been looking at it for a while, and after trying to decipher the long lambdas, which might have been better as named functions, I think it is, beside Kossebau's comments, fine. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29385 To:

Re: Adding a patch to 5.70

On Sunday, May 3, 2020 6:31:44 PM CEST Filip Fila wrote: > Dear Frameworks maintainers, > > Would it be possible to add this (https://phabricator.kde.org/D29352) patch > to the 5.70 release? > > The change concerns not breaking third-party Plasma themes, and as Nate > explained "If this doesn't

Adding a patch to 5.70

Dear Frameworks maintainers, Would it be possible to add this (https://phabricator.kde.org/D29352) patch to the 5.70 release? The change concerns not breaking third-party Plasma themes, and as Nate explained "If this doesn't land in Frameworks 5.70, Plasma 5.19 users run the risk of being hit by

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b1018e68703: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme (authored by filipf). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

ngraham accepted this revision. ngraham added a comment. If this doesn't land in Frameworks 5.70, Plasma 5.19 users run the risk of being hit by it, as 5.70 is the frameworks dependency for that Plasma release. Frameworks 5.70 just got tagged, so once this lands, it will need to be

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skip caching thumbnails on encrypted filesystems

thiago added inline comments. INLINE COMMENTS > thumbnail.cpp:743 > +const auto mount = mountsList.findByPath(filePath); > +allowCache = !(mount->mountType() == > QLatin1String("fuse.cryfs") || mount->mountType() == > QLatin1String("fuse.encfs")); > +

D29197: filenamesearch: Implement stat to display metainfo

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D29197 To: meven, #dolphin, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, azyx,

D26342: Allow overriding to disable auto language detection

This revision was automatically updated to reflect the committed changes. Closed by commit R246:422fac8a6f92: Allow overriding to disable auto language detection (authored by sdepiets, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26342?vs=81177=81805#toc

D26342: Allow overriding to disable auto language detection

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Noone seems to really disagree. Let's merge it. @sdepiets I hope this doesn't break everything ;) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

kossebau added a comment. Quick first nitpicks from initial scan what this patch is about, without having looked closer. INLINE COMMENTS > openurljobtest.cpp:108 > +{ > +std::for_each(m_filesToRemove.begin(), m_filesToRemove.end(), [](const > QString & f) { > +QFile::remove(f);

D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D29361 To: dfaure, kossebau, davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure created this revision. dfaure added reviewers: ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY - KRun::runUrl()

D29201: KCMUtils: Add option to append service file to list of arguments

alex added a dependent revision: D29384: KCM Runners: Use setAppendServiceFile method for plugin selector. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

jriddell added a comment. thanks :) REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

alex updated this revision to Diff 81799. alex added a comment. Little typo :-) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81798=81799 BRANCH service_path_append (branched from master) REVISION DETAIL https://phabricator.kde.org/D29201

D29201: KCMUtils: Add option to append service file to list of arguments

alex updated this revision to Diff 81798. alex added a comment. Rename method REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81239=81798 BRANCH service_path_append (branched from master) REVISION DETAIL https://phabricator.kde.org/D29201

D29372: Taiwan: Use "zh_TW" language code

nhiga added a comment. I would say that the file should also be renamed. //My comment from D29223 :// > The new file name follows the same naming scheme used by the PRC (mainland China) holiday file, holiday_cn_zh-cn

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

nhiga added a comment. > specified the start year of Peace Memorial Day 228和平紀念日 Great! This is what I have missed in my patch. > The star * ones are specified using the "lunar new year date" minus/plus some days, hoping to make it easier to adapt to additional years in the future.

D29369: Use UI marker context in more tr() calls

aacid added a comment. +0.5 REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29369 To: kossebau, #frameworks, #localization Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29369: Use UI marker context in more tr() calls

kossebau added inline comments. INLINE COMMENTS > aacid wrote in kbookmarkmenu.cpp:288 > @title:inmenu? Nope, this is a normal action/menu entry, the variable name is misleading here a bit. See below e.g. for the slot added. REPOSITORY R294 KBookmarks REVISION DETAIL

D29370: Use UI marker context in more tr() calls

aacid added a comment. +0.5 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29370 To: kossebau, #frameworks, #localization, broulik Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29369: Use UI marker context in more tr() calls

aacid added inline comments. INLINE COMMENTS > kbookmarkmenu.cpp:288 > > -QString title = tr("Open Folder in Tabs"); > +const QString title = tr("Open Folder in Tabs", "@action:inmenu"); > @title:inmenu? REPOSITORY R294 KBookmarks REVISION DETAIL

D29368: Use UI marker context in more tr() calls

aacid added a comment. +0.5 REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D29368 To: kossebau, #frameworks, #localization Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29367: Use UI marker context in more tr() calls

aacid added a comment. +0.5 REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D29367 To: kossebau, #frameworks, #localization, davidedmundson Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 03 May 2020 13:16:35 + Build duration: 4 min 2 sec and counting JUnit Tests

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 03 May 2020 13:11:00 + Build duration: 4 min 15 sec and counting JUnit Tests

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

nhiga added a reviewer: cgiboudeaux. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29373 To: weisi, winterz, cgiboudeaux Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29223: Update Taiwanese holidays

nhiga added a comment. @cgiboudeaux Thanks for the heads-up. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, dcaliste, michaelh,

D29347: KAuthorized: export method to reload restrictions

dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kauthorized.cpp:247 > Please also add a note next to this that it is for unit test, so people are > not wondering about this random KCONFIGCORE_EXPORT and first have to research > commit history. Good idea, done:

D29347: KAuthorized: export method to reload restrictions

kossebau added inline comments. INLINE COMMENTS > kauthorized.cpp:247 > > -static void initUrlActionRestrictions() > +KCONFIGCORE_EXPORT void reloadUrlActionRestrictions() > { Please also add a note next to this that it is for unit test, so people are not wondering about this random

D29347: KAuthorized: export method to reload restrictions

dfaure closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29381: Thumbnail text: use libmagic to detect encoding

pino added a comment. why not KEncodingProber from the KCodecs framework, like also the commented bits hint about? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29381 To: meven, #frameworks, sitter, ngraham Cc: pino, kde-frameworks-devel, kfm-devel, azyx,

D29198: filenamesearch:/ define a title for the query

This revision was automatically updated to reflect the committed changes. Closed by commit R318:e076d8668f67: filenamesearch:/ define a title for the query (authored by meven). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29198?vs=81330=81788 REVISION

D29197: filenamesearch: Implement stat to display metainfo

meven added a comment. This is a small review REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29197 To: meven, #dolphin, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29197: filenamesearch: Implement stat to display metainfo

meven added a comment. Please review REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29197 To: meven, #dolphin, #frameworks, ngraham, elvisangelaccio Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29381: Thumbnail text: use libmagic to detect encoding

meven created this revision. meven added reviewers: Frameworks, sitter, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY libmagic is the libraray used in `file` utility to

D29201: KCMUtils: Add option to append service file to list of arguments

alex edited the summary of this revision. alex added reviewers: meven, broulik. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29347: KAuthorized: export method to reload restrictions

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. a, for using in a different repo, ok. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc:

D29372: Taiwan: Use "zh_TW" language code

cgiboudeaux added a comment. D29223 addresses the issue and needs review REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. @nhiga Please have a look at D29372 . REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack,

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

dfaure added a comment. `src/kmainwindow_p.h:59:QEventLoopLocker locker;` so the refcounting effect is the same as documented, just with a different "backend". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks,

D28745: Skip caching thumbnails on encrypted filesystems

meven requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel,

D28745: Skip caching thumbnails on encrypted filesystems

meven added inline comments. INLINE COMMENTS > thumbnail.cpp:738 > +#else > +allowCache = false; > +#endif There is an error with the previous line, one of the two should be allowDirCached I think. Here you always ignore result of `sharesFilesystemWithThumbRoot` >