D28221: Don't write default value to configuration file when default value came from /etc/* file

bport updated this revision to Diff 82612. bport added a comment. Simplify the patch and adapt unittest I expected revertToDefault to revert either to cpp defined default or default from global file, but concept behind is to revert only for cpp based default. REPOSITORY R237 KConfig

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport planned changes to this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. In D28221#657482 , @dfaure wrote: > Ah! Now it actually makes sense to me. If we are changing what revertToDefault() does, then it makes sense to change the if() condition for calling it. Basically, now that it does the

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport updated this revision to Diff 82028. bport added a comment. - Fix comments - Ensure we don't have problem if we set value to "defaultcpp" and a global setting override it Regarding other comments: - I guess you mean if (mDefault == mReference) { with if (value ==

D29231: Add keyboard_shortcuts_inhibit protocol

bport abandoned this revision. bport added a comment. Follow up on gitlab https://invent.kde.org/kde/kwayland-server/-/merge_requests/1 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: romangg, crossi,

Re: changing icon sizes no longer emits signal

:emitChange is deeply nested in KDE4 compat stuff, > with possible exit paths before. > > A patch like the one attached seems to help, but someone who knows the KCM > better (or has time to dig) should make this conditional on the user > actually changing icon sizes, and only emit for the groups that have > changed. Solved by this one in theory, if you can confirm. https://phabricator.kde.org/D29285 -- Benjamin Port - enioka Haute Couture 06 38 83 18 16

D29231: Add keyboard_shortcuts_inhibit protocol

bport retitled this revision from "[WIP] Add keyboard_shortcuts_inhibit protocol" to "Add keyboard_shortcuts_inhibit protocol". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: romangg, crossi, kde-frameworks-devel,

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81491. bport added a comment. Simplify code arround QHash and QPair REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81386=81491 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81386. bport added a comment. fix qobject macro indentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81385=81386 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81385. bport added a comment. fix test, and take in consideration zzag feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81361=81385 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81361. bport added a comment. Use client not display for KeyboardShortcutsInhibitorInterface REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81358=81361 REVISION DETAIL https://phabricator.kde.org/D29231

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81358. bport marked an inline comment as done. bport added a comment. added const to wrong line REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81355=81358 REVISION DETAIL https://phabricator.kde.org/D29231

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

This revision was automatically updated to reflect the committed changes. Closed by commit R127:185f40195dc0: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order (authored by bport). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81355. bport added a comment. Cyril feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81351=81355 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES autotests/server/CMakeLists.txt

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport created this revision. bport added reviewers: zzag, davidedmundson, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Depends on D29054 . REPOSITORY

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport added a dependent revision: D29231: [WIP] Add keyboard_shortcuts_inhibit protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport updated this revision to Diff 80901. bport added a comment. Add missing const ref and fix coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29054?vs=80887=80901 REVISION DETAIL https://phabricator.kde.org/D29054 AFFECTED FILES

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport updated this revision to Diff 80887. bport added a comment. Increase protocol version and use const ref for QVector parameter REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29054?vs=80784=80887 REVISION DETAIL https://phabricator.kde.org/D29054

D28460: Add KCModuleData as base class for plugin

bport retitled this revision from "Add KCModuleDada as base class for plugin" to "Add KCModuleData as base class for plugin". REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: broulik, kde-frameworks-devel, LeGast00n, cblack,

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport updated this revision to Diff 80784. bport marked 4 inline comments as done. bport added a comment. - Send stack order on bind - Check ressource have good protocol version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29054?vs=80772=80784

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport added a dependent revision: D29056: [libtaskmanager] add stacking order data for wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

bport created this revision. bport added reviewers: zzag, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 AFFECTED FILES

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. Indeed probably need to update configuration too. Not sure why we didn't allow to track default value from file in the past by the way. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc:

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport updated this revision to Diff 80624. bport added a comment. Add KConfig unittest REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28221?vs=78862=80624 REVISION DETAIL https://phabricator.kde.org/D28221 AFFECTED FILES

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. Ok I will add a kconfig test REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

This revision was automatically updated to reflect the committed changes. Closed by commit R237:be28e096c533: Add force save behavior to KEntryMap (authored by bport). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=78861=80383 REVISION DETAIL

D28460: Add KCModuleDada as base class for plugin

bport retitled this revision from "Add KCModuleStateProbe as base class for plugin" to "Add KCModuleDada as base class for plugin". bport edited the summary of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: broulik,

D28460: Add KCModuleStateProbe as base class for plugin

bport updated this revision to Diff 79780. bport added a comment. Rename state probe to data (because can be useful for more than only state probe) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28460?vs=79772=79780 REVISION DETAIL

D28460: Add KCModuleStateProbe as base class for plugin

bport marked 10 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28460: Add KCModuleStateProbe as base class for plugin

bport updated this revision to Diff 79772. bport added a comment. ervin feedback REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28460?vs=79496=79772 REVISION DETAIL https://phabricator.kde.org/D28460 AFFECTED FILES src/CMakeLists.txt

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

bport accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-monospace-checkbox REVISION DETAIL https://phabricator.kde.org/D28274 To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport Cc: kde-frameworks-devel, LeGast00n,

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. In D28221#641971 , @dfaure wrote: > I have a hard time accepting that the documentation was wrong -- and if it was, then this commit has to fix it, and port as much of the app code that does exactly this, as possible.

D28460: Add KCModuleStateProbe as base class for plugin

bport updated this revision to Diff 79496. bport added a comment. Take in consideration feedbacks REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28460?vs=78969=79496 REVISION DETAIL https://phabricator.kde.org/D28460 AFFECTED FILES

D28460: Add KCModuleStateProbe as base class for plugin

bport added a dependent revision: D28461: In sidebar mode show if a module is in default state or not. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28460: Add KCModuleStateProbe as base class for plugin

bport created this revision. bport added reviewers: Plasma, ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY This class will allow to get state of a module without loading the UI. REPOSITORY

D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfontchooser.cpp:347 > > // Completed the font attributes grid > This comment is still valid ? > kfontchooser.cpp:381 > +if (flags &

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport added a comment. > !hasDefault() checks [system config files] and therefore should stay. Otherwise, when the situation is C++=1 system=2 and value to be written is 1 you'll revert() i.e. not write anything and then re-read 2, oops. > Sounds like you should add a unittest for this

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78861. bport marked 3 inline comments as done. bport added a comment. Take in consideration ervin feedback REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=78503=78861 REVISION DETAIL

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport updated this revision to Diff 78862. bport added a comment. Take in consideration dfaure and ervin feedback REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28221?vs=78292=78862 REVISION DETAIL https://phabricator.kde.org/D28221 AFFECTED FILES

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78503. bport added a comment. Take in consideration dfaure feedback. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=78432=78503 REVISION DETAIL https://phabricator.kde.org/D28128 AFFECTED FILES

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78432. bport added a comment. - fix when entry is a string (entry=) lead to empty string not fallback to default value - can't find a way to use bReverted / bDeleted without bForceSave because bReverted is set when we call revertEntry and at this time we

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport planned changes to this revision. bport added a comment. Change will be planed (firstly fix https://phabricator.kde.org/D28128) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D28128: Add force save behavior to KEntryMap

bport planned changes to this revision. bport added inline comments. INLINE COMMENTS > dfaure wrote in kconfigtest.cpp:1965 > This would pass no matter in which file the write happened, no, due to > caching? > Doesn't this need a generalLocal.reparseConfiguration() to be meaningful? yes indeed

D27502: Create ConfigView an unmanaged ConfigWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R246:12d1e200f081: Create ConfigView an unmanaged ConfigWidget (authored by bport). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=77269=78296 REVISION DETAIL

D28221: Don't write default value to configuration file when default value came from /etc/* file

bport created this revision. bport added reviewers: ervin, dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY This will allow administrator to change default value and be

D28128: Add force save behavior to KEntryMap

bport added a dependent revision: D28221: Don't write default value to configuration file when default value came from /etc/* file. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel,

D28128: Add force save behavior to KEntryMap

bport marked 2 inline comments as done. bport added a comment. Added a unittest REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

bport updated this revision to Diff 78289. bport added a comment. Add unit test REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28128?vs=77925=78289 REVISION DETAIL https://phabricator.kde.org/D28128 AFFECTED FILES autotests/kconfigtest.cpp

D28128: Add force save behavior to KEntryMap

bport created this revision. bport added reviewers: ervin, dfaure, meven, crossi, hchain. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Fix the following bug, if an entry is set on

D27840: Introduce SettingState* elements to ease KCM writing

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. From code POV this is ok, but neet to wait feedback from VDG to adapt state indicator REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi,

D27502: Create ConfigView an unmanaged ConfigWidget

bport updated this revision to Diff 77269. bport added a comment. rename check to skip and add missing negation for default REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=76517=77269 REVISION DETAIL https://phabricator.kde.org/D27502 AFFECTED

D27502: Create ConfigView an unmanaged ConfigWidget

bport updated this revision to Diff 76517. bport added a comment. rename check uppercase to skip uppercase REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=76384=76517 REVISION DETAIL https://phabricator.kde.org/D27502 AFFECTED FILES

D27502: Create ConfigView an unmanaged ConfigWidget

bport updated this revision to Diff 76384. bport added a comment. Rework, not expose anymore settings and loader but expose a new settings class REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=75997=76384 REVISION DETAIL

D27502: Create ConfigView an unmanaged ConfigWidget

bport added inline comments. INLINE COMMENTS > ervin wrote in settings.cpp:109 > This is an odd bit of logic, isn't it? Yes indeed, but what we want is to save false if checked and true if not checked. I moved the logic there in order to work with kconfigxt and with current implementation >

D27463: KconfigXT: Add a value attribute to Enum field choices

bport added inline comments. INLINE COMMENTS > KConfigXmlParser.cpp:203 > } > +else if (choice.name.contains(QLatin1Char(' '))) { > +std::cerr << "Tag attribute 'name' cannot contain a > space. You can use attribute 'value' to pass any string as the choice value."

D27502: Create ConfigView an unmanaged ConfigWidget

bport added a dependent revision: D27503: [KCM Spellchecking] port to KPropertySkeletonItem. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

bport created this revision. bport added reviewers: Plasma, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY - Allow to manage controller externally - Compatible (for checkbox)

D27497: Fix code generation for entries with min/max

bport added inline comments. INLINE COMMENTS > test_param_minmax.kcfg:17 > + > \ No newline at end of file Add a new line > test_param_minmax.kcfgc:4 > +Mutators=true > \ No newline at end of file add a new line > test_param_minmax_main.cpp:28 > +return 0; > +} Missing new line at end

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

bport created this revision. bport added reviewers: Plasma, davidedmundson, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Currently from David Edmundson comment on

D27342: Add setNotifyFunction to KPropertySkeletonItem

This revision was automatically updated to reflect the committed changes. Closed by commit R237:059a4feee45b: Add setNotifyFunction to KPropertySkeletonItem (authored by bport). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27342?vs=75540=75542 REVISION

D27342: Add setNotifyFunction to KPropertySkeletonItem

bport marked 2 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27342 To: bport, ervin, meven, crossi Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27342: Add setNotifyFunction to KPropertySkeletonItem

bport updated this revision to Diff 75540. bport added a comment. Fix doc REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27342?vs=75535=75540 REVISION DETAIL https://phabricator.kde.org/D27342 AFFECTED FILES src/core/kcoreconfigskeleton.cpp

D27342: Add setNotifyFunction to KPropertySkeletonItem

bport created this revision. bport added reviewers: ervin, meven, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY This function will be called when the property value change REPOSITORY R237

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

bport accepted this revision. bport added inline comments. INLINE COMMENTS > bport wrote in managedconfigmodule.cpp:145-146 > Those calls are done for each skeleton perhaps we can do only one call registerSettings is not on the hot path, so it will be ok REPOSITORY R296 KDeclarative

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

bport added inline comments. INLINE COMMENTS > managedconfigmodule.cpp:145-146 > + > +auto settingsChangedSlotIndex = > metaObject()->indexOfMethod("settingsChanged()"); > +auto settingsChangedSlot = > metaObject()->method(settingsChangedSlotIndex); > + Those calls are done for each

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

bport accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D26046 To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R296:cacff0a30bc8: Allow to use KPropertySkeletonItem in ManagedConfigModule (authored by bport). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

bport updated this revision to Diff 74980. bport added a comment. cleanup REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27132?vs=74979=74980 REVISION DETAIL https://phabricator.kde.org/D27132 AFFECTED FILES

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

bport updated this revision to Diff 74979. bport added a comment. Don't cast twice if not needed REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27132?vs=74935=74979 REVISION DETAIL https://phabricator.kde.org/D27132 AFFECTED FILES

D27132: Allow to use KPropertySkeletonItem in ManagedConfigModule

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27132

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

This revision was automatically updated to reflect the committed changes. Closed by commit R293:71fb41ae9ae8: Migrate config from KConfig to KConfigXt in order to allow KCM to use it (authored by bport). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D26519: Show button respecting what is declared by KCModule

This revision was automatically updated to reflect the committed changes. Closed by commit R295:f52314e6cf19: Show button respecting what is declared by KCModule (authored by bport). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26519?vs=73045=73494

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

This revision was automatically updated to reflect the committed changes. Closed by commit R265:4dc3f18f1443: Fix KCMModule::setButtons documentation, if Apply is activated we also want to… (authored by bport). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D26519: Show button respecting what is declared by KCModule

bport updated this revision to Diff 73045. bport added a comment. Simplify code REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26519?vs=73042=73045 REVISION DETAIL https://phabricator.kde.org/D26519 AFFECTED FILES src/kcmultidialog.cpp To: bport,

D26519: Show button respecting what is declared by KCModule

bport added inline comments. INLINE COMMENTS > ervin wrote in kcmultidialog.cpp:217 > Well, I think I wouldn't temper with the setVisible of helpButton at all. > Just to keep the behavior in line with systemsettings and keep the old > behavior. This is not what this patch is supposed to change

D26519: Show button respecting what is declared by KCModule

bport created this revision. bport added reviewers: ervin, meven, crossi, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26519

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

bport created this revision. bport added reviewers: ervin, meven, crossi, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

This revision was automatically updated to reflect the committed changes. Closed by commit R237:e88f9309e5db: Fix API doc, usrSave is called from save not deprecated writeConfig (authored by bport). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26495: Fix API doc, usrSave is called from save not deprecated writeConfig

bport created this revision. bport added a reviewer: ervin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26495 AFFECTED FILES

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

This revision was automatically updated to reflect the committed changes. Closed by commit R295:6d6e2427f8e2: Update KPluginSelector to allow KCM to show good state for reset, apply and… (authored by bport). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport marked an inline comment as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport updated this revision to Diff 72909. bport added a comment. fix REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26400?vs=72908=72909 REVISION DETAIL https://phabricator.kde.org/D26400 AFFECTED FILES src/file/CMakeLists.txt

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport updated this revision to Diff 72908. bport added a comment. Take in consideration ervin feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26400?vs=72701=72908 REVISION DETAIL https://phabricator.kde.org/D26400 AFFECTED FILES

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport marked 9 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport updated this revision to Diff 72906. bport added a comment. Increment version signal was introduced and remove uneeded blank line REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26466?vs=72885=72906 REVISION DETAIL

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport added inline comments. INLINE COMMENTS > ervin wrote in kpluginselector.cpp:389 > This logic looks wrong to me. > > isChanged indicates if an entry state was changed during the course of the > call to defaults(). It's very possible it's false when getting out of the > loop. > If that's

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport added a dependent revision: D26467: KCM runners: fix default button. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26466: Update KPluginSelector to allow KCM to show good state for reset, apply and default button

bport created this revision. bport added reviewers: Plasma, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY - emit changed with good value to ensure reset button is activated

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport added a dependent revision: D26401: KCM Baloo: Migrate to KConfigXT and add immutability. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77,

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport added reviewers: ervin, crossi, meven, Plasma. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 To: bport, ervin, crossi, meven, #plasma Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

bport created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. bport requested review of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26400 AFFECTED FILES src/file/CMakeLists.txt

D26044: Set breeze as default theme when reading from configuration file

This revision was automatically updated to reflect the committed changes. Closed by commit R302:ed86f4f37c6b: Set breeze as default theme when reading from configuration file (authored by bport). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D26044: Set breeze as default theme when reading from configuration file

bport marked 2 inline comments as done. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26044 To: bport, #plasma, ervin, crossi Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

bport updated this revision to Diff 71955. bport added a comment. QString to QStringLiteral REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26044?vs=71671=71955 REVISION DETAIL https://phabricator.kde.org/D26044 AFFECTED FILES src/kiconloader.cpp

D26044: Set breeze as default theme when reading from configuration file

bport added a dependent revision: D24846: Port kcm icons to kconfigxt. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26044 To: bport, #plasma, ervin, crossi Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

bport created this revision. bport added reviewers: Plasma, ervin, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Icons KCM is moved to KConfigXT, default value is "breeze" and in that case

D25077: Use compile time checked connect

bport accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25077 To: ervin, #plasma, #frameworks, mart, davidedmundson, bport Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24821: Add ManagedConfigModule

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Ok for me, when David remarks are addressed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24821 To: ervin, #plasma, #frameworks, mart, bport Cc:

D24821: Add ManagedConfigModule

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > managedconfigmodule.cpp:96 > +{ > +return false; > +} Like above I think we need to set it to true > managedconfigmodule.h:210 > + * > + * By

  1   2   >