D25506: Remove Attica from KAboutDialog

leinir added a comment. There we go - had to do some surgery to make it work, since of course kxmlgui has moved on since this patch was first made, but i've got an MR under way on https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/57 (currently WIP because i want to add in

D25506: Remove Attica from KAboutDialog

leinir added a comment. Right! Only a mere tiny short while later, the store has as of now got support for that avatar thing based on just the username - in a neat variety of ways, as well :) See Alexander's comment here for details: https://phabricator.kde.org/T10138#254182 (and i'll need

D29678: Fix incorrect colours in the KNS Quick messagebox

This revision was automatically updated to reflect the committed changes. Closed by commit R304:5ce4d1a29b96: Fix incorrect colours in the KNS Quick messagebox (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29678?vs=82744=82791

D29678: Fix incorrect colours in the KNS Quick messagebox

leinir updated this revision to Diff 82744. leinir added a comment. Address comment by @ngraham - Add a comment for the purpose of the control being a TextEdit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29678?vs=82659=82744 BRANCH

D29678: Fix incorrect colours in the KNS Quick messagebox

leinir added a comment. In D29678#670125 , @ngraham wrote: > Does this even need to be a TextEdit? Or is that to get mouse-selectability for the error text? If so, +1 but please add comments indicating this reason. That is precisely what

D29678: Fix incorrect colours in the KNS Quick messagebox

leinir edited the test plan for this revision. leinir added reviewers: Frameworks, KNewStuff, Plasma, bugseforuns. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29678 To: leinir, #frameworks, #knewstuff, #plasma, bugseforuns Cc: kde-frameworks-devel, LeGast00n,

D29678: Fix incorrect colours in the KNS Quick messagebox

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Explicitly set the colours used in the messagebox' content item, as the theme does not propagate to the simpler items,

D29455: KNS: Deprecate isRemote method and handle parse error properly

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Sorted, nicely done :) Makes the code just a touch simpler as well, which is always good :) REPOSITORY R304 KNewStuff BRANCH fix_isremote_stuff (branched from master) REVISION DETAIL

D29123: Do not mark entry as uninstalled if uninstallation script failed

leinir accepted this revision. leinir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > installation.h:113 > * > * The entry instance will be updated with any new information: > * Not blocking, but the documentation probably wants

D29451: KNS: Do not mark entry as installed if install script failed

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Thank you :D Land away :) REPOSITORY R304 KNewStuff BRANCH arcpatch-D29451 REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc:

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. (oops, mistakenly marked as accepted, sorry...) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc:

D29451: KNS: Do not mark entry as installed if install script failed

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In D29451#665420 , @alex wrote: > Fix connect > > Thanks, I wasn't aware of that until now :-) Same, until a couple of weeks ago

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > installation.cpp:355 > QProcess* p = runPostInstallationCommand(installedFiles.size() > == 1 ? installedFiles.first() : targetPath); > -

D29455: KNS: Deprecate isRemote method and handle parse error properly

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Apart from these couple of details, it looks pretty good :) (i'd say just fix and commit, but one of them's a tiny bit larger than just a typo fix ;) ) INLINE COMMENTS >

D29123: Do not mark entry as uninstalled if uninstallation script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Sorry about missing that bic issue before... INLINE COMMENTS > leinir wrote in installation.cpp:653 > Unless you report the entry as changed, the cache will not be updated and

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. A bit nitpicky, that first one, the second's more serious (i'd like to avoid that in new code), but looks good otherwise :) INLINE COMMENTS > installation.cpp:355 >

D29447: Fix showing updates when the option is selected

This revision was automatically updated to reflect the committed changes. Closed by commit R304:25d391c6f36b: Fix showing updates when the option is selected (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29447?vs=82021=82064 REVISION

D29455: KNS: Remove isRemote method and handle parse error properly

leinir requested changes to this revision. leinir added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > installation.h:76 > bool readConfig(const KConfigGroup ); > -bool isRemote() const; > i'm afraid this is an exported class, at most we can mark

D29447: Fix showing updates when the option is selected

leinir marked 2 inline comments as done. leinir added a comment. Thanks for making me realise that it doesn't have to be quite so elaborate, @alex ;) REPOSITORY R304 KNewStuff BRANCH fix-show-only-updates (branched from master) REVISION DETAIL https://phabricator.kde.org/D29447 To:

D29447: Fix showing updates when the option is selected

leinir updated this revision to Diff 82021. leinir added a comment. As @alex suggests, just use qlist::contains, it is supposed to be reasonably cheap, so... yup, trust the framework! ;) - Just use qlist::contains REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29447: Fix showing updates when the option is selected

leinir added inline comments. INLINE COMMENTS > alex wrote in itemsmodel.cpp:71 > On second thought why not just use: > `bool duplicate = m_entries.contains(entry);` Hmm... i do wonder slight of the cost of that, but also... much simpler code, so... basically can just go if

D29447: Fix showing updates when the option is selected

leinir updated this revision to Diff 82003. leinir added a comment. Address comment by @alex - Fix style (and consty things) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29447?vs=81993=82003 BRANCH fix-show-only-updates (branched from master)

D29447: Fix showing updates when the option is selected

leinir added reviewers: KNewStuff, Plasma, bugseforuns, ngraham, Frameworks. leinir added projects: Plasma, KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29447 To: leinir, #knewstuff, #plasma, bugseforuns, ngraham, #frameworks Cc: kde-frameworks-devel,

D29447: Fix showing updates when the option is selected

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This patch primarily fixes the issue that when picking the "Updateable Only" option on NewStuff.Page, we would be shown

D29222: Fix update auto selection

This revision was automatically updated to reflect the committed changes. Closed by commit R304:12642a1c0174: Fix update auto selection (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29222?vs=81412=81869 REVISION DETAIL

D28701: Add KPackage support to KNewStuffCore

This revision was automatically updated to reflect the committed changes. Closed by commit R304:3f38da8a70d8: Add KPackage support to KNewStuffCore (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28701?vs=81859=81868 REVISION DETAIL

D28701: Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 81859. leinir added a comment. Since we have had a new Frameworks release while this is waiting for the thumbs up, increase the @since to the next version. - Merge branch 'master' into add-kpackage-support - Merge branch 'master' into

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#660186 , @mart wrote: > +1 from me. Thanks! :) > does it need to go into next release or can also get in next+1? It really wants to go in soon as possible (since it fixes the whole global

Re: Information regarding upcoming Gitlab Migration

On Monday, 27 April 2020 21:25:09 BST Albert Astals Cid wrote: > El dilluns, 27 d’abril de 2020, a les 13:58:02 CEST, Bhushan Shah va escriure: > > In part I am mostly re-iterating what Ben already mentioned in different > > messages. > > > > On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. Ping team framework and such? (i realise we're all a tiny bit more stressy than usual...) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, broulik, bshah

D29101: KNewStuff: Fix file path and process call

leinir accepted this revision as: leinir. leinir added a comment. This revision is now accepted and ready to land. That's well spotted. Thanks for taking that one on :) REPOSITORY R304 KNewStuff BRANCH bugfix_uninstall (branched from master) REVISION DETAIL

D29222: Fix update auto selection

leinir updated this revision to Diff 81412. leinir added a comment. Thanks @ngraham, learn me to add debug information and then forget to commit it :P - Compile... REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29222?vs=81318=81412 BRANCH

D29222: Fix update auto selection

leinir edited the summary of this revision. leinir added reviewers: Frameworks, Plasma, bugseforuns, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29222 To: leinir, #frameworks, #plasma, bugseforuns, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack,

D29222: Fix update auto selection

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY The new autoselection for updating installed entries would firstly not be looking at the right amount of download

D28701: Add KPackage support to KNewStuffCore

leinir added inline comments. INLINE COMMENTS > mart wrote in kpackagejob.cpp:55 > is it worth encapsulating it in a runnable? the installation of a package is > already in a separathe thread. Annoyingly, the caller waits for that thread to complete, so the KPackage internals work

D29123: Do not mark entry as uninstalled if uninstallation script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. On a related note, i'm waiting on reviews on D28701 at the moment... which i'm afraid might wreck some havoc with your patch, as they touch

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

leinir added a comment. In D29126#655523 , @dfaure wrote: > And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Was /just/ about to be all "nooo, widgets in core, crying forever" but this isn't core, so go for it ;) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

leinir added a comment. (and now i've done it myself, terribly sorry about that, missed the WIP at the start of the title! Hope some of my comments were useful, though :) ) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven,

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. The reporting side of this seems based on a misunderstanding of what the UI-less Core is supposed to be doing... The conceptual intention in general isn't bad, but it needs a bit

D28701: Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80862. leinir added a comment. Some documentation and whitespace fixes for Frameworksiness - Fix up a few whitespace errors - Add some documentation to KPackageJob, and a few @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#653954 , @ngraham wrote: > I mean, GHNS basically *is* a userspace package manager, and things like dependency management and removal of stale files are why package managers exist. :) > > If it needs to be

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#652898 , @ngraham wrote: > Great. There are still a few more bugs though: > > When you install certain global themes, they ask for authentication so install an SDDM theme. However when you uninstall that

D28701: Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80617. leinir added a comment. Thank you to @ngraham for noticing this one! It only really pokes its head out if you have multiple things installed and then try and uninstall one of them - if you only have the one thing installed, it looks very much

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. As i thought, i was indeed holding the KPackage APi incorrectly ;) The culprit is hinted at in the line > org.kde.knewstuff.core: Attempting to perform an installation operation of type 3 on the package "/home/leinir/.local/share/plasma/desktoptheme/Sweet" of

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#650616 , @ngraham wrote: > Thanks, the hang is gone now. However I have a new problem: > > 1. Open Global Themes KCM and click new new global themes > 2. Install Sweet KDE and McMojave LAF global themes >

D28701: Add KPackage support to KNewStuffCore

leinir added reviewers: broulik, bshah. leinir added a comment. Tagging in a couple of people who were in the original chat about doing this integration... :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks,

D28701: Add KPackage support to KNewStuffCore

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80289. leinir added a comment. Address @ngraham's (and my own) worry about the synchronous behaviour exhibited by KPackage... Something a bit like this probably wants to go into KPackage itself, perhaps we can consider this after we've done a bit of

D28701: Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#649012 , @ngraham wrote: > This has fixed the issues I was seeing with installation and uninstallation, nice! However I'm not seeing a very long hang when installing certain global themes--for example Sweet KDE

D28701: Add KPackage support to KNewStuffCore

leinir added reviewers: ngraham, mart, davidedmundson. leinir added a comment. Tagging in those active in the referenced bug, except for the reporter who doesn't have a phabricator account REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma,

D28701: Add KPackage support to KNewStuffCore

leinir retitled this revision from "[WIP] Add KPackage support to KNewStuffCore" to "Add KPackage support to KNewStuffCore". leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80195. leinir added a comment. Think we're at the point where testing would be good, now. This update means we now attempt to adopt already installed kpackages if you try and install the package from knewstuff, and removal of entries installed using

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80184. leinir edited the test plan for this revision. leinir added a comment. (the fallback handling needs some more work, but also progress) - Clean up some of the error reporting, and reset the entry's state - Check if installedFile is a file, if

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80099. leinir added a comment. - Make a touch of noise when encountering the fallback REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28701?vs=80098=80099 BRANCH add-kpackage-support (branched from master) REVISION

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 80098. leinir added a comment. Bunch of new functionality, with a fallback which ought to allow it to work without requiring any kind of changes to the existing knsrc files based on kpackage, as long as they follow the pattern they seem to mostly

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#644973 , @ngraham wrote: > Okay thanks, can you update the test plan then? Also I think the diff currently does not actually fix 418466. Your comments (and adding on reviewers) seems to suggest to me

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir added a comment. In D28701#644943 , @ngraham wrote: > Am I not testing properly? Correct, that's the bit where i've not added instructions as required for switching to using the kpackage support. Short version, comment out the

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir updated this revision to Diff 79704. leinir added a comment. - Remove a stray newline REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28701?vs=79703=79704 BRANCH add-kpackage-support (branched from master) REVISION DETAIL

D28701: [WIP] Add KPackage support to KNewStuffCore

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Adding support for KPackage directly to KNewStuff means that we are able to deal more gracefully with things like

D28532: Introduce more user-visible error reporting for installations

This revision was automatically updated to reflect the committed changes. Closed by commit R304:eb23f549ea9b: Introduce more user-visible error reporting for installations (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir updated this revision to Diff 79474. leinir added a comment. - Merge branch 'master' into more-installation-error-handling - Actually read the error (not just all) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28532?vs=79195=79474 BRANCH

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28540: Fix layout in DownloadItemsSheet

This revision was automatically updated to reflect the committed changes. Closed by commit R304:449d056a2d77: Fix layout in DownloadItemsSheet (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28540?vs=79226=79290 REVISION DETAIL

D28540: Fix layout in DownloadItemsSheet

leinir edited the summary of this revision. leinir added reviewers: Frameworks, bugseforuns, mart, Plasma, KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28540 To: leinir, #frameworks, bugseforuns, mart, #plasma, #knewstuff Cc: kde-frameworks-devel,

D28540: Fix layout in DownloadItemsSheet

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY The previous code was primarily there to work around misfeatures of OverlaySheet which no longer exist. Consequently, we

D28532: Introduce more user-visible error reporting for installations

leinir updated this revision to Diff 79195. leinir added a comment. - Address @pino's comment re i18n overload usage REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28532?vs=79191=79195 BRANCH more-installation-error-handling (branched from master)

D28532: Introduce more user-visible error reporting for installations

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28532: Introduce more user-visible error reporting for installations

leinir edited the summary of this revision. leinir added reviewers: KNewStuff, Plasma, ngraham, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28532 To: leinir, #knewstuff, #plasma, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28532: Introduce more user-visible error reporting for installations

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this, we did have error reporting, but only in the way of writing errors out on the command line (through

D28220: Switch to using Kirigami's ShadowedRectangle

This revision was automatically updated to reflect the committed changes. Closed by commit R304:aa29f344928e: Switch to using Kirigamis ShadowedRectangle (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78430=79109 REVISION

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a comment. Ping? Not super critical, i guess, but it just feels sad to have things pending for weeks... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg Cc:

D28298: Reduce superfluous changedEntriesChanged emissions

leinir added inline comments. INLINE COMMENTS > Button.qml:90 > -value: ghnsDialog.engine.changedEntries > -} > Given the various annoying side effects of the cleaner solutions, perhaps reintroduce this, but add a "when" clause to ensure it only happens when we want it to? Maybe

D28220: Switch to using Kirigami's ShadowedRectangle

leinir marked 8 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in EntryScreenshots.qml:134 > The x and y offsets should be 0 by default, so there's little reason to > specify that I'd say. Ha, yes, quite, setting defaults does seem a little silly ;) REPOSITORY R304 KNewStuff REVISION

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78430. leinir added a comment. Address comment by @ahiemstra - Remove some unneeded values REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78342=78430 BRANCH switch-to-kirigami-shadowedrectangle

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a subscriber: davidedmundson. leinir added a comment. In D28220#633557 , @ngraham wrote: > Just an observation, we should maybe consider making a shared component for this screenshots list so that Discover can use it too. i

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78342. leinir added a comment. - Less magic numbers - Remove some unneeded bits REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78341=78342 BRANCH switch-to-kirigami-shadowedrectangle (branched from

D28220: Switch to using Kirigami's ShadowedRectangle

leinir edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added a reviewer: VDG. leinir marked 3 inline comments as done. leinir added a comment. (pending some screenshots of the visible change) INLINE COMMENTS > broulik wrote in EntryScreenshots.qml:138 > You used `largeSpacing` as `verticalOffset` before Hm, on second thought, it looks

D28220: Switch to using Kirigami's ShadowedRectangle

leinir marked 5 inline comments as done. leinir added inline comments. INLINE COMMENTS > broulik wrote in EntryScreenshots.qml:133 > Not needed given you `anchors.fill` Ah yes, quite :) > broulik wrote in EntryScreenshots.qml:135 > What's this for? That's a good question, really - i found

D28220: Switch to using Kirigami's ShadowedRectangle

leinir updated this revision to Diff 78341. leinir added a comment. - Increase Kirigami runtime dep version to 2.12 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28220?vs=78290=78341 BRANCH switch-to-kirigami-shadowedrectangle (branched from master)

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added reviewers: ahiemstra, broulik, mart. leinir added a comment. tagging in a couple of people who definitely know things about the new thing :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma,

D28220: Switch to using Kirigami's ShadowedRectangle

leinir added reviewers: KNewStuff, Frameworks, Plasma. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28220: Switch to using Kirigami's ShadowedRectangle

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This switches from using the QML DropShadow to using the new, high efficiency ShadowedRectangle in Kirigami. -

D20986: Don't call click on the delegate, when we just want it to become current item

leinir abandoned this revision. leinir added a comment. No longer needed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20986 To: leinir, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26794 To: leinir Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

This revision was automatically updated to reflect the committed changes. Closed by commit R304:f1dcbddf12ea: Fix update scenarios with no explicit downloadlink selected (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27544?vs=77818=77989#toc REPOSITORY R304

D27635: Restore kio-webdav plugin

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27635 REVISION DETAIL https://phabricator.kde.org/D27635 To: nicolasfella, bshah, leinir, #frameworks

D27544: Fix update scenarios with no explicit downloadlink selected

leinir updated this revision to Diff 77818. leinir marked 4 inline comments as done. leinir added a comment. Address @ahiemstra's comments - thanks! - Turn on C++14 support - Fix some whitespace issues, a leak, and add a warning - Less magic numbers, with the power of enums

D27544: Fix update scenarios with no explicit downloadlink selected

leinir marked 5 inline comments as done. leinir added a comment. Thanks for those, @ahiemstra, good stuff there :) INLINE COMMENTS > ahiemstra wrote in engine.cpp:614 > Code style: & attaches to the name, not the type. (Yes I hate it too). > > There's a few instances of this around. so

D27544: Fix update scenarios with no explicit downloadlink selected

leinir updated this revision to Diff 77494. leinir added a comment. - Merge branch 'master' into fix-update - Update @since REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27544?vs=76096=77494 BRANCH fix-update (branched from master) REVISION DETAIL

D27544: Fix update scenarios with no explicit downloadlink selected

leinir added a comment. In D27544#622575 , @alexde wrote: > In D27544#622272 , @ngraham wrote: > > > (...) there has to be a way to (...) label everything properly etc. > > > > > In

D27635: Restore kio-webdav plugin

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Minus that little API funniness, looks pretty good from here :) INLINE COMMENTS > CMakeLists.txt:9 > > -add_library(kaccounts_kio_webdav_plugin MODULE ${kio-webdav_SRCS}) > + >

D27704: Drop FindAccountsFileDir.cmake

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Removing unused stuff is always nice, well spotted :) REPOSITORY R155 KAccounts Integration BRANCH cma REVISION DETAIL https://phabricator.kde.org/D27704 To: nicolasfella,

  1   2   3   4   5   6   >