it to Phabricator since
Reviewboard is deprecated since some time.
- Gregor Mi
On Dez. 24, 2016, 12:49 nachm., Luke Dashjr wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
marked as submitted.
Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus.
Changes
---
Submitted with commit fa6bad3be579ec89c8126b00438234d0bc16c508 by Gregor Mi to
branch master.
Bugs: 335616
https://bugs.kde.org/show_bug.cgi?id=335616
Repository: kio
nerated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/#review100988
---
On July 27, 2017, 11:15 a.m., Gregor Mi wrote:
>
> ---
> This is an automaticall
igator.cpp 033046f06dd5bea3f4124669c55803aba3a31789
src/filewidgets/urlutil_p.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127111/diff/
Testing
---
Thanks,
Gregor Mi
ers to pre-select the
> > directory that the user is navigating up from".
That sounds better. Fixed in the coming update.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.rev
ilewidgets/kurlnavigator.cpp 3c045c5aaadb429fd22d28b55ad20d31b086ef48
src/filewidgets/urlutil.h PRE-CREATION
tests/CMakeLists.txt bc94a4aefd77fb9ce9b2a24075415aac7c30e5ca
tests/urlutiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127111/diff/
Testing
---
Thanks,
Gregor Mi
ist. Sorry for not to have responded earlier.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/#review92587
---
On Feb. 18,
you don't need to hit any
> [calculate] button.
>
> Second user case: Share the checksums. You calculate, and copy/paste the
> output.
>
> IMHO they don't need to be in separate tabs but separated with meaningful
> titles in the "checksum" tab.
>
you don't need to hit any
> [calculate] button.
>
> Second user case: Share the checksums. You calculate, and copy/paste the
> output.
>
> IMHO they don't need to be in separate tabs but separated with meaningful
> titles in the "checksum" tab.
>
you don't need to hit any
> [calculate] button.
>
> Second user case: Share the checksums. You calculate, and copy/paste the
> output.
>
> IMHO they don't need to be in separate tabs but separated with meaningful
> titles in the "checksum" tab.
>
you don't need to hit any
> [calculate] button.
>
> Second user case: Share the checksums. You calculate, and copy/paste the
> output.
>
> IMHO they don't need to be in separate tabs but separated with meaningful
> titles in the "checksum" tab.
>
you don't need to hit any
> [calculate] button.
>
> Second user case: Share the checksums. You calculate, and copy/paste the
> output.
>
> IMHO they don't need to be in separate tabs but separated with meaningful
> titles in the "checksum" tab.
>
you don't need to hit any
> [calculate] button.
>
> Second user case: Share the checksums. You calculate, and copy/paste the
> output.
>
> IMHO they don't need to be in separate tabs but separated with meaningful
> titles in the "checksum" tab.
>
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the groupbox is
> > unnecessary and confusing.
> >
> >
> On May 30, 2016, 5:54 a.m., Martin Gräßlin wrote:
> > Kind of unrelated: do you have ideas how we can integrate the "Donate" into
> > applications which don't have a help menu, like Plasma or KWin?
>
> Albert Astals Cid wrote:
> I don't see "obvious" places for things without much chrome
questions.
- Gregor Mi
On May 11, 2016, 11:01 p.m., Aleix Pol Gonzalez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
tps://git.reviewboard.kde.org/r/127887/#comment64748>
I don't know if this does the same but also didn't test.
src/kmoretools/kmoretoolsconfigdialog_p.cpp (line 201)
<https://git.reviewboard.kde.org/r/127887/#comment64749>
I wonder why here "for" is better than Q_FOREACH.
- Grego
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127237/#review93309
---
Ship it!
- Gregor Mi
On March 7, 2016, 8:38 p.m., Kåre
> On March 7, 2016, 9:29 p.m., Gregor Mi wrote:
> > src/kmoretools/kmoretoolsmenufactory.cpp, lines 128-129
> > <https://git.reviewboard.kde.org/r/127237/diff/2/?file=448481#file448481line128>
> >
> > Thanks for the comment. However, as long as we don't know
That said I don't know what the KDE policy is when dealing with this kind
of problem. Just adding null checks seems to make the code more complicated to
analyse later. You are a long-term committer, so your words have a high weight.
On the other hand I would be interested in a second opinion.
-
>
> (Updated March 1, 2016, 6:50 a.m.)
>
>
> Review request for KDE Frameworks and Gregor Mi.
>
>
> Repository: knewstuff
>
>
> Description
> ---
>
> If DBus is missing we get null-pointers in stead of KMoreToolsService*. This
> patch adds c
0094969b5c
tests/urlutiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127111/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-
Am 01.06.2015 09:48 schrieb David Faure:
On Thursday 21 May 2015 14:41:27 Gregor Mi wrote:
private:
-// Note that this object must live long enough in case the user
opens
-// the Configure... dialog
-KMoreTools* m_kmt = nullptr;
-
-QMenu* m_menu = nullptr
Hi,
I would like to add that there are other much bigger frameworks which have a
lot more
resources at hand and also have one single version under which all of the many
submodules
are released:
Java (Java 6, Java 7, Java 8, ...)
https://en.wikipedia.org/wiki/Java_version_history
.NET (3.0,
Hi David,
I just commited a fix for the unit tests.
In fact, is tests/kmoretoolstest supposed to be a unittest ?
It has both unittests and interactive dialogs in it. The interactive dialogs
can be
disabled via a flag but I guess I should separate this more cleanly.
but releasing something
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123421/#review79182
---
Ship it!
Ship It!
- Gregor Mi
On April 18, 2015, 7:45 p.m
On April 18, 2015, 9:29 p.m., Gregor Mi wrote:
Ship It!
Thanks for also taking care of the commments/documentation. There is some more,
which I will do later.
- Gregor
---
This is an automatically generated e-mail. To reply, visit
On April 17, 2015, 7:18 a.m., Gregor Mi wrote:
I did not receive an email on the final code changes. So this should
trigger another one.
.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https
On April 17, 2015, 7:18 a.m., Gregor Mi wrote:
I did not receive an email on the final code changes. So this should
trigger another one.
Gregor Mi wrote:
.
(still no email received. sorry for the potential noise)
- Gregor
://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
On April 15, 2015, 8:24 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910
/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
marked as submitted.
Review request for KDE Frameworks and Jeremy Whiting.
Changes
---
Submitted with commit b87e1772ee39c7edc002636a8ae35e09047308e4 by Gregor Mi to
branch master.
Repository: knewstuff
Description
---
Moved from kservice (https://git.reviewboard.kde.org/r/122576
-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review78777
---
On April 10, 2015, 11:04 a.m., Gregor Mi wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123223/#review78473
---
On April 3, 2015, 5:35 p.m., Gregor Mi wrote
://git.reviewboard.kde.org/r/122981/#comment53681
NOTE that this causes compile error in libKF5XmlGui
/home/gregor/dev/kf5/usr/lib64/libKF5XmlGui.so.5.8.0: undefined reference
to `KGlobalAccel::globalShortcutChanged(QAction*, QKeySequence const)'
collect2: error: ld returned 1 exit status
- Gregor Mi
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
KGlobalShortcutTest
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
KGlobalShortcutTest
eca7c52378ad60d0d5806561214b9788dd46a11e
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
KGlobalShortcutTest
in ./kservicetest sill succeed
3. Call `kbuildsycoca5 --noincremental` without and with the patch and try out
dolphin's Space Info menu. In the first case filelight is not found. With the
patch filelight is found.
Thanks,
Gregor Mi
___
Kde-frameworks-devel
e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123223/#review78424
---
On April 2, 2015, 11:55 a.m., Gregor Mi wrote:
---
This is an automatically generated e-mail
the SendTo... button and see debug output:
m_pluginLoader-init()
KIPI_FOUND...
m_pluginLoader-loadPlugins();
... pluginList.count() 0
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
is not found. With the
patch filelight is found.
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123095/#review78259
---
On March 30, 2015, 9:22 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail
` without and with the patch and try out
dolphin's Space Info menu. In the first case filelight is not found. With the
patch filelight is found.
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16
src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
tests.
- Gregor Mi
On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
KGlobalShortcutTest
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123095/#review78263
---
On March 30, 2015, 9:22 p.m., Gregor Mi wrote:
---
This is an automatically
/diff/
Testing
---
Run ksnapshot, click the SendTo... button and see debug output:
m_pluginLoader-init()
KIPI_FOUND...
m_pluginLoader-loadPlugins();
... pluginList.count() 0
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde
On March 15, 2015, 10:31 a.m., Dominik Haumann wrote:
src/kmoretools/kmoretools.h, line 394
https://git.reviewboard.kde.org/r/122910/diff/1/?file=354447#file354447line394
Do we need the kmt-prefix? Why not just
KMoreToolsService * service();
Gregor Mi wrote:
I am
/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/2/mynotinstapp2.desktop PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor
/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde
, 2015, 12:39 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/
---
(Updated March 21, 2015, 12:39 p.m
On March 22, 2015, 3:56 p.m., Albert Astals Cid wrote:
src/kglobalaccel.h, line 260
https://git.reviewboard.kde.org/r/122981/diff/2/?file=356138#file356138line260
typo in following
Gregor Mi wrote:
About why it is needed: see
KGlobalShortcutTest
is running.
Gregor Mi wrote:
Now 4 other tests fail. Can you give me a quick hint if there is some
persistent settings used by the unit tests which I can delete?
I tried this to debug one of the failing test cases:
$ strace -o aaa ./kglobalshortcuttest testFindActionByKey
and searched for stat
1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/122981/#review77902
---
On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77912
---
On March 22, 2015, 4:05 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply
---
On March 16, 2015, 8:29 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981
.
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122981/#review77606
---
On March 16, 2015, 8:29 p.m., Gregor Mi wrote
3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16
src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1
Diff: https://git.reviewboard.kde.org/r/122981/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
://git.reviewboard.kde.org/r/122910/#comment53239
The QAction should be created at first usage. But it must be destroyed when
the menu is cleared. I am not sure if this is a good way of doing it.
- Gregor Mi
On March 11, 2015, 11:06 p.m., Gregor Mi wrote
. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77502
---
On March 11, 2015, 11:06 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77502
---
On March 11, 2015, 11:06 p.m., Gregor Mi wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910/#review77502
---
On March 11, 2015, 11:06 p.m., Gregor Mi wrote
---
On March 11, 2015, 11:06 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122910
-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
: https://git.reviewboard.kde.org/r/122910/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/
- Gregor Mi
On March 1, 2015, 2:28 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576
/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde
/122576/#review77147
---
On March 1, 2015, 2:28 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576
implementation of that) but KMT itself isn't part
of the ksycoca technology, it should be higher up in the stack.
One idea would be to put it in KNewStuff. It's the same kind of thing,
viewed from far away: offering the user to install more stuff.
Gregor Mi wrote:
Regarding the lookup
?
- Gregor
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576/#review76114
---
On March 1, 2015, 2:28 p.m., Gregor Mi wrote
/kmoretools/kmoretools.cpp PRE-CREATION
src/kmoretools/kmoretools_p.h PRE-CREATION
src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks
/kate.png PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION
tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION
tests/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
---
On Feb. 16, 2015, 11:05 p.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122576
/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/kmoretools/kmoretoolstest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
/kmoretoolsconfigdialog.h PRE-CREATION
src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION
src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde
/kmoretoolsconfigwidget.ui PRE-CREATION
tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e
tests/kmoretools/1/a.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks
PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122576/diff/
Testing
---
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
all recent files. What about hide it by default
and let the client (kate, kaffeine etc.) decide if it should be shown or not by
- e.g. with .setOpenAllMenuItemVisible(true); or .setAllowOpenAll(true);
- Gregor Mi
On Feb. 12, 2015, 11:56 p.m., Thomas Murach wrote
/: This also
causes a BIC change and would therefore also require an SOVERSION bump. I am
wondering if another SOVERSION change would be good regarding having stable KDE
APIs. Is there a certain point in time when APIs like this one should not
change anymore?
- Gregor Mi
On Jan. 15, 2015, 1:24
-_1before.png (before patch)
http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_2after.png (after)
http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch)
http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after)
Thanks,
Gregor Mi
://git.reviewboard.kde.org/r/121379/#review71849
---
On Dec. 12, 2014, 11:04 a.m., Gregor Mi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
its worth, I'm not so happy with the change still (I liked the
icon). But thats only a matter of taste and without rational.
Gregor Mi wrote:
Thanks for clarifying. :-)
Christoph Feck wrote:
Committed to wrong branch
Yes, but the second push went to master (see
http
: [kwidgetsaddons/removeicon1] src: Remove top right icon from KPageView
Date: Fri, 12 Dec 2014 11:04:16 +
From: Gregor Mi codestr...@posteo.org
Reply-To: kde-comm...@kde.org
To: kde-comm...@kde.org
Git commit 7bf344b5137e419a5caab42c346a0eb20e5912e6 by Gregor Mi.
Committed on 07/12/2014 at 10:32
)
http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch)
http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after)
Thanks,
Gregor Mi
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
Hi there,
I encounter a problem with invisible buttons.
My dev env: running Plasma 4 on openSUSE 13.1, KDE version 4.11.5
and I use latest frameworks build from today (2014-11-02)
When I start for example
$ kcmshell5 mouse
or
$ ksnapshot
all the buttons are missing... sometimes. If I restart
1 - 100 of 119 matches
Mail list logo
