Re: C++11 policy in frameworks?

2015-02-08 Thread Jeremy Whiting
https://trac.macports.org/browser/trunk/dports/lang/llvm-3.7/Portfile I thought this was clang 3.7 maybe I'm confused though On Feb 8, 2015 1:39 PM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 8 de febrer de 2015, a les 09:55:05, Jeremy Whiting va escriure: Hey all, In trying

Review Request 122493: Use math.h round rather than C++11 std::lround.

2015-02-08 Thread Jeremy Whiting
is able to build on OS X 10.7 with the built in XCode compiler and standard library. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122481: Fix use of environ for OS X

2015-02-08 Thread Jeremy Whiting
to build on OS X 10.7 Diffs (updated) - src/widgets/kurlcompletion.cpp 1871c49a936e2ca322286e23ad6fe976ae2c7044 Diff: https://git.reviewboard.kde.org/r/122481/diff/ Testing --- kio builds with this patch on OS X 10.7 and 10.10 Thanks, Jeremy Whiting

Re: Framework Categories

2015-02-04 Thread Jeremy Whiting
Ok, I've changed knewstuff to a solution type. Should all frameworks that depend on kio be also changed to solution type ? On Tue, Feb 3, 2015 at 11:54 PM, Kevin Ottens er...@kde.org wrote: On Tuesday 03 February 2015 12:53:08 Jeremy Whiting wrote: Hey frameworks developers, Albert wrote

Framework Categories

2015-02-03 Thread Jeremy Whiting
Hey frameworks developers, Albert wrote a couple weeks ago: As far as i remember, functional means you can use it standalone, solution means it needs a daemon and integraion means it needs more stuff (more daemons? Is this categorization correct? Has it been checked with a dependency analysis

Re: [Kde-games-devel] Freeze in 6 weeks

2015-01-31 Thread Jeremy Whiting
Albert, Frameworks developers/maintainers, On Thu, Jan 29, 2015 at 12:43 PM, Albert Astals Cid aa...@kde.org wrote: El Dijous, 29 de gener de 2015, a les 10:05:01, Inge Wallin va escriure: On Wednesday, January 28, 2015 20:47:44 Albert Astals Cid wrote: El Dimecres, 28 de gener de 2015, a

Re: Review Request 122210: KCmdLineArgs: Fix -version handling

2015-01-22 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122210/#review74561 --- Ship it! Ship It! - Jeremy Whiting On Jan. 22, 2015, 1:43

Re: Review Request 122105: Fix KgDifficulty saving on app close

2015-01-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122105/#review74180 --- Ship it! Ship It! - Jeremy Whiting On Jan. 17, 2015, 4:53

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
, in so far as they need similar information. I'll admit it makes porting a little harder, but it should be possible to create a porting script without too much difficulty. Jeremy Whiting wrote: Ralf any updates on this patch? Ralf Habacker wrote: @Alex, you wrote

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
? It's much easier to apply a diff than to figure out where to put this file and if any other changes are needed to use it, etc. - Jeremy Whiting On Dec. 15, 2014, 1:01 a.m., Ralf Habacker wrote: --- This is an automatically generated

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-15 Thread Jeremy Whiting
On Dec. 12, 2014, 7:08 a.m., Alex Merry wrote: modules/ECMAddAppIcon.cmake, line 15 https://git.reviewboard.kde.org/r/121448/diff/1/?file=332663#file332663line15 Would this actually work? The code looks to me like pattern_rx would just be the filename again, so fn would be empty,

Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Jeremy Whiting
On Jan. 7, 2015, 5:35 a.m., Jeremy Whiting wrote: Ship It! Fixes it here. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121895/#review73359

Re: Review Request 121895: Fix local issues in KIO build

2015-01-07 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121895/#review73359 --- Ship it! Ship It! - Jeremy Whiting On Jan. 7, 2015, 4:52

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Jeremy Whiting
I hit the same issues reported by Marko here on OS X also, and have no KDE_INSTALL_DIRS_NO_DEPRECATED set either. Maybe the logic in ecm is broken somehow? On Wed, Jan 7, 2015 at 11:48 AM, Alex Merry alex.me...@kde.org wrote: On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: P.P.S.: I

Re: OSX/CI: kio-extras fails to build on branch master

2015-01-06 Thread Jeremy Whiting
, at 22:39 , Jeremy Whiting jpwhit...@kde.org wrote: I think this is the same problem that kconfig had last week. i.e. we need to change INSTALL_TARGET_ARGS to KDE_INSTALL_TARGET_ARGS. I'll take a look. yes, see the discussion with Milian and Christopher in thread “OSX/CI: konsole fails

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-06 Thread Jeremy Whiting
Yes, ecm changed recently. On Tue, Jan 6, 2015 at 3:55 PM, Marko Käning mk-li...@email.de wrote: Hi Christoph, I’ve found that these projects do not make use of KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: - systemsettings - muon - rocs - libkdegames - kiten - cantor -

Re: Review Request 121833: add reviewboardrc, targets kdeframeworks and plasma groups

2015-01-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121833/#review73077 --- Ship it! Ship It! - Jeremy Whiting On Jan. 4, 2015, 8:19

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

2015-01-03 Thread Jeremy Whiting
on the end of parser in the comment :) - Jeremy Whiting On Jan. 3, 2015, 2:36 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Jeremy Whiting
/121773/#comment50720 Why not use if HAVE_X11 !defined(Q_OS_MAC) to keep that fix in place? - Jeremy Whiting On Dec. 31, 2014, 3:23 a.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Jeremy Whiting
On Dec. 31, 2014, 5:52 a.m., Jeremy Whiting wrote: src/kdesud/kdesud.cpp, line 76 https://git.reviewboard.kde.org/r/121773/diff/1/?file=337535#file337535line76 Why not use if HAVE_X11 !defined(Q_OS_MAC) to keep that fix in place? Michael Palimaka wrote: !defined(Q_OS_MAC

Re: Review Request 121496: Fix build if the X11 headers are not located in /usr/include

2014-12-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121496/#review71973 --- Ship it! Ship It! - Jeremy Whiting On Dec. 13, 2014, 8:02

Re: Review Request 121401: Add Windows VERSIONINFO to KF5CoreAddons.dll

2014-12-09 Thread Jeremy Whiting
with that other change in it, right ? Otherwise anyone building on windows will need ecm from git (do they already?) - Jeremy Whiting On Dec. 8, 2014, 10:01 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply

Re: KF 5.5.0 changelog

2014-12-06 Thread Jeremy Whiting
Looks good to me on the attica/knewstuff entries. On Sat, Dec 6, 2014 at 7:59 AM, David Faure fa...@kde.org wrote: Here's the changelog I wrote for 5.5.0. Please everyone remember to use CHANGELOG in your commits, with a standalone description of the issue (i.e. which doesn't use the

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71372 --- Ship it! Ship It! - Jeremy Whiting On Dec. 4, 2014, 2:12

Re: Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

2014-11-26 Thread Jeremy Whiting
/#comment49591 what if caption already contains [*] ? Shouldn't we check for that and only append the [*] if it's not there already ? - Jeremy Whiting On Nov. 26, 2014, 8:10 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-20 Thread Jeremy Whiting
On Nov. 17, 2014, 4:33 p.m., Jeremy Whiting wrote: I tested this here and FileDialog qml still hangs the ui with this patch. (though at least the dialog appears) Martin Klapetek wrote: Yes, QML still hangs, not sure why though. Looking into it. Martin Klapetek wrote: So

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-17 Thread Jeremy Whiting
. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository

Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Jeremy Whiting
marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Also allow absolute filepaths for configfile parameter. Diffs - src/core/engine.cpp 7fae48a09aa88565ab1bfafcbff23494fabf75b1 Diff: https://git.reviewboard.kde.org/r

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-17 Thread Jeremy Whiting
with this patch. (though at least the dialog appears) - Jeremy Whiting On Nov. 17, 2014, 10:46 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-15 Thread Jeremy Whiting
, visit: https://git.reviewboard.kde.org/r/121098/#review70384 --- On Nov. 10, 2014, 11:17 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-15 Thread Jeremy Whiting
whether show() should pop up the dialog as modal or modeless. So as the modal is being set here, shouldn't the if (windowModality == Qt::NonModal) { just be removed instead and always call show()? Jeremy Whiting wrote: Yep, I've tried just removing the if, that makes

Review Request 121115: Use all of QT_PLUGIN_PATH paths rather than just QLibraryInfo path to look for plugins.

2014-11-13 Thread Jeremy Whiting
, the attica_kde.so plugin isn't found even if it's installed to a path that is in QT_PLUGIN_PATH. With this change it loads correctly. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 121115: Use all of QT_PLUGIN_PATH paths rather than just QLibraryInfo path to look for plugins.

2014-11-13 Thread Jeremy Whiting
: https://git.reviewboard.kde.org/r/121115/diff/ Testing --- Without this change, the attica_kde.so plugin isn't found even if it's installed to a path that is in QT_PLUGIN_PATH. With this change it loads correctly. Thanks, Jeremy Whiting

Re: Review Request 121100: Add qCDebug statements back into knewstuff sources.

2014-11-11 Thread Jeremy Whiting
ee2ead451be06854ea65ee9128231d37b118355c Diff: https://git.reviewboard.kde.org/r/121100/diff/ Testing --- Builds and works still, more debug output filterable with the kanagram logging category. Thanks, Jeremy Whiting ___ Kde-frameworks-devel

Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-10 Thread Jeremy Whiting
44eca192946f0da2b357b33e93a57ef0de05135b Diff: https://git.reviewboard.kde.org/r/121098/diff/ Testing --- fifteen puzzle config with patch from https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you choose a file. Thanks, Jeremy Whiting ___ Kde

Review Request 121099: Fix kautosave doesn't work with more than 1 file per application.

2014-11-10 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/121099/diff/ Testing --- It builds and the test passes. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121100: Add qCDebug statements back into knewstuff sources.

2014-11-10 Thread Jeremy Whiting
/ Testing --- Builds and works still, more debug output filterable with the kanagram logging category. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Ksshaskpass ?

2014-11-03 Thread Jeremy Whiting
November 2014 16:21:32 Jeremy Whiting a écrit : Ok, pushed to kde:ksshaskpass now. I'll request it move to kdereview tomorrow. I would like at least one other person to try it before that, as I'm the only one that has built and run the kf5 port that I know of. thanks, Jeremy On Sat, Nov 1

Re: Ksshaskpass ?

2014-11-03 Thread Jeremy Whiting
ksshaskpass has no more krazy issues and has been moved to kdereview. I think it's final resting place should be kde/workspace but I'm open to other ideas. It is usable on other platforms besides plasma, but it saves passwords in kwallet, so may make the most sense there. thanks, Jeremy P.S. We

Re: Ksshaskpass ?

2014-11-02 Thread Jeremy Whiting
Ok, pushed to kde:ksshaskpass now. I'll request it move to kdereview tomorrow. I would like at least one other person to try it before that, as I'm the only one that has built and run the kf5 port that I know of. thanks, Jeremy On Sat, Nov 1, 2014 at 3:14 PM, Jeremy Whiting jpwhit...@kde.org

Re: Ksshaskpass ?

2014-11-01 Thread Jeremy Whiting
it to kde/workspace unless someone has a better idea for it. It only needs CoreAddons, WidgetsAddons, I18n, and Wallet frameworks. thanks, Jeremy On Sat, Nov 1, 2014 at 2:40 PM, Jeremy Whiting jpwhit...@kde.org wrote: Ok, I'll push it to git somewhere today and let the list know where so it can get

Re: Review Request 120903: Fix typo in documentation.

2014-10-30 Thread Jeremy Whiting
a comment, no code to test. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120903: Fix typo in documentation.

2014-10-29 Thread Jeremy Whiting
Description --- Fix typo in documentation. Diffs - src/kconfigdialog.h 436aa05e7e206ccb8a814bb590d9c1af28c1fb98 Diff: https://git.reviewboard.kde.org/r/120903/diff/ Testing --- It's a comment, no code to test. Thanks, Jeremy Whiting

Re: Review Request 120589: Remove #ifndefs for WIN CE, we don't support CE anymore.

2014-10-22 Thread Jeremy Whiting
marked as submitted. Review request for KDE Frameworks, Nicolás Alvarez and Jeremy Whiting. Repository: knewstuff Description --- Remove #ifndefs for WIN CE, we don't support CE anymore. Diffs - src/core/installation.cpp b69837db5b9ec05bce0a9c7bdc854fa0c9391f0e Diff: https

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread Jeremy Whiting
, David Faure, Vavelin Kevin, and Jeremy Whiting. Changes --- Added Kevin and David to weigh in. Repository: knewstuff Description --- Add explicit to ctors with one parameter Diffs - src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 src/button.h

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread Jeremy Whiting
marked as submitted. Review request for KDE Frameworks, David Faure, Vavelin Kevin, and Jeremy Whiting. Repository: knewstuff Description --- Add explicit to ctors with one parameter Diffs - src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 src/button.h

Review Request 120589: Remove #ifndefs for WIN CE, we don't support CE anymore.

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120589/ --- Review request for KDE Frameworks, Nicolás Alvarez and Jeremy Whiting

private export

2014-10-14 Thread Jeremy Whiting
Hello, In KNewStuff autotests there are two disabled tests that build and work if I export the Author and EntryInternal classes, but these two classes are private (declared in _p.h files) so I'd rather not export them, since they aren't public api. Is there a way to have them exported when

Review Request 120592: Remove #ifndefs for WIN CE, we don't support CE anymore.

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120592/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository

Re: Review Request 120592: enable autotests for knewstuff

2014-10-14 Thread Jeremy Whiting
and Jeremy Whiting. Changes --- Fix summary Summary (updated) - enable autotests for knewstuff Repository: knewstuff Description --- Enable autotests. Make autotests build in the sources they need to test to avoid exporting. Patch by Albert Astals Cid aa...@kde.org

Re: private export

2014-10-14 Thread Jeremy Whiting
Meh, Albert found a decent enough way to do it. Posted to rb to look at. On Tue, Oct 14, 2014 at 5:03 PM, Aleix Pol aleix...@kde.org wrote: On Tue, Oct 14, 2014 at 10:37 PM, Jeremy Whiting jpwhit...@kde.org wrote: Hello, In KNewStuff autotests there are two disabled tests that build

Re: Review Request 120592: enable autotests for knewstuff

2014-10-14 Thread Jeremy Whiting
marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Enable autotests. Make autotests build in the sources they need to test to avoid exporting. Patch by Albert Astals Cid aa...@kde.org Diffs - autotests/CMakeLists.txt

Review Request 120574: Add explicit to ctors with one parameter

2014-10-13 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository

platforms

2014-10-13 Thread Jeremy Whiting
Do we support building and using frameworks on Windows CE anymore? I don't see it on http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess not, is that correct? If not I can clean up some old ifdefs in knewstuff sources. thanks, Jeremy

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Jeremy Whiting
about committing this is if it's allowed since it's a binary incompatible change. If it's not allowed I will add duplicates of these methods that are const and deprecate these non-const ones instead. Thanks, Jeremy Whiting ___ Kde-frameworks-devel

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Jeremy Whiting
not allowed I will add duplicates of these methods that are const and deprecate these non-const ones instead. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
instead. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
that are const and deprecate these non-const ones instead. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/#review68095 --- On Oct. 8, 2014, 3:20 p.m., Jeremy Whiting wrote

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
or not is for someone else to answer. Jeremy Whiting wrote: Yes, I saw that, the real question is if we allow BIC changes or not. Also I guess if we don't allow BIC changes in frameworks anymore we should change that page to not say BIC changes should all happen on Monday's anymore :) Aleix Pol

Re: Qt DevDays is coming; do we want to print up some Frameworks Cookbooks to give to attendees?

2014-10-02 Thread Jeremy Whiting
Valorie, I'm a bit confused. books.kde.org says the book is hosted at flossmanuals, but that url takes me to the oldish KDE Dev Guide is thi Frameworks Cookbook a different thing than that old book, right? Is the current wip book available somewhere ? I guess if so we should point that link at it

Re: KAnagram QML WebView crash

2014-08-23 Thread Jeremy Whiting
. Anyone with QtWebKit experience know what's going on here? do I need to change some qml property to make it not crash ? BR, Jeremy On Fri, Aug 22, 2014 at 4:11 PM, Jeremy Whiting jpwhit...@kde.org wrote: Sorry all, seems this is something wrong with my local setup. Though I've no clue what would

Re: KAnagram QML WebView crash

2014-08-23 Thread Jeremy Whiting
Hmm, could I be hitting the crash on TSymbolTableLevel::~TSymbolTableLevel() mentioned here: http://download.opensuse.org/ports/armv7hl/factory/repo/oss/ChangeLog On Sat, Aug 23, 2014 at 6:45 PM, Jeremy Whiting jpwhit...@kde.org wrote: Ok, I rebuilt frameworks and such on a fresh debian jessie

KAnagram QML WebView crash

2014-08-22 Thread Jeremy Whiting
Hello all, I'm reaching out because I can't seem to find a solution myself. TLDR If you can get a backtrace from building and running scratch/whiting/testqmlapp which uses QtWebKit's QML WebView I'd very much appreciate it. KAnagram qt4 version from master (before frameworks branch was merged)

Re: KAnagram QML WebView crash

2014-08-22 Thread Jeremy Whiting
I guess. thanks, Jeremy On Fri, Aug 22, 2014 at 3:57 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 22 d'agost de 2014, a les 15:45:12, Jeremy Whiting va escriure: Hello all, I'm reaching out because I can't seem to find a solution myself. TLDR If you can get a backtrace from

Re: Review Request 119345: Port away from deprecated QUrl API

2014-07-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119345/#review62618 --- Ship it! Ship It! - Jeremy Whiting On July 17, 2014, 11

Re: Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737

2014-06-27 Thread Jeremy Whiting
marked as submitted. Review request for KDE Frameworks, Marco Martin and Jeremy Whiting. Repository: knewstuff Description --- Add api for setting download widget and dialog title. Helps with bug 336737 Diffs - src/downloaddialog.h 7d8f2b40ee46baf18af401631816e0623d797623 src

Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

2014-06-27 Thread Jeremy Whiting
. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118970: Remove KDELibs4Support dependency.

2014-06-26 Thread Jeremy Whiting
and the tests run. Unrelated the sharedkvtmlfilestest exposes a bug in KEduVocDocument::open where the KFilterDev wont open, (bug from previous commit) not sure what to do here to fix it though. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing

Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

2014-06-26 Thread Jeremy Whiting
::open where the KFilterDev wont open, (bug from previous commit) not sure what to do here to fix it though. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

2014-06-26 Thread Jeremy Whiting
it though. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

git repo name in review request e-mail subject

2014-04-30 Thread Jeremy Whiting
Hey all, In looking at frameworks e-mail each day I find it would be much simpler if we would all add the git repo we are submitting the review request for in the subject. e-mail with subjects like make documentation match new values in code (not trying to single this one out, many are not that

Re: git repo name in review request e-mail subject

2014-04-30 Thread Jeremy Whiting
Ok, Added myself, good to know. That should help a bit. On Wed, Apr 30, 2014 at 4:39 PM, Christoph Feck christ...@maxiom.de wrote: On Wednesday 30 April 2014 22:55:55 Jeremy Whiting wrote: In looking at frameworks e-mail each day I find it would be much simpler if we would all add the git repo

Re: git repo name in review request e-mail subject

2014-04-30 Thread Jeremy Whiting
On Wed, Apr 30, 2014 at 6:08 PM, Michael Pyne mp...@kde.org wrote: On Wed, April 30, 2014 14:55:55 Jeremy Whiting wrote: Hey all, In looking at frameworks e-mail each day I find it would be much simpler if we would all add the git repo we are submitting the review request for in the subject

libkomparediff2

2014-04-25 Thread Jeremy Whiting
Hello, I've prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2 on the frameworks branch of it's git repo. If someone would take a look and check if I did anything wrong that would be great. It builds here and the tests all pass, but a second (or more) set of eyes is always welcome.

Re: KSpeech

2014-03-06 Thread Jeremy Whiting
On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn gladh...@kde.org wrote: Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: Took a quick read through that just now and it looks pretty promising from what I saw. I guess I don't know my way around gerrit very well because I couldn't see a place

KSpeech

2014-03-04 Thread Jeremy Whiting
Hello all, I've realized a bit ago that kspeech was not included in the kdelibs split (probably because it was in staging at the time and didn't conform to the other framework policies yet). I've cleaned it up a bit and put it in my scratch space, but have some architectural questions about it

Re: kf5 alpha 1 : attica?

2014-02-05 Thread Jeremy Whiting
if that was Jeremy Whiting or Frederik Gladhorn or someone else. Cc'ing them. Guys, any input? (Note that overall this would lower the future maintainance work on attica's buildsystem, since it will just be maintained together with the other frameworks, by anyone who makes changes to ECM

Re: Review Request 115416: Improve knewstuff dependencies

2014-01-31 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115416/#review48709 --- Ship it! Ship It! - Jeremy Whiting On Jan. 31, 2014, 11

kjs framework build failure

2014-01-22 Thread Jeremy Whiting
Hello, In trying to build frameworks on arch here I'm getting a build error in kjs/src/kjs/operations.cpp I'm not sure what I may be missing here, others report it builds fine on other distros. The offending _isnan seems to be in the original commit also, but I haven't tried to build since the

Review Request 113867: Add knewstuff public dependencies to it's config.cmake file.

2013-11-14 Thread Jeremy Whiting
--- KNewStuff's Config.cmake is missing it's public dependencies. This adds them. Diffs - tier3/knewstuff/KNewStuffConfig.cmake.in 54bee483444919ee0a337d117ff5f48139d04359 Diff: http://git.reviewboard.kde.org/r/113867/diff/ Testing --- Thanks, Jeremy Whiting

Re: Review Request 113867: Add knewstuff public dependencies to it's config.cmake file.

2013-11-14 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/113867/diff/ Testing --- Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113844: Move kspeech interface to tier3

2013-11-13 Thread Jeremy Whiting
/dbustexttospeech.desktop interfaces/kspeech/kspeech.h interfaces/kspeech/org.kde.KSpeech.xml tier3/CMakeLists.txt c801fd299d95f64d28676f80e86e2c86f9b39024 Diff: http://git.reviewboard.kde.org/r/113844/diff/ Testing --- Thanks, Jeremy Whiting

Re: Review Request 113844: Move kspeech interface to tier3

2013-11-13 Thread Jeremy Whiting
though. - Jeremy --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113844/#review43616 --- On Nov. 13, 2013, 10:16 a.m., Jeremy Whiting

Re: Review Request 113844: Move kspeech interface to tier3

2013-11-13 Thread Jeremy Whiting
c77fa19ad700c6e9af68434d7c6fdc304fceeba6 Diff: http://git.reviewboard.kde.org/r/113844/diff/ Testing --- Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113844: Move kspeech interface to tier3

2013-11-13 Thread Jeremy Whiting
://git.reviewboard.kde.org/r/113844/diff/ Testing --- Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113696: Rename knewstuff private headers to _p.h

2013-11-11 Thread Jeremy Whiting
/uploaddialog_p.h 084d626c095465b5176aa928fed1d6d6342e6e2d Diff: http://git.reviewboard.kde.org/r/113696/diff/ Testing --- It still builds. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: kdelibs/interfaces/khexedit

2013-11-11 Thread Jeremy Whiting
I see, and agree. So the way forward with kspeech would be to make it it's own framework. then at some point turn the header/dbus interface into a library that can hide the implementation details of using the dbus interface directly, right? Something like libkspeech.so that has a class/namespace

Re: the kspeech interface

2013-11-08 Thread Jeremy Whiting
I was actually wondering that myself the other day as I added to it in kdelibs master (that got branched into KDE/4.12) for a feature that hit jovie in KDE SC 4.12. It's used but really only needed to expose jovie's dbus interface for applications to use. Interestingly, knotify uses jovie but

Re: the kspeech interface

2013-11-08 Thread Jeremy Whiting
, Nov 8, 2013 at 10:40 PM, Jeremy Whiting jpwhit...@kde.org wrote: I was actually wondering that myself the other day as I added to it in kdelibs master (that got branched into KDE/4.12) for a feature that hit jovie in KDE SC 4.12. It's used but really only needed to expose jovie's dbus

Review Request 113696: Rename knewstuff private headers to _p.h

2013-11-06 Thread Jeremy Whiting
/113696/diff/ Testing --- It still builds. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113510: Deprecate methods in kimageio

2013-11-02 Thread Jeremy Whiting
/ Testing --- it still builds. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113500: make KNewStuff build on its own

2013-10-30 Thread Jeremy Whiting
/CMakeLists.txt 0cdfe43608397b756aba80dcc9c47c7ddf398d66 Diff: http://git.reviewboard.kde.org/r/113500/diff/ Testing --- Builds by itself and as part of kdelibs. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 113510: Deprecate methods in kimageio

2013-10-30 Thread Jeremy Whiting
--- KImageIO functions can be deprecated in favor of QImageReader and QImageWriter functionality. Diffs - kio/kio/kimageio.h cecadf1 Diff: http://git.reviewboard.kde.org/r/113510/diff/ Testing --- it still builds. Thanks, Jeremy Whiting

Review Request 113500: make KNewStuff build on its own

2013-10-29 Thread Jeremy Whiting
/diff/ Testing --- Builds by itself and as part of kdelibs. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Jeremy Whiting
knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1 Diff: http://git.reviewboard.kde.org/r/113388/diff/ Testing --- Builds. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 113388: Port knewstuff from KImageIO to QImageReader

2013-10-22 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113388/#review42163 --- On Oct. 22, 2013, 10:06 a.m., Jeremy Whiting wrote

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Jeremy Whiting
--- On Oct. 9, 2013, 2:24 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730

Re: Review Request 112730: add CMake changes to knewstuff

2013-10-14 Thread Jeremy Whiting
/entrydetailsdialog.cpp 65b75d79941d9026f368f82c7b6df91d754e0925 knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 Diff: http://git.reviewboard.kde.org/r/112730/diff/ Testing --- It builds and installs. Thanks, Jeremy Whiting

<    1   2   3   >