[Differential] [Updated] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2016-12-01 Thread kfunk (Kevin Funk)
kfunk added a reviewer: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jonathans, #frameworks

[Differential] [Planned Changes To] D3393: Make compile against WinXP SDK

2016-11-18 Thread kfunk (Kevin Funk)
kfunk planned changes to this revision. kfunk added inline comments. INLINE COMMENTS > dhaumann wrote in kioglobal_p_win.cpp:87 > Or should it just return false in this case? Thinking about it, yep, probably better that way. Will update the patch. REVISION DETAIL

[Differential] [Commented On] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-11-17 Thread kfunk (Kevin Funk)
kfunk added a comment. Heya Friedrich. You asked me to review this. From a super brief scan of the code I don't see anything blatantly wrong. I trust you that you've tested this good enough. Love the extensive documentation. What's left here from your side? REVISION DETAIL

[Differential] [Commented On] D3393: Make compile against WinXP SDK

2016-11-17 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D3393#63437, @dhaumann wrote: > In general ok (but why is this a review request for KSyntaxHighlighting?) Because the reviewers field auto-completion sucks :) REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL

[Differential] [Updated] D3393: Make compile against WinXP SDK

2016-11-17 Thread kfunk (Kevin Funk)
kfunk edited reviewers, added: Frameworks; removed: Framework: Syntax Hightlighting. REVISION DETAIL https://phabricator.kde.org/D3393 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, arichardson, #frameworks Cc: dhaumann

[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added a comment. And I meant this line: https://code.woboq.org/qt5/qtbase/src/corelib/io/qfsfileengine_win.cpp.html#547 (Woboq bug..., can't link the Windows version of `QFSFileEngine::drivers()`...) BRANCH master REVISION DETAIL https://phabricator.kde.org/D3392 EMAIL

[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D3392#63341, @brauch wrote: > Hm, there is at least one race condition here: thread A does old = ::SetErrorMode(...), then if before it resets it thread B does the same, then the old mode might never be restored. We can put a mutex

[Differential] [Updated] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added reviewers: brauch, Frameworks. REVISION DETAIL https://phabricator.kde.org/D3392 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, brauch, #frameworks

[Differential] [Changed Subscribers] D3226: Don't be fatal on File field not being properly parsed

2016-11-02 Thread kfunk (Kevin Funk)
kfunk added inline comments. INLINE COMMENTS > KF5ConfigMacros.cmake:71 > file(READ ${_tmp_FILE} _contents) > - string(REGEX MATCH "File=([^\n]+\\.kcfg)\n" "" "${_contents}") > + string(REGEX MATCH "File=([^\n]+\\.kcfg)c?\n" "" "${_contents}") > set(_kcfg_FILENAME

Re: Review Request 129260: Add find module for QtPlatformSupport

2016-10-25 Thread Kevin Funk
> On Oct. 25, 2016, 11:37 a.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not. > > Hrvoje Senjan wrote: > The module is internal, so it intentionally doesn't install any cmake > files.

[Differential] [Closed] D3091: Windows: Don't display error dialogs

2016-10-18 Thread kfunk (Kevin Funk)
kfunk closed this revision. kfunk added a comment. Pushed: commit f544380db86301f4833b2149dd46dca47acc8042 Author: Kevin Funk <kf...@kde.org> Date: Mon Oct 17 22:02:26 2016 +0200 Windows: Don't display error dialogs REVISION DETAIL https://phabricator.kde.org/D3091

[Differential] [Updated, 71 lines] D3091: Windows: Don't display error dialogs

2016-10-18 Thread kfunk (Kevin Funk)
kfunk updated this revision to Diff 7495. kfunk added a comment. Add Q_DISABLE_COPY CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3091?vs=7476=7495 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3091 AFFECTED FILES

[Differential] [Commented On] D3091: Windows: Don't display error dialogs

2016-10-17 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D3091#57279, @nalvarez wrote: > Meanwhile I'm skeptical of the need to "set it back". Is there any case where such error dialog boxes would be desirable? It seems like their existence is an ancient-app-compatibility thing. The

[Differential] [Commented On] D3091: Windows: Don't display error dialogs

2016-10-17 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D3091#57277, @broulik wrote: > Can't really comment on this, though. > While I'm a huge fan of RAII you don't seem to be returning early from that function RAII is not only useful for cases where you return early.

[Differential] [Updated, 70 lines] D3091: Windows: Don't display error dialogs

2016-10-17 Thread kfunk (Kevin Funk)
kfunk updated this revision to Diff 7476. kfunk added a comment. SetErrorMode -> SetThreadErrorMode (thread-safe) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3091?vs=7475=7476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3091 AFFECTED FILES

[Differential] [Updated] D3091: Windows: Don't display error dialogs

2016-10-17 Thread kfunk (Kevin Funk)
kfunk added reviewers: Frameworks, brauch. REVISION DETAIL https://phabricator.kde.org/D3091 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, brauch

Re: Scrap Baloo Thread Feedback

2016-10-07 Thread Kevin Funk
s sense for you to subscribe, no? Cheers, Kevin > (snip) -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Scrap baloo?

2016-09-30 Thread Kevin Funk
least, which work, are maintained (by more than one person) and where using them won't put another burden on us KDE developers who are lacking manpower in all different areas already. > Actually, I don't insist on a tracker based solution, but I would like to > have some that doesn't end up i

Re: Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

2016-09-26 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129020/#review99522 --- Ship it! Ship It! - Kevin Funk On Sept. 26, 2016, 9:45

Re: C++11 & friends

2016-09-13 Thread Kevin Funk
On Monday, 12 September 2016 09:10:46 CEST Jaroslaw Staniek wrote: > On 12 September 2016 at 08:04, Kevin Funk <kf...@kde.org> wrote: > > On Sunday, 11 September 2016 03:21:21 CEST Dominik Haumann wrote: > > > Hi all, > > > > > > I just saw a commi

Re: C++11 & friends

2016-09-12 Thread Kevin Funk
we take the liberty and ditch Q_NULLPTR completely for all > frameworks? > > Same also applies to 'override'. > > Best, > Dominik -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Review Request 128855: Fix build on Windows

2016-09-08 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128855/#review98993 --- Ship it! Ship It! - Kevin Funk On Sept. 7, 2016, 3:23

Re: Review Request 128855: Fix build on Windows

2016-09-07 Thread Kevin Funk
? - Kevin Funk On Sept. 7, 2016, 3:23 p.m., Gleb Popov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-09-04 Thread kfunk (Kevin Funk)
kfunk added a comment. Here's the backtrace (note: using Qt 5.6 branch): ntdll.dll!NtWaitForSingleObject() Unknown KernelBase.dll!7ffbcb2eaadf() Unknown > Qt5Core.dll!QWaitCondition::wait(QMutex * mutex=0x01c24fd16520, unsigned long

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-08-26 Thread kfunk (Kevin Funk)
kfunk added a comment. Bump? REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks

[Differential] [Commented On] D2546: Cleanup DBus-related resources before qApp exits

2016-08-26 Thread kfunk (Kevin Funk)
kfunk added a comment. Bump? REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks

[Differential] [Updated, 19 lines] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-08-23 Thread kfunk (Kevin Funk)
kfunk updated this revision to Diff 6175. kfunk added a comment. Fix typo in commit msg CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2545?vs=6173=6175 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 AFFECTED FILES src/kuiserverjobtracker.cpp

[Differential] [Updated] D2546: Cleanup DBus-related resources before qApp exits

2016-08-23 Thread kfunk (Kevin Funk)
kfunk updated the test plan for this revision. kfunk added reviewers: dfaure, vonreth. kfunk added a subscriber: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc:

[Differential] [Updated] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-08-23 Thread kfunk (Kevin Funk)
kfunk added reviewers: dfaure, vonreth. kfunk added a subscriber: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks

Re: Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label

2016-08-20 Thread Kevin Funk
> On Aug. 14, 2016, 7:17 p.m., Thomas Pfeiffer wrote: > > Actually, this is in violation of the current search HIG ( > > https://community.kde.org/KDE_Visual_Design_Group/HIG/SearchPattern ), but > > since the de-facto standard in our software and elsewhere is an inline > > hint, I suppose we

Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

2016-08-10 Thread Kevin Funk
(at least under MSVC). I'm not usually compiling kfilemetadata.git on Windows, so I wasn't affected by this change thus didn't notice. Can we make the dependency on xattr optional so we can restore the build with MSVC? - Kevin Funk On Feb. 26, 2016, 7:56 p.m., Kai Uwe Broulik wrote

Re: Review Request 128650: [KBookmarks] Fix crash on app shutdown due to QRegExp(QStringLiteral())

2016-08-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128650/#review98301 --- Rather port to `QRegularExpression` right away? - Kevin

[Differential] [Closed] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk closed this revision. kfunk added a comment. Pushed. commit 2bdb684a872aff26c01f5e1fc175fbaf663ad8ba Author: Kevin Funk <kf...@kde.org> Date: Tue Jul 12 10:18:40 2016 +0200 REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES https://phabricator.k

[Differential] [Commented On] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added a comment. FYI: There are more issues in other frameworks, the next deadlock is in kiconthemes... BRANCH master REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth,

[Differential] [Commented On] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added a comment. Waiting for a +1 from David. There's one possible point of regression, namely if `KGlobalAccel::self()` is being used after qApp ran all the post routines (and `KGlobalAccelPrivate::cleanup()` has been invoked already). Not sure if this is a problem, though.

[Differential] [Updated] D2142: KGlobalAccel: Fix deadlock on exit under Windows

2016-07-12 Thread kfunk (Kevin Funk)
kfunk added reviewers: dfaure, vonreth. kfunk added a subscriber: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2142 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, dfaure, vonreth Cc: #frameworks

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-07-11 Thread Kevin Funk
/124905/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-07-11 Thread Kevin Funk
. Because macro uses > > `${ARGN}` it shouldn't break anything. > > Kevin Funk wrote: > @dfaure: Do you think this issue should be fixed in Qt itself? > > I've just found > http://stackoverflow.com/questions/33874243/qprocessstartdetached-but-hide-console-win

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-25 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96850 --- Cool, thanks Andreas! - Kevin Funk On June 24, 2016, 8:17

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-21 Thread Kevin Funk
nFlags flags); ``` Makes the user code a bit easier to read. - Kevin Funk On June 19, 2016, 12:35 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 128194: Mark helper exe as non-gui app

2016-06-15 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128194/#review96525 --- Ship it! Ship It! - Kevin Funk On June 15, 2016, 3:43

Re: Review Request 128170: Allow nsspellcheck to be compiled on mac per default

2016-06-13 Thread Kevin Funk
tps://git.reviewboard.kde.org/r/128170/#comment65135> Nitpick: Excessive whitespace - Kevin Funk On June 13, 2016, 7:43 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 128170: Allow nsspellcheck to be compiled on mac per default

2016-06-13 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128170/#review96431 --- Ship it! Rest LGTM - Kevin Funk On June 13, 2016, 7:43

Re: KApiDox Maintainship

2016-06-10 Thread Kevin Funk
> Thanks Olivier! KApiDox does need that love! > And thanks Alex for the work so far! :) > > Aleix > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-de

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-17 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95522 --- Ship it! Ship It! - Kevin Funk On May 17, 2016, 5:55

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-04-18 Thread Kevin Funk
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review94684 ------- On Dec. 3, 2015, 8 a.m., Kevin Funk wrote: > > --- > This is an automati

Re: Review Request 127380: More conservative approach to saving some disk accesses

2016-03-19 Thread Kevin Funk
to judge. Generally I'd say "yes". Does `iconPath(..., KIconLoader::MatchBest)` return results you'd have received with `iconPath(..., KIconLoader::MatchExact)`? - Kevin Funk On March 15, 2016, 1:52 a.m., Aleix Pol Gonz

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

2016-03-19 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127406/#review93635 --- Ship it! Ship It! - Kevin Funk On March 17, 2016, 12

Re: Qt 5.6/QtWebkit

2016-03-19 Thread Kevin Funk
question. Cheers, Kevin > R. > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Desc

Re: Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

2016-03-14 Thread Kevin Funk
> On March 1, 2016, 4:37 p.m., Aleix Pol Gonzalez wrote: > > Eh... I just realized it's not 100% correct. We have a test > > (testUnknownIconNotCached) that fails, unsure how I didn't see it yesterday. > > > > The problem with this one is that we are not reacting when icons are > > introduced

Re: Review Request 127334: Fix build with -DBUILD_TEST=TRUE

2016-03-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/#review93396 --- Ship it! Ship It! - Kevin Funk On March 10, 2016, 7:04

Re: Review Request 127211: Properly use static QMaps

2016-02-28 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/#review92877 --- Ship it! Ship It! - Kevin Funk On Feb. 28, 2016, 9:52

Re: Review Request 127177: Compilation fixes for MSVC (2013)

2016-02-26 Thread Kevin Funk
tps://git.reviewboard.kde.org/r/127177/#comment63232> Remove indentation. Same below. - Kevin Funk On Feb. 25, 2016, 5:16 p.m., Thomas Friedrichsmeier wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-19 Thread Kevin Funk
tps://git.reviewboard.kde.org/r/127031/#comment63107> Maybe also add a hint / some code which shows how to use that uint? I.e. point to Qt's QT_VERSION_CHECK documentation or copy/paste it. - Kevin Funk On Feb. 19, 2016, 12:46 p.m., David Edmundson

Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Kevin Funk
--- As seen in GammaRay Diffs - src/krecursivefilterproxymodel.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f Diff: https://git.reviewboard.kde.org/r/126969/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list

Re: Review Request 126969: KRecursiveFilterProxyModel::match: Fix crash

2016-02-02 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks and Volker Krause. Changes --- Submitted with commit 11055706bca380b75da48b8f5d4c27c53d86372d by Kevin Funk to branch master. Repository: kitemmodels Description --- As seen in GammaRay Diffs - src

Re: Review Request 126745: Fix karchive autotests on Windows

2016-01-20 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks and Patrick Spendrin. Changes --- Submitted with commit 123235fc5f036e42afce90bce7d1c06742679080 by Kevin Funk to branch master. Repository: karchive Description --- Still not perfect (no proper dependencies set), but better

Re: Review Request 126745: Fix karchive autotests on Windows

2016-01-18 Thread Kevin Funk
the data in case examples/ changes. Diffs (updated) - autotests/CMakeLists.txt 39881f90c614200a6c840b67d14e6c518f8e57e9 Diff: https://git.reviewboard.kde.org/r/126745/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list

Re: Review Request 126764: Workaround for leading slash returned by QUrl::toDisplayString(QUrl::PreferLocalFile) untill fixed in Qt

2016-01-17 Thread Kevin Funk
/ Feel free to patch your self-built Qt on Windows for now... :) - Kevin Funk On Jan. 15, 2016, 10:30 p.m., Kåre Särs wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 126745: Fix karchive autotests on Windows

2016-01-14 Thread Kevin Funk
/CMakeLists.txt 39881f90c614200a6c840b67d14e6c518f8e57e9 Diff: https://git.reviewboard.kde.org/r/126745/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

2016-01-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126695/#review90838 --- Ship it! Ship It! - Kevin Funk On Jan. 10, 2016, 11:03

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126615/#review90492 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:51 p.m

Re: Review Request 126616: (ktextwidgets) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126616/#review90491 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:53 p.m

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/#review90493 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:45 p.m

Re: Review Request 126617: (kxmlgui) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

2016-01-03 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126617/#review90490 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:57 p.m

Re: Review Request 126453: Fix library order

2016-01-01 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks, Heiko Becker and Jeremy Whiting. Changes --- Submitted with commit 38685ad63b08a6c1c4de2c2ecd525188aecd3e94 by Kevin Funk to branch master. Repository: knewstuff Description --- Fixes issues leading to creation of QTBUG-47240

Re: Review Request 126453: Fix library order

2015-12-21 Thread Kevin Funk
it: https://git.reviewboard.kde.org/r/126453/#review89837 --- On Dec. 21, 2015, 4:06 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-21 Thread Kevin Funk
side (other reviewers welcome). - Kevin Funk On Dec. 21, 2015, 9:45 a.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 126453: Fix library order

2015-12-21 Thread Kevin Funk
. Repository: knewstuff Description --- Fixes issues leading to creation of QTBUG-47240 Diffs - src/CMakeLists.txt cc606444e48b0e519551183c022ccecdac0aa62f Diff: https://git.reviewboard.kde.org/r/126453/diff/ Testing --- Thanks, Kevin Funk

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-14 Thread Kevin Funk
ment61240> Duplicated documentation. Just `\sa KAboutPerson::fromJSON`? - Kevin Funk On Dec. 14, 2015, 11:45 a.m., Alex Richardson wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-12-02 Thread Kevin Funk
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84496 ------- On Aug. 27, 2015, 7:31 a.m., Kevin Funk wrote: > > --

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-27 Thread Kevin Funk
a console window when running an app on windows? I guess not? So maybe we should do whatever WIN32 does from within that function, if it's doable outside the add_executable call? Kevin Funk wrote: It's rather that `ecm_mark_non_gui_executable` is has a misleading meaning: Marks

Re: Paths to internal executables (c.f. libexec) hard-coded

2015-08-26 Thread Kevin Funk
On Wednesday 26 August 2015 13:40:20 Volker Krause wrote: On Wednesday 26 August 2015 13:15:15 Kevin Funk wrote: Heya, This is problem on Windows because the *final* installation location is not known at compile-time (obviously software is installed via installers, users can pick up

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-26 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review84389 --- On Aug. 24, 2015, 1:36 p.m., Kevin Funk wrote

Paths to internal executables (c.f. libexec) hard-coded

2015-08-26 Thread Kevin Funk
Opinions? -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-25 Thread Kevin Funk
to understand Done, see: commit 140a82d6796cb6ba82a9b173813968594113cb74 Author: Kevin Funk kf...@kde.org Date: Tue Aug 25 09:24:24 2015 +0200 Prefer qEnvironmentVariableIsSet - Kevin --- This is an automatically generated e-mail

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-25 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks, David Faure and Boudewijn Rempt. Changes --- Submitted with commit a04683c12300c6b388fad2cfcd8e173d06ca5693 by Kevin Funk to branch master. Repository: kio Description --- Make KDE_FORK_SLAVES work under Windows Diffs

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-25 Thread Kevin Funk
? - Kevin Funk On Aug. 24, 2015, 1:36 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/ --- (Updated Aug

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

2015-08-24 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 05167e5bf563f3b9b2465e9da2ecf1e4a86a0d4d by Kevin Funk to branch master. Bugs: 345860 https://bugs.kde.org/show_bug.cgi?id=345860 Repository: kcompletion Description --- Fix bad

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
/plugins/kf5/kio/file.dll from Z:/kderoot/lib/plugins/kf5/kio/file.dll ``` - Kevin Funk On Aug. 22, 2015, 10:45 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Kevin Funk
On Aug. 24, 2015, 11:52 a.m., Kevin Funk wrote: src/kglobalaccel.cpp, line 97 https://git.reviewboard.kde.org/r/124902/diff/1/?file=397839#file397839line97 Indeed. Just move into iface()? Martin Gräßlin wrote: it's also used for setting up the QDBusServiceWatcher

Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread Kevin Funk
. Repository: kio Description --- Make KDE_FORK_SLAVES work under Windows Diffs - src/core/slave.cpp 62455c1db471aa3fc1273b1bb398fbc183ddca1f Diff: https://git.reviewboard.kde.org/r/124904/diff/ Testing --- Thanks, Kevin Funk ___ Kde

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-24 Thread Kevin Funk
/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc Diff: https://git.reviewboard.kde.org/r/124905/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
On Aug. 24, 2015, 12:15 p.m., Kevin Funk wrote: More context: ``` [5748] klauncher not running... launching kdeinit [6344] kf5.kinit.klauncher: LAUNCHER_OK [2892] Could not find drkonqi at Z:/kderoot/bin/drkonqi [2892] QObject::connect: No such signal UrlHandler::destroyed

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
On Aug. 24, 2015, 12:07 p.m., Kevin Funk wrote: Still runs kbuildsycoca5 for me(?) ``` [3796] kf5.kservice.sycoca: Trying to open ksycoca from C:/Users/kfunk/AppData/Local/cache/ksycoca5 [3796] checking file timestamps [3796] timestamps check ok [3796] Emitting

Review Request 124905: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread Kevin Funk
/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-24 Thread Kevin Funk
exitStatus= 0 [5668] kf5.kservice.sycoca: Trying to open ksycoca from C:/Users/kfunk/AppData/Local/cache/ksycoca5 ``` ^ Check says ok but then still - Kevin Funk On Aug. 22, 2015, 10:45 a.m., David Faure wrote

Re: Review Request 124904: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread Kevin Funk
--- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124905: Make KDE_FORK_SLAVES work under Windows

2015-08-24 Thread Kevin Funk
://git.reviewboard.kde.org/r/124905/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124896: Fix bad behavior / running OOM on Windows

2015-08-24 Thread Kevin Funk
/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124896: Fix bad behavior / running OOM on Windows

2015-08-24 Thread Kevin Funk
/kzoneallocator.cpp 2ab9bb021ff09445f291f69ecc3f6facde7eed22 Diff: https://git.reviewboard.kde.org/r/124896/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

2015-08-24 Thread Kevin Funk
via fork, none of them (besides dbus-daemon for IPC) should be required, no? Didn't know about KDE_FORK_SLAVES yet, thanks! Anyhow - don't move away from KF5, let's work together :-) -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

2015-08-24 Thread Kevin Funk
On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: Am 2015-08-24 01:03, schrieb Kevin Funk: Right now whenever I start kdevelop I get the following daemons up and running on Windows: - dbus-daemon - kded5 - kglobalaccel5 - kioslave - klauncher KGlobalAccel should only

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Kevin Funk
started using KDevelop on Windows. Awesome! Thanks for this. - Kevin Funk On Aug. 24, 2015, 11:35 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124902

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Changes --- Submitted with commit a21e85d97f809870de94c84d2ca767260477f988 by Kevin Funk to branch master. Repository: kconfig Description --- Don't attempt to build error string in any case Diffs

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
://git.reviewboard.kde.org/r/124879/#review84189 --- On Aug. 22, 2015, 5:11 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879

Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
: kconfig Description --- Don't attempt to build error string in any case Diffs - src/gui/kconfiggroupgui.cpp e2eb950fb93d40abec0988c9af58c1ae14cb2011 Diff: https://git.reviewboard.kde.org/r/124879/diff/ Testing --- Thanks, Kevin Funk

Re: Minimum supported version of MSVC for frameworks

2015-08-17 Thread Kevin Funk
written until now anyway... Cheers, Kevin Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description

Minimum supported version of MSVC for frameworks

2015-08-13 Thread Kevin Funk
broken) C++11 support anyway) Opinions? If you want, I can make sure KF5 builds on MSVC2013, at least, in irregular intervals. Cheers [1] https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11 [2] https://paste.kde.org/pspfos96w -- Kevin Funk | kf

Re: Review Request 124696: Fix (worrying) MSVC warning

2015-08-11 Thread Kevin Funk
marked as submitted. Review request for KDE Frameworks and Mirko Boehm. Changes --- Submitted with commit ea52fb68bad35c91ed2cb39dc8cd0aeeea2f4f48 by Kevin Funk to branch master. Repository: threadweaver Description --- Warning: Z:\kderoot\download\git\threadweaver\src

<    1   2   3   4   5   6   >