Re: Review Request 124328: Man pages for kapidox

2015-07-12 Thread Kevin Krammer
and then translated by the usual docbook workflow? - Kevin Krammer On Juli 12, 2015, 4 nachm., Scott Kitterman wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124328

Re: Gerrit available for trial

2014-10-11 Thread Kevin Krammer
their own notifications in a quite flexible way. I.e. a framework maintainer could always get all noitifications for their framework. The notifications sent to the list would primarly serve as a provider of activitiy overview and new frameworks becoming available. Cheers, Kevin -- Kevin Krammer, KDE

Re: There's no proper replacement for KIcon

2014-09-12 Thread Kevin Krammer
On Thursday, 2014-09-11, 17:56:38, Eike Hein wrote: On 11.09.2014 17:22, Kevin Krammer wrote: Hicolor is there for cases where the setup fails to provide any workspace or distribution specific theme. Yes. So I'm thinking ahead and telling you how that setup looks like for a workspace

Gerrit available for trial

2014-09-12 Thread Kevin Krammer
, Kevin [1] https://gerrit.vesnicky.cesnet.cz/ [2] https://conf.kde.org/en/Akademy2014/public/events/140 -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Wednesday, 2014-09-10, 23:43:15, Albert Astals Cid wrote: El Dimarts, 9 de setembre de 2014, a les 16:25:26, Kevin Krammer va escriure: On Sunday, 2014-09-07, 10:27:06, Albert Astals Cid wrote: So as I see it, there's three options: * Do nothing, and expect that people have to set

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 09:33:23, Albert Astals Cid wrote: El Dijous, 11 de setembre de 2014, a les 08:46:11, Kevin Krammer va escriure: The rule to always also install an application icon into Hicolor was meant as an example of a general intent that Hicolor be fully usable. I don't

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 02:06:02, Albert Astals Cid wrote: El Dijous, 11 de setembre de 2014, a les 10:57:17, Kevin Krammer va escriure: On Thursday, 2014-09-11, 09:33:23, Albert Astals Cid wrote: El Dijous, 11 de setembre de 2014, a les 08:46:11, Kevin Krammer va escriure

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 15:29:13, Eike Hein wrote: On 11.09.2014 11:11, Kevin Krammer wrote: From my point of view there is little use case of having a fallback if it does not allow one to fall back to it. Check out the chat log for the idea of enhancing the spec to add some sort

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 15:40:14, Eike Hein wrote: On 11.09.2014 15:33, Kevin Krammer wrote: Sounds interesting, but checkout where? In this thread, where I've posted it and encouraged reading it a few times :). Ah :) I thought you were referring to some XDG discussion. Having

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 15:53:57, Eike Hein wrote: On 11.09.2014 15:43, Kevin Krammer wrote: Having a configurable fallback before the final fallback can't hurt, but that doesn't solve the actual problem of hicolor being incomplete. It is just a work around. Sort of, except I think

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 17:05:43, Eike Hein wrote: On 11.09.2014 16:09, Kevin Krammer wrote: Why would hicolor be distro/ISV specific? Because a hicolor theme everyone likes visually isn't going to happen. People will want to modify what's in that fall- back for theming reasons

Re: There's no proper replacement for KIcon

2014-09-09 Thread Kevin Krammer
fallback as specified? Applications already are more or less required to install their fallbacks in hicolor, so the shared icons should be there as well, no? Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description

Re: [Kde-pim] split kdepimlibs

2014-08-28 Thread Kevin Krammer
of the widgets are things like type data editors, which could be separated such that all editing logic and data handling can be used in a C++ or QML context. If the QML driven technology is not QtWidgets, then forcing a dependency might not be appreciated. Cheers, Kevin -- Kevin Krammer, KDE

Re: split kdepimlibs

2014-08-28 Thread Kevin Krammer
through it progressively. We also have Akademy and the sprint scheduled for November (?) at which we could sit down and methodically work through the list of everything and figure out what to do. I agree, it makes little sense to rush this before Akademy. Cheers, Kevin -- Kevin Krammer, KDE

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-27 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/#review65352 --- Ship it! Ship It! - Kevin Krammer On Aug. 22, 2014, 10:55

Re: split kdepimlibs

2014-08-26 Thread Kevin Krammer
akonadi-notes akonadi-socialutils gpgme++ kabc kalarmcal kblog kcalcore kcalutils kholidays kimap kioslave kldap kmbox kmime kontactinterface kpimidentities kpimtextedit kpimutils ktnef kxmlrpcclient mailtransport microblog qgpgme syndication Cheers, Kevin -- Kevin Krammer, KDE

Re: split kdepimlibs

2014-08-26 Thread Kevin Krammer
. kioslave indeed not a framework. I think that just pop3 is used by kdepim yes others can move to kio-extra Is the Akonadi IO slave in there as well? Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
://git.reviewboard.kde.org/r/119895/#comment45446 explicit Just a general question: do we really want a porting class in core addons? - Kevin Krammer On Aug. 22, 2014, 9:05 vorm., Laurent Montel wrote: --- This is an automatically generated e-mail

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
://git.reviewboard.kde.org/r/119895/ --- (Updated Aug. 22, 2014, 9:05 vorm.) Review request for KDE Frameworks, David Faure and Kevin Krammer. Repository: kcoreaddons Description --- Class helps user to migrate config file

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
On Aug. 22, 2014, 9:39 vorm., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
On Aug. 22, 2014, 9:39 vorm., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Kevin Krammer
On Aug. 22, 2014, 9:39 vorm., Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: How to promote less mature Frameworks?

2014-08-21 Thread Kevin Krammer
them to be part of kdelibs already, so there must be reasons). The libs were moved out of kdelibs at that time for different reasons, e.g. gettting them packages separately for better dependency control. Development follows the same policies as for kdelibs. Cheers, Kevin -- Kevin Krammer, KDE

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Krammer
their search engines in 10 KDE apps one after the other by hand. A centralized configuration is much more convenient. Hmm, what if KDE applications outside a KDE workspace are seen as separate entities by users of those other workspaces? Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-22 Thread Kevin Krammer
for kdecoreaddons? - Kevin Krammer On April 22, 2014, 9:32 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-22 Thread Kevin Krammer
On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: src/lib/util/kdelibs4migration.cpp, line 97 https://git.reviewboard.kde.org/r/117511/diff/2/?file=267469#file267469line97 Also maybe just a personal taste, but I find it better to explicitly use parentheses when mixing boolean

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-17 Thread Kevin Krammer
On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant for KDE applications porting, right? IMHO this would fit best in an explicit porting framework David Faure wrote: I don't want to put

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-14 Thread Kevin Krammer
On April 12, 2014, 11:12 a.m., Kevin Krammer wrote: I wonder if this really belongs in kdecoreaddons. I.e. it is only relevant for KDE applications porting, right? IMHO this would fit best in an explicit porting framework David Faure wrote: I don't want to put

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-12 Thread Kevin Krammer
. it is only relevant for KDE applications porting, right? IMHO this would fit best in an explicit porting framework src/lib/util/kdelibs4migration.cpp https://git.reviewboard.kde.org/r/117511/#comment38618 initialize d to nullptr? - Kevin Krammer On April 12, 2014, 11:01 a.m., David Faure wrote

Re: Move KDED out of frameworks?

2014-03-29 Thread Kevin Krammer
On Saturday, 2014-03-29, 01:21:24, Aleix Pol wrote: On Fri, Mar 28, 2014 at 9:14 PM, Kevin Krammer kram...@kde.org wrote: I thought I was obvious that I was addressing the Aleix's concern about portability of frameworks requiring D-Bus, but I must have failed at that. I'll try to make

Re: Move KDED out of frameworks?

2014-03-28 Thread Kevin Krammer
which discussed enabling QtDBus by default in Windows and Mac builds. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde

Re: Move KDED out of frameworks?

2014-03-28 Thread Kevin Krammer
On Friday, 2014-03-28, 20:26:59, Boudewijn Rempt wrote: On Fri, 28 Mar 2014, Kevin Krammer wrote: D-Bus does run on most platforms, at least on desktop. There was a thread on the Qt development list a short while ago which discussed enabling QtDBus by default in Windows and Mac builds

Re: Move KDED out of frameworks?

2014-03-28 Thread Kevin Krammer
On Friday, 2014-03-28, 20:55:02, Boudewijn Rempt wrote: On Fri, 28 Mar 2014, Kevin Krammer wrote: The D-Bus session/user daemon is also something that needs to be treated in a platform specific way as a dependency. E.g. on Windows there could be a D-Bus installer that applications bundle

Re: Query: Possible code contribution

2014-03-20 Thread Kevin Krammer
Hi, On Wednesday, 2014-03-19, 23:36:27, Harsh Kumar wrote: On 3/16/14, Kevin Krammer kram...@kde.org wrote: One other thing that came to my mind is development of examples for Frameworks 5, see [1] and [2]. Only a couple of the frameworks seem to have an examples subdirectory. I

Re: Query: Possible code contribution

2014-03-16 Thread Kevin Krammer
. Maybe even having tutorials on techbase.kde.org explaining the steps that were necessary to create the examples. CCing the frameworks development list. Cheers, Kevin [1] https://dot.kde.org/2014/03/04/kde-frameworks-5-alpha-two-out [2] http://community.kde.org/Frameworks -- Kevin Krammer, KDE

Re: Frameworks book

2014-03-16 Thread Kevin Krammer
be downloaded again. Cheers, Kevin [1] https://leanpub.com/ -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread Kevin Krammer
-- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring attachment: tier3-kjsembed.png signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

2014-03-01 Thread Kevin Krammer
On Saturday, 2014-03-01, 15:37:05, David Faure wrote: On Saturday 01 March 2014 13:37:31 Kevin Krammer wrote: On Saturday, 2014-03-01, 13:19:23, David Faure wrote: On Saturday 01 March 2014 12:12:37 KDE CI System wrote: CMake Error at CMakeLists.txt:30 (find_package): Could

Re: Review Request 116030: Extend tests to cover getConf... calls

2014-03-01 Thread Kevin Krammer
/ktranscripttest.cpp e3a27ff autotests/test.js ad53b1b autotests/testhelpers.h PRE-CREATION autotests/testhelpers.cpp PRE-CREATION src/ktranscript.cpp 44c8b63 Diff: https://git.reviewboard.kde.org/r/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin

Re: Review Request 116050: Adjust kpty tier for changed ki18n tier

2014-02-27 Thread Kevin Krammer
, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116049: Adjust kjsembed tier for changed ki18n tier

2014-02-27 Thread Kevin Krammer
/diff/ Testing --- Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Kevin Krammer
src/platformtheme/kdeplatformsystemtrayicon.cpp https://git.reviewboard.kde.org/r/116075/#comment35729 I see lambdas being using later on, in which case this looks like a candidate for std::find_if() with a lambda predicate - Kevin Krammer On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote

Re: Review Request 116030: Extend tests to cover getConf... calls

2014-02-25 Thread Kevin Krammer
/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116049: Adjust tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
: kjsembed Description --- ki18n changed from tier 2 to tier 1. kjsembed only depends on tier 1 now, becomes tier 2 Diffs - kjsembed.yaml 78c0a75 Diff: https://git.reviewboard.kde.org/r/116049/diff/ Testing --- Thanks, Kevin Krammer

Review Request 116050: Adjust kpty tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
--- ki18n changed from tier 2 to tier 1. kpty only depends on tier 1 now, becomes tier 2 Diffs - kpty.yaml 78c0a75 Diff: https://git.reviewboard.kde.org/r/116050/diff/ Testing --- Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing

Review Request 116051: Adjust kunitconversion tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
. Repository: kunitconversion Description --- ki18n changed from tier 2 to tier 1. kunitconversion only depends on tier 1 now, becomes tier 2 Diffs - kunitconversion.yaml 78c0a75 Diff: https://git.reviewboard.kde.org/r/116051/diff/ Testing --- Thanks, Kevin Krammer

Re: Review Request 116049: Adjust kjsembed tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
2 Diffs - kjsembed.yaml 78c0a75 Diff: https://git.reviewboard.kde.org/r/116049/diff/ Testing --- Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 116051: Adjust kunitconversion tier for changed ki18n tier

2014-02-25 Thread Kevin Krammer
://git.reviewboard.kde.org/r/116051/diff/ Testing --- Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-24 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50535 --- On Feb. 22, 2014, 2:15 p.m., Kevin Krammer wrote

Review Request 116030: Extend tests to cover getConf... calls

2014-02-24 Thread Kevin Krammer
://git.reviewboard.kde.org/r/116030/diff/ Testing --- All previously existing tests continue to run :) Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread Kevin Krammer
specific, i.e. would still work if QDialogButtonBox is replaced with something else in the future. But usage of the button box already leaks, there are two protected accessors to it. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-23 Thread Kevin Krammer
On Sunday, 2014-02-23, 18:41:38, David Faure wrote: On Sunday 23 February 2014 14:17:29 Kevin Krammer wrote: But usage of the button box already leaks, there are two protected accessors to it. In which class? You lost me. KPageDialog, base class of KConfigDialog according to the API docs

Re: kguiaddons uses qpa headers?

2014-02-23 Thread Kevin Krammer
to it. Obviously the returned object and its functionality is platform specific, but afterall its very purpose is to enable platform integration that goes beyond the things that can be wrapped in an abstraction across multiple platforms. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer

Review Request 115979: Cleanup after QtScript port

2014-02-23 Thread Kevin Krammer
/115979/diff/ Testing --- Everything still builds and tests succeed. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115979: Cleanup after QtScript port

2014-02-23 Thread Kevin Krammer
ki18n.yaml 9b601d5 src/ktranscript.cpp 4cdae75 Diff: https://git.reviewboard.kde.org/r/115979/diff/ Testing --- Everything still builds and tests succeed. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
://git.reviewboard.kde.org/r/115983/diff/ Testing --- All tests still run successfully Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
object is never deleted during runtime. So this just cleans up before process exit - Kevin Krammer On Feb. 23, 2014, 9:52 p.m., Kevin Krammer wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
object is never deleted during runtime. So this just cleans up before process exit - Kevin Krammer On Feb. 23, 2014, 9:52 p.m., Kevin Krammer wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115983: Reduce memory leaks

2014-02-23 Thread Kevin Krammer
== suppressed: 0 bytes in 0 blocks Diffs - src/ktranscript.cpp 1ce0d1a Diff: https://git.reviewboard.kde.org/r/115983/diff/ Testing --- All tests still run successfully Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115936: Split ki18n ktranscript tests into one using the plugin and one instantiating/destroying the class directly

2014-02-22 Thread Kevin Krammer
/ktranscripttest.cpp 78aecb4 src/ktranscript.cpp c922e91 src/ktranscript_p.h f1cc132 Diff: https://git.reviewboard.kde.org/r/115936/diff/ Testing --- All three tests run without failure Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50522 --- On Feb. 21, 2014, 4:30 p.m., Kevin Krammer wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 115936: Split ki18n ktranscript tests into one using the plugin and one instantiating/destroying the class directly

2014-02-22 Thread Kevin Krammer
/ Testing --- All three tests run without failure Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
. There is also a weird crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
requirements. There is also a weird crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Kevin Krammer
. There is also a weird crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: using KDBusConnectionPool in libraries

2014-02-21 Thread Kevin Krammer
, each running in a different thread. My guess is that it is thread-safe for sending, i.e. messages won't be interleaved, but there always needs to be a thread that runs the event loop for receiving and it is probably also the one that gets all replies and incoming calls. Cheers, Kevin -- Kevin

Re: Review Request 115936: Split ki18n ktranscript tests into one using the plugin and one instantiating/destroying the class directly

2014-02-21 Thread Kevin Krammer
src/ktranscript_p.h f1cc132 Diff: https://git.reviewboard.kde.org/r/115936/diff/ Testing --- All three tests run without failure Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-20 Thread Kevin Krammer
, visit: https://git.reviewboard.kde.org/r/115485/#review50376 --- On Feb. 16, 2014, 6:54 p.m., Kevin Krammer wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-16 Thread Kevin Krammer
crash at test shutdown, in QThreadStorage. As far as I can tell I did not change anything related to threads though. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: HAVE_X11 usage in KIO/core

2014-02-07 Thread Kevin Krammer
(Unknown) #endif Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-06 Thread Kevin Krammer
On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: Wow, great work! I attempted doing this some time ago, and all I managed to produce was two unit tests :). Looks good to me and works fine here. Just two (really minor) nitpicks. Kevin Krammer wrote: Thanks :) Good to hear

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Kevin Krammer
tell I did not change anything related to threads though. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-05 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review49036 --- On Feb. 5, 2014, 4:08 p.m., Kevin Krammer wrote

Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-04 Thread Kevin Krammer
to threads though. Thanks, Kevin Krammer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Change the ML default reply-to address

2014-01-31 Thread Kevin Krammer
-- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Change the ML default reply-to address

2014-01-29 Thread Kevin Krammer
repliably I've fallen back to using the mouse and right-clicking the right address. Pretty annoying but some mailinglists seem to have broken setups. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally

Re: Change the ML default reply-to address

2014-01-29 Thread Kevin Krammer
On Wednesday, 2014-01-29, 11:43:37, Martin Klapetek wrote: On Wed, Jan 29, 2014 at 11:23 AM, Kevin Krammer kram...@kde.org wrote: I am subscribed to more than two dozend KDE mailinglist (and numerous others). I post to some of the regularily while some others only sporadically. New mail

Re: Where to put QML Bindings for KDE frameworks?

2014-01-29 Thread Kevin Krammer
agree :) Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Change the ML default reply-to address

2014-01-29 Thread Kevin Krammer
On Wednesday, 2014-01-29, 12:30:55, Martin Gräßlin wrote: On Wednesday 29 January 2014 11:23:31 Kevin Krammer wrote: I am subscribed to more than two dozend KDE mailinglist (and numerous others). I post to some of the regularily while some others only sporadically. New mail to list

Re: Change the ML default reply-to address

2014-01-29 Thread Kevin Krammer
since this sends mails to the other person twice. Once directly and once through the list. IMHO it really sucks when that happens, polluting *my* inbox when replying to my mails on a list. Make sure you always remove the sender after you've hit reply-all for a list! Cheers, Kevin -- Kevin

Question regarding build of item models framework on Window

2014-01-22 Thread Kevin Krammer
Hi all, you are probably not subscribed to kde-devel so you might have missed that one: http://lists.kde.org/?l=kde-develm=139021750622083w=2 Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description

Re: Tier status of attica kwallet

2014-01-22 Thread Kevin Krammer
service, so that might be another unrelated framework. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel

Re: kwallet-framework optionally depends on kdepimlibs

2014-01-14 Thread Kevin Krammer
to date. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: New test with C++11 and lambda (UDSEntry testcase)

2013-09-21 Thread Kevin Krammer
) contained in one testcase method. Otherwise i would have to make signal/slot connections to member functions which is probably not something you want for testcases.. Wouldn't it also be possible to use QSignalSpy? Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Kevin Krammer
On Sunday, 2013-08-25, Valentin Rusu wrote: On 08/24/2013 02:32 PM, Kevin Krammer wrote: On Saturday, 2013-08-24, Albert Astals Cid wrote: El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: * AFAIK, frameworks should be independent and self-contained. kwallet

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-24 Thread Kevin Krammer
. if a lib needs a binary, that binary and the lib should be shipped together One thing that could be put into consideration is whether the library/API would work with any SecretService implementation or require kwalletd specifically. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

2013-08-07 Thread Kevin Krammer
context menu handling the text edit has configured? - Kevin Krammer On Aug. 6, 2013, 4:23 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912

Re: RFC: spell checking for QTextEdit

2013-08-07 Thread Kevin Krammer
spellchecking is a choice, the application developer has the best knowledge about whether a text edit will be used for natural language input or some code like text which would only confuse the spell checker anyway. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user

Re: RFC: spell checking for QTextEdit

2013-08-07 Thread Kevin Krammer
things like that anyway, i.e. functionality available in KDE Framworks becoming important enought to make it viable for Qt upstreaming. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-06 Thread Kevin Krammer
://git.reviewboard.kde.org/r/111689/#comment27513 if you create a QFileInfo object you can ask it for exits and use its isAbsolute() check later on instead of assuming Unix paths in line 72 - Kevin Krammer On Aug. 5, 2013, 11:29 p.m., Sebastian Kügler wrote

Re: Thoughts on the default syntax highlighter for QTextEdit task

2013-08-05 Thread Kevin Krammer
-- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Thoughts on the default syntax highlighter for QTextEdit task

2013-08-05 Thread Kevin Krammer
developer use it. Making it easy to hook it up with text input widgets would be a good feature in any case. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Kevin Krammer
? Not that it matters a lot given there are only two keys, just saying :) - Kevin Krammer On Aug. 1, 2013, 4:32 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Kevin Krammer
On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57 http://git.reviewboard.kde.org/r/111689/diff/3/?file=175832#file175832line57 Do we want the output/errors to be translated? Sebastian Kügler wrote: It's really

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-07-30 Thread Kevin Krammer
it build with NO_CAST_FROM_ASCII? staging/kservice/tools/desktoptojson/kconfigtojson.cpp http://git.reviewboard.kde.org/r/111689/#comment27175 different style in placement in header/source - Kevin Krammer On July 30, 2013, 7:45 p.m., Sebastian Kügler wrote

Re: DataEngine KPluginFactory

2013-07-01 Thread Kevin Krammer
On Monday, 2013-07-01, Sebastian Kügler wrote: On Monday, July 01, 2013 13:35:27 Kevin Krammer wrote: On Monday, 2013-07-01, Sebastian Kügler wrote: On Monday, July 01, 2013 09:03:29 Kevin Krammer wrote: What if the macro only creates the header content (as its name already suggests

Re: Add step parameter to DoubleInput QInputDialog

2013-05-10 Thread Kevin Krammer
KInputDialog::getItemList(), no? Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Add step parameter to DoubleInput QInputDialog

2013-05-10 Thread Kevin Krammer
On Friday, 2013-05-10, David Faure wrote: On Friday 10 May 2013 09:27:44 Kevin Krammer wrote: On Friday, 2013-05-10, David Faure wrote: On Wednesday 08 May 2013 17:26:17 David Gil Oliva wrote: Therefore, I think that it would be best to add a static method called getItemFromListView

Re: Add step parameter to DoubleInput QInputDialog

2013-05-10 Thread Kevin Krammer
On Friday, 2013-05-10, David Faure wrote: On Friday 10 May 2013 10:11:05 Kevin Krammer wrote: On Friday, 2013-05-10, David Faure wrote: I found no actual use case in the whole KDE code, for actual multiselection. All calls to getItemList are followed by a .first() or equivalent

Re: libexec (Re: kde5 or kf5 ?)

2013-02-23 Thread Kevin Krammer
not to use the native file dialogs or icons being loaded from resources and not using QIcon::fromTheme(). Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part

  1   2   >