D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

graesslin added a comment. The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

graesslin added a comment. For done code this warning is pointless and negative. I invite you to work with a code base like KWin where it is more important to have a working git blame than protection for theoretical problems. Nobody will be able to guarantee that a 500+ change to add

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

graesslin added a comment. This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for the way you developed C++ for 20 years. REPOSITORY R240 Extra CMake Modules

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

graesslin added a comment. I'm the author of this interface and I consider it nowadays as a mistake to have added it. If I would restart I would do the whole thing differently: input events need to be injected through a kernel module in a dedicated input device. It would need a user space

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

graesslin added a comment. I don't want to have key press/release in it. It has a reason that I didn't add key press/release from the start. The problem is the mismatch of key events and keysyms. Especially the kdeconnect use case for which this interface was developed has this problem.

D18114: FakeInput: add support for pointer move with absolute coordinates

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fake-input.xml:44 > > + > + New requests can only be added at end. Since is missing. > fakeinput_interface.cpp:85 >

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

graesslin added a subscriber: plasma-devel. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14910 To: graesslin, #kwin, #frameworks, davidedmundson Cc: plasma-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

graesslin added a comment. Sorry for strange upload, arc decided to no longer like me. I created the patch on Jun 30, 2017. Unfortunately the issue was embargo on freedesktop.org with the idea of a coordinated release. Today the patch for weston landed so I consider the embargo as

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

graesslin created this revision. graesslin added reviewers: KWin, Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. graesslin requested review of this revision. REVISION SUMMARY To better isolate the clients from each other eachh

D13541: Port solid from Qt5::Widgets to Qt5::Gui

graesslin created this revision. graesslin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. graesslin requested review of this revision. REVISION SUMMARY The only usage of widgets was to get the

D13535: Do not cancel old clipboard selection if it is same as the new one.

graesslin added a comment. I would appreciate a unit test for the issue. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks Cc: graesslin, kde-frameworks-devel, michaelh, ngraham, bruns

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

graesslin added a comment. I wouldn't change plasmaquick based on KWin's behavior. KWin is weird after all. We should rather work around inside KWin. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: graesslin,

D11925: Add "SkipSwitcher" to API

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. wonderful! Thanks to you two :-) And yes as soon as you push this change you can push the kwin change. REPOSITORY R127 KWayland BRANCH arcpatch-D11925 REVISION DETAIL

D12820: Add KWayland virtual desktop protocol

graesslin added inline comments. INLINE COMMENTS > mart wrote in org_kde_plasma_virtual_desktop.xml:45 > the virtualdesktop would then have an output property used for filtering? > or, the layout event could be kept in the manager, but be not just rows and > column, but pass the pair output and

D11925: Add "SkipSwitcher" to API

graesslin added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. any update on this? It's just the version increase in registry.cpp which is missing... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

graesslin added a comment. Restricted Application added a subscriber: kde-frameworks-devel. any update on this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: kde-frameworks-devel, graesslin, plasma-devel, ragreen,

D12820: Add KWayland virtual desktop protocol

graesslin added inline comments. INLINE COMMENTS > mart wrote in org_kde_plasma_virtual_desktop.xml:45 > How you would envision different virtual desktops per output? > to me is a bit of a weird concept, as an output is an actual desktop, not > virtual? Have a look at i3. Btw it's a really

D12820: Add KWayland virtual desktop protocol

graesslin added inline comments. INLINE COMMENTS > mart wrote in org_kde_plasma_virtual_desktop.xml:45 > Ok, so no layout information at all neither in the manager nor in the single > virtual desktops? > I kindof like that as makes things a lot simpler. Tough in this case if the > concept of

D12820: Add KWayland virtual desktop protocol

graesslin added inline comments. INLINE COMMENTS > org_kde_plasma_virtual_desktop.xml:4 > +

D12388: Output device color curves correction

graesslin added inline comments. Restricted Application added a subscriber: kde-frameworks-devel. INLINE COMMENTS > outputchangeset.cpp:91 > } > + > bool OutputChangeSet::positionChanged() const nitpick: added unrelated new line > outputdevice_interface.cpp:427 > + > +

D12388: Output device color curves correction

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please increase the versions. INLINE COMMENTS > output-management.xml:82 > > > please increment version > output-management.xml:142 > > + > +

D11925: Add "SkipSwitcher" to API

graesslin added a comment. The adjustments in registry.cpp are still missing. INLINE COMMENTS > graesslin wrote in plasmawindowmanagement_interface.cpp:122 > you need to increase the version number. this needs to be 9 REPOSITORY R127 KWayland REVISION DETAIL

D11925: Add "SkipSwitcher" to API

graesslin added a comment. There is one more file which need changes. In src/client/registry.cpp you need to increase the version numbers of the two changed protocols. Adding a new request can be really cumbersome. INLINE COMMENTS > plasmashell_interface.cpp:53 > > const quint32

D11583: Add platform detection and adjustment to kded

graesslin added a comment. Btw could someone please push for me. I'm not around the next two weeks REPOSITORY R297 KDED BRANCH platform-detection REVISION DETAIL https://phabricator.kde.org/D11583 To: graesslin, #frameworks, #plasma, apol, romangg Cc: michaelh, ngraham, bruns

D11583: Add platform detection and adjustment to kded

graesslin added a comment. In D11583#241314 , @apol wrote: > I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise is that this won't be a problem with Qt 5.11, right? Let's wait for it to happen, then we can still

D11924: Add "SkipSwitcher" to API

graesslin added a comment. In D11924#240631 , @ngraham wrote: > Martin, @sharvey does not yet have commit access. Would you like to land this patch for him, or should I? Please push, I probably won't get to it the next two weeks.

D11924: [WIP] Add "SkipSwitcher" to API

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

graesslin added a comment. In D11924#240045 , @graesslin wrote: > I'm not sure whether we can add elements to the states. Just checked: An implementation MAY add new atoms to this list. Implementations without extensions MUST

D11924: [WIP] Add "SkipSwitcher" to API

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I'm not sure whether we can add elements to the states. INLINE COMMENTS > netwininfotestwm.cpp:432 > const QByteArray skipTaskbar = >

D11925: [WIP] Add "SkipSwitcher" to API

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > sharvey wrote in plasmawindowmodel.h:110 > Correct version number? 5.45? I normally update those just before pushing to the next frameworks release

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

Hi Ben, I pushed a possible fix. No guarnatees as this code obviously compiled on my system. Could the compiler settings please be adjusted so that we have warnings be warnings on all ci systems and not fail on randomly? This was rather unexpected for me and makes it quite difficult to

D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

graesslin added inline comments. INLINE COMMENTS > kossebau wrote in netwm.cpp:2845-2847 > Seems clang (at least as of FreeBSD with -Wc++11-narrowing) does not like > this narrowing from the int topology properties to the uint32_t array one: > > 00:37:23

D11583: Add platform detection and adjustment to kded

graesslin created this revision. graesslin added reviewers: Frameworks, Plasma, apol. Restricted Application added a project: Frameworks. graesslin requested review of this revision. REVISION SUMMARY Current Plasma/master branch does no longer set the QT_QPA_PLATFORM env variable on Wayland.

D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

This revision was automatically updated to reflect the committed changes. Closed by commit R278:cc5d6fde1aba: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11414?vs=29760=30083#toc REPOSITORY R278

D11414: [xcb] Fix implementation of _NET_WM_FULLSCREEN_MONITORS

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added a project: Frameworks. graesslin requested review of this revision. REVISION SUMMARY According to NETWM spec the client "wishing to change this list MUST send a

D10235: [server] Add support for the frame semantics of Pointer version 5

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b6bd28ab0492: [server] Add support for the frame semantics of Pointer version 5 (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10235?vs=26336=28563#toc REPOSITORY

D10081: Don't assert if used incorrectly from dbus

This revision was automatically updated to reflect the committed changes. Closed by commit R268:7d272782a55e: Dont assert if used incorrectly from dbus (authored by graesslin). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10081?vs=26098=28562 REVISION

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R127:2dfe16d774c7: [server] Properly handle the situation when the DataSource for a drag gets… (authored by graesslin). Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

D10235: [server] Add support for the frame semantics of Pointer version 5

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. In D10235#213009 , @romangg wrote: > Shouldn't the sendFrame event sent by the compositor explicitly? The way it's currently send after

D10081: Don't assert if used incorrectly from dbus

graesslin added a comment. ping REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D10081 To: graesslin, #frameworks Cc: romangg, michaelh

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10142 To: graesslin, #frameworks, #kwin, #plasma Cc: plasma-devel, michaelh, ZrenBot, lesliezhai,

D10235: [server] Add support for the frame semantics of Pointer version 5

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin, #kwin, #plasma, #frameworks Cc: plasma-devel, schernikov, michaelh, ZrenBot,

D10495: Workaround to restore KF5 programs from system tray

graesslin added a comment. In D10495#205811 , @stikonas wrote: > This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10142 To: graesslin, #frameworks, #kwin, #plasma Cc: plasma-devel, schernikov, michaelh, ZrenBot,

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R127:d38825d934e4: [server] Dont crash when a subsurface gets commited whose parent surface got… (authored by graesslin). Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. In https://phabricator.kde.org/D10300#202468, @lbeltrame wrote: > Ping? Why this has not been committed even if in "accepted" state? Because I wasn't at my system yet.

D9207: Don't load KDE platform module in kglobalaccel5

graesslin added a comment. In https://phabricator.kde.org/D9207#201848, @hein wrote: > Well, the maintainer spoke out against it, so not much I can do. Please be aware that I am no longer the maintainer of kglobalaccel. Nevertheless I recommend against it as the risk of breakage

D10314: Use F11 as the shortcut to toggle the aside preview

graesslin added a comment. In https://phabricator.kde.org/D10314#201553, @ngraham wrote: > Yeah, and Dolphin already overloads that by using F11 to show and hide the Information panel. I wouldn't object to using a different keyboard shortcut, but then we'd want to but we'd want to do it

D10314: Use F11 as the shortcut to toggle the aside preview

graesslin added a comment. I'm a little bit late to the party, but F11is kind of the standard key for fullscreen. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10314 To: ngraham, #frameworks, markg Cc: graesslin, ltoscano, markg, michaelh, ngraham

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10235: [server] Add support for the frame semantics of Pointer version 5

graesslin created this revision. graesslin added reviewers: KWin, Plasma, Frameworks. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10081: Don't assert if used incorrectly from dbus

graesslin updated this revision to Diff 26098. graesslin added a comment. Remove the usless assert Roman found REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10081?vs=25895=26098 BRANCH dont-assert-on-dbus-misusage REVISION DETAIL

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10081: Don't assert if used incorrectly from dbus

graesslin created this revision. graesslin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. graesslin requested review of this revision. REVISION SUMMARY The component dbus interface allowed to remote kill the wayland session by sending an incorrect request to

D10040: Add serial number and EISA ID to OutputDevice interface

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > outputdevice.xml:104-107 > + + summary="textual representation of serial number"/> > + + summary="textual

[kglobalaccel] /: Stepping down as maintainer of KGlobalAccel

Git commit 147acd294dd08ab6c7468d34457d4d9d7995d988 by Martin Flöser. Committed on 13/01/2018 at 15:24. Pushed by graesslin into branch 'master'. Stepping down as maintainer of KGlobalAccel CCMAIL: kde-frameworks-devel@kde.org M +1-1metainfo.yaml https://commits.kde.org/kglobalaccel

[kwindowsystem] /: Stepping down as maintainer of KWindowSystem

Git commit 5b28310ef15360b05c1899a4cb229b4d71d28743 by Martin Flöser. Committed on 13/01/2018 at 15:22. Pushed by graesslin into branch 'master'. Stepping down as maintainer of KWindowSystem CCMAIL: kde-frameworks-devel@kde.org M +1-1metainfo.yaml https://commits.kde.org/kwindowsystem

Stepping down as KGlobalAccel and KWindowSystem maintainer after 5.42

Hi all, I had sent a mail some time ago asking for someone to step up as KGlobalAccel maintainer. I kept maintaining it as I didn't want to leave it in empty hands. But I feel the time is come for me that I am no longer able to maintain KGlobalAccel and as well KWindowSystem. Both are too

D9656: Fix naming inconsistency

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9656 To: davidedmundson, #plasma,

D9599: Create interface for passing server decoration palettes

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9599 To: davidedmundson, #plasma,

Re: Required Compiler for KDE Frameworks

Am 2017-12-30 23:41, schrieb Dominik Haumann: Hi, on https://community.kde.org/Frameworks/Policies, it says: The following minimal compiler versions are supported by KDE Frameworks: - GCC 4.6 - Clang 3.1 - VS2012 (MSVC11) Is this list really up-do-date? Afaik, we even require

D9550: Don't set the LD_LIBRARY_PATH in prefix.sh

graesslin accepted this revision. graesslin added inline comments. INLINE COMMENTS > prefix.sh.cmake:3-4 > + > +# LD_LIBRARY_PATH only needed if you are building without rpath > +# export LD_LIBRARY_PATH=@KDE_INSTALL_FULL_LIBDIR@:$LD_LIBRARY_PATH > Just a note: this would break for

D9510: [server] Add a method IdleInterface::simulateUserActivity

This revision was automatically updated to reflect the committed changes. Closed by commit R127:4595a2c2709e: [server] Add a method IdleInterface::simulateUserActivity (authored by graesslin). Restricted Application edited projects, added Plasma on Wayland; removed Plasma. CHANGED PRIOR TO

D9136: Add support for version 3 of data device manager interface

This revision was automatically updated to reflect the committed changes. Closed by commit R127:a715a6cd1fe3: Add support for version 3 of data device manager interface (authored by graesslin). Restricted Application edited projects, added Plasma on Wayland; removed Plasma. CHANGED PRIOR TO

D9510: [server] Add a method IdleInterface::simulateUserActivity

graesslin created this revision. graesslin added reviewers: Frameworks, Plasma, KWin. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY So far only the client was able to simulate user activity. This

D9407: Scope exported/imported objects to the test

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9407 To: davidedmundson, #plasma,

D9406: Fix ASAN warning on TestXdgForeign

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9406 To: davidedmundson, #plasma, graesslin Cc:

D9402: Fix error in WaylandSurface::testDisconnect

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9402 To: davidedmundson, #plasma,

D9319: Fix ASAN warnings in XDGForeignV2Interface

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9319 To: davidedmundson, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,

D9207: Don't load KDE platform module in kglobalaccel5

graesslin added a comment. In https://phabricator.kde.org/D9207#178257, @apol wrote: > In https://phabricator.kde.org/D9207#176322, @graesslin wrote: > > > I'm against a risky change here. Especially as this becomes irrelevant with Wayland. > > > What makes it risky?

D9136: Add support for version 3 of data device manager interface

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. INLINE COMMENTS > broulik wrote in datadevicemanager.h:74 > Should `Ask` perhaps become a bigger number in case stuff gets added in the > middle later like `Link` or is that

D9136: Add support for version 3 of data device manager interface

graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D9136 To: graesslin, #frameworks, #plasma, #kwin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8652: Add supported transformations to OutputDevice

graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. In https://phabricator.kde.org/D8652#176706, @davidedmundson wrote: > The comment about being static needs to be in the protocol xml too. Then this is good to go. > > ( though

D9209: Don't set a window icon in Plasma::Dialog

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9209 To: hein, #plasma, #frameworks, davidedmundson, graesslin Cc: broulik, plasma-devel, ZrenBot,

D9207: Don't load KDE platform module in kglobalaccel5

graesslin added a comment. I'm against a risky change here. Especially as this becomes irrelevant with Wayland. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9207 To: hein, #plasma, davidedmundson, mart Cc: graesslin, plasma-devel, #frameworks, ZrenBot,

D9136: Add support for version 3 of data device manager interface

graesslin created this revision. graesslin added reviewers: Frameworks, Plasma, KWin. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The main difference compared to version 2 is additional drag and

D9119: Initialize scale factor to the last scale factor set on any instance

graesslin added a comment. I agree with David that this is a hack. Also I think it will fail for multi screen with different dpi. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9119 To: hein, #plasma, davidedmundson, broulik, mart Cc: graesslin,

D9104: Properly do strings in the kpackage framework

graesslin added a comment. There are a few unrelated changes, but otherwise looks good. INLINE COMMENTS > package.cpp:360 > //Nested loop, but in the medium case resolves to just one iteration > -//qDebug() << "prefixes:" << prefixes.count() << prefixes; > +// qDebug() <<

D9092: Group some blocking dbus calls

graesslin accepted this revision. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D9092 To: apol, #frameworks, #plasma, davidedmundson, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D9086: [KWindowEffectsPrivateX11] Add reserve() call

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D9086 To: broulik, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9048: [kglobalaccel] Drop QWidget dependency

graesslin added inline comments. INLINE COMMENTS > anthonyfieroni wrote in CMakeLists.txt:36 > A depend has widgets on a public interface, i guess If KGlogalAccel needs Widgets, Widgets must stay. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9048 To:

D8919: Add explicit AppMenu protocol

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8919 To: davidedmundson, #plasma,

D8858: Fix testWaylandFullscreenShell.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,

D8919: Add explicit AppMenu protocol

graesslin added inline comments. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. INLINE COMMENTS > appmenu.xml:37-38 > + > + > + > + Could you please add "The string must be encoded in latin-1". REPOSITORY R127 KWayland

D8998: Add FindSeccomp to find-modules

graesslin added inline comments. INLINE COMMENTS > davidk wrote in FindSeccomp.cmake:50-55 > I'm not sure about this. @graesslin is this nessecarry? Most find-modules > don't check for the CMake version, and we don't do anything special here. No idea, that's copy pasted from some other cmake

D8919: Add explicit AppMenu protocol

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in appmenu.cpp:178 > Wayland strings can be UTF-8 but DBus service names and object paths can only > be ASCII. > > I figured it was best to avoid any potential locale issues. Fair enough. I wasn't aware of the DBus

D8919: Add explicit AppMenu protocol

graesslin added a comment. Looks good, just a few minor comments. INLINE COMMENTS > appmenu.cpp:178 > +Q_ASSERT(isValid()); > +org_kde_kwin_appmenu_set_address(d->appmenu, serviceName.toLatin1(), > objectPath.toLatin1()); > +} why toLatin1? I would expect a toUtf8? >

D8858: Fix testWaylandFullscreenShell.

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Could you please add a message that it is missing? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc:

D8396: Add support for zwp_idle_inhibit_manager_v1

This revision was automatically updated to reflect the committed changes. Closed by commit R127:9520c2f292d0: Add support for zwp_idle_inhibit_manager_v1 (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8396?vs=21046=22482#toc REPOSITORY R127 KWayland CHANGES

D8396: Add support for zwp_idle_inhibit_manager_v1

graesslin added a comment. In https://phabricator.kde.org/D8396#168165, @davidedmundson wrote: > I think we need some big discussion about how powerdevil inhbitions, logind inhibitions and this are all going to fit together in a clear coherent way. yeah. I'm not happy with this

D8383: [server] Support inhibiting the IdleInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R127:42b2daaec407: [server] Support inhibiting the IdleInterface (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8383?vs=21016=22363#toc REPOSITORY R127 KWayland CHANGES

D8396: Add support for zwp_idle_inhibit_manager_v1

graesslin added a comment. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8396 To: graesslin, #frameworks, #kwin, #plasma_on_wayland Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,

D8705: Remove Qt5::Widgets as a dependency

graesslin added a comment. In https://phabricator.kde.org/D8705#166045, @dfaure wrote: > I guess that the same argument could be made about Qt5::Widgets... if you're using a widget you're supposed to link to that, rather than indirectly via KWindowSystem... > > This is making me

D8705: Remove Qt5::Widgets as a dependency

graesslin added subscribers: dfaure, graesslin. graesslin added a comment. From my side a -1. This is not source compatible. Thus I think we need to wait for Frameworks 6 for it. I want @dfaure to ack/nack this change. REPOSITORY R278 KWindowSystem REVISION DETAIL

D8652: Add supported transformations to OutputDevice

graesslin updated this revision to Diff 21872. graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. enum and uint REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8652?vs=21869=21872 BRANCH

D8652: Add supported transformations to OutputDevice

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:470 > we have the initial send which is all fine > > Then you've got this dynamically add them. > But at a protocol level we have no way to remove and replace. > That's somewhat broken. > >

D8652: Add supported transformations to OutputDevice

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The server can announce all supported transformations on an

D8383: [server] Support inhibiting the IdleInterface

graesslin added a comment. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8383 To: graesslin, #frameworks, #kwin, #plasma_on_wayland Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,

D8396: Add support for zwp_idle_inhibit_manager_v1

graesslin added a comment. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8396 To: graesslin, #frameworks, #kwin, #plasma_on_wayland Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,

D8519: do not make the context menu a Window; do not force raise a window

graesslin added a comment. Maybe we can drop the force activate for all hosts? Are there any implementations left which are on X11? At least Ubuntu is Wayland based. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8519 To: mkoller, davidedmundson, graesslin

  1   2   3   >