D23464: Add breeze icons for ROOT cern files

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I think we should use `#1ed4e5` for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a

D23444: Remove applets/22/computer

This revision was automatically updated to reflect the committed changes. Closed by commit R266:fff83c41653a: Remove applets/22/computer (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23444?vs=64584=64692 REVISION DETAIL

D23444: Remove applets/22/computer

ndavis added a comment. In D23444#518948 , @ngraham wrote: > Are you sure this fixes the issue? I tried out the patch and deleted the removed files manually, but it didn't make a difference. Yes, but verifying the fix is a little tricky.

D23444: Remove applets/22/computer

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23444 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23444: Remove applets/22/computer

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23444 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23444: Remove applets/22/computer

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG:410854 REPOSITORY R266 Breeze Icons BRANCH remove-applet-computer (branched from

D22653: Add view-barcode-qr icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7461f90af829: Add view-barcode-qr icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=64574=64575 REVISION DETAIL

D22653: Add view-barcode-qr icons

ndavis marked 6 inline comments as done. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D22653 REVISION DETAIL https://phabricator.kde.org/D22653 To: ndavis, #breeze, ngraham, mbruchert Cc: lavender, ngraham, broulik, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22653: Add view-barcode-qr icons

ndavis updated this revision to Diff 64574. ndavis added a comment. - Make 32px be 32px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62915=64574 BRANCH arcpatch-D22653 REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILES

D22653: Add view-barcode-qr icons

ndavis commandeered this revision. ndavis edited reviewers, added: mbruchert; removed: ndavis. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 To: ndavis, #breeze, ngraham, mbruchert Cc:

D23365: Add battery-ups icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH ups-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23365 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23300: Add FictionBook 2 icons

ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

ndavis added a comment. Much better. There is only one thing left that I think should be done for 32 and 64 px. Rather than having a black "fb" for Breeze and and a white "fb" for Breeze Dark, use either white for both with a drop shadow under the "fb" or just black for both and no drop

D23300: Add FictionBook 2 icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Upon closer inspection, I found a few issues that need to be fixed. Blur can't be used because the Qt SVG renderer doesn't support it. You'll have to use linear or radial

D23300: Add FictionBook 2 icons

ndavis added a comment. Reduce the size of the SVGs by optimizing them with one of these tools: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham

D23249: Change radio to device icon, add more sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R266:5637b119d95d: Change radio to device icon, add more sizes (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23249?vs=64004=64006 REVISION

D23249: Change radio to device icon, add more sizes

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23249 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23249 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23249 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23249: Change radio to device icon, add more sizes

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Used by D21525 (Elisa). The previous version of this

D23161: Make media control icons outline style instead of solid style

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. We don't strictly adhere to outline or filled style (for better or worse), sometimes making use of both styles in the same icon (e.g., `view-list-icons`). I think the general

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D23116#511480 , @trickyricky26 wrote: > I thought about that, too, and while the red used in the icon is exactly `NegativeText`, the blue

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Not having `id="current-color-scheme"` causes stylesheets to not work correctly. INLINE COMMENTS > depth16to8.svg:1 > -http://www.w3.org/2000/svg; viewBox="0 0 22 22"> > - > -

D23104: Make 16px folder-activites look more like larger sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R266:18c7af79891c: Make 16px folder-activites look more like larger sizes (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23104?vs=63576=63589

D23104: Make 16px folder-activites look more like larger sizes

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23104 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23104: Make 16px folder-activites look more like larger sizes

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23104 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23104: Make 16px folder-activites look more like larger sizes

ndavis retitled this revision from "Make 16px start-here-kde look more like larger sizes" to "Make 16px folder-activites look more like larger sizes". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL

D23104: Make 16px start-here-kde look more like larger sizes

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH start-here (branched from master) REVISION DETAIL

D23019: Make notification icons look like bells

ndavis added a comment. @broulik With D23033 , the notification-disabled element will be unused. Do you still require changes to this patch? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis,

D23019: Make notification icons look like bells

ndavis edited dependencies, added: D23033: [notifications] Change default icon to notification-inactive; removed: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis,

D23019: Make notification icons look like bells

ndavis added a comment. In D23019#508599 , @broulik wrote: > You can't repurpose icon ids for different meanings: > F7178337: Screenshot_20190808_094519.png > This is what the "no notifications" case

D23019: Make notification icons look like bells

ndavis added a comment. In D23019#508581 , @broulik wrote: > Screenshots, please. > The question is what about the transition when this is released in Frameworks but the Plasma version with the change isn't yet. The screenshots would

D23019: Make notification icons look like bells

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

ndavis added a dependency: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

ndavis removed a dependent revision: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23019: Make notification icons look like bells

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH notification-icons (branched from master)

D23019: Make notification icons look like bells

ndavis added a dependent revision: D23018: [notifications] Remove unread counter, use icons instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23019 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22653: Add view-barcode-qr icons

ndavis added a comment. The 32px icons need to be 32x32, not 54x54. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis, ngraham Cc: lavender, ngraham, broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22884: [RFC] Don't show title on page by default

ndavis added a comment. In D22884#505718 , @aspotashev wrote: > In D22884#505656 , @ndavis wrote: > > > Perhaps it is technically a bug, but it seems to me that most of the time (at least in all of

D22653: Add view-barcode-qr icons

ndavis added a comment. actually, you can disregard my inline comments on the 32px icons, I didn't realize you had already removed the duplicate fill currentColor bits. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis,

D22653: Add view-barcode-qr icons

ndavis added inline comments. INLINE COMMENTS > view-barcode-qr.svg:7 > + > + style="fill:currentColor;fill-opacity:1;stroke:none;stroke-width:2" d="M 2 2 > L 2 6 L 6 6 L 6 2 L 2 2 z M 8 2 L 8 3 L 9 3 L 9 2 L 8 2 z M 8 3 L 7 3 L 7 5 L > 8 5 L 8 3 z M 8 5 L 8 6 L 9 6 L 9 5 L 8 5 z M 8 6

D22653: Add view-barcode-qr icons

ndavis added a comment. In D22653#505439 , @lavender wrote: > [snip] > And the 32 one has a transform that can be applied: > > http://www.w3.org/2000/svg; id="svg938" width="54" height="54">.ColorScheme-Text{color:#232629} > > > I

D22884: [RFC] Don't show title on page by default

ndavis added a comment. In D22884#505651 , @cfeck wrote: > The header title is usually more descriptive (longer) than the icon name, so no. Perhaps it is a bug, but it seems to me that most of the time (at least in all of the KDE

D22822: Add "users-other" icon

ndavis added a comment. I'll review this when I'm back from my vacation. I don't have my laptop with me. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22822 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22855: Make "edit-none" a symlink to "dialog-cancel"

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH make-edit-none-symlink-to-dialog-cancel (branched from master) REVISION DETAIL https://phabricator.kde.org/D22855 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg,

D22653: Add view-barcode-qr icons

ndavis added a comment. In D22653#504138 , @lavender wrote: > I noticed that only the 22px icons use the viewbox, is this intentional? > > As for the 32px one the validator I used complains that: > > Error:

D22653: Add view-barcode-qr icons

ndavis added a comment. I think you accidentally included a bunch of unrelated files. BTW, I'm currently on vacation and can't access my laptop. Could you show me a screenshot of the 32px icon at 1x size? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653

D12992: New elisa icon

ndavis added a comment. In D12992#503172 , @KonqiDragon wrote: > In D12992#269399 , @abetts wrote: > > > I think we are trying hard to accommodate and the elements are not lending themselves to

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks ready to land! In D22617#502629 , @davidhurka wrote: > - Add missing .ColorScheme-Text { to 24px versions of snap-page.svg > >

D22733: Delete redundant and monochrome versions of applications-internet

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Ha! I was just about to start working on this myself. Obviously, I agree that this should be done. However, we should take note of all of the instances where `applications-internet` is

D22653: Add view-barcode-qr icons

ndavis added a comment. I think I do want the 32px version to not have the blue corners so that it is visually consistent with the smaller versions. Once that is done, I will accept this, as long as there aren't any issues with the colorscheme support. REPOSITORY R266 Breeze Icons

D22670: Change Highlight to ButtonFocus

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b0541ffbff28: Change Highlight to ButtonFocus (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22670?vs=62427=62457

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis added a comment. In D22617#500953 , @davidhurka wrote: > What does `fill:currentColor` mean, by the way? The current color is determined by the color class. There has to be a `fill`, so we set it to `currentColor`. INLINE

D22670: Change Highlight to ButtonFocus

ndavis retitled this revision from "Change Highlight to ButtonFocus, improve stylesheet support" to "Change Highlight to ButtonFocus". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D22670: Change Highlight to ButtonFocus, improve stylesheet support

ndavis updated this revision to Diff 62427. ndavis added a comment. Remove extra changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22670?vs=62363=62427 BRANCH focus-color (branched from master) REVISION DETAIL

D22653: Add view-qrcode icons

ndavis added a comment. In D22653#500427 , @mbruchert wrote: > The blue corners are supposed to indicate that the QR-Code can be scanned. But aren't QR codes normally scannable? REPOSITORY R266 Breeze Icons REVISION DETAIL

D22653: Add view-qrcode icons

ndavis added a comment. In D22653#500471 , @broulik wrote: > How about `view-barcode-qr`? then we could potentially have specific `view-barcode-aztec` and also a fallback to `view-barcode` +1 REPOSITORY R266 Breeze Icons REVISION

D22670: Change Highlight to ButtonFocus, improve stylesheet support

ndavis created this revision. ndavis added reviewers: VDG, Plasma, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Changed Highlight to Button focus so that these SVGs wouldn't use the same

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis added a comment. In D22617#500369 , @davidhurka wrote: > Making the parts with background color transparent would be better, right? That would even work on systems which don’t access the stylesheet. Not necessarily. In Breeze,

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

ndavis added a comment. In D22617#500346 , @davidhurka wrote: > By the way, the suggested stylesheet in https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does not follow https://hig.kde.org/style/icon.html as far as I

D22653: Add view-qrcode icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 To: mbruchert, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

ndavis added a comment. Hi! Thanks for the patch. There are few things I'd like you to change before I accept this. The icons need optimization and colorscheme support (see workflow tips). If you have questions or need help, feel free to ask. 16px version: The margins are a pixel

D22647: Change Highlight to ButtonFocus in stylesheets

This revision was automatically updated to reflect the committed changes. Closed by commit R266:822b3ae3f88a: Change Highlight to ButtonFocus in stylesheets (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22647?vs=62303=62316

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. In D22617#500168 , @davidhurka wrote: > Other icons with fold in the bottom I could find: > > - document-duplicate > - document-revert-symbolic[-rtl] > - kt-restore-defaults > - password-copy > - viewpdf > -

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. In D22617#500031 , @davidhurka wrote: > Makes sense, so I’m flipping snap-page now. Is that written down somewhere? Nope, it was recently decided, but I've had that in the back of my mind for a while. >

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis added a comment. In D22647#500137 , @ngraham wrote: > Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation? Use a selection background color that

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis added a comment. In D22647#500117 , @ngraham wrote: > Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet. > > This will require documentation changes as well on

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. I'll give the latest changes a proper review in a little while. In D22617#500046 , @davidhurka wrote: > What is the icons-dark directory good for? The icons in there are mostly just the same as in icons.

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis retitled this revision from "Change Highlight to ViewFocus in stylesheets" to "Change Highlight to ButtonFocus in stylesheets". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22647: Change Highlight to ViewFocus in stylesheets

ndavis updated this revision to Diff 62303. ndavis added a comment. Change ViewFocus to ButtonFocus to match some elements in the Breeze desktop theme REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22647?vs=62299=62303 BRANCH focus-color (branched

D22647: Change Highlight to ViewFocus in stylesheets

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22647: Change Highlight to ViewFocus in stylesheets

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This fixes an issue where changing the selection background color in the colorscheme also

D22617: Add icons for pagelayout options, as needed in Okular

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Nice work! I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right

D22541: Update refresh and restart icons to reflect new breeze-icons versions

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R242 Plasma Framework (Library) BRANCH plasma-theme-refresh-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22541 To: ngraham,

D22534: Use clockwise arrows for *refresh* and update-* icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good! Can you also do `process-stop`? It shares the same basic shape and orientation as `view-refresh` and is used for related functions. REPOSITORY R266 Breeze Icons

D22003: Change selected text color to black

ndavis abandoned this revision. ndavis added a comment. Abandoning because it can negatively affect other widget styles. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D22003 To: ndavis, #vdg, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22297: Add id="current-color-scheme" to collapse-all icons

ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22297 To: nhiga, #vdg, davidhurka, ndavis Cc: ndavis, davidhurka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22147: Better use of Qt APIs in Plasma::Theme

ndavis added a comment. In D22147#491119 , @apol wrote: > In D22147#490887 , @ndavis wrote: > > > I've compiled this with the latest commits, but the problem hasn't gone away. > > > Try

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

This revision was automatically updated to reflect the committed changes. Closed by commit R296:f18d43b7ffd8: [GridDelegate] Fix gaps in corners of thumbnailArea highlight (authored by ndavis). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis added a comment. Anyone want to approve or request changes? It's not perfect, but it's a simple improvement. The ideal solution would require us to work around a problem with QML where images can't have their corners rounded by a parent object's border radius. REPOSITORY R296

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis updated this revision to Diff 61167. ndavis added a comment. - Remove radius when thumbnail is present REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20140?vs=55106=61167 BRANCH grid-delegate-rectangle (branched from master) REVISION DETAIL

D22275: [Svg] Fix porting error from QRegExp::exactMatch

ndavis added a comment. I can confirm this fixes the problem here: https://phabricator.kde.org/D22147#490563 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22275 To: broulik, #plasma, apol Cc: kde-frameworks-devel, ndavis, LeGast00n, michaelh,

D22147: Better use of Qt APIs in Plasma::Theme

ndavis added a comment. I've compiled this with the latest commits, but the problem hasn't gone away. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22147 To: apol, #plasma, #frameworks, mart Cc: ndavis, bruns, tcanabrava, fvogt, broulik,

D22147: Better use of Qt APIs in Plasma::Theme

ndavis added a comment. @apol This patch seems to have caused a bug in the way icons are loaded for the system tray: F6965245: Screenshot_20190704_032623.png When I compile plasma-framework without this patch, the system tray looks how it should:

D22102: Implement apply-on-double-click for all grid view KCM delegates

ndavis added a comment. In D22102#487806 , @ngraham wrote: > Maybe I should move back and examine the rationale for the proposal. > > Right now, I find it *extremely* annoying, slow, and frustrating to test new themes, colors, icons,

D10362: Change reveal password button logic

ndavis added a comment. In D10362#488389 , @ngraham wrote: > I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. I

D22172: [kio-extras] Use new activities icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH use-new-activities-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22172 To: GB_2, #plasma, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, kfm-devel,

D22173: [kactivities] Use new activities icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R6 KActivities BRANCH use-new-activities-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22173 To: GB_2, #plasma, #vdg, ndavis Cc: #vdg, kde-frameworks-devel, #plasma,

D10362: Change reveal password button logic

ndavis added a comment. In D10362#202435 , @starbuck wrote: > Would further be also likely more consistent with other toggles in the future, like imagined on mobile "wifi crossed out=disabled", etc. The difference between the WiFi toggle

D10362: Change reveal password button logic

ndavis added a comment. -1 for the current version How am I supposed to type with 2 hands and see the password at the same time if I have to hold down the left mouse button? -0.75 for the previous version of the patch We normally show the action that will happen when a button

D22155: Add new activities and virtual desktops icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm accepting this, but make sure you don't land this until you've submitted the other patches. REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons

D22155: Add new activities and virtual desktops icons

ndavis added a comment. Nice job! Are there other patches coming soon to fix the code where `preferences-activities` was used? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n,

D22108: [TabBar] Remove exterior margins

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D22108#487329 , @filipf wrote: > In D22108#487218 , @ndavis wrote: > > > 1+ visually. How

D22108: [TabBar] Remove exterior margins

ndavis added a comment. 1+ visually. How does it look with a vertical panel? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22108 To: filipf, #vdg, #plasma, ngraham Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22003: Change selected text color to black

ndavis edited the summary of this revision. ndavis added a dependency: D22000: [colors/Breeze] Change selected text color to black. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D22003 To: ndavis, #vdg, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n,

D22003: Change selected text color to black

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Also make black text color match the Shade Black color:

D21966: Add disk-quota icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH icon REVISION DETAIL https://phabricator.kde.org/D21966 To: nicolasfella, #plasma, #breeze, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, michaelh,

D21957: Add disk-quota icons

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH diskquota REVISION DETAIL https://phabricator.kde.org/D21957 To: nicolasfella, #breeze, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21919: Change joystick settings icon to game controller

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7ef3c35c7ed6: Change joystick settings icon to game controller (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21919?vs=60102=60113

<    2   3   4   5   6   7   8   9   10   11   >