D24826: Enforce 100 chars line width

romangg abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: carewolf, winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D24826: Enforce 100 chars line width

romangg added a comment. FYI I'm using a strict 100 chars limit nowadays on all my KWinFT projects (with the exception of KWinFT itself for now) and I'm very happy with this decision. As an example you can compare these two otherwise still pretty similar files:

Re: Recent breakage in kwallet

On Fri, May 15, 2020 at 3:53 PM Roman Gilg wrote: > > On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > > > Hi all, > > Recently, the package of KWallet framework for neon (devel unstable, > > package built out of current master state) seems to be brok

Re: Recent breakage in kwallet

On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > Hi all, > Recently, the package of KWallet framework for neon (devel unstable, > package built out of current master state) seems to be broken: kwallet > now can't open anymore wallets previously created (it works if the > local kwallet

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

romangg added inline comments. INLINE COMMENTS > zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:129 > We probably need to ask folks in `#wayland` whether inhibitors outlive the > manager object. In general objects created through some interface can outlive the interface bind if not

D28882: Create protocol to manage video feeds

romangg added inline comments. INLINE COMMENTS > screencast.xml:8 > + ]]> > + > + Interface names should be scoped too. Example

D28620: Add readmes clarifying state of plasma component versions

romangg accepted this revision. romangg added a comment. If you want to you can also add a ⚠️ (`:warning:`) emoticon to the deprecated text and in both some headings with `#`, `##`, etc. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D28620: Add readmes clarifying state of plasma component versions

romangg added a comment. README.md is common for viewing in modern code hosting solutions with markdown support. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D28620 To: davidedmundson, #plasma,

D26308: Set output device's logical size

romangg added a task: T11222: Reimagine output cloning. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26308 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

romangg removed a dependent revision: D26309: feat: replace replication source with logical size API. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26308 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

romangg updated this revision to Diff 72615. romangg marked 4 inline comments as done. romangg added a comment. - Add autotest - Cleanup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26308?vs=72427=72615 BRANCH replicaSize REVISION DETAIL

D26171: Implement wp_viewporter

romangg updated this revision to Diff 72576. romangg added a comment. - Cleanup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26171?vs=72575=72576 BRANCH viewporter REVISION DETAIL https://phabricator.kde.org/D26171 AFFECTED FILES

D26171: Implement wp_viewporter

romangg updated this revision to Diff 72575. romangg marked 6 inline comments as done. romangg added a comment. - Check source rectangle on related changes, buffer rename. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26171?vs=72029=72575 BRANCH

D26308: Set output device's logical size

romangg added a dependent revision: D26311: Handle output logical size changes. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26308 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

romangg added a dependent revision: D26309: feat: replace replication source with logical size API. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26308 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26308: Set output device's logical size

romangg added a comment. I thought about adding separate events/requests for an immutable`logical_size` just giving always back the current logical size of the output and `logical_size_override` always giving back the explicitly set logical size or an invalid size if none is set.

D26308: Set output device's logical size

romangg added a comment. This is an alternative to D23619 with more patches to come as discussed with David back then. INLINE COMMENTS > outputdevice.h:98 > }; > + > struct Mode { rm > outputdevice.xml:293 > + > + > +

D26308: Set output device's logical size

romangg created this revision. romangg added reviewers: KWin, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This adds protocol methods and API to query and set explicitly the

D26175: [plasmashell] Update docs for panelTakesFocus to make it generic

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > apol wrote in plasmashell_interface.h:178 > How about we rename now and deprecate this one? Yea, could be better. David should decide on what he prefers. But the

D26171: Implement wp_viewporter

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in surface_interface.cpp:485 > We're not testing this error in the case of: > > buffer is set > viewporter.sourceRect is set > > then later > buffer changes > viewporter.sourceRect remains the same > > this should be an

D26171: Implement wp_viewporter

romangg added a task: T4456: Implement viewporter protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26171: Implement wp_viewporter

romangg added inline comments. INLINE COMMENTS > surface_interface.h:130 > + **/ > +BufferInterface *constBuffer() const; > QPoint offset() const; Needed for a call in a const function in KWin. Do we want to do it like that? Other suggestions? REPOSITORY R127 KWayland REVISION

D26171: Implement wp_viewporter

romangg added a dependent revision: D26172: Add wp_viewporter support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D26171 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26171: Implement wp_viewporter

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY This patch adds interfaces for specifying viewports via the wp_viewporter protocol

D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D26153 To: davidedmundson, #kwin, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25576: [server] Do not own dmabuf implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R127:005a8ede4bb7: [server] Do not own dmabuf implementation (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25576?vs=70457=70463 REVISION

D25576: [server] Do not own dmabuf implementation

romangg added a dependent revision: D25577: Destroy dmabuf implementation on EGL backend going down. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D25576 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25576: [server] Do not own dmabuf implementation

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The dmabuf implementation should be managed by the compositor and not by the

D24826: Enforce 100 chars line width

romangg added a comment. In D24826#551280 , @cullmann wrote: > As explained in the thread on https://phabricator.kde.org/T11214, this will make the formatting ugly as hell, as if you have long method names, stuff is broken in arbitrary bad

D24826: Enforce 100 chars line width

romangg created this revision. romangg added reviewers: Frameworks, cullmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The KDE Frameworks style recommended a 100

D24663: Use ECMGenerateExportHeader to manage deprecated API better

romangg added a comment. It's ok that you pushed. Can you give a link to your preferred resource for me to read up on ECMGenerateExportHeader? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin Cc: romangg, zzag, kde-frameworks-devel,

D24003: kwaylandScanner produce version enum per class

romangg added a comment. By the way I guess the reason why only the `PrimarySelectionOfferV1InterfaceVersion` is there without the patch is that the other interfaces are created through the manager on request of the client while the offer is created server-side and then sent through an

D24003: kwaylandScanner produce version enum per class

romangg added a comment. Header output with the patch: #ifndef KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H #define KWAYLAND_SERVER_WP_PRIMARY_SELECTION_UNSTABLE_V1_H #include "global.h" #include "resource.h" #include namespace KWayland {

D24012: Supress mouse events in KCMs causing window moves

romangg added a comment. Forgot that KCMUtils is part of Frameworks... And probably doesn't make sense to create a bug fix Frameworks release just for that. The KScreen KCM is still usable, just moving outputs is difficult but also possible. So just push for next Frameworks release.

D24012: Supress mouse events in KCMs causing window moves

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Let's get it in the beta. But can you reply to @anthonyfieroni inline reply before pushing? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL

D23915: Improve documentation

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH arcpatch-D23915_1 REVISION DETAIL https://phabricator.kde.org/D23915 To: gladhorn, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Title of this diff must be changed before push. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23915 To: gladhorn, #kwin, romangg Cc: romangg, zzag,

D23915: Add some docstrings

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > zzag wrote in dpms.h:44 > Not sure that this is valid documentation for org_kde_kwin_dpms_manager > because it's nothing more but a factory. Yea, maybe just write

D23619: Introduce cloning and replication of output devices

romangg added a dependent revision: D23684: WIP: Add presenting event to output-device protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: kpiwowarski, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23684: WIP: Add presenting event to output-device protocol

romangg retitled this revision from "Add presenting event to output-device protocol" to "WIP: Add presenting event to output-device protocol". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23684 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23684: WIP: Add presenting event to output-device protocol

romangg added a dependency: D23619: Introduce cloning and replication of output devices. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23684 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23684: Add presenting event to output-device protocol

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The idea for this event is to inform output managing clients about the current state

D23619: Introduce cloning and replication of output devices

romangg updated this revision to Diff 65263. romangg marked 2 inline comments as done. romangg added a comment. - Fix enum ordering, typo. Thx @kpiwowarski. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23619?vs=65118=65263 BRANCH clone REVISION

D23619: Introduce cloning and replication of output devices

romangg added a dependent revision: D23665: [platforms/drm] Support output replication. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23619: Introduce cloning and replication of output devices

romangg added a dependent revision: D23662: Wayland: Support output replication. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23619: Introduce cloning and replication of output devices

romangg updated this revision to Diff 65118. romangg added a comment. - Add trigger reason and direction enums - Disable replication on output device going away I decided to go with the enums to make it explicit. Also I plan on using these in the future with events to signal the

D23619: Introduce cloning and replication of output devices

romangg added a comment. If the output device - that is the replication source - goes away (hot plug) we need to clear the `replicationSource` field in the other output device. This is straight forward with a single connect but question is if afterwards the replicate event should be send to

D23619: Introduce cloning and replication of output devices

romangg retitled this revision from "[server] Introduce cloning and replication of output devices" to "Introduce cloning and replication of output devices". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel,

D23619: [server] Introduce cloning and replication of output devices

romangg added inline comments. INLINE COMMENTS > zzag wrote in outputdevice.cpp:391 > Correction: that's not reliable way to check whether a C string is empty. You > assume that all empty strings have the same address, which in some cases > cannot be true, e.g. if the string is dynamically

D23619: [server] Introduce cloning and replication of output devices

romangg added a task: T11222: Reimagine output cloning. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23619: [server] Introduce cloning and replication of output devices

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The org_kde_kwin_outputdevice and respective org_kde_kwin_outputconfiguration

D23535: [server] Use cached current mode more and assert validness

This revision was automatically updated to reflect the committed changes. Closed by commit R127:0c0a2710dd3b: [server] Use cached current mode more and assert validness (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D23493: [server] Cache current mode

This revision was automatically updated to reflect the committed changes. romangg marked an inline comment as done. Closed by commit R127:ce5e25a4b63c: [server] Cache current mode (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D23493: [server] Cache current mode

romangg marked 2 inline comments as done. romangg added inline comments. INLINE COMMENTS > romangg wrote in outputdevice_interface.cpp:143 > Thanks. Will put it into a second diff. See D23535 REPOSITORY R127 KWayland BRANCH cacheMode REVISION DETAIL

D23535: [server] Use cached current mode more and assert validness

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY We can use the cached current mode in one more case. Additionally make it more

D23493: [server] Cache current mode

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:143 > we can also just use currentMode directly here and remove the loop above Thanks. Will put it into a second diff. REPOSITORY R127 KWayland BRANCH cacheMode REVISION DETAIL

D23493: [server] Cache current mode

romangg added a dependent revision: D23495: Get output pixel size from output device. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23493 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23493: [server] Cache current mode

romangg added a task: T11459: AbstractWaylandOutput and output device consolidation. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23493 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23493: [server] Cache current mode

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Instead of looping over all modes for retrieving current mode data copy it to a

D23224: Fix capitalization of Nextcloud

romangg added a comment. This means only change it in lines without `[..]`. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D23224 To: z3ntu Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Unified git commit message guideline

For KWin we think about a message guideline because our current best practice that we got used to over time is just sometimes putting tags in square brackets at the beginning of the subject line for indicating the location of the change in code but somebody noted having a square bracket in the

D10747: Implement zwp_linux_dmabuf_v1

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:1dd57d909165: Implement zwp_linux_dmabuf_v1 (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST

D10747: Implement zwp_linux_dmabuf_v1

romangg edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik Cc: zzag, kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, sgureev,

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 63224. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=61912=63224 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

Coding style: white space around asterisks

Hi, Frameworks C++ coding style for pointer declarations follows the asterisk to the right approach like Qt coding style recommends. This is most often a sensible choice but is difficult to read in my opinion when there is no identifier to the right the asterisk is associated with, for example

D18114: FakeInput: add support for pointer move with absolute coordinates

romangg added a comment. @jgrulich With D22571 looking promising do you want to put the keyboard parts of this diff into a separate one? There is still the question about keysyms and key events but we should discuss this in the new diff. Maybe we can

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. If there are no objections I would push this soon. There is one remaining annoyance I have with the current version: the name of the class inside the interface the compositor has to subclass for interfacing with KWayland. I changed the name from Bridge to Impl

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 61912. romangg added a comment. - Rebase on master - Use packaged dma-buf xml REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60654=61912 BRANCH dmaBuf REVISION DETAIL

D21672: [PowerStateMonitor] Be conservative when determining power state

romangg added a comment. The bug report was online for two weeks and it was categorized as Baloo bug. You had more than enough time to notice it. I hoped I wouldn't need to waste any more time on this issue besides the time I already had to spent for working around this bug for two

D21672: [PowerStateMonitor] Be conservative when determining power state

romangg added a comment. Reverted by d6d86cb86c on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a critical problem in released 5.60 @bruns. REPOSITORY R293 Baloo REVISION

D22459: Send wl_pointer.frame when emulating pointer events out of touch ones

romangg added a comment. Please include the context for this diff. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22459 To: dos, #kwin Cc: romangg, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22216: RFC: Use wayland-protocols

romangg accepted this revision. romangg added a subscriber: davidedmundson. romangg added a comment. This revision is now accepted and ready to land. Yea, let's wait until 5.60 branched and then push for 5.61 (after next weekend) as long as @davidedmundson does not say anything against it

D22216: RFC: Use wayland-protocols

romangg added a comment. Makes sense to me. Why was it done differently until now? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D22216 To: zzag, #kwin, #frameworks Cc: romangg, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D10747: Implement zwp_linux_dmabuf_v1

romangg added a dependent revision: D10750: wayland: Add support for zwp_linux_dmabuf. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik Cc: kde-frameworks-devel, romangg, plasma-devel,

D10747: Implement zwp_linux_dmabuf_v1

romangg edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, sgureev,

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60654. romangg added a comment. - D-pointer DmaBufBuffer - Only allow one create request in any case - Params in private interface class - typedef for LinuxDmabufUnstableV1Interface - Small cleanup - Set buffer privates and delete impl on

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60429. romangg added a comment. - Update protocol xml to wayland-protocols master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60366=60429 BRANCH dmaBuf REVISION DETAIL

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60366. romangg added a comment. - Minor style changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60364=60366 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60364. romangg added a comment. - Revert drm_fourcc.h whitespace changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60360=60364 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60360. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=28986=60360 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

romangg commandeered this revision. romangg added a reviewer: fredrik. romangg added a comment. Thanks @fredrik for initiating this. I'll try to finish the patches up. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin,

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Please add description, otherwise let's try it out. REPOSITORY R273 KGuiAddons BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 To: apol, romangg Cc:

D15910: Implement wl_surface::damage_buffer

This revision was automatically updated to reflect the committed changes. Closed by commit R127:b71e10359725: Implement wl_surface::damage_buffer (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15910?vs=48477=57749#toc REPOSITORY R127 KWayland CHANGES SINCE LAST

D18824: Implement wl_eglstream_controller Server Interface

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thanks. Don't forget to add the isValid check to the KWin patches now. Maybe also add a comment to the KWayland code, what's the reason for the separate create() call and that we want to

D18824: Implement wl_eglstream_controller Server Interface

romangg added a comment. The xml file is missing form the diff now. Don't forget to add it when pushing. In the first revision the interface failed to create when the dynamically loaded library was not present. Now it just fails silently on bind. Why is this ok? INLINE COMMENTS >

D19255: WIP: Alternate approach to D19253

romangg added a comment. In D19255#418729 , @davidedmundson wrote: > > Maybe add a TODO comment on merge to the setLogicalSize (that it does not handle the size plus scale change correctly in every case). > > Can you expand on what you

D19255: WIP: Alternate approach to D19253

romangg added a comment. Also CCBUG: 400987 REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D19255 To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19255: WIP: Alternate approach to D19253

romangg added a comment. Maybe add a TODO comment on merge to the setLogicalSize (that it does not handle the size plus scale change correctly in every case). REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D19255 To: davidedmundson, #kwin, romangg

D19255: WIP: Alternate approach to D19253

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I just tested it and it works. As you said in D19253 has same caveat as I pointed out not being in sync with wl_output::done event in case resolution

D15910: Implement wl_surface::damage_buffer

romangg added a comment. Will be pushed after 5.56 branched off. REPOSITORY R127 KWayland BRANCH damageBuffer REVISION DETAIL https://phabricator.kde.org/D15910 To: romangg, #kwin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:349 >xdgoutput_interface.h > + eglstream_controller_interface.h > ) alphabetical sorted > display.cpp:529 > +} else { > +qCWarning(KWAYLAND_SERVER) << "Unable to load > libnvidia-egl-wayland.so.1"; > +}

D18824: Implement wl_eglstream_controller Server Interface

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Impressive. Some small issues to resolve. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, zzag, #kwin

D15421: [server] Add surface data proxy mechanism

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:0b33f078bd1d: [server] Add surface data proxy mechanism (authored by romangg). CHANGED PRIOR TO COMMIT

D15023: [server] Add selectionChanged signal

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8caff837109c: [server] Add selectionChanged signal (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15023?vs=48513=51022#toc REPOSITORY R127 KWayland CHANGES SINCE

D17122: Add option to use wl_display_add_socket_auto

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma, romangg Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

romangg added a dependent revision: D18522: Name Wayland socket automatically when no socket name was specified. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma, romangg Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh,

D17122: Add option to use wl_display_add_socket_auto

romangg added inline comments. INLINE COMMENTS > fvogt wrote in test_display.cpp:223 > That won't work reliably either though - if wayland-0 is free, but wayland-1 > is used, it would pick wayland-0 and wayland-2. Maybe it should just check > that starting both displays at the same time

D17122: Add option to use wl_display_add_socket_auto

romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_display.cpp:223 > +QVERIFY(runtimeDir.exists()); > +QVERIFY(!runtimeDir.exists("wayland-0")); > +QVERIFY(!runtimeDir.exists("wayland-1"));

D17122: Add option to use wl_display_add_socket_auto

romangg added inline comments. INLINE COMMENTS > display.cpp:87 > +bool running = false, > + automaticSocketNaming = false; > QList outputs; bool running = false; bool automaticSocketNaming = false; REPOSITORY R127 KWayland REVISION DETAIL

D17122: RFC: Use wl_display_add_socket_auto by default

romangg added a comment. In D17122#395745 , @fvogt wrote: > > Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old

  1   2   3   4   >