D12145: autotests: Do not use QScopedPointer for plugins

michaelh updated this revision to Diff 32052. michaelh added a comment. - Rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12145?vs=31966&id=32052 BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kde.org/D1214

D12145: autotests: Do not use QScopedPointer for plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R286:8b8857cb6bc3: autotests: Do not use QScopedPointer for plugins (authored by michaelh). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12145?vs=32052&id=32053

D12145: autotests: Do not use QScopedPointer for plugins

bruns added a comment. The first question is - why should we use pointers at all (raw, std::unique_ptr, QScopedPointer, ...) for objects **with local only scope**. The typical answer is Inheritance, see e.g. http://doc.qt.io/qt-5/qscopedpointer.html#details A `Base` pointer can be used

D12145: autotests: Do not use QScopedPointer for plugins

mgallien added a comment. In D12145#245023 , @alexeymin wrote: > Just curious, why is this needed? To avoid dynamic memory allocations? I asked on new code to avoid using an extractor allocated on heap instead of on stack. @michaelh just

D12145: autotests: Do not use QScopedPointer for plugins

michaelh added a comment. In D12145#245023 , @alexeymin wrote: > Just curious, why is this needed? To avoid dynamic memory allocations? see D12028 . As I had copied that line, my conclusion was all or

D12145: autotests: Do not use QScopedPointer for plugins

alexeymin added a comment. Just curious, why is this needed? To avoid dynamic memory allocations? REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kde.org/D12145 To: michaelh, #baloo, #frameworks, mgallien, bruns Cc: alexeym

D12145: autotests: Do not use QScopedPointer for plugins

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for having done it everywhere. I had missed that "detail". REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from master) REVISION DETAIL https://phabricator.kd

D12145: autotests: Do not use QScopedPointer for plugins

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. TEST PLAN make && make test REPOSITORY R286 KFileMetaData BRANCH plugin-simple (branched from