cullmann abandoned this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12295
To: cullmann, #ktexteditor, #kate, dhaumann, brauch, sraizada
Cc: loh.tar, brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor,
szutmael, gennad, domson, michaelh,
cullmann commandeered this revision.
cullmann edited reviewers, added: sraizada; removed: cullmann.
cullmann added a comment.
We close this in favor of the other patches.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12295
To: cullmann, #ktexteditor, #kate,
loh.tar added a comment.
I didn't test it even more but think on it from time to time. If my slightly
negative comment was OK or too fast judged. And yes it may.
On the other hand I ask me if the approach to track each key stroke and
change the behavior on that record is right or a
loh.tar added a comment.
His original post with some more text/hints/questions
https://mail.kde.org/pipermail/kwrite-devel/2018-April/000345.html
He got the advice from @brauch to post here.
For me a little bit hard to follow, not only there but also here.
I could apply this
cullmann added a comment.
Hi, I like the improvements, just want some feedback on my questions above.
Still alive?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12295
To: sraizada, #ktexteditor, #kate, cullmann, dhaumann, brauch
Cc: brauch, ngraham,
cullmann added a reviewer: brauch.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12295
To: sraizada, #ktexteditor, #kate, cullmann, dhaumann, brauch
Cc: brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor,
michaelh, kevinapavew, bruns, demsking,
cullmann added a subscriber: brauch.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12295
To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor,
michaelh, kevinapavew, bruns, demsking, head7,
cullmann added a comment.
I like the idea.
For the patch:
I think one should check with isEmpty() if the thing is empty, instead of the
size() > 0 things, thats more clear.
And is there no m_currentAutobraceClosingChar clear missing somewhere? e.g.
don't go this two stack out of
cullmann requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12295
To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor,
sraizada added a comment.
The issue with matching unbalanced braces (picture in previous comment) also
happens in unmodified KWrite, so it doesn't seem to be an issue with this
revision.
This fails test 49 - kateview_test; but checking out ktexteditor from git and
then running make/make
ngraham added reviewers: Kate, cullmann, dhaumann.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12295
To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew,
ngraham, bruns, demsking,
sraizada updated this revision to Diff 34333.
sraizada added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel,
kwrite-devel; removed: Frameworks.
Improved patch, closing brackets get eaten properly in all cases I tested.
The only issue I found is that
sraizada created this revision.
sraizada added a reviewer: KTextEditor.
sraizada added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
sraizada requested review of this revision.
REVISION SUMMARY
With
13 matches
Mail list logo
