D12591: KFileWidget: Provide faster access to the icon position setting

rkflx abandoned this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12591 To: rkflx, #frameworks, ngraham Cc: kde-frameworks-devel, ngraham, elvisangelaccio, michaelh, bruns

D12591: KFileWidget: Provide faster access to the icon position setting

ngraham added a comment. In D12591#256212 , @rkflx wrote: > In D12591#255639 , @elvisangelaccio wrote: > > > > While the submenu itself is not advertised in the API docs, it was publicly accessible

D12591: KFileWidget: Provide faster access to the icon position setting

rkflx planned changes to this revision. rkflx added a comment. In D12591#255639 , @elvisangelaccio wrote: > > While the submenu itself is not advertised in the API docs, it was publicly accessible > > Where? Isn't it a member of

D12591: KFileWidget: Provide faster access to the icon position setting

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, much better than having a submenu with only two items when the main menu is itself not very big. Works great. One thought: with this patch, there will be two disabled and

D12591: KFileWidget: Provide faster access to the icon position setting

elvisangelaccio added a comment. > While the submenu itself is not advertised in the API docs, it was publicly accessible Where? Isn't it a member of `KDirOperator::Private`? (I'm referring to `decorationMenu`) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12591

D12591: KFileWidget: Provide faster access to the icon position setting

rkflx added a dependent revision: D12598: FileView: Provide faster access to the icon position setting. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12591 To: rkflx, #frameworks Cc: michaelh, bruns

D12591: KFileWidget: Provide faster access to the icon position setting

rkflx added a comment. If this gets approved, I'll do the same change to K3b for consistency, which was the only other app showing the submenu I could find on https://lxr.kde.org. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12591 To: rkflx, #frameworks Cc:

D12591: KFileWidget: Provide faster access to the icon position setting

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY The file dialog allows to move the file name labels from next to the icon to right under the icon for Short View.