D25315: KDirModel: implement showing "/" as a root node, optionally

dfaure added a comment. In D25315#619727 , @rrosch wrote: > > Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL. > > KDirModel takes care of that. > > Ah ok,

D25315: KDirModel: implement showing "/" as a root node, optionally

rrosch added a comment. > Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL. > KDirModel takes care of that. Ah ok, so it's going to do that without me needing to explicitly specify "Keep"? >> I

D25315: KDirModel: implement showing "/" as a root node, optionally

dfaure planned changes to this revision. dfaure added a comment. In D25315#619436 , @rrosch wrote: > Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally: > >

D25315: KDirModel: implement showing "/" as a root node, optionally

rrosch added a comment. Ok, I found one of the "implications". With `model->dirLister()->openUrl(m_initURL, KDirLister::Keep);` I can list KIO urls like `remote:`, `font:`, and `applications:`, but with `model->openUrl(m_initURL, KDirModel::ShowRoot);` I cannot, and only seems to display

D25315: KDirModel: implement showing "/" as a root node, optionally

rrosch added a comment. Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally: model->dirLister()->openUrl(QUrl::fromLocalFile("/"), KDirLister::Keep); to model->openUrl(QUrl::fromLocalFile("/"),

D25315: KDirModel: implement showing "/" as a root node, optionally

dfaure updated this revision to Diff 70183. dfaure added a comment. Add ShowRoot flag, excellent idea! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25315?vs=69778=70183 BRANCH 2019_11_kdirmodel_root REVISION DETAIL https://phabricator.kde.org/D25315

D25315: KDirModel: implement showing "/" as a root node, optionally

meven added inline comments. INLINE COMMENTS > kdirmodel.h:78 > + * Otherwise, this is equivalent to dirLister()->openUrl(url, flags) > + * @param url the URL of the directory whose contents should be > listed. The item for this directory will NOT be shown, the model starts at > its

D25315: KDirModel: implement showing "/" as a root node, optionally

dfaure created this revision. dfaure added reviewers: stefanocrocco, elvisangelaccio, meven, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The API for this is to call openUrl(QUrl()), which