meven added a comment.
ping
Would be important to land with
https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/2
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D28856
To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel,
meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.
Just two qDebug to remove, seems fine otherwise
INLINE COMMENTS
> globalshortcutsregistry.cpp:95
> {
> +qDebug() << component->uniqueName();
> if
davidre updated this revision to Diff 80265.
davidre added a comment.
Don't parse the disabledGroup as component
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28856?vs=80206=80265
BRANCH
disable (branched from master)
REVISION DETAIL
davidre marked 4 inline comments as done.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D28856
To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
davidre added inline comments.
INLINE COMMENTS
> globalshortcutsregistry.cpp:274
> +auto disabledComponents = KConfigGroup(&_config,
> "disabledComponents").readEntry("disabled", QStringList());
> for (const QString : groupList)
> {
good point
>
fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> globalshortcutsregistry.cpp:274
> +auto disabledComponents = KConfigGroup(&_config,
> "disabledComponents").readEntry("disabled", QStringList());
>
davidre updated this revision to Diff 80206.
davidre added a comment.
foo
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28856?vs=80205=80206
BRANCH
disable (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28856
AFFECTED
davidre created this revision.
davidre added reviewers: davidedmundson, fvogt, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.
REVISION SUMMARY
Works for writable and not writable files. Additional positive
