Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-09 Thread Alex Merry
On July 8, 2014, 9:51 p.m., Albert Astals Cid wrote: I know i'm late, but if CMake provides one, can't we just kill ours? The CMake one isn't quite compatible, so I wanted to keep this to make porting a little easier. Note that this is in kdelibs4support, and therefore deprecated. As soon

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61935 --- I know i'm late, but if CMake provides one, can't we just

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-08 Thread Aleix Pol
On Tuesday 08 July 2014 21:51:15 Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61935 ---

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-07 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61812 --- Working well to solve the build issues in Plasma 5 -

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-07 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61811 --- Ship it! Ship It! - Jonathan Riddell On July 4, 2014,

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-07 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/ --- (Updated July 7, 2014, 5:27 p.m.) Status -- This change has been

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-04 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/#review61601 --- cmake/modules/FindGettext.cmake

Re: Review Request 119111: Make FindGettext compatible with the one provided by CMake

2014-07-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119111/ --- (Updated July 4, 2014, 1:05 p.m.) Review request for KDE Frameworks and