Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review42187 --- This review has been submitted with commit

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-22 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 22, 2013, 9:51 p.m.) Status -- This change has been

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-21 Thread David Gil Oliva
On Oct. 11, 2013, 4:28 p.m., Kevin Ottens wrote: Ship It! Kevin Ottens wrote: Any reason why this patch isn't pushed yet? Yes. There are some personal reasons and, besides, I've been trying for days to compile Qt5.2 with no luck till today. I think I'll have both patches pushed

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41393 --- Ship it! Ship It! - Aurélien Gâteau On Oct. 8, 2013, 12:08

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41326 --- Looks good to me. One last thing: you need to document the

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-07 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 7, 2013, 10:08 p.m.) Review request for KDE Frameworks.

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-06 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 6, 2013, 8:56 p.m.) Review request for KDE Frameworks.

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41164 --- staging/kemoticons/src/core/kemoticonsprovider.h

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-01 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Oct. 1, 2013, 8:45 p.m.) Review request for KDE Frameworks.

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41018 --- staging/kemoticons/src/core/kemoticonsprovider.h

Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-09-28 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- Review request for KDE Frameworks. Description --- Adjust API in