Re: KIOWidgets and KFile

2013-09-30 Thread David Faure
On Sunday 29 September 2013 22:31:38 Sebastian Kügler wrote: On Sunday, September 29, 2013 20:50:28 David Faure wrote: This is clearly because kbookmarks was written as part of kio, and with konqueror in mind. I guess the question is how generic we want KBookmarks to be, i.e. should it

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-30 Thread Martin Gräßlin
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: [kde-doc-english] Making KDocTools independent of KArchive

2013-09-30 Thread Luigi Toscano
Albert Astals Cid wrote: El Diumenge, 29 de setembre de 2013, a les 12:14:49, David Faure va escriure: On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: So we don't have a man page anymore? Debian will be happy :D Also we're losing the i18n-zation side of the man page, which the

Re: KIOWidgets and KFile

2013-09-30 Thread Sebastian Kügler
On Sunday, September 29, 2013 23:49:15 Mark wrote: If i'm not mistaken, Dolphin is also using KBookmarks. Would your suggestion keep it alive for dolphin? Or would that mean creating a plugin that can read/write bookmarks to any file? It would work just like it is now. -- sebas

Jenkins build is back to stable : kdelibs_stable #846

2013-09-30 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/846/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KIOWidgets and KFile

2013-09-30 Thread Sebastian Kügler
On Monday, September 30, 2013 09:03:36 David Faure wrote: On Sunday 29 September 2013 22:31:38 Sebastian Kügler wrote: [...] I imagine KBookmark being a more service-like thing, rather than a mechanism to store and read bookmarks. What you say makes sense, it sure sounds like a future

kpart dependencies

2013-09-30 Thread Treeve Jelbert
kpart (tier3) depends on KIO and KService, both of which are still in staging standalone build of kpart then fails because of reference to kprotocolmanager.h, from kio, which has local includes include global.h // KIO::CacheControl #include kio/kiocore_export.h #include kprotocolinfo.h

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41018 --- staging/kemoticons/src/core/kemoticonsprovider.h

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

2013-09-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41019 --- Ping - Martin Klapetek On Sept. 25, 2013, 4:50 p.m., Martin

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41020 --- Ping - Martin Klapetek On Sept. 27, 2013, 9:15 a.m., Martin

Re: Review Request 112942: Move KDNSSD to tier2

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41021 --- ping? - Aleix Pol Gonzalez On Sept. 25, 2013, 5:35 p.m.,

Re: Review Request 112901: Remove weird cmake indirections

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/#review41023 --- ping? - Aleix Pol Gonzalez On Sept. 24, 2013, 1:32 p.m.,

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

2013-09-30 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41026 --- Ship it! Ship It! - John Layt On Sept. 25, 2013, 4:50

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-30 Thread Mark Gaiser
On Sept. 30, 2013, 11:23 a.m., Aleix Pol Gonzalez wrote: ping? As before, i'm ok with it, but am not going to give another ship it :) That really is up to someone with in deep knowledge about kde4support to see if it makes sense where you placed it. - Mark

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41027 --- staging/kprintutils/CMakeLists.txt

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41036 --- Ship it! Oh btw, it looks good to me and looks like an

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

2013-09-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41038 --- This review has been submitted with commit

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

2013-09-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 30, 2013, 2:16 p.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #1299

2013-09-30 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1299/changes Changes: [mklapetek] Remove unused image assets [mklapetek] Move KDEPrintSupport into KPrintUtils [mklapetek] Port from KLineEdit and KComboBox to their Qt variants -- [...truncated 18100

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Martin Klapetek
On Sept. 30, 2013, 2:01 p.m., Aleix Pol Gonzalez wrote: staging/kprintutils/CMakeLists.txt, line 30 http://git.reviewboard.kde.org/r/112964/diff/1/?file=192865#file192865line30 Why are you removing these? They have no effect on the code as the code compiles without them, so they

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 30, 2013, 2:23 p.m.) Status -- This change has been

Re: Review Request 112964: Prepare KPrintUtils cmake stuff

2013-09-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41043 --- This review has been submitted with commit

Build failed in Jenkins: kdelibs_frameworks_qt5 #1301

2013-09-30 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1301/changes Changes: [mklapetek] Remove unused includes; should fix the build -- [...truncated 17985 lines...] [ 73%] Building CXX object

Removing the KFileMetadataWidget

2013-09-30 Thread Vishesh Handa
Hello people The current KFileMetaDataWidget uses the Nepomuk libraries which no longer exist in kdelibs. So when we finally start splitting the libraries into their own git repos, kde4support will detect that Nepomuk is not installed and that will make KFileMetaDataWidget useless - It

Re: Making KDocTools independent of KArchive

2013-09-30 Thread T. C. Hollingsworth
Nicolás Alvarez wrote: Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux it would be easy to install, and on Windows it wouldn't be needed (what's a manpage?). And still leave it optional everywhere... Well if this is okay, you could just remove the KDE-specific DTDs

Re: Removing the KFileMetadataWidget

2013-09-30 Thread David Narvaez
On Mon, Sep 30, 2013 at 11:14 AM, Vishesh Handa m...@vhanda.in wrote: I'm planning on removing KFileMetaDataWidget completely, and marking it as deprecated in kdelibs4. Applications which still use it (Konversation and KGet) can start using Nepomuk::FileMetaDataWidget which offers the same api.