Re: KIOWidgets and KFile
On Sunday 29 September 2013 22:31:38 Sebastian Kügler wrote: On Sunday, September 29, 2013 20:50:28 David Faure wrote: This is clearly because kbookmarks was written as part of kio, and with konqueror in mind. I guess the question is how generic we want KBookmarks to be, i.e. should it work without KIO altogether (at the expense of losing automatic favicon integration -- can still be done by the caller though, as long as the favicon doesn't change over time... as far as I can see from the code). Maybe KBookmark could just be a small API backed by plugins? This would allow us to tackle bookmark provision the other way round, so we could - use different providers, thereby hook into what's there on a given system - use Nepomuk as a backend (we use Nepomuk for browser bookmarks in Plasma Active - hook into Chrome and Firefox bookmarks (at least read-only), we have code for this in KRunner - it'd let us get away for KBookmarks itself with minimal dependencies I imagine KBookmark being a more service-like thing, rather than a mechanism to store and read bookmarks. What you say makes sense, it sure sounds like a future direction for KBookmarks. I don't think this is the time for such work though, we want to release KF5 at some point, and this is major redesign. I think it has to be done as a separate lib, later. The main problem with that is that KBookmarks is actually both bookmark storage (using the XBEL format) and bookmark gui (add-bookmark dialog, bookmarks menu, toolbar). But well, in the case of plasma active you want neither one nor the other, so future efforts are indeed rather orthogonal to the current framework ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider
On Sept. 23, 2013, 12:07 p.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras? Martin Gräßlin wrote: Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing) Kevin Ottens wrote: Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-) I'm ok if you move it there then, looking forward to the patches. ;-) David Faure wrote: You know, if the dependency on QX11Extras is only for QX11Info::display(), that's really easy to write by hand in kmodifierkeyinfo_x11.cpp (see the 5 lines in QX11Info::display). Although I suspect after porting to XCB it would rather be about QX11Info::connection(), same thing though (accessible via QPlatformNativeInterface). QX11Info mostly exists for Qt4 source compat and for convenience, it's not mandatory to go through it. I'm not convinced about this going to KWindowSystem. An application developer who would want to display a Caps Lock indicator in the statusbar of his wordprocessor (say kile, which does exactly this) would first look at Qt, then notice you can't query it for the status of CapsLock, and would then look at kguiaddons and find it. But why would they look into KWindowSystem for this? This has nothing to do with window management. It's a key handling feature, complementing what's in QtGui. I certainly expect it to be implemented on Windows and/or Mac at some point in the future, it definitely makes sense there too (unlike, say, NETWM). Ok, I can see how to get away from QX11Extras, but Kevin also complained about XLib and XCB. And I do not see how I can interact with X11 without using either of those two. So either I'm allowed to use X-specific code in this module or the code cannot go into this module. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/#review40510 --- On Sept. 4, 2013, 8:37 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112443/ --- (Updated Sept. 4, 2013, 8:37 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines. Diffs - tier1/kguiaddons/CMakeLists.txt 3124c4d tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 Diff: http://git.reviewboard.kde.org/r/112443/diff/ Testing --- used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kde-doc-english] Making KDocTools independent of KArchive
Albert Astals Cid wrote: El Diumenge, 29 de setembre de 2013, a les 12:14:49, David Faure va escriure: On Monday 23 September 2013 20:23:13 Albert Astals Cid wrote: So we don't have a man page anymore? Debian will be happy :D Also we're losing the i18n-zation side of the man page, which the current -- help does not have. What do non-kde projects do? Write a man page by hand and translate it by hand? Or do they use .po files somehow? I've no clue, I don't participate in any non-kde project that has translated man pages. It seems po4a-gettextize knows how to create a .pot file from a manpage file. If anyone wants to give it a try to integrate into our l10n workflow... Still you'd lose the hability to say convert the manpage to an html file or a pdf like we have right now since it would not be a docbook anymore. We also lose our custom entities. On the other side, manpage generation does not require a final compression to bz2 (which is used for the htmls generated for the documentation), so maybe it could be possible to split something more? Just thinking aloud. Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KIOWidgets and KFile
On Sunday, September 29, 2013 23:49:15 Mark wrote: If i'm not mistaken, Dolphin is also using KBookmarks. Would your suggestion keep it alive for dolphin? Or would that mean creating a plugin that can read/write bookmarks to any file? It would work just like it is now. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kdelibs_stable #846
See http://build.kde.org/job/kdelibs_stable/846/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KIOWidgets and KFile
On Monday, September 30, 2013 09:03:36 David Faure wrote: On Sunday 29 September 2013 22:31:38 Sebastian Kügler wrote: [...] I imagine KBookmark being a more service-like thing, rather than a mechanism to store and read bookmarks. What you say makes sense, it sure sounds like a future direction for KBookmarks. I don't think this is the time for such work though, we want to release KF5 at some point, and this is major redesign. I think it has to be done as a separate lib, later. The main problem with that is that KBookmarks is actually both bookmark storage (using the XBEL format) and bookmark gui (add-bookmark dialog, bookmarks menu, toolbar). But well, in the case of plasma active you want neither one nor the other, so future efforts are indeed rather orthogonal to the current framework Yes, quite so. I'd love to have it hooked into our existing bookmarks, but that wasn't easy at that time. Plasma Active's bookmarks are now a really thin thing atop Nepomuk. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kpart dependencies
kpart (tier3) depends on KIO and KService, both of which are still in staging standalone build of kpart then fails because of reference to kprotocolmanager.h, from kio, which has local includes include global.h // KIO::CacheControl #include kio/kiocore_export.h #include kprotocolinfo.h ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/#review41018 --- staging/kemoticons/src/core/kemoticonsprovider.h http://git.reviewboard.kde.org/r/112984/#comment30112 Use KEMOTICONS_DEPRECATED I don't really understand what's better from ::save instead of ::saveTheme. Is it just the naming? They seem to do the same. - Aleix Pol Gonzalez On Sept. 28, 2013, 9:19 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112984/ --- (Updated Sept. 28, 2013, 9:19 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adjust API in KEmoticons framework: KEmoticonsProvider::save() -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save() and prefer saveTheme() instead. -Adjust plugins. -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(), which was empty. Now it's a pure virtual function. Therefore, I deprecate it and advice subclassing KEmoticonsProvider. Diffs - staging/kemoticons/src/core/kemoticonsprovider.h 85fc7efb8923d76476f0a16f70f8ebb15e451081 staging/kemoticons/src/core/kemoticonstheme.h b8b25f7607d3741dda78d6302c1ed81fbc9211a0 staging/kemoticons/src/core/kemoticonstheme.cpp ed3407cdd45c84d91f2d0057e108b760ff696ff2 staging/kemoticons/src/providers/adium/adium_emoticons.h 039a267679919c968bbe4d12c35abb90cf1bcc9b staging/kemoticons/src/providers/adium/adium_emoticons.cpp a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 staging/kemoticons/src/providers/kde/kde_emoticons.h 8cba6b194eee1543bf13f1177a0e4092f1a10943 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 5b5114a14dd94a6ebcba8a6f7dd163f73048189a staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 70bafa3fe4ba25c9d6a69634024b2c157235e674 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp e9f89eecce3d6e6407113a84cb5200ff66564c19 staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 0873a635a300e0ed8e38b1d59a535d6ec15b99cb staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 0dc92ed092d87a559fe7fa1a40e804843ab73d59 Diff: http://git.reviewboard.kde.org/r/112984/diff/ Testing --- It builds. It installs. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41019 --- Ping - Martin Klapetek On Sept. 25, 2013, 4:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112964: Prepare KPrintUtils cmake stuff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41020 --- Ping - Martin Klapetek On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 27, 2013, 9:15 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- ...before splitting. Diffs - staging/kprintutils/CMakeLists.txt 28ce872 staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 Diff: http://git.reviewboard.kde.org/r/112964/diff/ Testing --- Still builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112942: Move KDNSSD to tier2
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review41021 --- ping? - Aleix Pol Gonzalez On Sept. 25, 2013, 5:35 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Sept. 25, 2013, 5:35 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Moves KDNSSD to tier2, fixes some missing dependencies. Diffs - CMakeLists.txt eb1ea8c dnssd/CMakeLists.txt 15284e0 dnssd/ConfigureChecks.cmake dnssd/KDNSSDConfig.cmake.in dnssd/Mainpage.dox dnssd/PACKAGERS dnssd/config-dnssd.h.cmake dnssd/src/CMakeLists.txt dnssd/src/avahi-domainbrowser.cpp dnssd/src/avahi-domainbrowser_p.h dnssd/src/avahi-publicservice.cpp dnssd/src/avahi-publicservice_p.h dnssd/src/avahi-remoteservice.cpp dnssd/src/avahi-remoteservice_p.h dnssd/src/avahi-servicebrowser.cpp dnssd/src/avahi-servicebrowser_p.h dnssd/src/avahi-servicetypebrowser.cpp dnssd/src/avahi-servicetypebrowser_p.h dnssd/src/avahi_entrygroup_interface.h dnssd/src/avahi_entrygroup_interface.cpp dnssd/src/avahi_server_interface.h dnssd/src/avahi_server_interface.cpp dnssd/src/avahi_serviceresolver_interface.h dnssd/src/avahi_serviceresolver_interface.cpp dnssd/src/domainbrowser.h dnssd/src/domainmodel.h dnssd/src/domainmodel.cpp dnssd/src/dummy-domainbrowser.cpp dnssd/src/dummy-publicservice.cpp dnssd/src/dummy-remoteservice.cpp dnssd/src/dummy-servicebrowser.cpp dnssd/src/dummy-servicetypebrowser.cpp dnssd/src/kcm_kdnssd.kcfg dnssd/src/mdnsd-domainbrowser.cpp dnssd/src/mdnsd-domainbrowser_p.h dnssd/src/mdnsd-publicservice.cpp dnssd/src/mdnsd-remoteservice.cpp dnssd/src/mdnsd-responder.h dnssd/src/mdnsd-responder.cpp dnssd/src/mdnsd-sdevent.h dnssd/src/mdnsd-servicebrowser.cpp dnssd/src/mdnsd-servicebrowser_p.h dnssd/src/mdnsd-servicetypebrowser.cpp dnssd/src/mdnsd-servicetypebrowser_p.h dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml dnssd/src/publicservice.h dnssd/src/remoteservice.h dnssd/src/servicebase.h dnssd/src/servicebase.cpp dnssd/src/servicebase_p.h dnssd/src/servicebrowser.h dnssd/src/servicemodel.h dnssd/src/servicemodel.cpp dnssd/src/servicetypebrowser.h dnssd/src/settings.kcfgc staging/kde4support/src/ConfigureChecks.cmake 21cac3f tier2/CMakeLists.txt 73175b3 Diff: http://git.reviewboard.kde.org/r/112942/diff/ Testing --- Builds, no tests Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112901: Remove weird cmake indirections
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/#review41023
---
ping?
- Aleix Pol Gonzalez
On Sept. 24, 2013, 1:32 p.m., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/
---
(Updated Sept. 24, 2013, 1:32 p.m.)
Review request for Build System and KDE Frameworks.
Repository: kdelibs
Description
---
There were some un-reviewed cmake files where libraries would be defined with
a ${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that
didn't follow through.
I propose to remove all the uses for the moment, it's not ever being set
anyway.
Diffs
-
interfaces/kimproxy/library/CMakeLists.txt 36e55ef
interfaces/kmediaplayer/CMakeLists.txt 3d1797d
kdesu/CMakeLists.txt e526643
kdewebkit/CMakeLists.txt cdc5835
kfile/CMakeLists.txt e05137d
khtml/CMakeLists.txt 4e1bb80
kio/CMakeLists.txt 25dc6d9
kio/misc/kntlm/CMakeLists.txt fe70a8d
kjsembed/kjsembed/CMakeLists.txt 8ed55c1
knewstuff/src/CMakeLists.txt c313981
knotify/config/CMakeLists.txt 69e1c11
kparts/CMakeLists.txt 6ab9391
kpty/CMakeLists.txt 9a79827
kross/core/CMakeLists.txt 52cd3d4
kross/qts/CMakeLists.txt 1a30bd1
kross/ui/CMakeLists.txt 9e7806d
kutils/CMakeLists.txt 0cb281d
staging/kemoticons/src/core/CMakeLists.txt f7fb463
staging/ktextwidgets/src/CMakeLists.txt 4787c10
Diff: http://git.reviewboard.kde.org/r/112901/diff/
Testing
---
Everything still builds
Thanks,
Aleix Pol Gonzalez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41026 --- Ship it! Ship It! - John Layt On Sept. 25, 2013, 4:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
On Sept. 30, 2013, 11:23 a.m., Aleix Pol Gonzalez wrote: ping? As before, i'm ok with it, but am not going to give another ship it :) That really is up to someone with in deep knowledge about kde4support to see if it makes sense where you placed it. - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41022 --- On Sept. 24, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 24, 2013, 6:08 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Repository: kdelibs Description --- Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator. Diffs - staging/kde4support/autotests/CMakeLists.txt 473bdba staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION staging/kde4support/src/CMakeLists.txt 5dc206d staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112964: Prepare KPrintUtils cmake stuff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41027 --- staging/kprintutils/CMakeLists.txt http://git.reviewboard.kde.org/r/112964/#comment30118 Only half our modules are like this so far, should we add this as a KF5 module requirement? staging/kprintutils/CMakeLists.txt http://git.reviewboard.kde.org/r/112964/#comment30113 Why are you removing these? - Aleix Pol Gonzalez On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 27, 2013, 9:15 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- ...before splitting. Diffs - staging/kprintutils/CMakeLists.txt 28ce872 staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 Diff: http://git.reviewboard.kde.org/r/112964/diff/ Testing --- Still builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112964: Prepare KPrintUtils cmake stuff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41036 --- Ship it! Oh btw, it looks good to me and looks like an improvement. - Aleix Pol Gonzalez On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 27, 2013, 9:15 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- ...before splitting. Diffs - staging/kprintutils/CMakeLists.txt 28ce872 staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 Diff: http://git.reviewboard.kde.org/r/112964/diff/ Testing --- Still builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review41038 --- This review has been submitted with commit 273a89d6f10a9c2508ffd9a4394bb78417ebc126 by Martin Klapetek to branch frameworks. - Commit Hook On Sept. 25, 2013, 4:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112935: Move KPrintDialog into KPrintUtils
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 30, 2013, 2:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and John Layt. Repository: kdelibs Description --- Moves KPrintDialog out of kde4attic into KPrintUtils. Patch contains some changes like KComboBox - QComboBox etc and also removes couple of image icons, which are no longer needed (was part of a feature merged in qt). Will do separate commits. Diffs - staging/kde4attic/src/CMakeLists.txt 74ecc39 staging/kde4attic/src/kcupsoptionsjobwidget_p.h staging/kde4attic/src/kcupsoptionspageswidget.ui 0b6231b staging/kde4attic/src/kcupsoptionspageswidget_p.h staging/kde4attic/src/kcupsoptionspageswidget_p.cpp 5290405 staging/kde4attic/src/kcupsoptionssettingswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.h staging/kde4attic/src/kcupsoptionswidget_p.cpp 9393fbf staging/kde4attic/src/kdeprint_nup1.png 9f13429 staging/kde4attic/src/kdeprint_nup2.png 7289a7e staging/kde4attic/src/kdeprint_nup4.png b03a539 staging/kde4attic/src/kdeprint_nupother.png 5a7c385 staging/kde4attic/src/kdeprintdialog.h 5d9cd25 staging/kde4attic/src/kdeprintdialog.cpp 13f89a7 staging/kprintutils/src/CMakeLists.txt a2e56c9 staging/kprintutils/src/config-kprintutils.h.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112935/diff/ Testing --- Builds Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1299
See http://build.kde.org/job/kdelibs_frameworks_qt5/1299/changes Changes: [mklapetek] Remove unused image assets [mklapetek] Move KDEPrintSupport into KPrintUtils [mklapetek] Port from KLineEdit and KComboBox to their Qt variants -- [...truncated 18100 lines...] from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/ustring.h:36, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/identifier.h:25, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/CommonIdentifiers.h:24, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/completion.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/ExecState.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/interpreter.h:27, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/object.h:30, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/khtml/khtmladaptorpart.cpp:22: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashFunctions.h:110:1: warning: WTF_COMPILER_MSVC is not defined [-Wundef] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashFunctions.h:115:1: warning: WTF_COMPILER_MSVC is not defined [-Wundef] In file included from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashTraits.h:26:0, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashTable.h:26, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashMap.h:25, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashCountedSet.h:27, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/collector.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/ustring.h:36, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/identifier.h:25, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/CommonIdentifiers.h:24, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/completion.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/ExecState.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/interpreter.h:27, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/object.h:30, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/khtml/khtmladaptorpart.cpp:22: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashFunctions.h:159:1: warning: WTF_COMPILER_MSVC is not defined [-Wundef] In file included from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashTable.h:26:0, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashMap.h:25, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashCountedSet.h:27, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/collector.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/ustring.h:36, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/identifier.h:25, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/CommonIdentifiers.h:24, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/completion.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/ExecState.h:28, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/interpreter.h:27, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/object.h:30, from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/khtml/khtmladaptorpart.cpp:22: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashTraits.h:49:1: warning: WTF_COMPILER_MSVC is not defined [-Wundef] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../wtf/HashTraits.h:66:1: warning: WTF_COMPILER_MSVC is not defined [-Wundef] In file included from http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kjs/src/kjs/../kjs/identifier.h:25:0, from
Re: Review Request 112964: Prepare KPrintUtils cmake stuff
On Sept. 30, 2013, 2:01 p.m., Aleix Pol Gonzalez wrote: staging/kprintutils/CMakeLists.txt, line 30 http://git.reviewboard.kde.org/r/112964/diff/1/?file=192865#file192865line30 Why are you removing these? They have no effect on the code as the code compiles without them, so they are useless. Also I think the code should compile without any definitions being removed. On Sept. 30, 2013, 2:01 p.m., Aleix Pol Gonzalez wrote: staging/kprintutils/CMakeLists.txt, line 15 http://git.reviewboard.kde.org/r/112964/diff/1/?file=192865#file192865line15 Only half our modules are like this so far, should we add this as a KF5 module requirement? Could be, it's only temporary to allow building everything in one dir anyway and it should go away once everything is splitted for real. Imho it's easier in later stage to just remove one if line than to investigate what packages need to be found. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41027 --- On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 27, 2013, 9:15 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- ...before splitting. Diffs - staging/kprintutils/CMakeLists.txt 28ce872 staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 Diff: http://git.reviewboard.kde.org/r/112964/diff/ Testing --- Still builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112964: Prepare KPrintUtils cmake stuff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 30, 2013, 2:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- ...before splitting. Diffs - staging/kprintutils/CMakeLists.txt 28ce872 staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 Diff: http://git.reviewboard.kde.org/r/112964/diff/ Testing --- Still builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112964: Prepare KPrintUtils cmake stuff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/#review41043 --- This review has been submitted with commit 6801892e80324911ac9c1c6249922d016bf367ed by Martin Klapetek to branch frameworks. - Commit Hook On Sept. 27, 2013, 9:15 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112964/ --- (Updated Sept. 27, 2013, 9:15 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- ...before splitting. Diffs - staging/kprintutils/CMakeLists.txt 28ce872 staging/kprintutils/KPrintUtilsConfig.cmake.in f281555 Diff: http://git.reviewboard.kde.org/r/112964/diff/ Testing --- Still builds. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1301
See http://build.kde.org/job/kdelibs_frameworks_qt5/1301/changes Changes: [mklapetek] Remove unused includes; should fix the build -- [...truncated 17985 lines...] [ 73%] Building CXX object staging/kio/tests/CMakeFiles/kioslavetest.dir/kioslavetest_automoc.cpp.o [ 73%] Linking CXX executable kopenwithtest Building CXX object staging/kio/tests/CMakeFiles/kurlrequestertest_gui.dir/kurlrequestertest_gui_automoc.cpp.o Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/kcalendarsystemthai.cpp.o [ 73%] Building CXX object staging/kio/tests/CMakeFiles/kruntest.dir/kruntest.cpp.o Linking CXX executable kioslavetest Linking CXX executable kurlrequestertest_gui [ 73%] [ 73%] Building CXX object staging/kio/tests/CMakeFiles/kruntest.dir/kruntest_automoc.cpp.o Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/kdatetime.cpp.o [ 73%] Built target getalltest Linking CXX executable kruntest [ 73%] [ 73%] Built target KParts [ 73%] Generating ui_displaycert.h Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/kdatetimeformatter.cpp.o [ 73%] Generating ui_cacertificates.h Scanning dependencies of target previewtest [ 73%] Building CXX object staging/kio/tests/CMakeFiles/previewtest.dir/previewtest.cpp.o [ 73%] Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/kdatetimeparser.cpp.o [ 73%] Built target kdirlistertest_gui [ 74%] [ 75%] Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/kdayperiod.cpp.o Building CXX object staging/kio/tests/CMakeFiles/previewtest.dir/previewtest_automoc.cpp.o [ 75%] Built target kdirmodeltest_gui [ 75%] [ 75%] Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/ktimezone.cpp.o [ 75%] Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/klocalizeddate.cpp.o Generating ui_kcupsoptionspageswidget.h Linking CXX executable previewtest [ 75%] [ 75%] Built target kopenwithtest [ 75%] Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/ksystemtimezone.cpp.o Built target kurlrequestertest_gui [ 75%] Built target kioslavetest Scanning dependencies of target kbookmarkdialogtest [ 75%] Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/date/ktzfiletimezone.cpp.o [ 75%] Building CXX object staging/kbookmarks/tests/CMakeFiles/kbookmarkdialogtest.dir/kbookmarkdialogtest.cpp.o [ 75%] [ 75%] Scanning dependencies of target kbookmarktest Built target kruntest [ 75%] Building CXX object staging/kbookmarks/tests/CMakeFiles/kbookmarkdialogtest.dir/kbookmarkdialogtest_automoc.cpp.o Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/localization/klocale.cpp.o [ 75%] Linking CXX executable kbookmarkdialogtest Building CXX object staging/kbookmarks/autotests/CMakeFiles/kbookmarktest.dir/kbookmarktest.cpp.o [ 75%] Scanning dependencies of target kcm_ssl [ 75%] Building CXX object staging/kbookmarks/autotests/CMakeFiles/kbookmarktest.dir/kbookmarktest_automoc.cpp.o Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/localization/klocale_kde.cpp.o Scanning dependencies of target kacltest [ 75%] [ 75%] Building CXX object kio/tests/CMakeFiles/kacltest.dir/kacltest.cpp.o Building CXX object staging/kde4support/src/kssl/kcm/CMakeFiles/kcm_ssl.dir/kcmssl.cpp.o [ 75%] Linking CXX executable kbookmarktest [ 75%] [ 75%] Building CXX object kio/tests/CMakeFiles/kacltest.dir/kacltest_automoc.cpp.o Building CXX object staging/kde4support/src/kssl/kcm/CMakeFiles/kcm_ssl.dir/cacertificatespage.cpp.o Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/localization/klocale_unix.cpp.o Linking CXX executable kacltest http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kde4support/src/kssl/kcm/cacertificatespage.cpp:53:2: warning: #warning QT5 PORT TO NEW API [-Wcpp] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/staging/kde4support/src/kssl/kcm/cacertificatespage.cpp:81:2: warning: #warning QT5 PORT TO NEW API [-Wcpp] Scanning dependencies of target kdbusservicestartertest Scanning dependencies of target KPrintUtils [ 75%] Scanning dependencies of target kfiledialogtest Building CXX object staging/kde4support/src/kssl/kcm/CMakeFiles/kcm_ssl.dir/displaycertdialog.cpp.o [ 75%] [ 75%] Building CXX object kio/tests/CMakeFiles/kdbusservicestartertest.dir/kdbusservicestartertest.cpp.o [ 75%] [ 75%] Building CXX object staging/kde4attic/src/CMakeFiles/KDE4Attic.dir/KDE4Attic_automoc.cpp.o Building CXX object kio/tests/CMakeFiles/kfiledialogtest.dir/kfiledialogtest.cpp.o Building CXX object staging/kprintutils/src/CMakeFiles/KPrintUtils.dir/kprintpreview.cpp.o [ 75%] Building CXX object staging/kde4support/src/kssl/kcm/CMakeFiles/kcm_ssl.dir/kcm_ssl_automoc.cpp.o [ 75%] [ 75%] Linking CXX shared library libKDE4Attic.so Building CXX object kio/tests/CMakeFiles/kdbusservicestartertest.dir/kdbusservicestartertest_automoc.cpp.o Building
Removing the KFileMetadataWidget
Hello people The current KFileMetaDataWidget uses the Nepomuk libraries which no longer exist in kdelibs. So when we finally start splitting the libraries into their own git repos, kde4support will detect that Nepomuk is not installed and that will make KFileMetaDataWidget useless - It literally will not do anything. I'm planning on removing KFileMetaDataWidget completely, and marking it as deprecated in kdelibs4. Applications which still use it (Konversation and KGet) can start using Nepomuk::FileMetaDataWidget which offers the same api. Objections? -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Making KDocTools independent of KArchive
Nicolás Alvarez wrote: Maybe we can use a third-party docbook-to-manpage conversion tool. On Linux it would be easy to install, and on Windows it wouldn't be needed (what's a manpage?). And still leave it optional everywhere... Well if this is okay, you could just remove the KDE-specific DTDs and entities from the relevant docbook files and just call xsltproc manually. IIRC xml2pot and friends are not too picky about what sort of XML gets fed into them, so scripty should just continue to make POTs out of these plain docbooks just as well as it handles normal KDE ones. But, the script that generates kde-l10n-foo tarballs probably just calls meinproc so some work may be needed on that side to get translation working properly. (Whether that be fixing meinproc to handle non-KDE customized docbooks if it doesn't already or just fixing that script to use xsltproc where needed.) -T.C. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Removing the KFileMetadataWidget
On Mon, Sep 30, 2013 at 11:14 AM, Vishesh Handa m...@vhanda.in wrote: I'm planning on removing KFileMetaDataWidget completely, and marking it as deprecated in kdelibs4. Applications which still use it (Konversation and KGet) can start using Nepomuk::FileMetaDataWidget which offers the same api. I'll port KGet to Nepomuk::FileMetaDataWidget this week and put you in the review. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
