---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116952/#review53782
---
Ship it!
Another reason to get rid of prefixes indeed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116938/#review53784
---
Ship it!
Very nice.
src/plugin/kpluginloader.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116980/#review53796
---
docs/kded5/man-kded5.8.docbook
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116952/
---
(Updated March 23, 2014, 12:20 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116952/#review53802
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116952/#review53800
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116952/#review53801
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116938/#review53805
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116938/#review53803
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116938/#review53804
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116938/
---
(Updated March 23, 2014, 12:23 p.m.)
Status
--
This change has been
On March 23, 2014, 12:15 p.m., Burkhard Lück wrote:
docs/kded5/man-kded5.8.docbook, line 9
https://git.reviewboard.kde.org/r/116980/diff/1/?file=256194#file256194line9
All other docbook man pages in frameworks have kde; User's Manual
here, why this change?
To reflect the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116980/
---
(Updated March 23, 2014, 1:02 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116991/
---
Review request for KDE Frameworks and David Faure.
Repository: kded
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116980/
---
(Updated March 23, 2014, 1:37 p.m.)
Review request for KDE Frameworks.
On March 22, 2014, 10:21 p.m., Nicolás Alvarez wrote:
I can't test this because the kservice framework (dep of kinit) doesn't
compile on Windows.
Yeah... I was operating on the basis of this is probably less broken than
before. kwrapper_win.cpp also has some defunct stuff in it, I guess
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116934/
---
(Updated March 23, 2014, 1:51 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116980/
---
(Updated March 23, 2014, 1:55 p.m.)
Review request for Documentation and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116934/#review53811
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 1:51
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116934/
---
(Updated March 23, 2014, 2:11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116934/#review53812
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116993/
---
Review request for KDE Frameworks.
Repository: kcmutils
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116873/#review53813
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 3:47
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116994/
---
Review request for KDE Frameworks and Christoph Cullmann.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116991/#review53814
---
Ship it!
src/kded.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116994/#review53815
---
Ship it!
Ship It!
- Christoph Cullmann
On March 23, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116873/
---
(Updated March 23, 2014, 2:46 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116873/#review53816
---
This review has been submitted with commit
On March 23, 2014, 2:32 p.m., David Faure wrote:
src/kded.cpp, line 778
https://git.reviewboard.kde.org/r/116991/diff/1/?file=256350#file256350line778
To be honest I don't like this very much, the variable bCheckSycoca
suddenly changes meaning, from being the default value to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116991/#review53817
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116991/
---
(Updated March 23, 2014, 2:50 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/
---
Review request for KDE Frameworks.
Repository: kconfig
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116994/
---
(Updated March 23, 2014, 2:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116994/#review53819
---
This review has been submitted with commit
On 20/03/14 08:13, David Faure wrote:
On Thursday 20 March 2014 00:28:44 Alex Merry wrote:
LXR says the only
users are a couple of projects that haven't even made it onto
projects.kde.org.
Talking about LXR... I just finished setting up http://lxrnew.kde.org/ident
Can you use it for your
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116997/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116999/
---
Review request for KDE Frameworks.
Repository: kparts
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/
---
Review request for KDE Frameworks.
Repository: kservice
Description
On 23/03/14 14:55, Alex Merry wrote:
On 20/03/14 08:13, David Faure wrote:
On Thursday 20 March 2014 00:28:44 Alex Merry wrote:
LXR says the only
users are a couple of projects that haven't even made it onto
projects.kde.org.
Talking about LXR... I just finished setting up
On March 22, 2014, 11:21 p.m., Nicolás Alvarez wrote:
I can't test this because the kservice framework (dep of kinit) doesn't
compile on Windows.
Alex Merry wrote:
Yeah... I was operating on the basis of this is probably less broken
than before. kwrapper_win.cpp also has some
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117003/
---
Review request for KDE Frameworks.
Repository: kconfig
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117004/
---
Review request for KDE Frameworks and Christoph Feck.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117005/
---
Review request for KDE Frameworks and David Faure.
Repository: kservice
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117006/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References
lists a bunch of kde4 references that should be cleaned up. Any row
that contains things that aren't review requests is up for grabs
(including the ones that say in progress). Just put your email
address in the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117005/#review53829
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 6:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117006/#review53830
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 6:25
On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote:
this seems to broke kded modules loading here:
Cannot load library /usr/lib64/libkdeinit5_kio_file:
(/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No
such file or directory)
Hrvoje Senjan wrote:
err,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116966/#review53833
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 9:58
On Sunday 23 March 2014 17:33:46 Alex Merry wrote:
On 23/03/14 14:55, Alex Merry wrote:
On 20/03/14 08:13, David Faure wrote:
On Thursday 20 March 2014 00:28:44 Alex Merry wrote:
LXR says the only
users are a couple of projects that haven't even made it onto
projects.kde.org.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116936/#review53834
---
Ship it!
src/html/kopenssl.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116937/#review53835
---
Ship it!
Ship It!
- David Faure
On March 20, 2014, 8:50
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/
---
(Updated March 23, 2014, 8:12 p.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116958/#review53839
---
Hmm clearly the whole thing can be removed if there are no
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53841
---
Ship it!
- David Faure
On March 21, 2014, 6:15 p.m., Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/#review53850
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 4:45
On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote:
While I'm fine with the idea behind this optimization, I worry that this
implementation could create situations were a configuration change is not
picked up by the system. For instance, what happens if the user doesn't
immediately
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116967/#review53854
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 10:20
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53855
---
Ship it!
with one fix first
src/kcmultidialog.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116968/#review53856
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 10:27
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/#review53857
---
I don't really get the point of this change? (it's mostly a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116970/#review53858
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 11:06
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116971/#review53859
---
Ship it!
Ship It!
- David Faure
On March 21, 2014, 11:16
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116993/#review53860
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 2:18
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116845/#review53862
---
Ship it!
Everything seems fine for this to go in as is. The
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116845/
---
(Updated March 23, 2014, 10 p.m.)
Status
--
This change has been
On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote:
While I'm fine with the idea behind this optimization, I worry that this
implementation could create situations were a configuration change is not
picked up by the system. For instance, what happens if the user doesn't
immediately
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/#review53869
---
Ship it!
Ship It!
- David Faure
On March 23, 2014, 2:52
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116971/#review53871
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116971/
---
(Updated March 23, 2014, 11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116966/#review53873
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116966/
---
(Updated March 23, 2014, 11:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116968/#review53875
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117010/
---
Review request for KDE Frameworks and David Faure.
Repository: kconfig
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117010/#review53876
---
Ah, the old usrReadConfig still exists, OK, that solves my
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117011/
---
Review request for KDE Frameworks and kdewin.
Repository: kdoctools
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116866/#review53877
---
src/colors/kcolorutils.cpp
On March 24, 2014, 12:51 a.m., Aleix Pol Gonzalez wrote:
So what should happen so that we didn't need the workaround?
QStandardPaths would have to look in %KDEROOT%\share and not just
C:\ProgramData.
- Alexander
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117011/#review53880
---
Please add kdewin too. Given the outcome of the other RR, I'm
On March 23, 2014, 11:51 p.m., Aleix Pol Gonzalez wrote:
So what should happen so that we didn't need the workaround?
Alexander Richardson wrote:
QStandardPaths would have to look in %KDEROOT%\share and not just
C:\ProgramData.
So why aren't we adding this in Qt? Or even, why are
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117004/#review53884
---
Ship it!
Ship It!
- Christoph Feck
On March 23, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
See http://build.kde.org/job/krunner_master_qt5/37/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in
See http://build.kde.org/job/kde4support_master_qt5/85/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
84 matches
Mail list logo
