Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 175 - Unstable!

2017-01-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/175/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Jan 2017 01:37:36 + Build duration: 5 min 19 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Closed] D3912: kdoctools_install: match the full path for the program

2017-01-02 Thread ltoscano (Luigi Toscano)
This revision was automatically updated to reflect the committed changes. Closed by commit R238:938e439db206: kdoctools_install: match the full path for the program (authored by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3912?vs=9597=9622

Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-02 Thread Albert Astals Cid
> On Jan. 2, 2017, 10:53 p.m., Albert Astals Cid wrote: > > I don't think this makes any sense. I understand your pain, would i'd > > rather improve the search of hunspell than accept it's crap and you want > > people to override it. > > Andreas Sturmlechner wrote: > It sure ain't pretty.

Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-02 Thread Andreas Sturmlechner
> On Jan. 2, 2017, 10:53 p.m., Albert Astals Cid wrote: > > I don't think this makes any sense. I understand your pain, would i'd > > rather improve the search of hunspell than accept it's crap and you want > > people to override it. It sure ain't pretty. But then I don't know why the

Re: Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129742/#review101749 --- I don't think this makes any sense. I understand your pain,

[Differential] [Accepted] D3912: kdoctools_install: match the full path for the program

2017-01-02 Thread aacid (Albert Astals Cid)
aacid accepted this revision. aacid added a reviewer: aacid. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D3912 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129733/#review101744 --- Ship it! Ship It! - René J.V. Bertin On Jan. 2, 2017,

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129733/ --- (Updated Jan. 2, 2017, 8:57 p.m.) Review request for KDE Frameworks,

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread David Faure
> On Jan. 2, 2017, 8:29 p.m., René J.V. Bertin wrote: > > Ship It! > > René J.V. Bertin wrote: > Oops, I was too fast. > > David, on a whim I just tried > > ``` > sudo ln -s ../../.. /opt/local/share/applications/kde4/testlink > ``` > > which is the exact

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin
> On Jan. 2, 2017, 9:29 p.m., René J.V. Bertin wrote: > > Ship It! Oops, I was too fast. David, on a whim I just tried ``` sudo ln -s ../../.. /opt/local/share/applications/kde4/testlink ``` which is the exact same kind of tarpit situation that got me the other day. Your patch doesn't

Re: Review Request 129733: KSycoca: don't follow symlink to directories, it creates a risk of recursion

2017-01-02 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129733/#review101740 --- Ship it! Ship It! - René J.V. Bertin On Dec. 31,

Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

2017-01-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/#review101738 --- unfortunately this has a significant problem: see

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 171 - Fixed!

2017-01-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/171/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Jan 2017 15:15:47 + Build duration: 1 min 40 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 171 - Fixed!

2017-01-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/171/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Jan 2017 15:15:47 + Build duration: 1 min 40 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 129744: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129744/ --- (Updated Jan. 2, 2017, 2:53 p.m.) Status -- This change has been

Re: Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129745/ --- (Updated Jan. 2, 2017, 2:53 p.m.) Status -- This change has been

Re: Review Request 129748: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129748/ --- (Updated Jan. 2, 2017, 3:51 p.m.) Status -- This change has been

Re: Review Request 129747: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129747/ --- (Updated Jan. 2, 2017, 2:52 p.m.) Status -- This change has been

Re: Review Request 129751: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129751/ --- (Updated Jan. 2, 2017, 5:51 p.m.) Status -- This change has been

Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129750/ --- (Updated Jan. 2, 2017, 2:50 p.m.) Status -- This change has been

Re: Review Request 129749: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129749/ --- (Updated Jan. 2, 2017, 2:49 p.m.) Status -- This change has been

Re: Review Request 129749: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129749/#review101737 --- Ship it! Ship It! - Christoph Feck On Jan. 2, 2017,

Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129750/#review101731 --- Ship it! Ship It! - Lamarque Souza On Jan. 2, 2017,

Re: Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129750/#review101729 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2,

Re: Review Request 129751: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129751/#review101730 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2,

Re: Review Request 129748: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129748/#review101727 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2,

Re: Review Request 129747: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129747/#review101726 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2,

Re: Review Request 129746: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129746/#review101725 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2,

Re: Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129745/#review101724 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2,

Re: Review Request 129744: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129744/#review101723 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 2,

Review Request 129751: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129751/ --- Review request for KDE Frameworks. Repository: networkmanager-qt

Review Request 129750: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129750/ --- Review request for KDE Frameworks. Repository: solid Description

Review Request 129749: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129749/ --- Review request for KDE Frameworks. Repository: kwidgetsaddons

[Differential] [Accepted] D3850: Pass -fno-operator-names when supported

2017-01-02 Thread Ivan Čukić
ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Fine by me. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES

Review Request 129748: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129748/ --- Review request for KDE Frameworks. Repository: kwayland Description

Re: Review Request 129743: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129743/ --- (Updated Jan. 2, 2017, 11:04 a.m.) Status -- This change has been

Re: Review Request 129743: Q_ENUMS -> Q_ENUM

2017-01-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129743/#review101719 --- Ship it! Ship It! - David Rosca On Jan. 2, 2017,

Review Request 129747: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129747/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Review Request 129746: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129746/ --- Review request for KDE Frameworks. Repository: kdbusaddons Description

Re: Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129745/ --- (Updated Jan. 2, 2017, 10:48 a.m.) Review request for KDE Frameworks.

Review Request 129745: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129745/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129723/ --- (Updated Jan. 2, 2017, 10:46 a.m.) Status -- This change has been

Review Request 129744: Q_ENUMS -> Q_ENUM and Q_FLAGS -> Q_FLAG

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129744/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

2017-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129723/#review101718 --- Ship it! This is going to be called multiple times in

Review Request 129743: Q_ENUMS -> Q_ENUM

2017-01-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129743/ --- Review request for KDE Frameworks. Repository: bluez-qt Description

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

2017-01-02 Thread Anthony Fieroni
> On Ян. 2, 2017, 11:42 преди обяд, David Faure wrote: > > src/extractorcollection.cpp, line 155 > > > > > > Shouldn't this be the other way around? > > > > You're looking for an extractor for type ==

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 355 - Fixed!

2017-01-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Jan 2017 09:47:45 + Build duration: 1 min 6 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 355 - Fixed!

2017-01-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Jan 2017 09:47:45 + Build duration: 1 min 6 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 354 - Failure!

2017-01-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/354/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Jan 2017 09:42:02 + Build duration: 23 sec CHANGE SET No changes

Re: Minimum required cmake version

2017-01-02 Thread David Faure
On lundi 2 janvier 2017 03:50:06 CET Aleix Pol wrote: > On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne wrote: > > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote: > >> Hey, > >> > >> On 27/12/16 19:30, Aleix Pol wrote: > >> > +1 on changing to 3.0. > >> > >> Thanks for

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

2017-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review101716 --- src/extractorcollection.cpp (line 155)

Re: Review Request 129741: Add renaming capability to ioslaves

2017-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129741/#review101715 --- Renaming is really a special case of moving. Saying that