D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols

poboiko added reviewers: pinakahuja, vhanda. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D4995 To: poboiko, pinakahuja, vhanda Cc: #frameworks

D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols

poboiko created this revision. poboiko added a project: Frameworks. REVISION SUMMARY I've noted that on some PDF files, "balooshow -x file.pdf" segfaulted. Backtrace showed that it crashed due to having single "X" term (see line 201)

Re: Review Request 129985: [kio-extras] Thumbs for audio files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129985/#review102777 --- Any other downsides? - Anthony Fieroni On Март 6, 2017,

D4799: Delay notifications until desktop session has loaded

mck182 added a comment. Looks like this could work. The `KDE_FULL_SESSION` check is really old, I'm not sure if this has any implications. As David noted, the waiting thing should go to Plasma workspace, that's where it belongs. Also, it would be preferred if the implementation was

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/ --- (Updated March 9, 2017, 3:57 p.m.) Review request for KDE Frameworks,

D4972: Start drag with press and hold on touch events

mart added a comment. the discussion seems to me a bit unrelated with the review in itself. for me the patch is ok, +1 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D4972 To: davidedmundson, #plasma Cc: mart, hein, broulik, plasma-devel, #frameworks,

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 6, 2017, 11:38 p.m., Aleix Pol Gonzalez wrote: > > src/ioslaves/file/file.cpp, line 1378 > > > > > > I'm not convinced, what's the point of requestroot? Why don't you let > > it call the action

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/ --- (Updated March 9, 2017, 2:57 p.m.) Review request for KDE Frameworks,

D4799: Delay notifications until desktop session has loaded

davidedmundson added a comment. Cool, but we should put the blocking code in plasma, not here. Otherwise we'd interefere with other platforms. Maybe in plasma-workspace/startkde REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo Cc:

Communication with Phabricator upstream

Hi everyone, Just repeating my last email on this subject as it seems some folks have missed the previous memo. All issues with Phabricator should be logged at https://phabricator.kde.org/tag/phabricator/ - not with upstream. This is being done to avoid duplicate tasks, and to allow us to