D6197: Add basic KAuth support to file ioslave

chinmoyr updated this revision to Diff 15621. chinmoyr marked 6 inline comments as done. chinmoyr added a reviewer: dfaure. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6197?vs=15515=15621 REVISION DETAIL https://phabricator.kde.org/D6197 AFFECTED FILES

D6277: Emit errors when keditbookmarks is missing

valeriymalov marked an inline comment as done. valeriymalov added inline comments. INLINE COMMENTS > aacid wrote in kbookmarkmanager.cpp:341 > Why const_cast? Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since it doesn't change the object, yet we need to emit

D6279: API dox: add notes to KActionCollection about QAction ownership handling

kossebau updated this revision to Diff 15611. kossebau added a comment. note auto-removal on destroying the action REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6279?vs=15594=15611 BRANCH apidoxQActionOwnership REVISION DETAIL

D6288: isocpp.xml: replace P printf-like format with p

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY 'P' format does not exist, 'p' format is missing. TEST PLAN printf("%p", pointer); REPOSITORY R216 Syntax Highlighting BRANCH

D6277: Emit errors when keditbookmarks is missing

aacid added inline comments. INLINE COMMENTS > kbookmarkmanager.cpp:337 > +if (d->m_dialogAllowed && qobject_cast(qApp) && > QThread::currentThread() == qApp->thread()) { > +QMessageBox::critical(QApplication::activeWindow(), > QApplication::applicationName(), err); > +

D6277: Emit errors when keditbookmarks is missing

valeriymalov marked 2 inline comments as done. valeriymalov added inline comments. INLINE COMMENTS > aacid wrote in kbookmarkmanager.cpp:335 > Have you checked errorString actually returns something? > > Given startDetached is static it seems kind of weird it would update the > "this"

D6277: Emit errors when keditbookmarks is missing

valeriymalov updated this revision to Diff 15608. valeriymalov added a comment. Call startDetached without an object since it's static (my bad, QProcess object does return an error but it's UnknownError and I assume should be seeing FailedToStart; there doesn't seem to be any other

D6277: Emit errors when keditbookmarks is missing

aacid added inline comments. INLINE COMMENTS > kbookmarkmanager.cpp:330 > +{ > +QProcess *keditbookmarks = new QProcess(this); > +bool success = > keditbookmarks->startDetached(QStringLiteral("keditbookmarks"), args); You're leaking keditbookmarks > kbookmarkmanager.cpp:335 > +

D6279: API dox: add notes to KActionCollection about QAction ownership handling

apol added a comment. Then it would make sense to say what happens if an action is destroyed as well, no? Something like `If an action is destroyed will be removed automatically from the KActionCollection`. Which is what I think it happens but didn't really check. REPOSITORY R263

D6279: API dox: add notes to KActionCollection about QAction ownership handling

kossebau created this revision. Restricted Application added a project: Frameworks. REPOSITORY R263 KXmlGui BRANCH apidoxQActionOwnership REVISION DETAIL https://phabricator.kde.org/D6279 AFFECTED FILES src/kactioncollection.h To: kossebau, #frameworks, dfaure

D6277: Emit errors when keditbookmarks is missing

valeriymalov edited the summary of this revision. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D6277 To: valeriymalov, #frameworks Cc: ltoscano

D6277: Emit errors when keditbookmarks is missing

ltoscano added a comment. This is not a comment about the content of the patch, but if it closed that bug, please change the reference to the bug with a simple line containing: BUG: xx REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D6277 To:

D6277: Emit errors when keditbookmarks is missing

valeriymalov created this revision. valeriymalov added a project: Frameworks. REVISION SUMMARY KBookmarkManager::slotEditBookmarks is supposed to run keditbookmarks, but does not emit any errors when if it's missing This makes "Edit bookmarks" menu fail silently in applications that use

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/26/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Mon, 19 Jun 2017 15:35:25 + Build duration: 6 min 40 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 19 Jun 2017 15:35:25 + Build duration: 2 min 6 sec and counting

D6253: Use FindInotify.cmake to decide wheter inotify is available.

This revision was automatically updated to reflect the committed changes. Closed by commit R244:59db8a5ea224: Use FindInotify.cmake to decide wheter inotify is available. (authored by tcberner). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/12/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Mon, 19 Jun 2017 15:17:04 + Build duration: 2 min 58 sec and counting JUnit Tests

D6265: Use FindInotify.cmake to decide wheter inotify is available.

This revision was automatically updated to reflect the committed changes. Closed by commit R293:401b38989f0d: Use FindInotify.cmake to decide wheter inotify is available. (authored by adridg). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6265?vs=15563=15583

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote: > > this will work only when the Dialog' version of setvisible is called, > > So this will break released Plasma? no, it just means that who calls show() or the wrong setVisible() would

D6215: Make sure size is final after showEvent

davidedmundson added a comment. > this will work only when the Dialog' version of setvisible is called, So this will break released Plasma? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas,

D6215: Make sure size is final after showEvent

mart updated this revision to Diff 15579. mart added a comment. hide again mainitem when not visible show it in setVisible, that is before show. this will work only when the Dialog' version of setvisible is called, so must be paid attention when using dialog directly from C++, but

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Ah, PEBKAC, I only added NO_DEFAULT_PATH to the code when manually applying the patch. Fixing also PATH->PATHS improved things, and the executable now is found in ${_path}. No

KDE CI: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/23/ Project: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 Date of build: Mon, 19 Jun 2017 12:39:49 + Build duration: 2 min 46 sec and

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. Thanks for the fix. Sadly this fails on my openSUSE TW system with system Qt5 packages, where _path is /usr/lib64/qt5/bin, and while that dir has both qhelpgenerator-qt5 and

KDE CI: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build-sandbox.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/22/ Project: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 Date of build: Mon, 19 Jun 2017 12:08:15 + Build duration: 2 min 24 sec and

D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)

This revision was automatically updated to reflect the committed changes. Closed by commit R296:fd4d41bd65fd: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it… (authored by hein). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D6253: Use FindInotify.cmake to decide wheter inotify is available.

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6253 To: tcberner, #freebsd, dfaure, kfunk Cc: #frameworks

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system

D6215: Make sure size is final after showEvent

mart added a comment. with this, that removes most of the properties depending from visible, i usually get properly sized notifications, tough every now and then the size still fails and a reposition is always visible right after the notification appears https://pastebin.com/ia8nLGiw

D6197: Add basic KAuth support to file ioslave

eliasp added inline comments. INLINE COMMENTS > file.h:107 > +}; > +bool execWithRoot(const QString , const QString , const > QVariant , PriviledgeWarning warning); > +void endPriviledgeOp(); I find `execWithRoot()` to be a bit misleading, as the goal shouldn't be to always

D6215: Make sure size is final after showEvent

mart added a comment. In https://phabricator.kde.org/D6215#117370, @mart wrote: > it's maybe due to the layout of actions buttons that changes (in the notification applet, populatepopup) but this (columnLayout computed height) doesn't really have effect until it's visible. in

D6215: Make sure size is final after showEvent

mart added a comment. it's maybe due to the layout of actions buttons that changes (in the notification applet, populatepopup) but this (columnLayout computed height) doesn't really have effect until it's visible. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D6215: Make sure size is final after showEvent

mart added a comment. this is how it looks under wayland, keeping the visibility change of the mainitem in plasma-framework and your patch in the notifications applet F3787256: Spectacle.Vd3087.png REPOSITORY R242 Plasma Framework (Library) REVISION

D6116: Add new stateChanged() signal to active connection

jgrulich updated this revision to Diff 15566. jgrulich added a comment. Revert unwanted change REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6116?vs=15564=15566 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6116 AFFECTED FILES

D6116: Add new stateChanged() signal to active connection

jgrulich updated this revision to Diff 15564. jgrulich added a comment. Fix enum name and avoid ABI breakage with overriden signal REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6116?vs=15210=15564 BRANCH master REVISION DETAIL

D1231: Add Remote Access interface to KWayland

davidedmundson added a comment. We don't want or need to go via the QPA on the server side. The wayland specific output management is in the DRM plugin, your code is in the DRM plugin. It should be simple. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To:

D6265: Use FindInotify.cmake to decide wheter inotify is available.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D6265 To: adridg, dfaure, vhanda, tcberner Cc: #frameworks

D6265: Use FindInotify.cmake to decide wheter inotify is available.

adridg added reviewers: vhanda, tcberner. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D6265 To: adridg, dfaure, vhanda, tcberner Cc: #frameworks

D6265: Use FindInotify.cmake to decide wheter inotify is available.

adridg created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY FreeBSD also has sys/inotify.h available, but it is a library. We added FindInotify.cmake to ecm a while a go for this, but never got