D6197: Add basic KAuth support to file ioslave

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 15621.
chinmoyr marked 6 inline comments as done.
chinmoyr added a reviewer: dfaure.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6197?vs=15515=15621

REVISION DETAIL
  https://phabricator.kde.org/D6197

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt
  src/ioslaves/file/kauth/file.actions
  src/ioslaves/file/kauth/helper.cpp
  src/ioslaves/file/kauth/helper.h
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, elvisangelaccio, #frameworks, dfaure
Cc: eliasp, aacid

D6277: Emit errors when keditbookmarks is missing

[Valeriy Malov]

valeriymalov marked an inline comment as done.
valeriymalov added inline comments.

INLINE COMMENTS

> aacid wrote in kbookmarkmanager.cpp:341
> Why const_cast?

Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since it 
doesn't change the object, yet we need to emit non-const singal error. So 
should it be const or not?

Also, I'm looking at slotEditBookmarks and slotEditBookmarksAtAddress, and 
don't understand why those weren't const, since they don't have side-effects 
too, although I might be missing something since I'm not too familiar with Qt.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6279: API dox: add notes to KActionCollection about QAction ownership handling

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 15611.
kossebau added a comment.


  note auto-removal on destroying the action

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6279?vs=15594=15611

BRANCH
  apidoxQActionOwnership

REVISION DETAIL
  https://phabricator.kde.org/D6279

AFFECTED FILES
  src/kactioncollection.h

To: kossebau, #frameworks, dfaure
Cc: apol

D6288: isocpp.xml: replace P printf-like format with p

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  'P' format does not exist, 'p' format is missing.

TEST PLAN
  printf("%p", pointer);

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ioscpp-printf-like

REVISION DETAIL
  https://phabricator.kde.org/D6288

AFFECTED FILES
  data/syntax/isocpp.xml

To: jpoelen
Cc: #frameworks

D6277: Emit errors when keditbookmarks is missing

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kbookmarkmanager.cpp:337
> +if (d->m_dialogAllowed && qobject_cast(qApp) && 
> QThread::currentThread() == qApp->thread()) {
> +QMessageBox::critical(QApplication::activeWindow(), 
> QApplication::applicationName(), err);
> +}

critical is a bit heavy in my opinion, i'd just go for warning for this and the 
debug line below.

> kbookmarkmanager.cpp:341
> +qCritical() << QStringLiteral("Failed to start keditbookmarks");
> +emit const_cast(this)->error(err);
> +}

Why const_cast?

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

[Valeriy Malov]

valeriymalov marked 2 inline comments as done.
valeriymalov added inline comments.

INLINE COMMENTS

> aacid wrote in kbookmarkmanager.cpp:335
> Have you checked errorString actually returns something?
> 
> Given startDetached is static it seems kind of weird it would update the 
> "this" errorString

Yeah it returns unknown error, my mistake, I suppose I should just switch back 
to call without object since it's a static method
There don't seem to be any informative errors apart from FailedToStart (which 
is the only one we are interested in?) in QProcess anyway

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

[Valeriy Malov]

valeriymalov updated this revision to Diff 15608.
valeriymalov added a comment.


  Call startDetached without an object since it's static (my bad, QProcess 
object does return an error but it's UnknownError and I assume should be seeing 
FailedToStart; there doesn't seem to be any other interesting errors so 
probably return value from startDetached should be enough)

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6277?vs=15589=15608

REVISION DETAIL
  https://phabricator.kde.org/D6277

AFFECTED FILES
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6277: Emit errors when keditbookmarks is missing

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kbookmarkmanager.cpp:330
> +{
> +QProcess *keditbookmarks = new QProcess(this);
> +bool success = 
> keditbookmarks->startDetached(QStringLiteral("keditbookmarks"), args);

You're leaking keditbookmarks

> kbookmarkmanager.cpp:335
> +QString err = tr("Cannot launch keditbookmarks: %1\n\n"
> + "Most likely you do not have keditbookmarks 
> currently installed").arg(keditbookmarks->errorString());
> +

Have you checked errorString actually returns something?

Given startDetached is static it seems kind of weird it would update the "this" 
errorString

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: aacid, ltoscano

D6279: API dox: add notes to KActionCollection about QAction ownership handling

[Aleix Pol Gonzalez]

apol added a comment.


  Then it would make sense to say what happens if an action is destroyed as 
well, no?
  Something like `If an action is destroyed will be removed automatically from 
the KActionCollection`. Which is what I think it happens but didn't really 
check.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D6279

To: kossebau, #frameworks, dfaure
Cc: apol

D6279: API dox: add notes to KActionCollection about QAction ownership handling

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added a project: Frameworks.

REPOSITORY
  R263 KXmlGui

BRANCH
  apidoxQActionOwnership

REVISION DETAIL
  https://phabricator.kde.org/D6279

AFFECTED FILES
  src/kactioncollection.h

To: kossebau, #frameworks, dfaure

D6277: Emit errors when keditbookmarks is missing

[Valeriy Malov]

valeriymalov edited the summary of this revision.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: ltoscano

D6277: Emit errors when keditbookmarks is missing

[Luigi Toscano]

ltoscano added a comment.


  This is not a comment about the content of the patch, but if it closed that 
bug, please change the reference to the bug with a simple line containing:
  
  BUG: xx

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

To: valeriymalov, #frameworks
Cc: ltoscano

D6277: Emit errors when keditbookmarks is missing

[Valeriy Malov]

valeriymalov created this revision.
valeriymalov added a project: Frameworks.

REVISION SUMMARY
  KBookmarkManager::slotEditBookmarks is supposed to run keditbookmarks, but 
does not emit any errors when if it's missing
  This makes "Edit bookmarks" menu fail silently in applications that use 
KBookmarks (e.g. krdc, konsole)
  
  See https://bugs.kde.org/show_bug.cgi?id=303830

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D6277

AFFECTED FILES
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: valeriymalov, #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 26 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/26/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Mon, 19 Jun 2017 15:35:25 +
 Build duration:
6 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(10/10)85%
(79/93)85%
(79/93)73%
(6043/8239)43%
(10796/25227)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(33/40)83%
(33/40)97%
(2595/2682)49%
(6579/13503)src.desktoptojson100%
(3/3)100%
(3/3)79%
(84/106)38%
(146/384)src.lib67%
(2/3)67%
(2/3)56%
(302/536)22%
(192/893)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/787)18%
(195/1086)src.lib.io90%
(9/10)90%
(9/10)59%
(825/1397)29%
(939/3214)src.lib.jobs71%
(5/7)71%
(5/7)52%
(159/304)39%
(57/146)src.lib.plugin100%
(8/8)100%
(8/8)86%
(646/748)44%
(1035/2326)src.lib.randomness100%
(2/2)100%
(2/2)67%
(66/99)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)46%
(349/764)40%
(794/1981)src.lib.util100%
(10/10)100%
(10/10)81%
(665/816)50%
(814/1616)

build.log
Description: Binary data

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 21 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/21/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 19 Jun 2017 15:35:25 +
 Build duration:
2 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 22 test(s)Failed: TestSuite.kdirwatch_stat_unittest

build.log
Description: Binary data

D6253: Use FindInotify.cmake to decide wheter inotify is available.

[Tobias C. Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:59db8a5ea224: Use FindInotify.cmake to decide wheter 
inotify is available. (authored by tcberner).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6253?vs=15532=15584

REVISION DETAIL
  https://phabricator.kde.org/D6253

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/io/kdirwatch.cpp

To: tcberner, #freebsd, dfaure, kfunk
Cc: #frameworks

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 12 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/12/
 Project:
Frameworks baloo kf5-qt5 XenialQt5.7
 Date of build:
Mon, 19 Jun 2017 15:17:04 +
 Build duration:
2 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(12/12)77%
(111/144)77%
(111/144)73%
(5039/6932)50%
(2613/5194)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(42/42)89%
(16/18)autotests.integration100%
(3/3)100%
(3/3)95%
(242/255)64%
(140/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(40/40)57%
(25/44)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(736/736)53%
(390/740)autotests.unit.file100%
(11/11)100%
(11/11)97%
(788/809)51%
(438/864)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(315/326)52%
(156/302)src.codecs100%
(5/5)100%
(5/5)87%
(120/138)76%
(32/42)src.engine97%
(38/39)97%
(38/39)79%
(1607/2038)58%
(796/1379)src.file39%
(17/44)39%
(17/44)45%
(678/1506)38%
(374/980)src.file.extractor100%
(2/2)100%
(2/2)69%
(20/29)58%
(7/12)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(22/22)61%
(11/18)src.lib55%
(6/11)55%
(6/11)43%
(429/991)40%
(228/575)

build.log
Description: Binary data

D6265: Use FindInotify.cmake to decide wheter inotify is available.

[Adriaan de Groot]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:401b38989f0d: Use FindInotify.cmake to decide wheter 
inotify is available. (authored by adridg).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6265?vs=15563=15583

REVISION DETAIL
  https://phabricator.kde.org/D6265

AFFECTED FILES
  CMakeLists.txt
  src/file/CMakeLists.txt

To: adridg, dfaure, vhanda, tcberner
Cc: #frameworks

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote:
  
  > > this will work only when the Dialog' version of setvisible is called,
  >
  > So this will break released Plasma?
  
  
  no, it just means that who calls show() or the wrong setVisible() would just 
get the previous behavior of mainItem being shown only at showevent, so with 
the potential resize/position glitch that is already in now, but setvisible 
gets called both there and in the showevent, so it wouldn't significantly break 
(just in most common case, the second setvisible would be a noop)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[David Edmundson]

davidedmundson added a comment.


  > this will work only when the Dialog' version of setvisible is called,
  
  So this will break released Plasma?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart updated this revision to Diff 15579.
mart added a comment.


  hide again mainitem when not visible
  
  show it in setVisible, that is before show.
  this will work only when the Dialog' version of setvisible is called,
  so must be paid attention when using dialog directly from C++,
  but it covers all QML usage

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6215?vs=15462=15579

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6215

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6249: FindQHelpGenerator: avoid picking up Qt4 version

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Ah, PEBKAC, I only added NO_DEFAULT_PATH to the code when manually applying 
the patch. Fixing also PATH->PATHS improved things, and the executable now is 
found in ${_path}.
  
  No more objection from my side :)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6249

To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system

KDE CI: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 - Build # 23 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/23/
 Project:
Frameworks networkmanager-qt kf5-qt5 XenialQt5.7
 Date of build:
Mon, 19 Jun 2017 12:39:49 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(6/6)56%
(174/312)56%
(174/312)54%
(6126/11241)36%
(1856/5102)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)100%
(239/239)47%
(149/318)autotests.settings100%
(46/46)100%
(46/46)99%
(1274/1282)55%
(346/626)src30%
(29/97)30%
(29/97)28%
(968/3433)21%
(410/1912)src.dbus21%
(16/78)21%
(16/78)9%
(88/946)6%
(5/78)src.fakenetwork75%
(6/8)75%
(6/8)69%
(494/711)44%
(56/128)src.settings92%
(71/77)92%
(71/77)66%
(3063/4630)44%
(890/2040)

build.log
Description: Binary data

D6249: FindQHelpGenerator: avoid picking up Qt4 version

[Friedrich W. H. Kossebau]

kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.


  Thanks for the fix.  Sadly this fails on my openSUSE TW system with system 
Qt5 packages, where _path is /usr/lib64/qt5/bin, and while that dir has both 
qhelpgenerator-qt5 and qhelpgenerator files, they are links pointing to the 
actual executable file located at /usr/bin/qhelpgenerator-qt5
  
lrwxrwxrwx 1 root root 31 28. Mai 12:40 
/usr/lib64/qt5/bin/qhelpgenerator-qt5 -> ../../../bin/qhelpgenerator-qt5
lrwxrwxrwx 1 root root 31 28. Mai 12:40 /usr/lib64/qt5/bin/qhelpgenerator 
-> ../../../bin/qhelpgenerator-qt5
  
  Still had no time to investigate some more why this fails.
  
  (Actually it is not such an issue if the Qt4 version is used, it's working as 
well. But still using the latest version of qhelpgenerator, as provided by qt5, 
feels better -> "newer is better!")

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D6249

To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system

KDE CI: Frameworks networkmanager-qt kf5-qt5 XenialQt5.7 - Build # 22 - Failure!

[no-reply]

BUILD FAILURE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20networkmanager-qt%20kf5-qt5%20XenialQt5.7/22/
 Project:
Frameworks networkmanager-qt kf5-qt5 XenialQt5.7
 Date of build:
Mon, 19 Jun 2017 12:08:15 +
 Build duration:
2 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 299.61 KB...]Scanning dependencies of target ipv4settingtest[ 83%] Building CXX object autotests/settings/CMakeFiles/ipv4settingtest.dir/ipv4settingtest.cpp.o[ 83%] Building CXX object src/fakenetwork/CMakeFiles/fakeNetwork.dir/device.cpp.o[ 84%] Linking CXX executable bondsettingtest[ 84%] Built target olpcmeshsettingtestScanning dependencies of target wimaxsettingtest[ 84%] Building CXX object autotests/settings/CMakeFiles/wimaxsettingtest.dir/wimaxsettingtest.cpp.o[ 84%] Built target bondsettingtestScanning dependencies of target connectionsettingtest[ 84%] Building CXX object autotests/settings/CMakeFiles/connectionsettingtest.dir/connectionsettingtest.cpp.o[ 84%] Linking CXX executable pppoesettingtest[ 84%] Linking CXX executable pppsettingtest[ 85%] Linking CXX executable gsmsettingtest[ 85%] Built target pppoesettingtest[ 85%] Linking CXX executable adslsettingtest[ 85%] Building CXX object src/fakenetwork/CMakeFiles/fakeNetwork.dir/fakenetwork.cpp.o[ 85%] Built target pppsettingtest[ 85%] Built target gsmsettingtestScanning dependencies of target bluetoothsettingtest[ 86%] Building CXX object autotests/settings/CMakeFiles/bluetoothsettingtest.dir/bluetoothsettingtest.cpp.oScanning dependencies of target ipv6settingtest[ 87%] Building CXX object autotests/settings/CMakeFiles/ipv6settingtest.dir/ipv6settingtest.cpp.o[ 87%] Built target adslsettingtestScanning dependencies of target serialsettingtest[ 88%] Building CXX object autotests/settings/CMakeFiles/serialsettingtest.dir/serialsettingtest.cpp.o[ 88%] Building CXX object autotests/settings/CMakeFiles/wimaxsettingtest.dir/wimaxsettingtest_automoc.cpp.o[ 89%] Building CXX object autotests/settings/CMakeFiles/ipv4settingtest.dir/ipv4settingtest_automoc.cpp.o[ 90%] Building CXX object src/fakenetwork/CMakeFiles/fakeNetwork.dir/settings.cpp.o[ 90%] Building CXX object autotests/settings/CMakeFiles/connectionsettingtest.dir/connectionsettingtest_automoc.cpp.o/home/jenkins/workspace/Frameworks networkmanager-qt kf5-qt5 XenialQt5.7/src/fakenetwork/fakenetwork.cpp:389:64: warning: unused parameter 'iface' [-Wunused-parameter] QDBusObjectPath FakeNetwork::GetDeviceByIpIface(const QString )^[ 90%] Building CXX object autotests/settings/CMakeFiles/bluetoothsettingtest.dir/bluetoothsettingtest_automoc.cpp.o[ 91%] Linking CXX executable wimaxsettingtest[ 91%] Building CXX object autotests/settings/CMakeFiles/serialsettingtest.dir/serialsettingtest_automoc.cpp.o[ 91%] Built target wimaxsettingtest[ 91%] Linking CXX executable ipv4settingtestScanning dependencies of target bridgesettingtest[ 91%] Linking CXX executable connectionsettingtest[ 91%] Building CXX object autotests/settings/CMakeFiles/bridgesettingtest.dir/bridgesettingtest.cpp.o[ 91%] Building CXX object autotests/settings/CMakeFiles/ipv6settingtest.dir/ipv6settingtest_automoc.cpp.o/home/jenkins/workspace/Frameworks networkmanager-qt kf5-qt5 XenialQt5.7/src/fakenetwork/settings.cpp:76:71: warning: unused parameter 'connection' [-Wunused-parameter] QDBusObjectPath Settings::AddConnectionUnsaved(const NMVariantMapMap )   ^/home/jenkins/workspace/Frameworks networkmanager-qt kf5-qt5 XenialQt5.7/src/fakenetwork/settings.cpp:82:62: warning: unused parameter 'uuid' [-Wunused-parameter] QDBusObjectPath Settings::GetConnectionByUuid(const QString )  ^[ 91%] Built target ipv4settingtest[ 92%] Building CXX object autotests/settings/CMakeFiles/bridgesettingtest.dir/bridgesettingtest_automoc.cpp.o[ 92%] Linking CXX executable bluetoothsettingtest[ 92%] Building CXX object src/fakenetwork/CMakeFiles/fakeNetwork.dir/wireddevice.cpp.o[ 92%] Built target bluetoothsettingtestScanning dependencies of target wiredsettingtest[ 92%] Building CXX object autotests/settings/CMakeFiles/wiredsettingtest.dir/wiredsettingtest.cpp.o[ 92%] Linking CXX executable serialsettingtest[ 92%] Built target serialsettingtest[ 92%] Building CXX object autotests/settings/CMakeFiles/wiredsettingtest.dir/wiredsettingtest_automoc.cpp.o[ 92%] Linking CXX executable ipv6settingtest[ 92%] Building CXX object src/fakenetwork/CMakeFiles/fakeNetwork.dir/wirelessdevice.cpp.o[ 92%] Building CXX object src/fakenetwork/CMakeFiles/fakeNetwork.dir/fakeNetwork_automoc.cpp.o[ 92%] Built target connectionsettingtestScanning dependencies of target vpnsettingtest[ 92%] Linking CXX executable bridgesettingtest[ 93%] Building CXX object 

D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:fd4d41bd65fd: Don't rely on QQuickWindow delivering 
QEvent::Ungrab as mouseUngrabEvent (as it… (authored by hein).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6246?vs=15508=15574

REVISION DETAIL
  https://phabricator.kde.org/D6246

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp

To: hein, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6253: Use FindInotify.cmake to decide wheter inotify is available.

[Kevin Funk]

kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6253

To: tcberner, #freebsd, dfaure, kfunk
Cc: #frameworks

D6249: FindQHelpGenerator: avoid picking up Qt4 version

[Kevin Funk]

kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6249

To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  with this, that removes most of the properties depending from visible, i 
usually get properly sized notifications, tough every now and then the size 
still fails and a reposition is always visible right after the notification 
appears
  https://pastebin.com/ia8nLGiw

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6197: Add basic KAuth support to file ioslave

[Elias Probst]

eliasp added inline comments.

INLINE COMMENTS

> file.h:107
> +};
> +bool execWithRoot(const QString , const QString , const 
> QVariant , PriviledgeWarning warning);
> +void endPriviledgeOp();

I find `execWithRoot()` to be a bit misleading, as the goal shouldn't be to 
always elevate to `root`'s privileges but to only what's required to execute 
the specific operation (e.g. browse `/home/someotheruser` doesn't need `root`'s 
privileges but only `someotheruser`'s privileges).

Always elevating to root is IMHO by far too permissive.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6197

To: chinmoyr, elvisangelaccio, #frameworks
Cc: eliasp, aacid

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6215#117370, @mart wrote:
  
  > it's maybe due to the layout of actions buttons that changes (in the 
notification applet, populatepopup) but this (columnLayout computed height) 
doesn't really have effect until it's visible.
  
  
  in fact, if in the notification applet i do, right before setVisible():
  popup->property("mainItem").value()->setVisible(true);
  
  making mainitem visible just before the showevent, 
  then the look is correct.
  
  if i do that right in the showevent handler, it's too late and i get wrongly 
calculate sizes and spurious extra resize events

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  it's maybe due to the layout of actions buttons that changes (in the 
notification applet, populatepopup) but this (columnLayout computed height) 
doesn't really have effect until it's visible.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  this is how it looks under wayland, keeping the visibility change of the 
mainitem in plasma-framework and your patch in the notifications applet 
F3787256: Spectacle.Vd3087.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6116: Add new stateChanged() signal to active connection

[Jan Grulich]

jgrulich updated this revision to Diff 15566.
jgrulich added a comment.


  Revert unwanted change

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6116?vs=15564=15566

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6116

AFFECTED FILES
  src/activeconnection.cpp
  src/activeconnection.h
  src/activeconnection_p.h
  src/fakenetwork/activeconnection.h
  src/fakenetwork/fakenetwork.cpp
  src/vpnconnection.h

To: jgrulich, lvsouza
Cc: anthonyfieroni, davidedmundson, #frameworks

D6116: Add new stateChanged() signal to active connection

[Jan Grulich]

jgrulich updated this revision to Diff 15564.
jgrulich added a comment.


  Fix enum name and avoid ABI breakage with overriden signal

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6116?vs=15210=15564

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6116

AFFECTED FILES
  CMakeLists.txt
  src/activeconnection.cpp
  src/activeconnection.h
  src/activeconnection_p.h
  src/fakenetwork/activeconnection.h
  src/fakenetwork/fakenetwork.cpp
  src/vpnconnection.h

To: jgrulich, lvsouza
Cc: anthonyfieroni, davidedmundson, #frameworks

D1231: Add Remote Access interface to KWayland

[David Edmundson]

davidedmundson added a comment.


  We don't want or need to go via the QPA on the server side. The wayland 
specific output management is in the  DRM plugin, your code is in the DRM 
plugin. It should be simple.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas

D6265: Use FindInotify.cmake to decide wheter inotify is available.

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6265

To: adridg, dfaure, vhanda, tcberner
Cc: #frameworks

D6265: Use FindInotify.cmake to decide wheter inotify is available.

[Adriaan de Groot]

adridg added reviewers: vhanda, tcberner.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D6265

To: adridg, dfaure, vhanda, tcberner
Cc: #frameworks

D6265: Use FindInotify.cmake to decide wheter inotify is available.

[Adriaan de Groot]

adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  FreeBSD also has sys/inotify.h available, but it is a library.
  
  We added FindInotify.cmake to ecm a while a go for this, but never got
  around to upstream the rest of the patches. On Linux, the include and
  libraries are empty (but found) while on FreeBSD with inotify they
  are set to the right paths.
  
  See also https://phabricator.kde.org/D6253.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6265

AFFECTED FILES
  CMakeLists.txt
  src/file/CMakeLists.txt

To: adridg, dfaure
Cc: #frameworks