D6331: Make sure that the tsfiles target is generated

lueck added a comment. locale fr or uk build now, but without the script files beeing installed. Looks like ./scripts/autogen.sh needs to be adapted as well REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D6331 To: apol, #frameworks, ltoscano, lueck

D6331: Make sure that the tsfiles target is generated

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY I'm not sure how it's possible that pofiles is defined but tsfiles isn't, but this does fix the issue reported by Luigi: CMake Error at /usr/lib64/cmake/KF5I18n/KF5I18NMacros.cmake:129

D6328: add unit test for isocpp

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH ioscpp-test REVISION DETAIL https://phabricator.kde.org/D6328 AFFECTED FILES

D6197: Add basic KAuth support to file ioslave

elvisangelaccio added a comment. Looks good to me now, just minor issues. INLINE COMMENTS > file.cpp:1407-1408 > +{ > +int status = messageBox(WarningContinueCancel, warningMessage(warnId), > QStringLiteral("Warning!"), > +QStringLiteral("Continue"), >

D6197: Add basic KAuth support to file ioslave

chinmoyr updated this revision to Diff 15702. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Removed the ifdef. Moved the execWithElevatedPrivilege() method to file_unix.cpp . REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Re: Kirigami in Frameworks

On 21 June 2017 at 15:00, Marco Martin wrote: > As there were no replies for quite a while, i assume there are no > particular objections. > > so, how to proceed? what needs to be doe to do the actual move? Does it comply with the policies (as much as they are relevant for

D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor

mgallien created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY one should delete the QMediaPlayer in the owner thread to avoid crash TEST PLAN Tested with visual studio 2015 build on Windows

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kossebau added a comment. @palimaka You have KDE push rights, correct? Will you have time this week to push this, or do you want someone/me to do that for you? Would be good to have this in as soon as possible, given tagging release is <2 weeks away :) REPOSITORY R240 Extra CMake

D6313: WIP: Support device pixel ratio in icon loader and engine

kvermette added a comment. In https://phabricator.kde.org/D6313#118250, @davidedmundson wrote: > For SVG icons this is fine. > > For pixmap icons this is only part of the needed changes. > > We don't want to load the 16px image and then resize it, I think that's what this would

D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin

rjvbb set the repository for this revision to R302 KIconThemes. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6309 To: rjvbb, #frameworks Cc: tfry, kde-mac, #frameworks

D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin

rjvbb updated this revision to Diff 15694. rjvbb added a comment. In fact any kind of plugin can do this that is loaded sufficiently early, or even an initialisation procedure in an additional library you link with (but that is maybe TMI and somewhat self-evident). I don't mind propaganda

Re: Kirigami in Frameworks

As there were no replies for quite a while, i assume there are no particular objections. so, how to proceed? what needs to be doe to do the actual move? On Mon, Jun 5, 2017 at 2:42 PM, Marco Martin wrote: > Hi all, > The Kirigami component set always was targeted to be

D6313: WIP: Support device pixel ratio in icon loader and engine

cfeck added inline comments. INLINE COMMENTS > cfeck wrote in kiconloader.cpp:863 > Please use some rounding here. Scaling factors such as 1.4 cannot be > represented exactly. > > Either add some formatting specifiers, e.g. for three decimal places, or use > qRound(scale * 1000). Just

D6313: WIP: Support device pixel ratio in icon loader and engine

cfeck added inline comments. INLINE COMMENTS > kiconloader.cpp:1299 > > -if (d->findCachedPixmapWithPath(key, pix, path)) { > +if (d->findCachedPixmapWithPath(key, pix, path)) {// skip cache > if (path_store) { Is this a left-over change from disabling this check? REPOSITORY

D6313: WIP: Support device pixel ratio in icon loader and engine

cfeck added inline comments. INLINE COMMENTS > kiconloader.cpp:863 > + % QLatin1Char('@') > + % QString::number(scale) > % QLatin1Char('_') Please use some rounding here. Scaling factors such as 1.4 cannot be represented exactly. Either add some formatting

D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin

tfry added a comment. Much clearer, now, IMO. Your osx-integration plugin is what I was thinking of, when writing about "patched libs". See, that's how confused I am, I just can't seem to remember any of this... How about adding that detail, too, e.g.: ... provided that the

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsQt5.7 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsQt5.7/22/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsQt5.7 Date of build: Wed, 21 Jun 2017 13:44:23 + Build duration: 3 min 7 sec and

D6313: WIP: Support device pixel ratio in icon loader and engine

davidedmundson added a comment. For SVG icons this is fine. For pixmap icons this is only part of the needed changes. We don't want to load the 16px image and then resize it, I think that's what this would do? That would be an unacceptable regression. We would need a folder

D6220: CMake: Fix CMP0058 warning when using Ninja

kfunk added reviewers: vkrause, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6220 To: kfunk, vkrause, dhaumann Cc: #frameworks

D6313: WIP: Support device pixel ratio in icon loader and engine

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Since Qt 5.9 there's a ScaledPixmapHook in QIconEngine which is called when device pixel ratio is > 1 and it wants a

D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin

rjvbb set the repository for this revision to R302 KIconThemes. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6309 To: rjvbb, #frameworks Cc: tfry, kde-mac, #frameworks

D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin

rjvbb updated this revision to Diff 15688. rjvbb added a comment. To be honest I didn't even think of patched libs, certainly not Qt itself. What I *can* think of is a platform theme plugin like the one from plasma-integration, which can serve a comparable purpose (including making the the

D6215: Make sure size is final after showEvent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eab4aa9909a6: Make sure size is final after showEvent (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6215?vs=15579=15682

D6215: Make sure size is final after showEvent

mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks,

D6215: Make sure size is final after showEvent

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks,

D6215: Make sure size is final after showEvent

mart added a comment. so, on the 5 points: 1. yes, is necessary, resizing windows in their show event is definitely not enough, causes events to arrive to reset to the old geometry in race with the setgeometry done there, if it's the qpa, if it's qwindow, if it's the windowmanager

D6277: Emit errors when keditbookmarks is missing

valeriymalov updated this revision to Diff 15681. valeriymalov added a comment. Toned down error from critical to warning, removed const cast REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6277?vs=15608=15681 REVISION DETAIL

D6277: Emit errors when keditbookmarks is missing

valeriymalov marked 2 inline comments as done. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D6277 To: valeriymalov, #frameworks Cc: aacid, ltoscano

D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin

tfry added a comment. It's difficult to explain a confusing situation, clearly, but I don't think you succeeded. AFAIU, there are //three// distinct approaches: a) embedded icons b) QIcon::setThemeSearchPaths() c) patched libs From the current wording I'm not sure, whether you do

D6215: Make sure size is final after showEvent

davidedmundson added a comment. > no, it just means that who calls show() or the wrong setVisible() would just get the previous behavior of mainItem being shown only at showevent, Ok, great It's somewhat confusing as you have multiple completely independent attempts to

D6215: Make sure size is final after showEvent

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6309: KIconThemes: some additional details about themes & icons on Mac & MSWin

rjvbb created this revision. rjvbb added a project: Frameworks. REVISION SUMMARY This clarifies a few details about icons and icon themes on Mac and MS Windows, calling attention to the fact that icon themes can be available as usual and that embedded icon resources are thus not the only way