D7296: Restore behaviour of KKeyServer::symXToKeyQt

This revision was automatically updated to reflect the committed changes. Closed by commit R278:53ab31c663e6: Restore behaviour of KKeyServer::symXToKeyQt (authored by dfaure). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7296?vs=18109=18159 REVISION

D7296: Restore behaviour of KKeyServer::symXToKeyQt

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D7296 To: dfaure, graesslin Cc: #frameworks

D7292: Deprecate KStandardAction::Help

elvisangelaccio updated this revision to Diff 18154. elvisangelaccio added a comment. - @deprecated since... REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7292?vs=18093=18154 BRANCH deprecate-help REVISION DETAIL

D6972: Add CC BY-SA 4.0 International and set it as default

ltoscano added a comment. Ping! REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D6972 To: ltoscano, jriddell, lueck, yurchor Cc: jriddell, lueck, #frameworks, #documentation, skadinna

D7293: Deprecate KStandardAction::SaveOptions

elvisangelaccio updated this revision to Diff 18155. elvisangelaccio added a comment. - @deprecated since... REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7293?vs=18094=18155 BRANCH deprecate-saveoptions REVISION DETAIL

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

kossebau closed this revision. kossebau added a comment. Hm, I tried to close this one by adding a line Differential Revision: https://phabricator.kde.org/D7281 in the commit, but seems that was not picked up, so closing manually See eb5f8570f4aa3f6391ef0c040f55b1331e36e0c7 REPOSITORY

D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

This revision was automatically updated to reflect the committed changes. Closed by commit R236:359c0d18fecb: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

kossebau accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7281 To: mpyne, #frameworks, kossebau Cc: kossebau

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/44/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 15 Aug 2017 01:29:45 + Build duration: 3 min 27 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/40/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 15 Aug 2017 01:29:45 + Build duration: 3 min 3 sec and counting JUnit

D7316: Avoid sending data offers from an invalid source.

davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY A DataDevice will have a source when offers are available, but it can also be legitimately cleared.

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/56/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 15 Aug 2017 03:04:54 + Build duration: 22 min and counting JUnit Tests

D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Nested classes inherit the visibility of their outer class, so all the KClass::Private symbols have

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart added a comment. ping? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

davidedmundson added a comment. > of course we do that :-) We're not. Kwin does not check if a client has a selection. It merely checks if the client has an interface from a selection can be fetched, it does not check that device actually has a valid selection. > you think

D6964: Force Plasma style for QQC2 in applets

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6964 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Tests leaving behind large temporary files

Hi all, Since the deployment of the new CI system we've been noticing that disk usage on the FreeBSD and Windows builders is adversely impacted upon by tests leaving significantly large files in the temporary file directories. Just today two of the FreeBSD Builders were knocked out by these

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/41/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 09:04:03 + Build duration: 40 sec and counting JUnit Tests

D6899: support X-KDE-OnlyShowOnQtPlatforms

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma, davidedmundson Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff,

D6899: support X-KDE-OnlyShowOnQtPlatforms

This revision was automatically updated to reflect the committed changes. Closed by commit R297:937ade5d7357: support X-KDE-OnlyShowOnQtPlatforms (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6899?vs=17177=18132#toc REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE

D7297: Add Pony highlighting

dhaumann added a comment. Looks already quite good. But I think one more iteration to especially fix the licensing would be nice. INLINE COMMENTS > foldingtest.pony:2 > +/* > +Copyright (C) 2016 Volker Krause > + Is this file intentionally added? > highlight.pony:1 >

D7289: Rewrite the email syntax definition

dhaumann added a comment. Ah, one more thing: we probably can add spellChecking="false" for some item datas... REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7289 To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann Cc:

D7253: Add build-flatpak target if there is a flatpak recipe around

cgiboudeaux added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:361 > +function(_find_json_recipe json_recipe) > +execute_process(COMMAND git ls-files *org.kde.*.json > +OUTPUT_VARIABLE json find_package(Git) if(Git_FOUND) execute_process(COMMAND GIT_EXECUTABLE...

D5799: Rebase Less syntax highlighting on SCSS one

jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. Hello, To be able to compile with the current frameworks, I have had to remove the leading/trailing spaces:

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/55/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 11:31:33 + Build duration: 14 min and counting JUnit Tests

D7289: Rewrite the email syntax definition

vkrause added a comment. Correct, any highlighting of the body content is gone, intentionally. The original highlighting was from a time when emails had 4-5 human readable headers and ASCII bodys. At that time body highlighting made sense, and even reading emails in kate was feasible.

D7289: Rewrite the email syntax definition

dhaumann added a comment. OK, sounds sane. Please commit, no need for another review round. Thanks! REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7289 To: vkrause, #framework_syntax_hightlighting, kwrite-devel, dhaumann Cc: dhaumann,

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.7 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/22/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 13:06:57 + Build duration: 2 min 5 sec and counting JUnit Tests

KDE CI: Frameworks kxmlgui kf5-qt5 XenialQt5.7 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20XenialQt5.7/32/ Project: Frameworks kxmlgui kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 12:39:40 + Build duration: 4 min 2 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 11:02:53 + Build duration: 5 min 33 sec and counting JUnit

D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

dhaumann added a comment. As a side note: Leaking the visibility of nested classes is almost something that could be mentioned in [1]. Then again, this is only a BC issue, if these nested classes are used/accessible in public API. [1]

Re: Tests leaving behind large temporary files

Hello Ben, On Mon, Aug 14, 2017 at 10:59:49PM +1200, Ben Cooksley wrote: > Could someone please investigate, determine which test(s) are > responsible and fix those tests to cleanup after themselves? > I did some investigation on those left-out files, and it seems it's not the code of

KDE CI: Frameworks kimageformats kf5-qt5 XenialQt5.7 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20XenialQt5.7/9/ Project: Frameworks kimageformats kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 13:15:45 + Build duration: 1 min 12 sec and counting JUnit

Re: KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!

On lundi 14 août 2017 15:58:54 CEST David Rosca wrote: > Hi, > I just fixed it yesterday and now it fails again. > What did change this time, please? That would be my changes, then. I'm working on making tests run without the need to "make install" first. I'll debug the failure, thanks for the

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/17/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 14:34:57 + Build duration: 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks kpeople kf5-qt5 XenialQt5.7 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20XenialQt5.7/18/ Project: Frameworks kpeople kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 14:45:46 + Build duration: 1 min 49 sec and counting JUnit Tests

KDE CI: Frameworks kconfigwidgets kf5-qt5 XenialQt5.7 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20XenialQt5.7/22/ Project: Frameworks kconfigwidgets kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 14:46:31 + Build duration: 1 min 16 sec and counting JUnit

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin added a comment. > If your patch works, then mine would too. It's checking the exact same pointer, just one frame earlier. But then it's an easy thing: let's do both. Your patch and mine. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To:

KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 13:49:21 + Build duration: 3 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 XenialQt5.7 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20XenialQt5.7/27/ Project: Frameworks kconfig kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 13:57:14 + Build duration: 6 min 8 sec and counting JUnit Tests

KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/20/ Project: Frameworks bluez-qt kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 13:49:21 + Build duration: 5 min 32 sec and counting JUnit Tests

Re: KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 20 - Unstable!

Hi, I just fixed it yesterday and now it fails again. What did change this time, please? Thanks, David On Mon, Aug 14, 2017 at 3:54 PM, wrote: > *BUILD UNSTABLE* > Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5- > qt5%20XenialQt5.7/20/ > Project: Frameworks

KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/21/ Project: Frameworks bluez-qt kf5-qt5 XenialQt5.7 Date of build: Mon, 14 Aug 2017 14:25:02 + Build duration: 2 min 12 sec and counting JUnit Tests

KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/22/ Project: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 14:25:02 + Build duration: 1 min 50 sec and counting JUnit Tests

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/20/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 14:54:46 + Build duration: 40 sec and counting JUnit Tests Name:

D7289: Rewrite the email syntax definition

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b54210c3e238: Rewrite the email syntax definition (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7289?vs=18106=18150#toc REPOSITORY R216 Syntax Highlighting CHANGES

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/42/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 14 Aug 2017 16:57:26 + Build duration: 41 sec and counting JUnit Tests

D7253: Add build-flatpak target if there is a flatpak recipe around

elvisangelaccio abandoned this revision. elvisangelaccio added a comment. In https://phabricator.kde.org/D7253#135251, @apol wrote: > Ugh my bad ^^', I don't know what happened. > > > The reason why I'm discussing this is that I think one of the advantages of Flatpak > > is that

D7292: Deprecate KStandardAction::Help

elvisangelaccio added a comment. In https://phabricator.kde.org/D7292#135318, @dhaumann wrote: > Not sure, but is that reason enough to deprecate API? This doesn't sound convincing yet... Well, I can think of other reasons: - you wouldn't add a new enum value unless there is

D7287: Improve KStandardAction apidox.

elvisangelaccio updated this revision to Diff 18146. elvisangelaccio added a comment. - Improve GoTo doc. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7287?vs=18098=18146 BRANCH improve-apidox REVISION DETAIL

D7287: Improve KStandardAction apidox.

elvisangelaccio requested review of this revision. elvisangelaccio marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D7287 To: elvisangelaccio, #frameworks, dhaumann Cc: dhaumann