concise instructions how to use sub...@bugs.kde.org?

[René J . V . Bertin]

Hi,

I'm looking for some concise instructions how to submit reports to BKO via the 
bug reporting address (something more straightforward than retro-engineering 
DrKonqi ;)).

I've come across something (www.plcrashreporter.org) that could replace DrKonqi 
on Mac, and which might eventually be implemented instead of the code in 
whatever framework invokes DrKonqi.

Thank,
René

D7130: KMoreTools: Update and fix desktopfiles

[gregormi]

gregormi updated this revision to Diff 20781.
gregormi added a comment.


  Rebase, run _update_all_files.sh and fix outdated desktop files

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7130?vs=17723=20781

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

AFFECTED FILES
  autotests/kmoretools/kmoretoolstest.cpp
  autotests/kmoretools/kmoretoolstest2.cpp
  data/kmoretools-desktopfiles/_INFO
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/angrysearch.desktop
  data/kmoretools-desktopfiles/catfish.desktop
  data/kmoretools-desktopfiles/com.uploadedlobster.peek.desktop
  data/kmoretools-desktopfiles/ding.desktop
  data/kmoretools-desktopfiles/disk.desktop
  data/kmoretools-desktopfiles/filelight.png
  data/kmoretools-desktopfiles/filelight.svg
  data/kmoretools-desktopfiles/fontinst.desktop
  data/kmoretools-desktopfiles/fontmatrix.desktop
  data/kmoretools-desktopfiles/fsearch.desktop
  data/kmoretools-desktopfiles/giggle.desktop
  data/kmoretools-desktopfiles/git-cola-folder-handler.desktop
  data/kmoretools-desktopfiles/git-cola.desktop
  data/kmoretools-desktopfiles/gitg.desktop
  data/kmoretools-desktopfiles/gnome-search-tool.desktop
  data/kmoretools-desktopfiles/gparted.desktop
  data/kmoretools-desktopfiles/gucharmap.desktop
  data/kmoretools-desktopfiles/htop.desktop
  data/kmoretools-desktopfiles/kdf.desktop
  data/kmoretools-desktopfiles/kding.desktop
  data/kmoretools-desktopfiles/ksystemlog.desktop
  data/kmoretools-desktopfiles/org.gnome.clocks.desktop
  data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop
  data/kmoretools-desktopfiles/org.kde.filelight.desktop
  data/kmoretools-desktopfiles/org.kde.kcharselect.desktop
  data/kmoretools-desktopfiles/org.kde.kdf.desktop
  data/kmoretools-desktopfiles/org.kde.kfind.desktop
  data/kmoretools-desktopfiles/org.kde.kmousetool.desktop
  data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop
  data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop
  data/kmoretools-desktopfiles/org.kde.ksysguard.desktop
  data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop
  data/kmoretools-desktopfiles/org.kde.ktimer.desktop
  data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop
  data/kmoretools-desktopfiles/org.kde.spectacle.desktop
  data/kmoretools-desktopfiles/shutter.desktop
  data/kmoretools-desktopfiles/shutter.svg
  data/kmoretools-desktopfiles/simplescreenrecorder.desktop
  data/kmoretools-desktopfiles/xfce4-taskmanager.desktop
  src/kmoretools/kmoretoolspresets.cpp
  src/kmoretools/kmoretoolspresets.h
  tests/kmoretools/kmoretoolstest_interactive.cpp

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

Re: concise instructions how to use sub...@bugs.kde.org?

[Kevin Funk]

On Sunday, 15 October 2017 12:07:57 CEST René J.V. Bertin wrote:
> Hi,
> 
> I'm looking for some concise instructions how to submit reports to BKO via
> the bug reporting address (something more straightforward than
> retro-engineering DrKonqi ;)).
> 
> I've come across something (www.plcrashreporter.org) that could replace
> DrKonqi on Mac, and which might eventually be implemented instead of the
> code in whatever framework invokes DrKonqi.

Why don't you finish / bump people on
  https://phabricator.kde.org/D4929

... which  would be the more straight-forward and sustainable variant? I 
thought this is working in general?

Why do we need diverge again (i.e. introducing a tool where no-one is familiar 
with) instead of completing existing work?

Thanks,
Kevin

> Thank,
> René


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.

Re: Adding build info attribute to KAboutData to improve bug report data?

[Kevin Funk]

On Sunday, 8 October 2017 19:45:00 CEST Kevin Funk wrote:
> Heya,
> 
> The KDevelop team is currently discussing a patch which adds git-describe
> like information to the version string in KAboutData:
>   https://phabricator.kde.org/D8158
>   (don't bother reading through the comments...)
> 
> Problem:
> 
> When KAboutData's version is set to something like "5.1.80-24-g262fb4cb9f"
> and when attempting to report a bug via KDevelop -> Help -> Report Bug,
> bugs.kde.org will no longer pre-select the correct version in the version
> list. Even worse: The version information is lost completely if the user
> does not copy it from the dialog.
> 
> Idea:
> Let's add a 'build info' attribute to KAboutData which may contain custom
> data filled by a project to provide more information about a specific
> build.
> 
> Then, for instance in KDevelop's main.cpp:
> ```
> KAboutData data(...);
> data.setBuildInfo("Version: " KDEVELOP_FULL_VERSION_STRING);
> ```
> ... with KDEVELOP_FULL_VERSION_STRING being "5.1.80-24-g262fb4cb9f"

@KCoreAddons maintainers: Do you think that makes sense? In that case I'd 
create a patch which adds such API to KAboutData.

Regards,
Kevin

> And then during the bug report process, just amend the url used to direct
> the user to bugs.kde.org:
>   https://bugs.kde.org/enter_bug.cgi?
> format=guided=kdevelop=5.1.80=Build%20information:
> %0AVersion:%205.1.80-24-g262fb4cb9f
> 
> Would require changes in kcoreaddons (KAboutData) and kxmlgui (KBugReport)
> afaics.
> 
> Comments? There are a couple of other KDE projects (thinking of krita, kexi
> -- which also use Git info) which could benefit from this.
> 
> This is also extensible, one could add more content to the build info
> attribute which would be sent over to bugs.kde.org.
> 
> Regards,
> Kevin


-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @kossebau 
  After this change we get the
  
Tried to unregister a kio job that hasn't been registered.
  
  warning with a `KCompositeJob` in Ark (batchextract.cpp).
  
  The job is now automatically unregistered and the `unregisterJob(this)` call 
in the job destructor is causing this warning.
  Are KCompositeJobs still supposed to unregister themselves?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D3977

To: kossebau, #frameworks, kfunk
Cc: elvisangelaccio, kfunk

D8304: Don't position a Dialog if it's of type OSD

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The OSDs are positioned by the Wayland compositor. This fixed the issue
  found in https://phabricator.kde.org/D8268.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dialog-no-position-osd

REVISION DETAIL
  https://phabricator.kde.org/D8304

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: graesslin, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 125 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/125/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Sun, 15 Oct 2017 08:46:48 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)67%
(6/9)67%
(6/9)64%
(409/640)43%
(169/393)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc80%
(4/5)80%
(4/5)54%
(173/320)34%
(90/263)src.libkirigami50%
(2/4)50%
(2/4)74%
(236/320)61%
(79/130)

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 119 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/119/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 08:46:48 +
 Build duration:
1 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D8050: Expose wl_display_set_global_filter as a virtual method

[Martin Flöser]

graesslin added a comment.


  @davidedmundson The CI image is updated, you can push this now.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  +1 for having this property
  -1 for the current rather verbose date format. Look at the "Modified" column 
in the any dolphin details view. It (on my setup) just shows a date and a HH:MM 
timestamp. That would be enough information, right?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D8303

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, 
ngraham, andrebarros, emmanuelp

D8296: Use Ctrl+, as the standard shortcut for "Configure "

[Jonathan Marten]

marten added a comment.


  FYI: KMail uses Ctrl+comma and Ctrl+dot as standard shortcuts for "Collapse 
all threads" and "Expand all threads" respectively.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: marten, graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

[Kevin Funk]

kfunk added a comment.


  In KDevelop, this is also a really important shortcut for navigating through 
the source. `Ctrl+,` for jumping to definition, `Ctrl+.` for jumping to 
declaration. /me wonders if one really needs a shortcut for configuring 
shortcuts at all.
  
  
https://lxr.kde.org/search?_filestring=&_string=Qt%3A%3ACTRL.*Qt%3A%3AKey_Comma 
lists the usages (=> Digikam, KDevelop, KMail)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: kfunk, marten, graesslin, broulik, #frameworks

D8304: Don't position a Dialog if it's of type OSD

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dialog-no-position-osd

REVISION DETAIL
  https://phabricator.kde.org/D8304

To: graesslin, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I guess +1 from me. Infopanel and tooltips are disabled by default anyway, so 
it's not a big deal if we also show the mtime there.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D8303

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid
Cc: elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, ngraham, 
andrebarros, emmanuelp

Re: Persistent data with KDED (or KIOD) and a KIO Slave?

[Mark Gaiser]

On Sat, Oct 14, 2017 at 8:27 AM, David Faure  wrote:

> On dimanche 8 octobre 2017 15:22:00 CEST Mark Gaiser wrote:
> > But then i still miss one rather important detail that i can't really
> find
> > anywhere..
> > Lets say I have that module and call it "tags2" (as Baloo already has
> tags,
> > therefore tags2 to prevent naming issues).
> >
> > So i make a dbus service file named:
> >   Name=org.kde.tags2
> >
> > And in the "tags2.json" i put:
> >
> > {
> > "KPlugin": {
> > "Description": "Put tags on files and folders.",
> > "Name": "Tags 2",
> > "ServiceTypes": [
> > "KDEDModule"
> > ]
> > },
> >
> > "X-KDE-DBus-ModuleName": "tags2",
> > "X-KDE-DBus-ServiceName": "org.kde.tags2"
> > }
> >
> > What do i do in the client side code to start this module?
>
> You just make a DBus call to the service org.kde.tags, with
> object path /modules/tags2. That will start kiod if needed,
> load the module, and make the call.
>
> The best solution for this is with type safety rather than without,
> i.e. generating C++ from the DBus xml file. See e.g.
> kio/core/kpasswdserverclient.cpp which makes calls to the kiod
> kpasswdserver
> module using the generated OrgKdeKPasswdServerInterface class.
> qt5_add_dbus_interface() is the cmake function for doing that.
>
> > That "client side" can be an IO slave, but it can also be some special
> Tags
> > helper classes to create a new tag name with description and icon or
> such.
>
> Sure, anyone can make dbus calls.
>
> > I need to call something to trigger KIOD to start this module, but i
> can't
> > figure out what.
> >
> > How do i see qCDebug output from kiod plugins anyhow?
>
> In ~/.xsession-errors, or by killing kiod and restarting it in a terminal.
>
>
Hi David,

Thank you for the detailed reply, this really helps and is information that
is quite difficult to find ;)

Re: concise instructions how to use sub...@bugs.kde.org?

[Martin Steigerwald]

Hi René,

René J.V. Bertin - 15.10.17, 12:07:
> I'm looking for some concise instructions how to submit reports to BKO via
> the bug reporting address (something more straightforward than
> retro-engineering DrKonqi ;)).
> 
> I've come across something (www.plcrashreporter.org) that could replace
> DrKonqi on Mac, and which might eventually be implemented instead of the
> code in whatever framework invokes DrKonqi.

I´d say: Just use reportbug Debian package and command… but why on Earth do 
you ask this on the KDE Frameworks development mailing list?

I also suggest to subscribe to the debian-kde mailing list in case you use KDE 
software on Debian … I and others usually announce transitions and help with 
user issues.

Thanks,
-- 
Martin

Re: concise instructions how to use sub...@bugs.kde.org?

[Luigi Toscano]

René J.V. Bertin ha scritto:
> Hi,
> 
> I'm looking for some concise instructions how to submit reports to BKO via 
> the bug reporting address (something more straightforward than 
> retro-engineering DrKonqi ;)).


Bugzilla instances exposes an API; I think that we have the REST API enabled
already.



> 
> I've come across something (www.plcrashreporter.org) that could replace 
> DrKonqi on Mac, and which might eventually be implemented instead of the code 
> in whatever framework invokes DrKonqi.

Or extend DrKonqi to use it, or help fixing DrKonqi (it is not clear what is
the problem here).

-- 
Luigi

Re: concise instructions how to use sub...@bugs.kde.org?

[Luigi Toscano]

Martin Steigerwald ha scritto:
> Hi René,
> 
> René J.V. Bertin - 15.10.17, 12:07:
>> I'm looking for some concise instructions how to submit reports to BKO via
>> the bug reporting address (something more straightforward than
>> retro-engineering DrKonqi ;)).
>>
>> I've come across something (www.plcrashreporter.org) that could replace
>> DrKonqi on Mac, and which might eventually be implemented instead of the
>> code in whatever framework invokes DrKonqi.
> 
> I´d say: Just use reportbug Debian package and command… but why on Earth do 
> you ask this on the KDE Frameworks development mailing list?
> 
> I also suggest to subscribe to the debian-kde mailing list in case you use 
> KDE 
> software on Debian … I and others usually announce transitions and help with 
> user issues.

This email is not about the Debian bugtracker.

-- 
Luigi

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/49/
 Project:
Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 15 Oct 2017 17:17:30 +
 Build duration:
1 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 186.68 KB...]/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7/src/kcharselectdata.cpp:155:36: warning: comparison is always true due to limited range of data type [-Wtype-limits] if (code >= 0xF000 && code <= 0x) {^[ 24%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[ 24%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[ 24%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7/src/kfontaction.cpp:147:2: warning: #warning is a GCC extension #warning FIXME: items need to be converted  ^/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7/src/kfontaction.cpp:147:2: warning: #warning FIXME: items need to be converted [-Wcpp][ 26%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[ 27%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[ 27%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[ 27%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.o[ 29%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.o[ 29%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kled.cpp.o[ 29%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.o[ 32%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpassworddialog.cpp.o[ 32%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kruler.cpp.o/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7/src/kruler.cpp:158:2: warning: #warning is a GCC extension #warning FIXME setFrameStyle(WinPanel | Raised);  ^/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7/src/kruler.cpp:158:2: warning: #warning FIXME setFrameStyle(WinPanel | Raised); [-Wcpp][ 33%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselector.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kxyselector.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kseparator.cpp.o[ 34%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ksqueezedtextlabel.cpp.o[ 34%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktitlewidget.cpp.o[ 34%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoggleaction.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktogglefullscreenaction.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstateserializer.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstatemaintainerbase.cpp.o[ 36%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/keditlistwidget.cpp.o[ 36%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcursor.cpp.o[ 36%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingwidget.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingpainter.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kactionselector.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorcombo.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoolbarspaceraction.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpixmapregionselectordialog.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpixmapregionselectorwidget.cpp.o[ 39%] Building CXX object 

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 49 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/49/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 17:17:30 +
 Build duration:
2 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 98.98 KB...][ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpassworddialog.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kruler.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselector.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kxyselector.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kseparator.cpp.o/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kruler.cpp:158:2: warning: #warning is a language extension [-Wpedantic]#warning FIXME setFrameStyle(WinPanel | Raised); ^/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kruler.cpp:158:2: warning: FIXME setFrameStyle(WinPanel | Raised); [-W#warnings][ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ksqueezedtextlabel.cpp.o2 warnings generated.[ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoggleaction.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktitlewidget.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktogglefullscreenaction.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstateserializer.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstatemaintainerbase.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/keditlistwidget.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcursor.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingwidget.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingpainter.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kactionselector.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorcombo.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kratingwidget.cpp:267:/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/build/src/KF5WidgetsAddons_autogen/include/moc_kratingwidget.cpp:147:21: warning: 'setRating' is deprecated [-Wdeprecated-declarations]case 3: _t->setRating((*reinterpret_cast< uint(*)>(_a[1]))); break;^/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kratingwidget.cpp:138:21: note: 'setRating' has been explicitly marked deprecated herevoid KRatingWidget::setRating(unsigned int rating)^In file included from /usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kratingwidget.cpp:267:/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/build/src/KF5WidgetsAddons_autogen/include/moc_kratingwidget.cpp:149:21: warning: 'setMaxRating' is deprecated [-Wdeprecated-declarations]case 5: _t->setMaxRating((*reinterpret_cast< uint(*)>(_a[1]))); break;^/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kratingwidget.cpp:156:21: note: 'setMaxRating' has been explicitly marked deprecated herevoid KRatingWidget::setMaxRating(unsigned int max)^In file included from /usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kratingwidget.cpp:267:/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/build/src/KF5WidgetsAddons_autogen/include/moc_kratingwidget.cpp:151:21: warning: 'setOnlyPaintFullSteps' is deprecated [-Wdeprecated-declarations]case 7: _t->setOnlyPaintFullSteps((*reinterpret_cast< bool(*)>(_a[1]))); break;^/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kratingwidget.cpp:175:21: note: 'setOnlyPaintFullSteps' has been explicitly marked deprecated herevoid KRatingWidget::setOnlyPaintFullSteps(bool fs)^In file included from /usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/src/kratingwidget.cpp:267:/usr/home/jenkins/workspace/Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7/build/src/KF5WidgetsAddons_autogen/include/moc_kratingwidget.cpp:157:22: warning: 'setPixmap' is deprecated [-Wdeprecated-declarations]case 13: _t->setPixmap((*reinterpret_cast< const QPixmap(*)>(_a[1]))); break;  

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/128/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 14:37:39 +
 Build duration:
4 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/26/
 Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 18:33:39 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kptyprocesstest

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Nathaniel Graham]

ngraham added a comment.


  Honestly I think it's fine the way it is: in the details view, we have a nice 
compact string that doesn't make the column too wide, and in the Information 
Panel, we have a longer string that provides more information and isn't too big 
since text can wrap there.
  
  I do see your point though, and I agree that the long string should be 
customizable in some way for people who prefer a shorter string. But that seems 
out of scope for this change; can we stick to this change here, and discuss 
that other change (which I do approve of:) ) in another patch or bug report?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D8303

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, 
ngraham, andrebarros, emmanuelp

D8304: Don't position a Dialog if it's of type OSD

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ecd00a565a99: Dont position a Dialog if its 
of type OSD (authored by graesslin).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8304?vs=20769=20794

REVISION DETAIL
  https://phabricator.kde.org/D8304

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: graesslin, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Frameworks kimageformats kf5-qt5 XenialQt5.7 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20XenialQt5.7/11/
 Project:
Frameworks kimageformats kf5-qt5 XenialQt5.7
 Date of build:
Sun, 15 Oct 2017 18:28:21 +
 Build duration:
2 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 10 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-picFailed: TestSuite.kimageformats-read-pcxFailed: TestSuite.kimageformats-read-psdFailed: TestSuite.kimageformats-read-rasFailed: TestSuite.kimageformats-read-rgbFailed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-read-xcfFailed: TestSuite.kimageformats-write-pcxFailed: TestSuite.kimageformats-write-rgbFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(1/2)75%
(3/4)75%
(3/4)62%
(254/413)38%
(92/242)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)63%
(254/401)39%
(92/234)tests0%
(0/1)0%
(0/1)0%
(0/12)0%
(0/8)

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  @markg I actually like the current verbose format. That's somewhat unrelated 
to this; can we track that change, if any, with a new patch?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D8303

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, 
ngraham, andrebarros, emmanuelp

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 20 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.9/20/
 Project:
Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 15 Oct 2017 17:17:30 +
 Build duration:
2 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 120.80 KB...]kled.cpp[  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.objkmessagebox.cpp[ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.objkmessagebox_p.cpp[ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.objkmultitabbar.cpp[ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.objkstandardguiitem.cpp[ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.objkurllabel.cpp[ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.objkcapacitybar.cpp[ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.objkfontrequester.cpp[ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kruler.cpp.objkruler.cpp[ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselector.cpp.objkselector.cpp[ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kxyselector.cpp.objkxyselector.cpp[ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kseparator.cpp.obj[ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ksqueezedtextlabel.cpp.objkseparator.cppksqueezedtextlabel.cpp[ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktitlewidget.cpp.objktitlewidget.cpp[ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoggleaction.cpp.objktoggleaction.cpp[ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktogglefullscreenaction.cpp.obj[ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstateserializer.cpp.objktogglefullscreenaction.cppkviewstateserializer.cpp[ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstatemaintainerbase.cpp.objkviewstatemaintainerbase.cpp[ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/keditlistwidget.cpp.objkeditlistwidget.cpp[ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcursor.cpp.obj[ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingwidget.cpp.objkcursor.cppkratingwidget.cpp[ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingpainter.cpp.objkratingpainter.cpp[ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kactionselector.cpp.objkactionselector.cpp[ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorcombo.cpp.objkcolorcombo.cpp[ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoolbarspaceraction.cpp.objktoolbarspaceraction.cpp[ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpixmapregionselectordialog.cpp.objkpixmapregionselectordialog.cpp[ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpixmapregionselectorwidget.cpp.objkpixmapregionselectorwidget.cpp[ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kactionmenu.cpp.objkactionmenu.cpp[ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoolbarlabelaction.cpp.objktoolbarlabelaction.cpp[ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoolbarpopupaction.cpp.objktoolbarpopupaction.cpp[ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpagedialog.cpp.objkpagedialog.cpp[ 19%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpagemodel.cpp.objkpagemodel.cpp[ 19%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpageview.cpp.objkpageview.cpp[ 19%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpageview_p.cpp.objkpageview_p.cpp[ 20%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpagewidget.cpp.objkpagewidget.cpp[ 20%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpagewidgetmodel.cpp.objkpagewidgetmodel.cpp[ 20%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kassistantdialog.cpp.objkassistantdialog.cpp[ 21%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagewidget.cpp.objkmessagewidget.cpp[ 21%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/lineediturldropeventfilter.cpp.objlineediturldropeventfilter.cpp[ 22%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpasswordlineedit.cpp.objC:\CI\workspace\Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9\src\kpageview_p.cpp(136): error C2027: use of undefined type 'QScrollBar'C:\CM\MSVCQt5.9\include\qt5\QtWidgets/qabstractscrollarea.h(52): note: see declaration of 'QScrollBar'C:\CI\workspace\Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9\src\kpageview_p.cpp(136): error C2227: left of '->sizeHint' must point to class/struct/union/generic typeC:\CI\workspace\Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9\src\kpageview_p.cpp(136): error C2228: left of '.width' must have class/struct/unionkpasswordlineedit.cpp[ 

D8314: Fix deprecation warning

[Kevin Funk]

kfunk created this revision.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Warning:
  
/home/kfunk/devel/src/kf5/ktexteditor/src/dialogs/katedialogs.cpp:1455:11:
warning: 'runUrl' is deprecated [-Wdeprecated-declarations]
KRun::runUrl(url, QStringLiteral("text/x-patch"), nullptr, true);
  ^
/home/kfunk/devel/install/kf5/include/KF5/KIOWidgets/krun.h:302:17:
note: 'runUrl' has been explicitly marked deprecated here
static bool KIOWIDGETS_DEPRECATED runUrl(const QUrl , const QString 
, QWidget *window,
^

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8314

AFFECTED FILES
  src/dialogs/katedialogs.cpp

To: kfunk
Cc: #frameworks, kevinapavew, cullmann, sars, dhaumann

D8315: CMake cleanup: Don't hardcode -std=c++0x

[Kevin Funk]

kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This is both set by ECM & Qt5 CMake config files

REPOSITORY
  R279 ThreadWeaver

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8315

AFFECTED FILES
  CMakeLists.txt
  benchmarks/CMakeLists.txt
  examples/CMakeLists.txt

To: kfunk
Cc: #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  In https://phabricator.kde.org/D8056#155537, @ngraham wrote:
  
  > Any progress? This is too good a change to not merge. :)
  
  
  Today I finally had the time to work on this and I've implemented the "select 
first result by default" and it seems to work nicely.
  
  I started working on how to  make up/down arrows move in the treeview while 
maintaining the focus on the text field. I thought of using an eventFilter to 
intercept those two keys and pass them to the QTreeView using the 
keyPressEvent() method. The problem is that I get an error on the fact that the 
method is protected. For now I've put the eventFilter method in the class 
KOpenWithDialog since it is the only one deriving QObject, but I'm not sure it 
is the right place.
  
  So I need to work on this a little bit more, and I'm afraid I won't have time 
next week because I am on a trip. So it needs to wait a bit more.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: ngraham, alexeymin, #frameworks

KDE CI: Frameworks kunitconversion kf5-qt5 FreeBSDQt5.7 - Build # 20 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20FreeBSDQt5.7/20/
 Project:
Frameworks kunitconversion kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 18:31:23 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

Re: Adding build info attribute to KAboutData to improve bug report data?

[Michael Pyne]

On Sun, Oct 15, 2017 at 02:31:27PM +0200, Kevin Funk wrote:
> On Sunday, 8 October 2017 19:45:00 CEST Kevin Funk wrote:
> > Heya,
> > 
> > The KDevelop team is currently discussing a patch which adds git-describe
> > like information to the version string in KAboutData:
> >   https://phabricator.kde.org/D8158
> >   (don't bother reading through the comments...)
> > 
> > *snip*
> > 
> > Then, for instance in KDevelop's main.cpp:
> > ```
> > KAboutData data(...);
> > data.setBuildInfo("Version: " KDEVELOP_FULL_VERSION_STRING);
> > ```
> > ... with KDEVELOP_FULL_VERSION_STRING being "5.1.80-24-g262fb4cb9f"
> 
> @KCoreAddons maintainers: Do you think that makes sense? In that case I'd 
> create a patch which adds such API to KAboutData.

I still think the idea makes sense.

The name might need to be different (data.setFoo instead of addFoo).
"BuildInfo" is probably too abbreviated compared to the rest of the
names we have in the class.

Is there any thought to the idea of potentially having other build data
included with this information (e.g. ABI, potential cross-compilation,
etc.)?  If so then a generic "Build Information" is fine but then we
shouldn't assume only scm versions going forward (and some of this
information may be already separately present in the Bugzilla data).

If not, then maybe a more specific name is appropriate, like
"setBugReportDetail" (since this is intended to support improved bug
reports) or "setSourceRevision" (which describes what we're actually
capturing).  Just my thoughts, happy to support it going in however
makes the mose sense.

Regards,
 - Michael Pyne

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/22/
 Project:
Frameworks kemoticons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 15 Oct 2017 18:28:46 +
 Build duration:
2 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kemoticons-kemoticontestFailed: TestSuite.kemoticons-ktexttohtmlplugintest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)83%
(10/12)83%
(10/12)36%
(226/620)26%
(122/477)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)95%
(146/153)66%
(102/154)src.core71%
(5/7)71%
(5/7)16%
(71/458)4%
(13/313)src.integrationplugin100%
(2/2)100%
(2/2)100%
(9/9)70%
(7/10)

FYI: Added .arcconfig files to all frameworks

[Kevin Funk]

Heya,

just pushed an .arcconfig file to all framework repositories. There were still 
lots of frameworks without them.

Example commit:
  https://cgit.kde.org/qqc2-desktop-style.git/commit/?
id=146e370704938e6cab6278a5e203f3ef2cf93946

Regards,
Kevin

-- 
Kevin Funk | kf...@kde.org | http://kfunk.org

signature.asc
Description: This is a digitally signed message part.

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/45/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 18:27:21 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Mark Gaiser]

markg added a comment.


  In https://phabricator.kde.org/D8303#155840, @ngraham wrote:
  
  > @markg I actually like the current verbose format. That's somewhat 
unrelated to this; can we track that change, if any, with a new patch?
  
  
  That depends on how you want to do that ;)
  
  What i'm thinking about, but that might be way too specific, is providing a 
settings field somewhere where you fill in the date time format you want to 
see. And then use that format everywhere in Dolphin. But that would be a micro 
setting that probably not everyone would agree to.
  
  Another option is getting it from the settings as both your and my preference 
is there. Just go to System Settings -> Formats and there you see "Time". There 
are two lines there, long format and short format. I think it would be 
acceptable if dolphin is a "Time format" dropdown in it's settings that picks 
either the long format or the short format. Would that work for you? The 
default probably has to stay the short format though, as the long one will 
explode the detail view width.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D8303

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, 
ngraham, andrebarros, emmanuelp

D8311: Require the same internal version as you're building

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a reviewer: KNewStuff.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Previously the KNewStuff sub-frameworks would require the dependency 
frameworks version of itself, rather than the version being built, which caused 
fun little issues.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D8311

AFFECTED FILES
  KF5NewStuffConfig.cmake.in
  KF5NewStuffQuickConfig.cmake.in

To: leinir, #knewstuff
Cc: #frameworks, ZrenBot

D7787: Set KPageListView width properly

[Łukasz Wojniłowicz]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:56c136985448: Set KPageListView width properly (authored 
by wojnilowicz).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7787?vs=19457=20807

REVISION DETAIL
  https://phabricator.kde.org/D7787

AFFECTED FILES
  src/kpageview_p.cpp

To: wojnilowicz, #frameworks
Cc: cfeck, tbaumgart, #kmymoney

D8296: Use Ctrl+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham added a comment.


  Darn, that's a shame. Looks like I was holding it wrong. I'll find another 
shortcut that doesn't conflict. Any suggestions?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: argonel, kfunk, marten, graesslin, broulik, #frameworks

D8296: Use Ctrl+, as the standard shortcut for "Configure "

[Eli MacKenzie]

argonel added a comment.


  In https://phabricator.kde.org/D8296, @ngraham wrote:
  
  > I chose Ctrl+, because that's the standard shortcut for all (and I do mean 
all) programs in the macOS world--a standard that has started to trickle into 
the Windows world as well, because there was previously no standard there. 
Might as well standardize on what's already a de facto standard elsewhere, to 
avoid throwing away people's muscle memory.
  
  
  The muscle memory for Mac users isn't preserved, as the keystroke there is 
command-, not control, and command physically corresponds to Alt. So this only 
gets us a relatively new Windows shortcut, on top of the legacy CUA system. I 
have no idea whether Windows still follows CUA or not.
  
  In https://phabricator.kde.org/D8296#155573, @kfunk wrote:
  
  > In KDevelop, this is also a really important shortcut for navigating 
through the source. `Ctrl+,` for jumping to definition, `Ctrl+.` for jumping to 
declaration. /me wonders if one really needs a shortcut for configuring 
shortcuts at all.
  
  
  As we're a CUA-derived UI, we already have a keyboard shortcut for Configure 
Shortcuts: Alt-s Alt-h. Same for Configure $app: Alt-s Alt-c
  
  While I do find switching back and forth between Mac and CUA intermittently 
frustrating, we really can't easily implement the same suite of keystrokes as 
Mac because of the Alt combinations being reserved for menus.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: argonel, kfunk, marten, graesslin, broulik, #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 124 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/124/
 Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
 Date of build:
Sun, 15 Oct 2017 14:37:39 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)62%
(57/92)62%
(57/92)38%
(3493/9222)26%
(1860/7156)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(22/22)100%
(22/22)76%
(607/795)38%
(390/1028)src.declarativeimports.core57%
(4/7)57%
(4/7)28%
(246/883)14%
(86/620)src.plasma62%
(13/21)62%
(13/21)40%
(1412/3573)29%
(773/2697)src.plasma.private46%
(11/24)46%
(11/24)39%
(649/1649)28%
(303/1080)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/190)0%
(0/126)src.plasmaquick50%
(6/12)50%
(6/12)27%
(548/2019)19%
(302/1583)src.plasmaquick.private33%
(1/3)33%
(1/3)27%
(31/113)27%
(6/22)

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In https://phabricator.kde.org/D3977#155721, @elvisangelaccio wrote:
  
  > @kossebau 
  >  After this change we get the
  >
  >  Tried to unregister a kio job that hasn't been registered.
  >   
  >   warning with a `KCompositeJob` in Ark (batchextract.cpp).
  >   
  >
  > The job is now automatically unregistered and the `unregisterJob(this)` 
call in the job destructor is causing this warning.
  >  Are KCompositeJobs still supposed to unregister themselves?
  
  
  KJob related knowledge sadly completely swapped out of my brain, would need 
to investigate myself. No idea if there should be done anything special for 
KCompositeJobs.
  
  On a quick look the automatic unregistering based on the finished signal 
seems to make sense for any KJob subclass. Perhaps the change in this commit 
conflicts with some older code in Ark to work around the old behaviour and 
which does some additional manual unregistration? Or perhaps some slot in 
accidentally invoked 2x so the unregistration happens more than once, with the 
second try than failing? Wild guesses is all I have to offer, sorry. I cannot 
remember anything questionable about this patch, so no pointers into it, 
instead my initial reaction would be to look at the consumer side.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D3977

To: kossebau, #frameworks, kfunk
Cc: elvisangelaccio, kfunk

KDE CI: Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20AndroidQt5.9/2/
 Project:
Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9
 Date of build:
Sun, 15 Oct 2017 17:17:30 +
 Build duration:
4 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 178.93 KB...][ 25%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[ 25%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kfontaction.cpp:147:2: warning: #warning is a GCC extension #warning FIXME: items need to be converted  ^/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kfontaction.cpp:147:2: warning: #warning FIXME: items need to be converted [-Wcpp][ 26%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[ 27%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[ 27%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[ 27%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.o[ 29%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.o[ 29%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kled.cpp.o[ 29%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.o[ 31%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.o[ 32%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpassworddialog.cpp.o[ 32%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kruler.cpp.o/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kruler.cpp:158:2: warning: #warning is a GCC extension #warning FIXME setFrameStyle(WinPanel | Raised);  ^/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kruler.cpp:158:2: warning: #warning FIXME setFrameStyle(WinPanel | Raised); [-Wcpp][ 33%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselector.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kxyselector.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kseparator.cpp.o[ 34%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ksqueezedtextlabel.cpp.o[ 34%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktitlewidget.cpp.o[ 34%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoggleaction.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktogglefullscreenaction.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstateserializer.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstatemaintainerbase.cpp.o[ 36%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/keditlistwidget.cpp.o[ 36%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcursor.cpp.o[ 36%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingwidget.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingpainter.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kactionselector.cpp.o[ 37%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorcombo.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoolbarspaceraction.cpp.o/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kratingpainter.cpp: In function 'void _k_imageToGrayScale(QImage&, float)':/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kratingpainter.cpp:179:36: warning: cast from 'uchar* {aka unsigned char*}' to 'QRgb* {aka unsigned int*}' increases required alignment of target type [-Wcast-align] QRgb *data = "" *) img.bits();^/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kratingpainter.cpp: In function 'void _k_imageToSemiTransparent(QImage&)':/home/user/workspace/Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9/src/kratingpainter.cpp:196:36: warning: cast from 'uchar* {aka unsigned char*}' to 'QRgb* {aka unsigned int*}' 

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.9 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.9/3/
 Project:
Frameworks kunitconversion kf5-qt5 AndroidQt5.9
 Date of build:
Sun, 15 Oct 2017 18:31:23 +
 Build duration:
3 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 242 B...]All nodes of label ‘AndroidQt5.9’ are offlineRunning on Docker Swarm-5f8ca94d4b95 in /home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kunitconversion > git init /home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.9 # timeout=10Fetching upstream changes from git://anongit.kde.org/kunitconversion > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kunitconversion +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kunitconversion # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kunitconversion # timeout=10Fetching upstream changes from git://anongit.kde.org/kunitconversion > git fetch --tags --progress git://anongit.kde.org/kunitconversion +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 77e8079c02629b9b51479159c1b7a92a746fefff (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 77e8079c02629b9b51479159c1b7a92a746fefffCommit message: "Add .arcconfig" > git rev-list d70259745a6cf1b2fc5cc5941d591831f0ef5f6f # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.9/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision c87b4b363b2eefa59dbb1c362b246e6928d19ae5 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f c87b4b363b2eefa59dbb1c362b246e6928d19ae5Commit message: "Ensure ASAN is symbolised on FreeBSD. Ref T7054"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.9/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision a968655c86985dfbfacc44542045a98fec45574e (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f a968655c86985dfbfacc44542045a98fec45574eCommit message: "Update the location here as well"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks kunitconversion kf5-qt5 AndroidQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress 

Re: Adding build info attribute to KAboutData to improve bug report data?

[David Faure]

On dimanche 15 octobre 2017 14:31:27 CEST Kevin Funk wrote:
> On Sunday, 8 October 2017 19:45:00 CEST Kevin Funk wrote:
> > Heya,
> > 
> > The KDevelop team is currently discussing a patch which adds git-describe
> > 
> > like information to the version string in KAboutData:
> >   https://phabricator.kde.org/D8158
> >   (don't bother reading through the comments...)
> > 
> > Problem:
> > 
> > When KAboutData's version is set to something like "5.1.80-24-g262fb4cb9f"
> > and when attempting to report a bug via KDevelop -> Help -> Report Bug,
> > bugs.kde.org will no longer pre-select the correct version in the version
> > list. Even worse: The version information is lost completely if the user
> > does not copy it from the dialog.
> > 
> > Idea:
> > Let's add a 'build info' attribute to KAboutData which may contain custom
> > data filled by a project to provide more information about a specific
> > build.
> > 
> > Then, for instance in KDevelop's main.cpp:
> > ```
> > KAboutData data(...);
> > data.setBuildInfo("Version: " KDEVELOP_FULL_VERSION_STRING);
> > ```
> > ... with KDEVELOP_FULL_VERSION_STRING being "5.1.80-24-g262fb4cb9f"
> 
> @KCoreAddons maintainers: Do you think that makes sense? In that case I'd
> create a patch which adds such API to KAboutData.

Sounds good to me.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Nathaniel Graham]

ngraham added a comment.


  Great, thank you!

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8303

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, 
ngraham, andrebarros, emmanuelp

D8314: Fix deprecation warning

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8314

To: kfunk, apol
Cc: #frameworks, kevinapavew, cullmann, sars, dhaumann

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham added a comment.


  I do find myself doing this a lot, yes. I know a lot of people who, upon 
downloading a new piece of software, the first thing they do is check out the 
preferences window to see what's available. It's a subtle thing, but throughout 
the macOS world where the shortcut is consistent across all apps, people do in 
fact open the Preferences windows a lot. With a consistent shortcut, it's 
practically a zero-effort operation. In platforms without that, the mental and 
physical effort is greater, so they don't open the Preferences window as much.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In https://phabricator.kde.org/D3977#155973, @elvisangelaccio wrote:
  
  > From what I can see, after this change any job registered with
  >
  >   KIO::getJobTracker()->registerJob(job);
  >   
  >
  > no longer needs to be manually unregistered with
  >
  >   KIO::getJobTracker()->unregisterJob(job);
  
  
  Looking at the history, `KJobTrackerInterface::registerJob(KJob *job)`has 
connected the job's `finished(KJob*)` signal to the tracker's 
`unregisterJob(KJob*)` since ages, 2008 and possibly longer (cmp. 
https://phabricator.kde.org/R446:7308fa7e6b756f5c6fe1b8adbcc6095e3bb5b995)
  
  And this commit here now uncovered that somehow for Ark as well.
  
  > This is a minor thing, but should probably be documented somewhere.
  
  Agreed, by just looking at the API (dox) one would assume one had to possibly 
also unregister manually. You proposed it -> you do it? :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D3977

To: kossebau, #frameworks, kfunk
Cc: elvisangelaccio, kfunk

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 50 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/50/
 Project:
Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 15 Oct 2017 23:38:52 +
 Build duration:
3 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)56%
(83/148)56%
(83/148)30%
(4373/14402)23%
(1777/7879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1577/1592)52%
(838/1606)src43%
(50/115)43%
(50/115)22%
(2796/12810)15%
(939/6273)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 50 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/50/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 23:38:52 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

[Eli MacKenzie]

argonel added a comment.


  Ctrl-Alt-, is way outside of anything I would expect as a common shortcut. 
Did you try Alt-,? I have no idea whether it'd work or not, but the odds of 
having a menu whose name begins with (or even contains) a comma are low.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham retitled this revision from "Use Ctrl+, as the standard shortcut for 
"Configure "" to "Use Ctrl+Alt+, as the standard shortcut for 
"Configure "".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: argonel, kfunk, marten, graesslin, broulik, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[David Faure]

dfaure added a comment.


  You can send (forward) a key event to a widget (like the QTreeView) using 
qApp->sendEvent(), rather than trying to call the protected method 
keyPressEvent() directly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: ngraham, alexeymin, #frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

[Albert Astals Cid]

aacid added a comment.


  do you really find yourself opening the app settings that offen that you need 
a shortcut?
  
  I personally don't think adding this shortcut makes sense, the preferences is 
not something you invoke usually, i.e. like Ctrl+C, Ctrl+V
  
  Your original patch had some value trying to cater for the macOs refugees, 
but now that isn't even the case, i have to ask, why "steal" from apps one more 
shortcut?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

Re: concise instructions how to use sub...@bugs.kde.org?

[Martin Steigerwald]

Luigi Toscano - 15.10.17, 14:06:
> Martin Steigerwald ha scritto:
> > René J.V. Bertin - 15.10.17, 12:07:
> >> I'm looking for some concise instructions how to submit reports to BKO
> >> via
> >> the bug reporting address (something more straightforward than
> >> retro-engineering DrKonqi ;)).
> >> 
> >> I've come across something (www.plcrashreporter.org) that could replace
> >> DrKonqi on Mac, and which might eventually be implemented instead of the
> >> code in whatever framework invokes DrKonqi.
> > 
> > I´d say: Just use reportbug Debian package and command… but why on Earth
> > do
> > you ask this on the KDE Frameworks development mailing list?
> > 
> > I also suggest to subscribe to the debian-kde mailing list in case you use
> > KDE software on Debian … I and others usually announce transitions and
> > help with user issues.
> 
> This email is not about the Debian bugtracker.

I completely misunderstood the original mail.

Sorry for the noise.

Thanks,
-- 
Martin

D7130: KMoreTools: Update and fix desktopfiles

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:7d3992479ea1: KMoreTools: Update and fix desktopfiles 
(authored by gregormi, committed by ngraham).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7130?vs=20781=20830

REVISION DETAIL
  https://phabricator.kde.org/D7130

AFFECTED FILES
  autotests/kmoretools/kmoretoolstest.cpp
  autotests/kmoretools/kmoretoolstest2.cpp
  data/kmoretools-desktopfiles/_INFO
  data/kmoretools-desktopfiles/_update_all_files.sh
  data/kmoretools-desktopfiles/angrysearch.desktop
  data/kmoretools-desktopfiles/catfish.desktop
  data/kmoretools-desktopfiles/com.uploadedlobster.peek.desktop
  data/kmoretools-desktopfiles/ding.desktop
  data/kmoretools-desktopfiles/disk.desktop
  data/kmoretools-desktopfiles/filelight.png
  data/kmoretools-desktopfiles/filelight.svg
  data/kmoretools-desktopfiles/fontinst.desktop
  data/kmoretools-desktopfiles/fontmatrix.desktop
  data/kmoretools-desktopfiles/fsearch.desktop
  data/kmoretools-desktopfiles/giggle.desktop
  data/kmoretools-desktopfiles/git-cola-folder-handler.desktop
  data/kmoretools-desktopfiles/git-cola.desktop
  data/kmoretools-desktopfiles/gitg.desktop
  data/kmoretools-desktopfiles/gnome-search-tool.desktop
  data/kmoretools-desktopfiles/gparted.desktop
  data/kmoretools-desktopfiles/gucharmap.desktop
  data/kmoretools-desktopfiles/htop.desktop
  data/kmoretools-desktopfiles/kdf.desktop
  data/kmoretools-desktopfiles/kding.desktop
  data/kmoretools-desktopfiles/ksystemlog.desktop
  data/kmoretools-desktopfiles/org.gnome.clocks.desktop
  data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop
  data/kmoretools-desktopfiles/org.kde.filelight.desktop
  data/kmoretools-desktopfiles/org.kde.kcharselect.desktop
  data/kmoretools-desktopfiles/org.kde.kdf.desktop
  data/kmoretools-desktopfiles/org.kde.kfind.desktop
  data/kmoretools-desktopfiles/org.kde.kmousetool.desktop
  data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop
  data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop
  data/kmoretools-desktopfiles/org.kde.ksysguard.desktop
  data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop
  data/kmoretools-desktopfiles/org.kde.ktimer.desktop
  data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop
  data/kmoretools-desktopfiles/org.kde.spectacle.desktop
  data/kmoretools-desktopfiles/shutter.desktop
  data/kmoretools-desktopfiles/shutter.svg
  data/kmoretools-desktopfiles/simplescreenrecorder.desktop
  data/kmoretools-desktopfiles/xfce4-taskmanager.desktop
  src/kmoretools/kmoretoolspresets.cpp
  src/kmoretools/kmoretoolspresets.h
  tests/kmoretools/kmoretoolstest_interactive.cpp

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Derp derp derp. Works fine now.

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D3977: Fix memleak in KDynamicJobTracker, KWidgetJobTracker needs QApplication

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D3977#155762, @kossebau wrote:
  
  > On a quick look the automatic unregistering based on the finished signal 
seems to make sense for any KJob subclass. Perhaps the change in this commit 
conflicts with some older code in Ark to work around the old behaviour and 
which does some additional manual unregistration? Or perhaps some slot in 
accidentally invoked 2x so the unregistration happens more than once, with the 
second try than failing? Wild guesses is all I have to offer, sorry. I cannot 
remember anything questionable about this patch, so no pointers into it, 
instead my initial reaction would be to look at the consumer side.
  
  
  Yes Ark has a manual unregistration, which I can easily fix.
  From what I can see, after this change any job registered with
  
KIO::getJobTracker()->registerJob(job);
  
  no longer needs to be manually unregistered with
  
KIO::getJobTracker()->unregisterJob(job);
  
  This is a minor thing, but should probably be documented somewhere.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D3977

To: kossebau, #frameworks, kfunk
Cc: elvisangelaccio, kfunk

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:38681e7d27f5: Show Date Modified information by default 
in Dolphins Information Panel and… (authored by ngraham).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8303?vs=20768=20818

REVISION DETAIL
  https://phabricator.kde.org/D8303

AFFECTED FILES
  src/metadatafilter.cpp

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, 
ngraham, andrebarros, emmanuelp

D7130: KMoreTools: Update and fix desktopfiles

[Nathaniel Graham]

ngraham added a comment.


  I'm afraid this still doesn't merge cleanly onto Dolphin's master branch for 
me. `arc patch D7130` reports the following:
  
This diff is against commit e2d0a8108ec04a208d384176d53f413686ed35f2, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (c58226ce4f40c5c475728587f5a735a75f8be901)
  
  (https://phabricator.kde.org/R318:c58226ce4f40c5c475728587f5a735a75f8be901 
being HEAD)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

Re: FYI: Added .arcconfig files to all frameworks

[Aleix Pol]

On Sun, Oct 15, 2017 at 8:39 PM, Kevin Funk  wrote:
> Heya,
>
> just pushed an .arcconfig file to all framework repositories. There were still
> lots of frameworks without them.
>
> Example commit:
>   https://cgit.kde.org/qqc2-desktop-style.git/commit/?
> id=146e370704938e6cab6278a5e203f3ef2cf93946
>
> Regards,
> Kevin
>
> --
> Kevin Funk | kf...@kde.org | http://kfunk.org

Danke schön! :)

Aleix

D8321: Only check for legacy system tray icons if we're going to make one

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  On Plasma is a rather pointless check as our QPT uses SNIs
  so we end up checking something we've already checked,
  only in a blocking way - and we're going to no-op anyway.
  
  BUG: 385371

TEST PLAN
  killed kded5
  created an SNI. It failed into the else branch

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8321

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20AndroidQt5.9/3/
 Project:
Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9
 Date of build:
Sun, 15 Oct 2017 23:38:52 +
 Build duration:
5 min 18 sec and counting

D8296: Use Ctrl+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham updated this revision to Diff 20821.
ngraham added a comment.


  lxr.kde.org showed several programs using Ctrl+, but nothing uses Ctrl+Alt+,

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8296?vs=20738=20821

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8296

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: ngraham, #frameworks, #vdg
Cc: argonel, kfunk, marten, graesslin, broulik, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  No worries, take your time. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: ngraham, alexeymin, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @ngraham This patch is for knewstuff :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D8303: Show Date Modified information by default in Dolphin's Information Panel and Tooltips

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  In https://phabricator.kde.org/D8303#155858, @ngraham wrote:
  
  > Honestly I think it's fine the way it is: in the details view, we have a 
nice compact string that doesn't make the column too wide, and in the 
Information Panel, we have a longer string that provides more information and 
isn't too big since text can wrap there.
  >
  > I do see your point though, and I agree that the long string should be 
customizable in some way for people who prefer a shorter string. But that seems 
out of scope for this change; can we stick to this change here, and discuss 
that other change (which I do approve of:) ) in another patch or bug report?
  
  
  Oke, then it's a +1 :)

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8303

To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef, 
ngraham, andrebarros, emmanuelp

D8315: CMake cleanup: Don't hardcode -std=c++0x

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R279 ThreadWeaver

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8315

To: kfunk, apol
Cc: #frameworks

D7130: KMoreTools: Update and fix desktopfiles

[Luigi Toscano]

ltoscano added a subscriber: mak.
ltoscano added a comment.


  In https://phabricator.kde.org/D7130#155151, @gregormi wrote:
  
  > > @ltoscano, can we commit this?
  >
  >
  >
  > > I still disagree in the way this is done, as it means manually 
periodically updating the information and it's definitely not the right thing 
to do.
  >
  > Hi Luigi,
  >
  > I agree with you that the manual updating process is not good. As the 
library was written, there was no better way. The desktop file method was 
chosen because it was said that they avoid duplicate translation work. See last 
point of the Introduction 
https://api.kde.org/frameworks/knewstuff/html/classKMoreTools.html ("Reduce 
translation effort by re-using .desktop files of the services added to the 
menu."). Since the goal of KMoreTools is to present applications that are not 
installed, I currently see no other way to ship all the desktop files.
  >
  > > That said, if @elvisangelaccio approves this, it can go in as temporary 
fix but the next update should work on using the appstream library to get those 
information from appstream files. Or any other solutions which does not involve 
duplicating the information.
  >
  > I looked at the appstream documentation but I was not able to extract 
information that would help me to understand how to use it in the KMoreTools 
case. To be of use in KMoreTools there should be an offline database with all 
needed applications and descriptions. How will this database be filled with new 
applications? Maybe you can point me to some suitable documentation?
  
  
  The idea is that you don't care about the database. The appstream database is 
downloaded/updated like the list of the packages provided by the package 
manager. You just query the database; check what plasma-discover does, for 
example. @mak , who maintain many stuff related with the appstream technology, 
may help as well.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: mak, ngraham, ltoscano, #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/52/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 15 Oct 2017 21:38:47 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittestFailed: TestSuite.kshelltest

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 21 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.9/21/
 Project:
Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 15 Oct 2017 23:38:52 +
 Build duration:
9 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: TestSuite.kcolorbuttontest

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 126 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/126/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Mon, 16 Oct 2017 03:01:39 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)67%
(6/9)67%
(6/9)64%
(409/640)43%
(169/393)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc80%
(4/5)80%
(4/5)54%
(173/320)34%
(90/263)src.libkirigami50%
(2/4)50%
(2/4)74%
(236/320)61%
(79/130)

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 121 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/121/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Mon, 16 Oct 2017 03:01:24 +
 Build duration:
48 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(278/346)80%
(278/346)57%
(29972/52248)42%
(16576/39291)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4504/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8160/14198)49%
(4561/9279)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3491/7603)30%
(1300/4403)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file100%
(2/2)100%
(2/2)51%
(435/849)42%
(317/749)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1770/3781)38%
(1326/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)63%
(377/594)48%
(280/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)56%

D8321: Only check for legacy system tray icons if we're going to make one

[Martin Flöser]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8321

To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8296: Use Alt+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham retitled this revision from "Use Ctrl+Alt+, as the standard shortcut 
for "Configure "" to "Use Alt+, as the standard shortcut for 
"Configure "".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

D8296: Use Alt+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham added a comment.


  Alt+, is definitely better, yeah. Also, now we are actually preserving 
recovering Mac users' muscle memory, since the Alt key on a PC keyboard is in 
the same place as the Command key on a Mac keyboard.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 120 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/120/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 16 Oct 2017 03:01:39 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/46/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 16 Oct 2017 03:01:04 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

Re: Adding build info attribute to KAboutData to improve bug report data?

[Luca Beltrame]

Il giorno Sun, 08 Oct 2017 19:45:00 +0200
Kevin Funk  ha scritto:

> Heya,
> 
> The KDevelop team is currently discussing a patch which adds
> git-describe like information to the version string in KAboutData:
>   https://phabricator.kde.org/D8158
>   (don't bother reading through the comments...)

Is it added at compile time? I didn't read through the diff yet, but
how would you define a "development" build? 
This is to make sure that no such things are put in released versions,
which would cause problems with reproducible builds.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B


pgpkzhMO2I7PD.pgp
Description: Firma digitale OpenPGP

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

[Nathaniel Graham]

ngraham updated this revision to Diff 20839.
ngraham added a comment.


  Switch to Alt+, since that makes a bit more sense and actually preserves 
recovering Mac users' muscle memory (Alt being in the same place as the Command 
key)

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8296?vs=20821=20839

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8296

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks