D10365: New icon for Elisa music player

[Matthieu Gallien]

mgallien added a comment.


  In D10365#205750 , @andreask wrote:
  
  > can we get it now to master?
  >
  > @paullesur is hopefully interested in other icon's too.
  
  
  @paullesur do you have a KDE contributor account ? If not, I cannot push due 
to life events pushing me away from keyboard.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10365

To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien
Cc: mmustac, mgallien, januz, astippich, andreask, andreaska, ltoscano, 
ngraham, #frameworks, jussiv, paullesur, michaelh, ognarb, kmf, progwolff

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

[Jeremy Whiting]

whiting added a comment.


  Hey all, this change breaks Kompare 
https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's 
textChanged signal to update a button's enabled state. We are not seeing the 
textChanged signal on the KUrlRequester anymore when programatically setting 
the url with the KUrlComboBox we give to the KUrlRequester via it's setUrl 
method. Looking at KUrlComboBox::setUrl it's blocking signals in the body of 
setUrl and since we are not connecting to the QLineEdit anymore we never get 
that signal.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7968

To: mwolff, apol, dfaure
Cc: whiting, #frameworks, michaelh

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:789
> +if (!d->applet->isContainment()) {
> +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), 
> qMin(d->preloadWeight() + s_preloadWeightIncrement, 100));
> +}

I was also wondering about dbus-activated applet, from what I can tell whenever 
I start a media player, the score is reduced, so I'll most likely end up with 0 
for media controller immediately.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.7 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/17/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 14 Feb 2018 21:08:50 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(411/1441)21%
(182/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/4)

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/17/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 14 Feb 2018 21:08:50 +
 Build duration:
3 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(411/1441)21%
(182/856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)49%
(53/109)23%
(13/56)src90%
(9/10)90%
(9/10)31%
(358/1156)24%
(169/694)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/41)0%
(0/4)

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/9/
 Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 14 Feb 2018 21:08:50 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.dbusrunnertestFailed: TestSuite.runnercontexttest

D10511: Update krunner plugin template

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R308:cd4f8c4fd6b7: Update krunner plugin template (authored by 
kossebau).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10511?vs=27159=27185

REVISION DETAIL
  https://phabricator.kde.org/D10511

AFFECTED FILES
  templates/runner/%{APPNAMELC}.cpp
  templates/runner/%{APPNAMELC}.desktop
  templates/runner/%{APPNAMELC}.h
  templates/runner/CMakeLists.txt
  templates/runner/Messages.sh
  templates/runner/src/%{APPNAMELC}.cpp
  templates/runner/src/%{APPNAMELC}.h
  templates/runner/src/CMakeLists.txt
  templates/runner/src/plasma-runner-%{APPNAMELC}.desktop

To: kossebau, broulik
Cc: #frameworks, michaelh

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10518: Use QWidget to see if the window is visible

[Andrius Štikonas]

stikonas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

[Aleix Pol Gonzalez]

apol updated this revision to Diff 27182.
apol removed a reviewer: stikonas.
apol added a comment.
This revision now requires review to proceed.


  Properly detect the window state when not on X11
  
  KWindowInfo doesn't support most features on Wayland (or any other backend)
  so we provide an alternative simpler, dumber path.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10518?vs=27180=27182

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: apol, #frameworks
Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

[Andrius Štikonas]

stikonas accepted this revision.
stikonas added a comment.
This revision is now accepted and ready to land.


  Works for me.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas reclaimed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas abandoned this revision.
stikonas added a comment.


  Le's close it in favour of https://phabricator.kde.org/D10518

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas updated this revision to Diff 27181.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10495?vs=27106=27181

REVISION DETAIL
  https://phabricator.kde.org/D10495

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10518: Use QWidget to see if the window is visible

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  Instead of using KWindowInfo::mappingState that won't give reliable
  information about the window on wayland.

TEST PLAN
  tested locally

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: apol, #frameworks
Cc: michaelh

D10512: try to preload certain applets in a smart way

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:789
> +if (!d->applet->isContainment()) {
> +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), 
> qMin(d->preloadWeight() + s_preloadWeigthIncrement, 100));
> +}

So if you ever open the any applet slightly more than every alternate login (at 
any point during that session) over time it'll become blocking preloaded on 
boot?

Your login to desktop will just get slower and slower until it's ultimately 
loading everything.

---

I'm against doing any hacks without prior profiling.

If we find plasma-pa (for example) gains a lot at no cost, great! Add the entry.

If we find plasma-pa loaded in a nanosecond anyway, and takes up 10Mb of RAM to 
do so, then it's a very silly thing to do.

I'd like to see some numbers for every applet we add it to, I don't think the 
shell is in a position to do this automatically.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: davidedmundson, broulik, apol, ngraham, plasma-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D10511: Update krunner plugin template

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R308 KRunner

BRANCH
  updaterunnertemplate

REVISION DETAIL
  https://phabricator.kde.org/D10511

To: kossebau, broulik
Cc: #frameworks, michaelh

D10512: try to preload certain applets in a smart way

[Nathaniel Graham]

ngraham added a comment.


  Let's keep in mind the PR aspect of this: if we end up 30 MB heavier and a 
few seconds slower on a cold boot for a new install, advanced users who 
frequent internet forums and write reviews will notice this, but they probably 
won't notice that some widgets open more quickly once Plasma is loaded.
  
  Perhaps we could invert the logic: instead of preloading everything and then 
over time removing infrequently used widgets from the list, we could preload 
only a few fixed things like the menu, Task Manager, and plasma-nm, and for 
everything else, prelaod based on frequency of use.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> apol wrote in appletquickitem.cpp:87
> Isn't X-Plasma-PreloadWeight for that?

It's to have some default weights without having to populate every desktop file

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10512: try to preload certain applets in a smart way

[Kai Uwe Broulik]

broulik added a comment.


  Cool!
  
  Since this is all applet quick item stuff it will just work™ with applet 
within system tray?
  Would be nice to have some `qCInfo` in there somewhere so we can better 
understand what it's doing, when it's increasing/decreasing the rating, when 
it's preloading it, etc.

INLINE COMMENTS

> appletquickitem.cpp:47
> +//weight values for the logic for when or if to preload
> +static const int s_defaultPreloadWeight = 50;
> +static const int s_defaultLauncherPreloadWeight = 100;

imho using an `enum` rather than a bunch of `static int`s is nicer

> appletquickitem.cpp:49
> +static const int s_defaultLauncherPreloadWeight = 100;
> +static const int s_defaultDatePreloadWeight = 80;
> +static const int s_immediatePreloadWeight = 70;

Are you sure we want to preload the calendar right away? This thing takes 
forever to open, wouldn't want to have that slow down plasma startup massively.

> appletquickitem.cpp:95
> +//default widgets to be barely preloaded
> +return qBound(0, 
> applet->config().readEntry(QStringLiteral("PreloadWeight"), 
> qMax(defaultWeight, 
> applet->pluginMetaData().rawData().value(QStringLiteral("X-Plasma-PreloadWeight")).toInt())),
>  100);
> +}

Could this be split into multiple lines, it's quite hard to follow

> appletquickitem.cpp:636
> +//decrease weight until we open it again
> +applet()->config().writeEntry(QStringLiteral("PreloadWeight"), qMax(0, 
> preloadWeight - s_preloadWeightIncrement));
> +

This should go into a function, there's like three places where a "random" 
`writeEntry` is scattered around

> appletquickitem.cpp:642
> +//spread the creation over a random delay between 2 and 10 seconds, 
> to make it look plasma started before, and load everything in the background 
> without big noticeable freezes
> +QTimer::singleShot(qrand() % ((1 + 1) - 2000) + 2000, [this]() {
> +d->createFullRepresentationItem();

Add `this` as context or else it would blow up when the applet is destroyed 
before the timer fires:

  QTimer::singleShot(qrand..., this, [this]() {

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: broulik, apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10494: update handle- icons for kirigami

[Alessandro Longo]

alex-l added a comment.


  +1 for 3-dots icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10494

To: andreask, alex-l, mart
Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  In D8056#206326 , @simgunz wrote:
  
  > I was thinking to discuss the possibility to make a new KDE UI component 
for collapsible headers so that it can be used in multiple places. Maybe I can 
open a task for discussing this and collect opinions and possible use cases to 
see if it makes sense.
  
  
  That sounds great. This is a pretty common and user-friendly UI paradigm, so 
it would make perfect sense to make it more widely available.
  
  In D8056#206326 , @simgunz wrote:
  
  > My next big goal is try to improve the usability of Okular, especially 
improving the annotations. (I think there are at least 10 bug reports opened by 
me on this). I'll get you involved soon.
  
  
  You're my hero! This is a big tentpole of the Usability & Productivity 
initiative. Take a look at some of the Okular bugs mentioned on 
https://phabricator.kde.org/T6831
  
  A major problem is that Okular (or poppler) often saves annotations in ways 
that don't make them renderable in other viewers, or when printing. See the 
following bugs:
  
  - https://bugs.kde.org/show_bug.cgi?id=383651
  - https://bugs.kde.org/show_bug.cgi?id=275371
  - https://bugs.kde.org/show_bug.cgi?id=378186
  - https://bugs.kde.org/show_bug.cgi?id=390293

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D10512: try to preload certain applets in a smart way

[Aleix Pol Gonzalez]

apol added a comment.


  It sounds like it should be the shell who decides what needs preloading, 
rather than the framework guessing it.

INLINE COMMENTS

> appletquickitem.cpp:87
> +//some applet types we want a bigger weight
> +if (provides.contains(QStringLiteral("org.kde.plasma.launchermenu"))) {
> +defaultWeight = s_defaultLauncherPreloadWeight;

Isn't X-Plasma-PreloadWeight for that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10512

To: mart, #plasma
Cc: apol, ngraham, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx added a comment.


  Great to hear. Hopefully you'll find the right balance between chasing the 
big goals and doing small changes here and there to learn the trade for 
achieving the former ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  In D8056#206303 , @rkflx wrote:
  
  > @simgunz Thanks again for your patience (first commit in July!). Hope to 
see more patches from you in the future (both large* like this one, but also 
smaller things**), as you both have a good eye for usability as well as the 
means to implement changes. You should think about applying for commit access 
in tandem with you next patch or the one after that ;)
  
  
  I finished writing my Ph.D. thesis right now. Finally I am a free man again! 
(this is also the reason why it took so long to complete this revision, because 
my commits came spaced by months :-) )
  
  I'll definitely have more free time from this moment on, and I'll be glad to 
contribute.
  
  > *) I know Nate would love to get collapsible headers in Dolphin's sidebar…
  
  I was thinking to discuss the possibility to make a new KDE UI component for 
collapsible headers so that it can be used in multiple places. Maybe I can open 
a task for discussing this and collect opinions and possible use cases to see 
if it makes sense.
  
  > **) Just ask if you need ideas.
  
  I usually have too many, and not enough time. Reason why my big projects are 
swamped, and why I open a lot of bugs without fixing them myself.
  
  I must say I loved the phabricator experience. I always programmed by myself 
my own projects, but discussing how to implement things, having someone to 
review the modifications is why more fun and the quality of the outcome is way 
better.
  
  My next big goal is try to improve the usability of Okular, especially 
improving the annotations. (I think there are at least 10 bug reports opened by 
me on this). I'll get you involved soon.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/114/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 14 Feb 2018 17:20:14 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 134 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/134/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 14 Feb 2018 17:20:14 +
 Build duration:
9 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31484/59552)38%
(18479/48806)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5215/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8333/14342)50%
(4867/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7839)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/132/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Wed, 14 Feb 2018 17:20:14 +
 Build duration:
7 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31506/59552)38%
(18500/48882)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8548/9096)48%
(5213/10759)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8340/14343)50%
(4874/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7839)33%
(1634/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D10251: [RFC] Use mipmap filtering in window thumbnails

[Nathaniel Graham]

ngraham added a comment.


  Crisper would definitely be nicer too, but if that's too hard, this is 
already a big visual win even in its current state.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e3af26bbb1e7: Improve usability of Open With 
dialog by adding option to filter the… (authored by simgunz, committed by 
rkflx).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=27136=27171

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Nathaniel Graham]

ngraham added a comment.


  In D8056#206303 , @rkflx wrote:
  
  > *) I know Nate would love to get collapsible headers in Dolphin's sidebar…
  
  
  *completely coincidental mention* https://bugs.kde.org/show_bug.cgi?id=389803 
:)
  
  Allow me to echo everything @rkflx said. This is excellent work, and I can't 
wait to see what else you come up with in the future!

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  @simgunz Thanks again for your patience (first commit in July!). Hope to see 
more patches from you in the future (both large* like this one, but also 
smaller things**), as you both have a good eye for usability as well as the 
means to implement changes. You should think about applying for commit access 
in tandem with you next patch or the one after that ;)
  
  *) I know Nate would love to get collapsible headers in Dolphin's sidebar…
  **) Just ask if you need ideas.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27169.
mart added a comment.


  - correct typo

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27163=27169

BRANCH
  mart/preload

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart updated this revision to Diff 27163.
mart added a comment.


  - silence warnings

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10512?vs=27162=27163

BRANCH
  mart/preload

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10512: try to preload certain applets in a smart way

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  preload popups of some applets after init in the background
  based on a value of X-Plasma-PreloadWeight in the desktop file
  if present, otherwise some default values based on the applet
  type (Provides)
  
  Save the weight in the config, if an applet is never opened,
  slowly decrease the weight, when it reaches 0 don't preload it
  next start, increase every time it gets opened, so at the moment
  it's quite aggressive about preloading, in order to not do it
  a lot of plasma startups without touching the applet are needed
  
  Applet with a very big weigth will be preloaded immediately,
  therefore having an impact on the time it will take to have
  a panel visible and usable, while lesser weigths will preload
  after a random number of seconds between 2 and 10, so will load
  in the background after everything is started

TEST PLAN
  Plasma starts up correctly, applets load correctly and can be added
  correctly both those expanded or collapsed.
  plasmashell appears correctly usable without too big hiccups even
  while it's loading things in the background
  
  some numbers:
  without preloading, plasma takes around 64 mb of memory after startup
  when preloading everything about 94, so it's a cost of about 30 mb
  which is not negligible.
  don't have precise timing, but if everything gets preloaded immediately,
  the time to get an usable desktop appears to be at least doubled,
  while the delayed preloading (except just a couple of applets) doesn't
  seem to have a big impact on the time needed to get an usable desktop

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  mart/preload

REVISION DETAIL
  https://phabricator.kde.org/D10512

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10511: Update krunner plugin template

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  - clean-up CMakeLists.txt from unused things
  - move source files into subdirectory src/
  - prepare usage of ki18n
  - add license headers, default to lgpl 2.1+
  - prefix desktop file with "plasma-runner-"

REPOSITORY
  R308 KRunner

BRANCH
  updaterunnertemplate

REVISION DETAIL
  https://phabricator.kde.org/D10511

AFFECTED FILES
  templates/runner/%{APPNAMELC}.cpp
  templates/runner/%{APPNAMELC}.desktop
  templates/runner/%{APPNAMELC}.h
  templates/runner/CMakeLists.txt
  templates/runner/Messages.sh
  templates/runner/src/%{APPNAMELC}.cpp
  templates/runner/src/%{APPNAMELC}.h
  templates/runner/src/CMakeLists.txt
  templates/runner/src/plasma-runner-%{APPNAMELC}.desktop

To: kossebau, broulik
Cc: #frameworks, michaelh

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

[Nathaniel Graham]

ngraham added reviewers: Kate, cullmann.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks for doing this, Marijo. It's much appreciated. I'll let the Kate folks 
comment too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10509

To: mmustac, #ktexteditor, ngraham, #kate, cullmann
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D10508: Add icons for KStandardActions Deselect and Replace

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the image; now I can feature it in this coming weekend's Usability 
& Productivity 
 post!

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: Add icons for KStandardActions Deselect and Replace

[Marijo Mustac]

mmustac edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

[Marijo Mustac]

mmustac created this revision.
mmustac added reviewers: KTextEditor, ngraham.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
mmustac requested review of this revision.

REVISION SUMMARY
  This patch adds some more icons to the menus.
  One in the file menu, one in the bookmark menu and some in the tool menu.
  
  Example:
  F5711485: tools.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10509

AFFECTED FILES
  src/utils/katebookmarks.cpp
  src/view/kateview.cpp

To: mmustac, #ktexteditor, ngraham
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D10508: Add icons for KStandardActions Deselect and Replace

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:5bd125e26d0b: Add icons for KStandardActions Deselect and 
Replace (authored by mmustac, committed by ngraham).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10508?vs=27152=27156

REVISION DETAIL
  https://phabricator.kde.org/D10508

AFFECTED FILES
  src/kstandardaction_p.h

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: Add icons for KStandardActions Deselect and Replace

[Nathaniel Graham]

ngraham added a comment.


  Yep, I just wanted to make sure you knew how to deploy it properly to test.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: Add icons for KStandardActions Deselect and Replace

[Marijo Mustac]

mmustac added a comment.


  I can't access the link at the moment but changed the title according ;)
  And kate picks up this change automatically because they relay on this 
framework already or did I get you wrong?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: Add icons for KStandardActions Deselect and Replace

[Marijo Mustac]

mmustac retitled this revision from "[KStandardAction] Add additional icons to 
menus" to "Add icons for KStandardActions Deselect and Replace".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: [KStandardAction] Add additional icons to menus

[Nathaniel Graham]

ngraham added a comment.


  Also, you don't need "[KStandardAction]" in the title. A better commit 
message would indicate the actual icons. Maybe something like this:
  
  "Add icons for KStandardActions Deselect and Replace"
  
  See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: [KStandardAction] Add additional icons to menus

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great! Do you know how to deploy this patch such that apps e.g. Kate 
can pick up the change?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10508: [KStandardAction] Add additional icons to menus

[Marijo Mustac]

mmustac created this revision.
mmustac added reviewers: Frameworks, ngraham.
Restricted Application added a project: Frameworks.
mmustac requested review of this revision.

REVISION SUMMARY
  I added also here the icons for the "replace" and "deselect" action.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10508

AFFECTED FILES
  src/kstandardaction_p.h

To: mmustac, #frameworks, ngraham
Cc: michaelh

D10495: Workaround to restore KF5 programs from system tray

[Andrius Štikonas]

stikonas added a comment.


  Well, basically when you click on any KF5 application (e.g. Konversation, 
KGpg, Akregator, etc...) in the system tray, nothing happens.
  This does no happen with Qt5-only programs. Clicking on system tray there 
always brings the window up.
  
  From what I can see in the code, on X11 
KWindowSystem::activateWindow(associatedWidget->winId()); raises the window
  but if I understand correctly KWindowSystem::activateWindow can never work on 
Wayland. This is clearly not what end user
  would expect.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D10495

To: stikonas, wbauer, #plasma, davidedmundson, volkov
Cc: graesslin, #kwin, plasma-devel, kde-frameworks-devel, #frameworks, 
michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D9840: Tentative patch to reduce I/O overhead of plasmashell when copying files

[Milian Wolff]

mwolff added a comment.


  I guess this can be abandoned now that the real culprit was found, no?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D9840

To: jtamate, #frameworks, dfaure
Cc: mwolff, ngraham, mmustac, michaelh