D11998: Ensure that the model is set when resetResizing is called

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH fixConnectWarning REVISION DETAIL https://phabricator.kde.org/D11998 To: fabiank, dfaure, ngraham, apol Cc: apol, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:48:33 + Build duration: 38 min and counting JUnit Tests Name:

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:47:29 + Build duration: 38 min and counting JUnit

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:48:58 + Build duration: 56 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:49:25 + Build duration: 1 hr 5 min and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:48:45 + Build duration: 1 hr 36 min and counting JUnit Tests Name:

D11982: Use statbuf consistently

michaelh updated this revision to Diff 31561. michaelh added a comment. - Correct typo REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11982?vs=31515=31561 BRANCH statbuf (branched from master) REVISION DETAIL https://phabricator.kde.org/D11982

D12007: Add test case for parsing of double opening '(('

michaelh added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:278 > ; > - > +// Test 1 for KDE#392620 > +QTest::newRow("a OR ((b AND c) AND d)") BUG:392620? (Not sure) > advancedqueryparsertest.cpp:291 > +; > +// Test 2 for KDE#392620 > +

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

dfaure added a comment. This broke the unittest : c Internal cmake changing into directory: /d/kde/build/5/frameworks/ki18n/autotests/ki18n_install Error: cmake execution failed The C compiler identification is GNU 4.8.5 The CXX compiler identification is GNU 5.3.1 Check for

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/69/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:35:05 + Build duration: 1 min 20 sec and counting JUnit

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

dfaure added a comment. Reference: https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/ but also reproducible locally. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:48:45 + Build duration: 45 min and counting JUnit Tests Name:

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/48/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:50 + Build duration: 45 min and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:48:48 + Build duration: 45 min and counting JUnit Tests Name:

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 09:05:22 + Build duration: 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.9 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:47:55 + Build duration: 1 hr 20 min and counting JUnit Tests Name:

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:35:05 + Build duration: 9 min 30 sec and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/35/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:47:29 + Build duration: 19 min and counting JUnit

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:03 + Build duration: 18 min and counting JUnit

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:44 + Build duration: 27 min and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:48 + Build duration: 27 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:58 + Build duration: 36 min and counting JUnit Tests

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.9 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks threadweaver kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:49:36 + Build duration: 53 min and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:49:25 + Build duration: 52 min and counting JUnit Tests Name:

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.10/24/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:49:06 + Build duration: 52 min and counting JUnit Tests Name:

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 09:05:22 + Build duration: 4 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:48:04 + Build duration: 1 hr 21 min and counting JUnit Tests

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:49:06 + Build duration: 1 hr 51 min and counting JUnit Tests Name:

D11998: Ensure that the model is set when resetResizing is called

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bff960d67162: Ensure that the model is set when resetResizing is called (authored by fabiank). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11998?vs=31525=31578

D11826: Simplify Term operator&& and ||

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b0dcc732ca98: Simplify Term operator and || (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11826?vs=31581=31582 REVISION DETAIL

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/30/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 11:46:29 + Build duration: 12 min and counting JUnit Tests Name: (root)

D12006: Make list of subterms in debug output easier to spot

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH b#392620_unittest REVISION DETAIL https://phabricator.kde.org/D12006 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

nibags updated this revision to Diff 31565. nibags added a comment. - xharbour.xml is restored I have verified that the `Int` rule is not equivalent to `` REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11543?vs=30172=31565 BRANCH

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/53/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:47:18 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks ki18n kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:47:55 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/97/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:49:20 + Build duration: 48 min and counting

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:49:03 + Build duration: 51 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 209 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/209/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:48:07 + Build duration: 51 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 122 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/122/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:49:20 + Build duration: 1 hr 9 min and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:47:29 + Build duration: 1 hr 23 min and counting JUnit

KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.10/12/ Project: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 07 Apr 2018 07:47:55 + Build duration: 1 hr 55 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:48:58 + Build duration: 1 hr 54 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 210 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/210/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 10:35:42 + Build duration: 26 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 188 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/188/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:07 + Build duration: 26 min and counting JUnit Tests Name:

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:41 + Build duration: 25 min and counting JUnit Tests Name:

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/70/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:47:18 + Build duration: 26 min and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/40/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:33 + Build duration: 24 min and counting JUnit Tests

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. In term of comparison to the FileCopyJob for instance, the difference I can spot with the DeleteJob implementation, is that the FileCopyJobPrivate itselft instanciates a subJob in this case a DirectCopyJob that will do the work, using internally SimpleJobPrivate.

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. In D11176#241716 , @dfaure wrote: > Reference: https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/ but also reproducible locally.

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/23/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:48:33 + Build duration: 1 hr 30 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/58/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:48:07 + Build duration: 1 hr 43 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.10/9/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 07 Apr 2018 07:47:48 + Build duration: 1 hr 50 min and counting

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:49:25 + Build duration: 2 hr 1 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 189 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/189/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 10:35:42 + Build duration: 18 min and counting JUnit Tests Name:

D12016: [ktexteditor] much faster positionFromCursor

jtamate created this revision. jtamate added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Use static variables to store information about last call.

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 73 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/73/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:35:05 + Build duration: 4 min 45 sec and counting JUnit Tests

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 59 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/59/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:46:40 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:48:52 + Build duration: 32 min and counting JUnit Tests

KDE CI: Frameworks ki18n kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks ki18n kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:47:55 + Build duration: 30 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/16/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 07:48:03 + Build duration: 31 min and counting JUnit Tests

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/21/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 07 Apr 2018 07:49:03 + Build duration: 42 min and counting JUnit

D12014: [kcoreaddons] convert to new connect syntax

jtamate created this revision. jtamate added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Convert to the new connect syntax. As the job2 parameter was

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:47:18 + Build duration: 1 hr 15 min and counting JUnit Tests

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 07:49:03 + Build duration: 1 hr 46 min and counting JUnit Tests

D12017: taglibextractortest: Test for multiple values

michaelh created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY - Create new set of audio sample files - Add 2 artists and genres each using Picard -

D11826: Simplify Term operator&& and ||

bruns updated this revision to Diff 31581. bruns added a comment. rebased REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11826?vs=31541=31581 BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 AFFECTED FILES

D12005: Fix merging of terms in the AdvancedQueryParser

bruns updated this revision to Diff 31585. bruns added a comment. rebased REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12005?vs=31543=31585 BRANCH baloo_term_cleanup_2 REVISION DETAIL https://phabricator.kde.org/D12005 AFFECTED FILES

D12006: Make list of subterms in debug output easier to spot

This revision was automatically updated to reflect the committed changes. Closed by commit R293:04f972a7f551: Make list of subterms in debug output easier to spot (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12006?vs=31546=31586 REVISION

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 60 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/60/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 11:20:18 + Build duration: 17 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/29/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 11:20:18 + Build duration: 26 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/59/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 10:35:42 + Build duration: 1 hr 25 min and counting JUnit Tests Name: (root)

D12028: taglibextractortest: Add test for files with empty metadata

michaelh created this revision. michaelh added reviewers: mgallien, Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Indicates a bug in `kfilemetadata` delivering genre property when genre has no value.

D12029: taglibextractor: Fix empty genre bug

michaelh created this revision. michaelh added reviewers: mgallien, Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Depends on D12028 TEST PLAN make test REPOSITORY

D12028: taglibextractortest: Add test for files with empty metadata

michaelh added a dependent revision: D12029: taglibextractor: Fix empty genre bug. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks Cc: astippich, ashaposhnikov, michaelh, spoorun, ngraham, bruns, alexeymin

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

dfaure added a comment. This calls for unittests. UndoManager has unittests here in kio, but if this requires kio_desktop then the test needs to be where kio_desktop is. INLINE COMMENTS > copyjob.cpp:2095 > ++m_processedFiles; > -emit q->copyingDone(q, *m_currentStatSrc, >

D12014: [kcoreaddons] convert to new connect syntax

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D12014 To: jtamate, dfaure Cc: #frameworks, michaelh, ngraham, bruns

D11183: Sonnet: don't impose the default client

This revision was automatically updated to reflect the committed changes. Closed by commit R246:e63a234d55d9: Dont impose using the default client (authored by rjvbb). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11183?vs=31594=31608 REVISION DETAIL

D12025: Terminate query execution early if subterm returns empty result set

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Leaf queries may return an empty result set, which is

D11828: Simplify orPostingIterator and make it faster

bruns updated this revision to Diff 31623. bruns added a reviewer: michaelh. bruns added a comment. cleanup REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11828?vs=31008=31623 BRANCH speedup_orpostingoperator REVISION DETAIL

D10702: Always use a job to delete files to avoid freezing process waiting on IO

dfaure added a comment. s/thread/process/. It's not about threads it's about two processes: the (GUI) application, and the kioslave. But you present all this in a rather convoluted way, it's much simpler. The SimpleJob for asking a kioslave to delete a file is KIO::file_delete which

D10803: handle more tags in taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, spoorun, bruns,

D10803: handle more tags in taglibextractor

astippich added a comment. @mgallien this should be safe to land now since KF 5.45 has been tagged, right? REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham, michaelh Cc: vhanda, dfaure, michaelh,

D11183: Sonnet: don't impose the default client

rjvbb updated this revision to Diff 31594. rjvbb added a comment. Unnecessary rebump, pardon, rebase. What's holding this up? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11183?vs=30657=31594 REVISION DETAIL https://phabricator.kde.org/D11183 AFFECTED FILES

D11183: Sonnet: don't impose the default client

rjvbb set the repository for this revision to R246 Sonnet. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

D11183: Sonnet: don't impose the default client

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause Cc: mwolff, kde-frameworks-devel, michaelh, ngraham, bruns

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Right now, the Breeze icon for "Configure" is sub-optimal

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. Phabricator is //really// bad at showing file changes that involve symlinks (specifically, turning a file into a symlink), so for code-oriented people, here's the little shell script I used to produce these changes: cd repos/breeze-icons for DIR in

D11982: Use statbuf consistently

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. This obviously needs some cleanup, but this should not hold up this request ... We should check if instead of replicating the code in the individual ioslaves we could push the

D10803: handle more tags in taglibextractor

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibextractortest.cpp:82 > Hmm, I disagree since they are simple and they don't leave room for ambiguity Maybe just add a Prefix or Suffix for all QStrings? Same applies to any Int values, you can never tell if the right

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12034 To: ngraham, #vdg, #plasma Cc: sharvey, #frameworks, michaelh, ngraham, bruns

D12037: Immediately apply termInConstruction when term is complete

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Term::Or and Term::And delimit the term in

D12037: Immediately apply termInConstruction when term is complete

bruns added dependencies: D11888: Handle adjacent special characters correctly, D12007: Add test case for parsing of double opening '(('. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12037 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh,

D11888: Handle adjacent special characters correctly

bruns added a dependent revision: D12037: Immediately apply termInConstruction when term is complete. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D12007: Add test case for parsing of double opening '(('

bruns added a dependent revision: D12037: Immediately apply termInConstruction when term is complete. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D11888: Handle adjacent special characters correctly

bruns removed a task: T3: Add string "Your system default" to translation. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12037: Immediately apply termInConstruction when term is complete

bruns removed a task: T2: sudoku activity string must be changed: ". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12037 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

KDE CI: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.10 - Build # 9 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsMSVCQt5.10/9/ Project: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 08 Apr 2018 02:26:08 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 190 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/190/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 08 Apr 2018 03:29:53 + Build duration: 1 hr 11 min and counting JUnit Tests Name:

D12007: Add test case for parsing of double opening '(('

bruns updated this revision to Diff 31634. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12007?vs=31547=31634 BRANCH b#392620_unittest REVISION DETAIL https://phabricator.kde.org/D12007 AFFECTED FILES autotests/unit/lib/advancedqueryparsertest.cpp To:

D12007: Add test case for parsing of double opening '(('

bruns marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

  1   2   >