D12228: kdirlister new connect syntax

jtamate updated this revision to Diff 32663. jtamate added a comment. Removed comment. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12228?vs=32661=32663 REVISION DETAIL https://phabricator.kde.org/D12228 AFFECTED FILES src/core/kcoredirlister.cpp

D12130: Use the more user-friendly string "File type" in the save dialogs

rkflx added a comment. In D12130#245921 , @ngraham wrote: > I might need some help with this. It seems that the apps whose save dialogs show a combobox in place of a filter list are creating a `QDialog` and setting the Mime types list with

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

rkflx added a comment. Sorry, I don't really get what you mean. I'm not proposing going back to KDE3, Nate is proposing going back to the KDE3 design! (In KDE4 this was improved to what we have in KF5, FYI.) Also, I don't see where you get from that I'm proposing to follow any "law"? Not

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. In general it's okay to display nerdy technical information hidden away like this--as long as it's actually useful information! That's the real question. If it's of no real value to anyone for any use case that we can imaging, we can probably safely remove it.

D12228: kdirlister new connect syntax

dfaure added inline comments. INLINE COMMENTS > kcoredirlister.cpp:525 > qCDebug(KIO_CORE_DIRLISTER) << "Iterating over dirs" << lstDirsCopy; > +// JTA: FIXME: Entonces puede estar aquí el problema > for (QList::const_iterator it = lstDirsCopy.begin(); This should probably not

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32657. anemeth added a comment. Remove accidental left in change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32655=32657 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL

D12228: kdirlister new connect syntax

jtamate updated this revision to Diff 32656. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Change the first connect. No need to change the name of the slot. Pass the plain error message. REPOSITORY R241 KIO CHANGES

D11155: handle zip files embedded within zip files

dfaure added a comment. ping? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: #frameworks, michaelh, bruns

D12371: fix always reproducible crash

jtamate added a comment. More investigation, in bold what causes the problem. moveListersWithoutCachedItemsJob append KDirLister(0x3b510c70) to holders for url= QUrl("file:///virtual/kde5/5kde/build/frameworks/kio") forgetDirs removeAll in directoryData[

D12311: Align lock icon with bold message text; reduce overall size of dialog

ltoscano added a comment. Do you really want to remove the proper source of information in security dialog that asks you some additional credentials? Please keep it there. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32671. anemeth added a comment. @ngraham good advice Smooth scale the fast downscaled image for good performance REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32657=32671 BRANCH image_smooth_downscale

D12388: Output device color curves correction

romangg created this revision. romangg added a reviewer: Frameworks. Restricted Application added a project: Frameworks. romangg requested review of this revision. REVISION SUMMARY Extends the output device and output configuration interfaces with the ability to query and set the RGB color

D12385: Thumbnail smooth scaling in filepicker

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth planned changes to this revision. anemeth added a comment. In D12385#250511 , @broulik wrote: > What's the performance penalty of that? Does the file dialog request the correct size from the preview job? It shouldn't have to end up in

D12251: Integrate with androiddeployqt dependencies files

aacid added a comment. threre's not so many unneded stuff in there to be honest, maybe kross, kate and the emoticonthemes, but doesn't seem terrible. One would improve that by not depending on the whole kf5umbrella probably? REPOSITORY R306 KParts REVISION DETAIL

D12385: Thumbnail smooth scaling in filepicker

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL

D12385: Thumbnail smooth scaling in filepicker

broulik added a comment. What's the performance penalty of that? Does the file dialog request the correct size from the preview job? It shouldn't have to end up in this codepath that often, I //think//. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To:

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham added a comment. In D12130#250476 , @rkflx wrote: > In D12130#245921 , @ngraham wrote: > > > I might need some help with this. It seems that the apps whose save dialogs show a combobox in

D12385: Thumbnail smooth scaling in filepicker

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: #frameworks, michaelh, bruns

D12228: kdirlister new connect syntax

jtamate updated this revision to Diff 32661. jtamate added a comment. Removed Q_PRIVATE_SLOT. Didn't saw them again. :-( REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12228?vs=32658=32661 REVISION DETAIL https://phabricator.kde.org/D12228 AFFECTED FILES

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. Could we use the fast scaling while resizing, then change to the smooth scaling once the resize operation is done? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: broulik, ngraham, #frameworks, michaelh,

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. Reviewers: as part of my task to redesign and tidy up this dialog box, I'm considering removing the Details button in the bottom left corner, along with the small pop-open panel that shows additional information. My argument is that the info in the Details panel is

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32672. anemeth added a comment. Remove debug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32671=32672 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham added a comment. In D12333#250475 , @rkflx wrote: > Sorry, I don't really get what you mean. I'm not proposing going back to KDE3, Nate is proposing going back to the KDE3 design! (In KDE4 this was improved to what we have in KF5, FYI.)

D12384: Fix double margins around DownloadDialog

kossebau created this revision. kossebau added a reviewer: leinir. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REPOSITORY R304 KNewStuff BRANCH fixextramarginarounddownladdialog

D12228: kdirlister new connect syntax

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good, but shouldn't you remove the Q_PRIVATE_SLOT declarations too? They aren't used anymore, AFAICS. INLINE COMMENTS > kcoredirlister.cpp:2720 > +

D12385: Thumbnail smooth scaling in filepicker

anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12371: fix always reproducible crash

dfaure requested changes to this revision. dfaure added a comment. I find this solution horrible. QPointers screams "we designed this wrongly, the ownership rules are unclear, stuff gets deleted randomly, we have to guard against it". So while I don't deny that we might have designed

D12228: kdirlister new connect syntax

jtamate updated this revision to Diff 32658. jtamate added a comment. Added space. Removed SLOT. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12228?vs=32656=32658 REVISION DETAIL https://phabricator.kde.org/D12228 AFFECTED FILES

D12228: kdirlister new connect syntax

dfaure added a comment. I meant this stuff: src/core/kcoredirlister.h:Q_PRIVATE_SLOT(d, void _k_slotPercent(KJob *, unsigned long)) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12228 To: jtamate, dfaure, #frameworks Cc: michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. If you really want to save some space (and probably make it easier for users to understand the dialog without getting lost), I think the whole > An application is attempting to perform an action that requires privileges. > Authentication is required to perform

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. Its not available otherwise ... REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns,

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. I too cannot reproduce the performance issue, even after nuking `~/.cache/thumbnails` and having it regenerate the thumbnails. Can you, @cfeck? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: cfeck,

D12385: Thumbnail smooth scaling in filepicker

cfeck added a comment. The XDG thumbnail spec has two thumbnail sizes, 128 and 256. It is possible that you hit the "slow" issue when only one size of thumbnail had been created, but the other was still pending. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385

D12389: Filepicker reads thumbs preview from Dolphin settings

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg Cc: ngraham,

D12228: kdirlister new connect syntax

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12228 To: jtamate, dfaure, #frameworks Cc: michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. The "Authentication is required to ..." header line is directly sourced from the action definition below `/usr/share/polkit-1/actions/*` "Administrator password" is insufficient/wrong, as you can also (dependent on system configuration) authorize the actions as

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a subscriber: stikonas. sharvey added a comment. Semi-related bug from @stikonas, while I'm on dialog duty: https://bugs.kde.org/show_bug.cgi?id=393355 REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. Hmm, I was actually leaning the other way. Ditch the generic boilerplate and keep the app-specific text. I think it's helpful when the dialog tells you why it appeared and what app/function is requesting your password. REPOSITORY R121 Policykit (Polkit) KDE Agent

D12388: Output device color curves correction

zzag added inline comments. INLINE COMMENTS > outputconfiguration.cpp:184 > +uint16_t *s = reinterpret_cast(wl_array_add(dest, > sizeof(uint16_t))); > +*s = (uint16_t)c; > +} Maybe `static_cast`? I haven't used wl_array but can't you allocate big

D12311: Align lock icon with bold message text; reduce overall size of dialog

abetts added a comment. In D12311#250637 , @bruns wrote: > If you really want to save some space (and probably make it easier for users to understand the dialog without getting lost), I think the whole > > > An application is attempting to

D12388: Output device color curves correction

cfeck added inline comments. INLINE COMMENTS > outputconfiguration.h:211 > + */ > +void setColorCurves(OutputDevice *outputdevice, QVector red, > QVector green, QVector blue); > + The documentation could state how many elements need to be in the vectors. Ideally, every component could

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. BTW I don't know what caused the performance issue when moving the slider before, maybe something heavy was running in the background, but I can't reproduce the problem anymore. F5815440: 2018-04-20 21-45-19.webm

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. Btw, an easy way to trigger the dialog is e.g. $> pkcheck -u -p $$ -a org.freedesktop.udisks2.eject-media-system $$ is the PID of the shell. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#250660 , @bruns wrote: > No, thats completely off, as thats the action you are authorizing. > > > Authorization is required to format disk WDC WD10EZEX-08M2NA0 > > I want it to show what it is asking

D12389: Filepicker reads thumbs preview from Dolphin settings

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12311: Align lock icon with bold message text; reduce overall size of dialog

ngraham added a comment. So right now, we have two strings of text: - The top bold string comes from the app and differs on a per-app basis - The bottom long boilerplate string is from us, and shown all the time I like @abetts' idea: we should remove the app-specific text and make

D12311: Align lock icon with bold message text; reduce overall size of dialog

ltoscano added a comment. In D12311#250660 , @bruns wrote: > No, thats completely off, as thats the action you are authorizing. > > > Authorization is required to format disk WDC WD10EZEX-08M2NA0 > > I want it to show what it is asking

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. Gnome-disks does, and so do other programs. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas,

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32675. anemeth added a comment. Remove debug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32674=32675 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32674. anemeth added a comment. Revert resize change. Turns out the image we got here is already downsized to around 128x128 and we further downsize it (if needed), dependent on the icon size. Working with this small images the smooth scaling

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. No, thats completely off, as thats the action you are authorizing. > Authorization is required to format disk WDC WD10EZEX-08M2NA0 I want it to show what it is asking permission for, and to be specific - does it want to format the USB stick I just inserted, or

D11155: handle zip files embedded within zip files

ngraham added a comment. Does this resolve https://bugs.kde.org/show_bug.cgi?id=73821? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

anemeth updated this revision to Diff 32680. anemeth added a comment. Revert centered icons when there is only one column, fix comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12306?vs=32614=32680 BRANCH grid_layout (branched from master) REVISION

D12389: Filepicker reads thumbs preview from Dolphin settings

ngraham accepted this revision. ngraham added a reviewer: Dolphin. ngraham added a comment. This revision is now accepted and ready to land. Wow, a truly trivial fix! Since Dolphin is currently where the config UI for this lives, I think it makes sense to re-use that information here. I

D12389: Filepicker reads thumbs preview from Dolphin settings

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH dolphin_thumbs (branched from master) REVISION DETAIL

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. The small-text boilerplate is definitely on the chopping block. @ltoscano makes a fine case for keeping the Details section. @bruns - Thanks for helping me find the source of the incoming messages. I hadn't gotten around to searching for them yet, but you saved

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/76/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 21 Apr 2018 00:01:54 + Build duration: 6 min 58 sec and counting JUnit Tests

D12392: Fix the "Default" color scheme to match Breeze again

ngraham edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: #frameworks, michaelh, bruns

D12392: Fix the "Default" color scheme to match Breeze again

ngraham edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D12392 To: ngraham, #breeze, #plasma, hein Cc: #frameworks, michaelh, bruns

D12392: Fix the "Default" color scheme to match Breeze again

ngraham created this revision. ngraham added reviewers: Breeze, Plasma, hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Over the years, the "Default" color scheem seems

D12389: Filepicker reads thumbs preview from Dolphin settings

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO BRANCH dolphin_thumbs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/59/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 21 Apr 2018 00:01:54 + Build duration: 3 min 40 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/20/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 21 Apr 2018 00:01:54 + Build duration: 8 min 59 sec and counting JUnit Tests

D12306: Filepicker dialog proper grid icon layout

ngraham added a comment. Ooh, centering when there's only one column is a nice touch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

abetts added a comment. +1 In D12333#250266 , @rkflx wrote: > In D12333#250194 , @abetts wrote: > > > I gave a +1 to the original idea because I feel that there isn't really much closeness that

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.10/10/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 Date of build: Fri, 20 Apr 2018 06:16:49 + Build duration: 3 min 6 sec and counting

[kcoreaddons] src/lib: Revert "Warning--"

Git commit bf353edc42fdecf9fda34a024ba7cabcd0efaf68 by Ben Cooksley. Committed on 20/04/2018 at 08:47. Pushed by bcooksley into branch 'master'. Revert "Warning--" The changes in these commits fail on all platforms aside from Linux, breaking the FreeBSD, Android and Windows builds. CCMAIL:

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 20 Apr 2018 08:49:45 + Build duration: 8 min 27 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Fri, 20 Apr 2018 08:49:45 + Build duration: 8 min 41 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/75/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 20 Apr 2018 08:49:45 + Build duration: 6 min 11 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 AndroidQt5.10 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.10/11/ Project: Frameworks kcoreaddons kf5-qt5 AndroidQt5.10 Date of build: Fri, 20 Apr 2018 08:49:45 + Build duration: 1 min 3 sec and counting

D12371: fix always reproducible crash

apol added inline comments. INLINE COMMENTS > kdirmodel.cpp:401 > { > +// dirLister is probably onwed by KCoreDirListerCache > if (d->m_dirLister) { Maybe KCoreDirListerCache should be using a QPointer? or checking if it gets deleted? > kdirmodel.h:65 > */ > +// Can't take

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

rkflx added a comment. In D12333#250194 , @abetts wrote: > I gave a +1 to the original idea because I feel that there isn't really much closeness that you can achieve with the open dialog. It is simple, straightforward. I find the

D12371: fix always reproducible crash

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Don't take ownership of KDirLister in KDirModel. When KDirModel is destroyed, it also deleted the

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 58 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/58/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 20 Apr 2018 08:49:45 + Build duration: 3 min 11 sec and counting JUnit

D12378: Properly search for NetworkManager

jgrulich added a reviewer: Frameworks. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D12378 To: jgrulich, #frameworks Cc: #frameworks, michaelh, bruns

D12378: Properly search for NetworkManager

jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jgrulich requested review of this revision. REVISION SUMMARY Make use of CMake module from nm-qt to search for libnm (NetworkManager library) instead of

D12371: fix always reproducible crash

jtamate updated this revision to Diff 32640. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Implemented as Aleix suggested, using QPointer. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Fri, 20 Apr 2018 11:43:37 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/41/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Fri, 20 Apr 2018 11:43:37 + Build duration: 17 min and counting JUnit

D12379: [Containment Interface] Don't enter edit mode when immutable

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY Opening the toolbox when widgets are locked reveals the widget

D12371: fix always reproducible crash

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. ^^' this won't work though. If the object gets deleted you will get a null pointer in the list. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12371 To:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 224 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ java.io.IOException: remote file operation failed:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 73 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ java.io.IOException: remote file operation failed:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/135/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 20 Apr 2018 10:44:02 + Build duration: 4 min 29 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/36/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 20 Apr 2018 11:43:37 + Build duration: 3 min 5 sec and counting

D12339: [KUrlNavigatorButton] Also don't stat MTP

This revision was automatically updated to reflect the committed changes. Closed by commit R241:73d2036b09a9: [KUrlNavigatorButton] Also dont stat MTP (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12339?vs=32536=32633 REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/110/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 20 Apr 2018 10:44:02 + Build duration: 2 min 50 sec and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 203 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/203/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 20 Apr 2018 09:52:56 + Build duration: 6 min 32 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 74 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/74/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 20 Apr 2018 09:59:20 + Build duration: 5 min 19 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 225 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/225/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 20 Apr 2018 09:59:16 + Build duration: 24 min and counting JUnit Tests Name: (root)

D12378: Properly search for NetworkManager

jgrulich edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D12378 To: jgrulich, #frameworks Cc: #frameworks, michaelh, bruns

D12378: Properly search for NetworkManager

jgrulich edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D12378 To: jgrulich, #frameworks Cc: #frameworks, michaelh, bruns

D12371: fix always reproducible crash

jtamate added a comment. In D12371#250366 , @apol wrote: > ^^' this won't work though. If the object gets deleted you will get a null pointer in the list. If the QPointer kdl detects that the guarded pointer is invalid it is removed

D12233: Avoid manipulation of lists with quadratic complexity

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jtamate wrote in pendingfilequeue.cpp:68 > According to std::partition > > what matches isDescendant

D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

broulik updated this revision to Diff 32644. broulik added a comment. - Also reject `QMouseEvent` REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12380?vs=32643=32644 REVISION DETAIL https://phabricator.kde.org/D12380 AFFECTED FILES

D12380: [Containment Interface] Honor plasma/containment_context_menu restriction

broulik created this revision. broulik added reviewers: Plasma, sitter. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY Allows disabling context menus. This got lost in the

  1   2   >