D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

ngraham added reviewers: Frameworks, Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin Cc: meven, ltoscano, #frameworks, michaelh, bruns

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

ngraham marked an inline comment as done. ngraham added a comment. I took a crack at accessing `statx` directly, but I'm waay out of my depth here and will need some help making this actually work. There doesn't seem to be a glibc wrapper for `statx` yet, so we have to access it

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it" to "[WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available". ngraham edited the summary of this revision. ngraham edited the test plan for this

D7423: Populate UDS_CREATION_TIME on Linux if Qt and kernel versions support it

ngraham updated this revision to Diff 32762. ngraham added a comment. Attempt so far unsuccessfully to use statx directly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7423?vs=21871=32762 BRANCH arcpatch-D7423 REVISION DETAIL

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 03:39:28 + Build duration: 20 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Apr 2018 03:39:28 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 205 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/205/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 03:38:53 + Build duration: 4 min 57 sec and counting JUnit Tests Name:

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. FYI: I undid the wonky manual UI sizing that @broulik objected to. In hindsight, not the best approach. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey,

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey added a comment. Okay, this patch is back to where we started, with nothing changed except centering the icon. Hopefully we can commit it now. I'll move the discussion over how to redesign the dialog itself to a separate task. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH

D12311: Align lock icon with bold message text; reduce overall size of dialog

sharvey updated this revision to Diff 32758. sharvey added a comment. - Merge branch 'master' into align-lock-icon - Undo manual resizing of ser combo box & password error box REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

D12424: Install pri file for qmake support & document it in metainfo.yaml

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH installprifile REVISION DETAIL https://phabricator.kde.org/D12424 To: kossebau, #build_system, lbeltrame Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun,

D12423: Install pri file for qmake support & document it in metainfo.yaml

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH installprifile REVISION DETAIL https://phabricator.kde.org/D12423 To: kossebau, #build_system, lbeltrame Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12423: Install pri file for qmake support & document it in metainfo.yaml

kossebau added a dependency: D12424: Install pri file for qmake support & document it in metainfo.yaml. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12423 To: kossebau, #build_system Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12424: Install pri file for qmake support & document it in metainfo.yaml

kossebau added a dependent revision: D12423: Install pri file for qmake support & document it in metainfo.yaml. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12424 To: kossebau, #build_system Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12424: Install pri file for qmake support & document it in metainfo.yaml

kossebau created this revision. kossebau added a reviewer: Build System. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Allows to use KFileMetaDataBaloo in qmake-based

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham updated this revision to Diff 32748. ngraham added a comment. Move the warnings to their own line so they're not missed, and also to improve the presentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12420?vs=32732=32748 BRANCH

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D12422 To: ngraham, #frameworks, #dolphin Cc: michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham updated this revision to Diff 32747. ngraham added a comment. Move the warnings to their own line so they're not missed, and also to improve the presentation CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12422?vs=32742=32747 BRANCH

D12423: Install pri file for qmake support & document it in metainfo.yaml

kossebau created this revision. kossebau added a reviewer: Build System. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Allows to use Baloo in qmake-based projects with

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham added a dependent revision: D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham set the repository for this revision to R241 KIO. ngraham added a dependency: D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility. Restricted

D12422: Use a regular dialog rather than a list dialog when trashing or deleting a single file

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin. ngraham requested review of this revision. REVISION SUMMARY This patch uses a regular-style dialog instead of a list-style dialog when the user is trying to trash or delete only a single item. It looks a bit nicer

D10980: updated hanle icon

ngraham added a comment. I really don't like that icon at all, I'm afraid. It has no meaning to me. It doesn't suggest directionality, movement, or dragging. How about something more like this: F5816766: arrow.png REPOSITORY R266 Breeze

D10980: updated hanle icon

mart added a comment. F5816754: Screenshot_20180421_214512.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10980 To: andreask, mart Cc: ngraham, #frameworks, michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, elvisangelaccio. Restricted Application added a project: Frameworks. ngraham requested review of this revision. TEST PLAN [image goes here] REPOSITORY R241 KIO BRANCH more-serious-delete-text (branched from

D12306: Filepicker dialog proper grid icon layout

ngraham added a comment. Me too. Let's not let the perfect be the enemy of the good here. @rkflx, are you satisfied with this now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: abetts, rkflx, ngraham,

D11828: Simplify orPostingIterator and make it faster

bruns marked 8 inline comments as done. bruns added inline comments. INLINE COMMENTS > michaelh wrote in orpostingiterator.cpp:28 > `, m_nextId(ULONG_LONG_MAX)` ? Currently the only reserved value is `0`, and I prefer to keep it as is. REPOSITORY R293 Baloo REVISION DETAIL

D10075: Make pacakge usefull for cross compilation

knauss added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:45 > the 3rd parameter is a bool. This change won't do what you expect. > > (https://cmake.org/cmake/help/v3.0/command/option.html) well it compiles like I expected it... but yeah I see this is a bug not a

D12306: Filepicker dialog proper grid icon layout

anemeth added a comment. The same thing with the scrollbar area constantly reserved can be reproduced on Windows in a standalone Qt app using QListView, so it is definitely a Qt issue. It could be fixed by creating a new widget for this, but I'm not up for that task. F5816535:

D12384: Fix double margins around DownloadDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R304:25b78145d247: Fix double margins around DownloadDialog (authored by kossebau). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12384?vs=32653=32722 REVISION

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/60/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 21 Apr 2018 15:16:36 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/77/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 21 Apr 2018 15:16:36 + Build duration: 6 min 27 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/21/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 21 Apr 2018 15:16:36 + Build duration: 3 min 9 sec and counting JUnit Tests

D7929: [WIP] Add new Column View option to KDirOperator

ngraham added a comment. Ah, what a shame. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

fvogt abandoned this revision. fvogt added a comment. In D7929#251013 , @ngraham wrote: > We're doing a UI and usability overhaul of the Open & Save dialogs in T8552: Polish Open/Save dialogs , and I think

D12384: Fix double margins around DownloadDialog

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fixextramarginarounddownladdialog REVISION DETAIL https://phabricator.kde.org/D12384 To: kossebau, leinir, davidedmundson Cc: #frameworks, michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: dfaure, cfeck, dhaumann, ngraham, elvisangelaccio, lbeltrame, #frameworks, michaelh, bruns

D7929: [WIP] Add new Column View option to KDirOperator

ngraham added a comment. We're doing a UI and usability overhaul of the Open & Save dialogs in T8552: Polish Open/Save dialogs , and I think perhaps we should revisit this. I'm very strongly in favor of adding column-based navigation to both `KDirOperator`

D12327: Show Detailed Tree View by default

ngraham added a comment. In D12327#250944 , @rkflx wrote: > In D12327#250911 , @ngraham wrote: > > > In fact, if we integrated the Up button into the `KURLNavigator` widget, it would solve some

D12327: Show Detailed Tree View by default

rkflx added a comment. In D12327#250911 , @ngraham wrote: > In fact, if we integrated the Up button into the `KURLNavigator` widget, it would solve some issues automatically (e.g. lack of up button in Gwenview). I could see some people

D12389: Filepicker reads thumbs preview from Dolphin settings

ngraham added a comment. In D12389#250931 , @alexeymin wrote: > Stupid question, what happens if dolphin is not installed? I answered that in the comment above yours. :) KConfig seems to handle it without issue. But test it out and see

D12389: Filepicker reads thumbs preview from Dolphin settings

alexeymin added a comment. Stupid question, what happens if dolphin is not installed? REPOSITORY R241 KIO BRANCH dolphin_thumbs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg, ngraham, #dolphin Cc: alexeymin, ngraham,

D12327: Show Detailed Tree View by default

ngraham added a comment. In D12327#250898 , @rkflx wrote: > In D12327#250864 , @ngraham wrote: > > > - Bandwagon: Windows and macOS's default details style views allow expansion by default too >

D12327: Show Detailed Tree View by default

rkflx added a comment. In D12327#250864 , @ngraham wrote: > - Bandwagon: Windows and macOS's default details style views allow expansion by default too I'm all for going tree-style, but honestly I don't see expansion in Windows? Are we

D12385: Thumbnail smooth scaling in filepicker

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Definitely a visual improvement! Let's wait for a few more opinions regarding whether this is the right approach technically. REPOSITORY R241 KIO BRANCH image_smooth_downscale

D12327: Show Detailed Tree View by default

ngraham added a comment. Or, a compromise: If we wanted to go all the way and have Dolphin-style options (Icons View, Compact view, Detailed view), I could support that for consistency's sake as long as we have three buttons like Dolphin does, rather than a combobox or a drop-down menu.

D12327: Show Detailed Tree View by default

ngraham added a comment. Reasons to change the default to Detailed View or Detailed Tree View: - Ergonomics: the current default requires side-scrolling for long lists, which is almost never ideal - Usefulness: by showing the details columns by default (which also makes sorting more

D12327: Show Detailed Tree View by default

rkflx added a comment. One more idea: We could go all the way to a Windows style file dialog, i.e. use a single button to switch views, which has //all// options in it: - Short View > Next to Filename (needs new name) - Short View > Above to Filename (needs new name) - Detailed View

D12327: Show Detailed Tree View by default

rkflx added a comment. In D12327#250797 , @elvisangelaccio wrote: > But Detailed View and Detailed Tree View are two different things, no? (I'm not even sure Windows supports the latter) That's correct, Windows does not support the

D12327: Show Detailed Tree View by default

elvisangelaccio added a comment. In D12327#250786 , @rkflx wrote: > In D12327#250761 , @elvisangelaccio wrote: > > > I'm not sure I agree with this change > > > At least it's not a -1 yet, so

D12342: Update CMakeLists.txt

elvisangelaccio removed a reviewer: Frameworks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D12342 To: michaelh, #baloo, #dolphin, elvisangelaccio, #frameworks Cc: ashaposhnikov, astippich, spoorun

D12342: Update CMakeLists.txt

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > michaelh wrote in CMakeLists.txt:4 > There is not indication that `baloo-widgets` is an Application. Yet it > resides in the

D12327: Show Detailed Tree View by default

rkflx added a comment. In D12327#250761 , @elvisangelaccio wrote: > I'm not sure I agree with this change At least it's not a -1 yet, so maybe we can convince you once everything is in place…!? > afaik Windows does not show the

D12327: Show Detailed Tree View by default

elvisangelaccio added a comment. I'm not sure I agree with this change, and afaik Windows does not show the tree view by default in its file dialogs (unless you are referring to `FolderBrowserDialog` from .Net) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To:

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. I hit the resizing performance issue without this patch too, so it's unrelated to this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 204 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/204/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 21 Apr 2018 07:14:05 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 226 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/226/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 21 Apr 2018 07:14:05 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/75/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 21 Apr 2018 07:14:05 + Build duration: 7 min 3 sec and counting JUnit Tests Name: (root)

D12228: kdirlister new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ee0a0f1ef323: kdirlister new connect syntax (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12228?vs=32663=32686#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#250688 , @bruns wrote: > Gnome-disks does, and so do other programs. Gnome-disks uses UDisks to do everything and can't do anything on its own. So available features are very limited (not even resizing

D12306: Filepicker dialog proper grid icon layout

rkflx added a comment. In D12306#250724 , @ngraham wrote: > Ooh, centering when there's only one column is a nice touch. Not sure what you mean? The whole patch is about centering everything, that's still happening obviously. The revert