KDE CI: Frameworks kcompletion kf5-qt5 FreeBSDQt5.10 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kcompletion kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 22 May 2018 11:49:13 + Build duration: 1 min 27 sec and counting JUnit

D11925: Add "SkipSwitcher" to API

sharvey updated this revision to Diff 34636. sharvey added a comment. - Increate interface versions for PlasmaShell and PlasmaWindowManagement REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=32996=34636 BRANCH arcpatch-D11925 REVISION DETAIL

D12992: New elisa icon

alex-l added a comment. F5863162: image.png ^ I'm for this one without the quaver F5862923: image.png ^ or this one with white symbol REPOSITORY R266 Breeze Icons REVISION DETAIL

D12896: Add Telegram plugin

nicolasfella added a comment. I've played around with flatpaked Telegram and made it working. However: My Telegram.desktop file executes this: /usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -- @@u %u @@ I can share a

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

davidedmundson added a comment. This doesn't make sense (assuming everything else works correctly, which clearly isn't the case) registry->setup(); connection->roundtrip(); should mean the server will announce all the interfaces and we block all execution until we've

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

romangg added a comment. In D13037#266379 , @davidedmundson wrote: > should mean the server will announce all the interfaces and we block all execution until we've processed it all. DialogShadows is created as Q_GLOBAL_STATIC. Maybe

D13033: Expose getter method for KConfig::addConfigSources

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Used in subsequent patch REPOSITORY R237 KConfig REVISION DETAIL

D13032: Fix cleanup of kconfigtest kdeglobals

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We expand the path of kdeglobals to

D13034: Add mechanism to notify other clients of config changes over DBus

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Intention is not to create a registry like system, but to replace

D11235: [DrKonqi] Request change of ptrace scope from KCrash

adridg added a comment. Comments directed at licensing and non-Linux cases. INLINE COMMENTS > queryptrace.cpp:1 > +#include > + Missing file header / license bits > queryptrace.cpp:49 > + > +#endif For non-Linuxen, include a null implementation here. > queryptrace.h:1 > +#ifndef

D11235: [DrKonqi] Request change of ptrace scope from KCrash

maximilianocuria added inline comments. INLINE COMMENTS > queryptrace.cpp:26 > +server.sun_family = AF_UNIX; > +sprintf(server.sun_path, "/tmp/kcrash_%lld", > QCoreApplication::applicationPid()); > +if (::connect(sfd, (struct sockaddr *), sl) == 0) { Please honour TMPDIR or, even

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Dialog might try to set PlasmaShellSurface before

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

romangg added a task: T8771: PlasmaQuick::Dialog and/or KWin (internal window) problems. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11925: Add "SkipSwitcher" to API

sharvey added a comment. In D11925#265446 , @graesslin wrote: > any update on this? It's just the version increase in registry.cpp which is missing... Done. I was unclear as to what needed to change. I got a little outside help from

D13034: Add mechanism to notify other clients of config changes over DBus

zzag added inline comments. INLINE COMMENTS > kconfig.cpp:526 > +QDBusConnection::sessionBus().send(message); > +#endif > +} #else Q_UNUSED(changes); Q_UNUSED(path); #endif > kconfigwatcher.cpp:82 > +KConfigGroup group = d->m_config->group(QString());//top level group > +

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/24/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Tue, 22 May 2018 14:17:03 + Build duration: 2 min 32 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 22 May 2018 14:17:04 + Build duration: 2 min 25 sec and counting

D11925: Add "SkipSwitcher" to API

This revision was automatically updated to reflect the committed changes. Closed by commit R127:10b00a219e9f: Add SkipSwitcher to API (authored by sharvey). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=34636=34654 REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 22 May 2018 15:28:04 + Build duration: 9 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 22 May 2018 15:28:04 + Build duration: 11 min and counting JUnit Tests

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. ok it should work now. REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo Cc: maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34644. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34581=34644 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc: maximilianocuria, elvisangelaccio,

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34645. renatoo added a comment. Fixed all tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34644=34645 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc:

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 22 May 2018 13:50:03 + Build duration: 2 min 55 sec and counting

D12992: New elisa icon

ngraham added a subscriber: mgallien. ngraham added a comment. Let's make sure that @mgallien has a say as well. It's for his app, after all! :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: mgallien, alex-l,

D12858: [KCharSelect] Fix table cell size

This revision was automatically updated to reflect the committed changes. Closed by commit R236:43d23824a94c: [KCharSelect] Fix table cell size with Qt 5.11 (authored by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12858?vs=34516=34649

D11925: Add "SkipSwitcher" to API

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. wonderful! Thanks to you two :-) And yes as soon as you push this change you can push the kwin change. REPOSITORY R127 KWayland BRANCH arcpatch-D11925 REVISION DETAIL

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34646. renatoo added a comment. Fixed code style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34645=34646 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc:

D13037: [Dialog] Set PlasmaShellSurface on PlasmaShell being announced

graesslin added a comment. I wouldn't change plasmaquick based on KWin's behavior. KWin is weird after all. We should rather work around inside KWin. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13037 To: romangg, #plasma Cc: graesslin,

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr added a comment. Restricted Application added a subscriber: kde-frameworks-devel. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13043: Properly sanitize input

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Helps to use it together with ModelTest REPOSITORY R275

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham planned changes to this revision. ngraham added a comment. Hmm, that makes sense. OK, I'll re-work this. The problem here is that if we want to fix 356045, there's no getting around reading a `.directory` file as part of this process, but maybe I can narrowly conditionalize it

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 34672. croick added a comment. Restricted Application added a subscriber: kde-frameworks-devel. - use `QDir::tempPath()` REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=31244=34672 BRANCH ptracer REVISION

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

apol added inline comments. INLINE COMMENTS > global.cpp:332 > +KIO::StatJob *job = KIO::stat(url); > +job->exec(); > +KIO::UDSEntry entry = job->statResult(); having a blocking stat isn't good. stat will take a while on some protocols and it's not even all that quick on local file

D12156: implement reading of rating tag

mgallien added a subscriber: cgilles. mgallien added a comment. @cgilles Are you somehow using KFileMetaData (seems correct if one looks at the Debian package dependencies) ? This diff is about adding a way to read ratings from "tags" native to a specific file format. This would be in

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

ngraham added a comment. @lshoravi are you willing and able to address the above-mentioned issues, or should someone else comandeer the revision and do it themselves? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma,

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34666. renatoo added a comment. Run tests in an empty home dir CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34646=34666 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To:

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266626 , @ngraham wrote: > I know you didn't change that, but it might be a nice enhancement (hint hint). :) In D13018#266626 , @ngraham wrote: > I

D12992: New elisa icon

januz added a comment. In D12992#266673 , @mgallien wrote: > In D12992#266288 , @alex-l wrote: > > > F5863162: image.png > > > > ^ I'm for this one without

D13018: Fix unit test for kfileplacesmodeltest

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks for indulging me. :) Now onto `kfileplacesviewtest`... REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria,

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham created this revision. ngraham added reviewers: Frameworks, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY `KIO::iconNameForUrl()` was doing a lot

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 6 inline comments as done. croick added a comment. Thank you for your comments, totally forgot about licensing. INLINE COMMENTS > maximilianocuria wrote in queryptrace.cpp:26 > Please honour TMPDIR or, even better, use QTemporaryDir (this will also make > the generated path

D13018: Fix unit test for kfileplacesmodeltest

bruns added a comment. Shouldn't this be handled by: http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: bruns, ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34670. croick added a comment. - add license text - use `QDir::tempPath()` - ifdefs to definition REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=30979=34670 BRANCH ptracer REVISION DETAIL

D12992: New elisa icon

mgallien added subscribers: astippich, januz. mgallien added a comment. In D12992#266288 , @alex-l wrote: > F5863162: image.png > > ^ I'm for this one without the quaver I also prefer this one

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 34671. croick marked an inline comment as done. croick added a comment. - check size of socket path REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=34670=34671 BRANCH ptracer REVISION DETAIL

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 34673. croick added a comment. - remove superfluous line... REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=34672=34673 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 AFFECTED FILES

D12896: Add Telegram plugin

apol added a comment. In D12896#266351 , @nicolasfella wrote: > I've played around with flatpaked Telegram and made it working. However: > My Telegram.desktop file executes this: > /usr/bin/flatpak run --branch=stable --arch=x86_64

D13018: Fix unit test for kfileplacesmodeltest

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. `kiofilewidgets-kfileplacesmodeltest` still fails for me with this patch: grep 'FAIL! : KFilePlacesModelTest' -A 3 Testing/Temporary/LastTest.log FAIL! :

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. as maximilianocuria said, before run the tests you need to create a temporary home path: HOMETMP=$(mktemp -d) trap 'rm -rf $HOMETMP' EXIT export HOME="$HOMETMP" REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham,

D13018: Fix unit test for kfileplacesmodeltest

ngraham added a comment. Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time. REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria,

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266623 , @ngraham wrote: > Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time. I am not sure, this is

D13018: Fix unit test for kfileplacesmodeltest

ngraham added a comment. I know you didn't change that, but it might be a nice enhancement (hint hint). :) REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, bruns

Re: QStandardPaths::GenericDataLocation on MacOS

Hi, I just remembered that some time ago I wrote a small library that allows me to use binaries compiled against my own patched qt5-kde with an "official" Qt build: it provides the additional symbols that are in qt5-kde but not standard Qt through code injection (DYLD_INSERT_LIBRARIES). That

D13018: Fix unit test for kfileplacesmodeltest

maximilianocuria added a comment. In D13018#266137 , @elvisangelaccio wrote: > Hmm, still seems to fail here: > > $ ctest -R kfileplacesmodeltest > Test project /home/elvis/dev/kde/kio/local-build > Start 50: