D9387: Add cross compile support for kconfig_compiler and kconf_update.

[Ralf Habacker]

habacker added a comment.


  
  
  In D9387#180530 , @apol wrote:
  
  > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to 
be exported with kconfigcompiler though, at the moment it's not.
  
  
  that means host tooling support in kconfig is not usable in kconfig yet

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D9387

To: habacker, dfaure, ltoscano, bcooksley, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D9387: Add cross compile support for kconfig_compiler and kconf_update.

[Ralf Habacker]

habacker added a comment.


  The KF5_HOST_TOOLING approach in kconfig does not work because it is not poss
  
  In D9387#180530 , @apol wrote:
  
  > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to 
be exported with kconfigcompiler though, at the moment it's not.
  
  
  so you are saying that host tooling support  in kconfig does not work yet
  
  > Here's the android scripts for reference. 
https://cgit.kde.org/sysadmin/ci-tooling.git/tree/system-images/android/sdk
  
  But this link is useless because it does not show  how  the included file 
cmake file should be setup up.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D9387

To: habacker, dfaure, ltoscano, bcooksley, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D9387: Add cross compile support for kconfig_compiler and kconf_update.

[Ralf Habacker]

habacker added a comment.


  The KF5_HOST_TOOLING approach in kconfig does not work because it is not poss
  
  In D9387#180530 , @apol wrote:
  
  > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to 
be exported with kconfigcompiler though, at the moment it's not.
  
  
  you are saying that host tooling support  in kconfig does not work yet

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D9387

To: habacker, dfaure, ltoscano, bcooksley, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

Re: purpose unittests on Windows

[Ben Cooksley]

On Fri, Aug 10, 2018 at 7:28 PM David Faure  wrote:
>
> Any idea why purpose can't find the KIO http and file protocols -- on Windows?
>
> https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.10/76/testReport/junit/(root)/TestSuite/alternativesmodeltest/
>
> That's very odd, because the dependency from purpose on kio is there in 
> kde-build-metadata
> (it wouldn't build otherwise), and using kio_file from other frameworks 
> surely works (e.g. in KParts).
>
> The lookup for protocols looks for "kf5/kio" under all Qt plugin directories, 
> i.e. $QT_PLUGIN_PATH.
>
> The CI log says
> QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks purpose kf5-qt5 
> WindowsMSVCQt5.10\install-prefix\lib\plugins;C:\Craft\CI\windows-msvc2017_64-cl-debug\lib\qca-qt5'
>
> Is that supposed to include KIO's plugins?
>
> I guess so, given that a Unix CI job for purpose says
> QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'
>
> => is there a kf5\kio subdir in C:\CI\workspace\Frameworks purpose kf5-qt5 
> WindowsMSVCQt5.10\install-prefix\lib\plugins ?

I've checked and the following seem to be present in that directory,
which looks correct to me:

ModeLastWriteTime Length Name
- -- 
-a8/10/2018   8:39 PM 274944 file.dll
-a8/10/2018   8:40 PM 352256 ftp.dll
-a8/10/2018   8:40 PM 185856 ghelp.dll
-a8/10/2018   8:39 PM 185856 help.dll
-a8/10/2018   8:45 PM 946688 http.dll
-a8/10/2018   8:40 PM 189440 remote.dll
-a8/10/2018   8:40 PM 122880 trash.dll

Is there any debug output we can enable to see how it is searching for
the plugins?

Cheers,
Ben

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

D14732: Actually allow to set the refresh rate for device statistics

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14732

To: volkov, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14733: [KFormat] Add human readable list displaying function

[Safa Alfulaij]

safaalfulaij retitled this revision from "[KFormat] Add human readble list 
displaying function" to "[KFormat] Add human readable list displaying function".

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14733

To: safaalfulaij, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D14733: [KFormat] Add human readble list displaying function

[Safa Alfulaij]

safaalfulaij added a comment.


  In D14733#306325 , @bruns wrote:
  
  > You should start with
  >  a) a use case
  >  b) show it actually matches the needs of different languages.
  >
  > For e.g. englisch and the most european languages, two different positions 
are sufficent. Also, the AndListType and the UnitListType are identical. What 
is missing is a format where no conjunction is used, i.e. all lists elements 
are joined using ', '
  
  
  a) Most of the uses I found is in PIM, where day names and people names are 
joined for a neat sentence. Maybe even email header renderer could use this. 
Other uses: KAlgebra 
 and 
KTurtle . 
Maybe even KMyMoney with the print check function (representing the full text 
representation of the amount.)
  Not a very strong use case, yes, but I thought this can be helpful.
  
  b) I agree with this that most languages use 2 positions only. I prefered to 
do what Unicode is doing 
 
and provide all the three forms they provide, to be in the safe side.
  And you can see in that document all the forms they have. I thought it will 
be an overkill to add them all. I've scanned most languages in Unicode and 
there isn't any difference between normal and shorter versions.
  
  If you see that this could be useful, then great, let's develop it. Otherwise 
we can just ignore it till we find a good use case.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14733

To: safaalfulaij, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D14707: autotests: skip '/' fstab check with zfs

[Stefan Brüns]

bruns added a comment.


  In D14707#305773 , @dfaure wrote:
  
  > OK maybe I misunderstood the comment "Welcome to the wondeful world of / on 
zfs with boot-environments :)."
  >
  > If it's not related to zfs then two options:
  >
  > 1. allowing for no root possible mountpoint, as you suggest, but I don't 
like it, it could hide a major regression in KMountPoint one day.
  > 2. somehow finding that we're in the zpool/bootfs/whatever case where this 
can happen (so the test still runs in the "normal case").
  >
  >   Any idea how to do the latter? Is this a FreeBSD-specific thing? We could 
allow "no root" only on FreeBSD, if nothing else...
  
  
  The question is what this check is supposed to assert. In general, there is 
no guarantee how the fstab looks like, it can be completely empty. You only 
need a root fs, and that can be given e.g. using kernel parameters. Think of 
e.g. Live images, which is copied to an optical medium (/dev/srN on Linux) or a 
USB stick (/dev/sdX).
  
  Probably the code should check against a well known string/file instead of 
the fstab of the running system, i.e. pass something else than /etc/fstab to 
setmntent.
  
  Oh, and maybe we should get rid of anything #if defined(_OS_SOLARIS_), 
defined(_AIX) or defined(WIN32_WCE)  ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14707

To: dfaure
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D14733: [KFormat] Add human readble list displaying function

[Safa Alfulaij]

safaalfulaij updated this revision to Diff 39425.
safaalfulaij added a comment.


  Fix test
  No unrelated changes

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14733?vs=39418=39425

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14733

AFFECTED FILES
  autotests/kformattest.cpp
  autotests/kformattest.h
  src/lib/util/kformat.cpp
  src/lib/util/kformat.h
  src/lib/util/kformatprivate.cpp
  src/lib/util/kformatprivate_p.h

To: safaalfulaij, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D14733: [KFormat] Add human readble list displaying function

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kformattest.cpp:396
> +
> +QStringList testDate;
> +QCOMPARE(format.formatList(testDate), QStringLiteral(""));

Why test**Date**?

> kformat.h:287
>   *
> - * e.g. given formatDuration(6), returns "1.0 minutes"
> + * e.g. given formatDecimalDuration(6), returns "1.0 minutes"
>   *

No unrelated changes, please.

> kformatprivate.cpp:477
>  
> -// Handle correctly problematic case #1 (look at 
> KFormatTest::prettyFormatDuration())
> +// Handle correctly problematic case #1 (look at 
> KFormatTest::formatSpelloutDuration())
>  if (seconds == 60) {

No unrelated changes, please.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14733

To: safaalfulaij, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D14733: [KFormat] Add human readble list displaying function

[Stefan Brüns]

bruns added a comment.


  You should start with
  a) a use case
  b) show it actually matches the needs of different languages.
  
  For e.g. englisch and the most european languages, two different positions 
are sufficent. Also, the AndListType and the UnitListType are identical. What 
is missing is a format where no conjunction is used, i.e. all lists elements 
are joined using ', '

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14733

To: safaalfulaij, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D14702: Java: add binaries & hex-float, and support underscores in numbers

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14702

To: nibags, dhaumann, cullmann, vkrause, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, 
demsking, cullmann, sars, dhaumann

D14702: Java: add binaries & hex-float, and support underscores in numbers

[Nathaniel Graham]

ngraham added a comment.


  > - BUG 386391
  
  This needs to be on its own line (not as part of a bulleted list) and there 
needs to be a colon. Like this:
  
  `BUG: 386391`

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14702

To: nibags, dhaumann, cullmann, vkrause, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, 
demsking, cullmann, sars, dhaumann

D14733: [KFormat] Add human readble list displaying function

[Safa Alfulaij]

safaalfulaij added a comment.


  Tbh I don't fully understand the `struct` and `find` statments (just saw 
working similar code and edited-copy-pasted). I prefer if someone can continue 
this instead of me.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14733

To: safaalfulaij, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14733: [KFormat] Add human readble list displaying function

[Safa Alfulaij]

safaalfulaij created this revision.
safaalfulaij added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
safaalfulaij requested review of this revision.

REVISION SUMMARY
  Add formatList() to convert QStringLists to human readable strings.
  This makes it possible to display strings like "A, B, C and D" natively in
  all languages.

TEST PLAN
  Added a test

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14733

AFFECTED FILES
  autotests/kformattest.cpp
  autotests/kformattest.h
  src/lib/util/kformat.cpp
  src/lib/util/kformat.h
  src/lib/util/kformatprivate.cpp
  src/lib/util/kformatprivate_p.h

To: safaalfulaij, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14730: Sort returned formats in Definition::formats() by id

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e23573cc90f3: Sort returned formats in 
Definition::formats() by id (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14730?vs=39411=39416

REVISION DETAIL
  https://phabricator.kde.org/D14730

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/40/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 10 Aug 2018 14:43:47 +
 Build duration:
1 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)46%
(693/1491)29%
(241/834)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)76%
(111/147)51%
(38/74)src90%
(9/10)90%
(9/10)50%
(582/1175)31%
(203/656)src.declarative0%
(0/2)0%
(0/2)0%
(0/133)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/36)0%
(0/2)

D14732: Actually allow to set the refresh rate for device statistics

[Alexander Volkov]

volkov added reviewers: Frameworks, jgrulich.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D14732

To: volkov, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14732: Actually allow to set the refresh rate for device statistics

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  Set the DBus property of the NetworkManager, not the internal
  property that doesn't affect anything.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14732

AFFECTED FILES
  src/devicestatistics.cpp

To: volkov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14730: Sort returned formats in Definition::formats() by id

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think any sorting is better than the current "random" hash order.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  sort-formats (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14730

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14730: Sort returned formats in Definition::formats() by id

[Dominik Haumann]

dhaumann updated this revision to Diff 39411.
dhaumann added a comment.


  - Update comment

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14730?vs=39408=39411

BRANCH
  sort-formats (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14730

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Nathaniel Graham]

ngraham added a comment.


  +1 conceptually, as this seems relevant to the privacy initiative as well.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14730: Sort returned formats in Definition::formats() by id

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Sorting the formats() by id results in the same order as the
  itemDatas are defined in the xml file. This is required for
  several reasons:
  
  - KTextEditor currently uses the first format if no format was explicitly 
specified (which typically is "Normal Text")
  - Fonts & Colors will list the itemDatas in correct order
  - Printing the syntax guide is sorted correctly as well

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  sort-formats (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14730

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp

To: dhaumann, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

Re: KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

[David Faure]

On vendredi 10 août 2018 13:35:32 CEST CI System wrote:
> BUILD SUCCESS

YES !!! :-)

Finally.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/46/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 10 Aug 2018 11:30:56 +
 Build duration:
4 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(69/83)83%
(69/83)70%
(5681/8112)49%
(2810/5720)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)94%
(1492/1581)49%
(702/1420)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/333)0%
(0/241)src.plugin67%
(2/3)67%
(2/3)46%
(40/87)41%
(31/76)src.services97%
(28/29)97%
(28/29)61%
(1871/3047)42%
(794/1884)src.sycoca83%
(24/29)83%
(24/29)76%
(2119/2772)62%
(1235/1989)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(2/2)100%
(2/2)91%
(105/115)69%
(33/48)

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/45/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 10 Aug 2018 11:24:12 +
 Build duration:
5 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(69/83)83%
(69/83)70%
(5676/8109)49%
(2808/5718)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)94%
(1488/1578)49%
(701/1418)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/333)0%
(0/241)src.plugin67%
(2/3)67%
(2/3)46%
(40/87)41%
(31/76)src.services97%
(28/29)97%
(28/29)61%
(1870/3047)42%
(791/1884)src.sycoca83%
(24/29)83%
(24/29)76%
(2119/2772)62%
(1237/1989)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(2/2)100%
(2/2)91%
(105/115)69%
(33/48)

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/19/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 10 Aug 2018 11:24:11 +
 Build duration:
34 sec and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 213 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/213/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 10 Aug 2018 10:42:36 +
 Build duration:
5 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 59 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31990/59968)38%
(16181/42782)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9072/9503)51%
(3974/7804)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8331/14357)50%
(4652/9291)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3894/7926)34%
(1586/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1022)38%
(315/830)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1331)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

D14723: Add option to disable KWallet entirely in the new wallet dialog

[David Faure]

dfaure added a comment.


  +1, looks good to me (I just wonder how well KDE applications actually behave 
with KWallet disabled...)

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 212 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/212/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 10 Aug 2018 10:22:31 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 734.47 KB...]Scanning dependencies of target kurlnavigatortest[ 90%] Building CXX object autotests/CMakeFiles/kfilecustomdialogtest.dir/kfilecustomdialogtest.cpp.o[ 90%] Building CXX object autotests/CMakeFiles/knewfilemenutest.dir/knewfilemenutest.cpp.o[ 91%] Building CXX object autotests/CMakeFiles/kfilecustomdialogtest.dir/kfilecustomdialogtest_autogen/mocs_compilation.cpp.o[ 92%] Building CXX object autotests/CMakeFiles/knewfilemenutest.dir/knewfilemenutest_autogen/mocs_compilation.cpp.o[ 92%] Building CXX object autotests/CMakeFiles/kurlnavigatortest.dir/kurlnavigatortest.cpp.o[ 92%] Built target listrecursivetest_autogenScanning dependencies of target kfileplacesmodeltest[ 92%] Building CXX object autotests/CMakeFiles/kfilecopytomenutest.dir/kfilecopytomenutest_autogen/mocs_compilation.cpp.o[ 92%] Built target previewtest_autogen[ 92%] Building CXX object autotests/CMakeFiles/kurlnavigatortest.dir/kurlnavigatortest_autogen/mocs_compilation.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/kfileplacesmodeltest.dir/kfileplacesmodeltest.cpp.oScanning dependencies of target kfilewidgettestScanning dependencies of target kurlcomboboxtest[ 93%] Building CXX object autotests/CMakeFiles/kurlcomboboxtest.dir/kurlcomboboxtest.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/kfilewidgettest.dir/kfilewidgettest.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/kfilewidgettest.dir/kfilewidgettest_autogen/mocs_compilation.cpp.o[ 93%] Building CXX object autotests/CMakeFiles/kurlcomboboxtest.dir/kurlcomboboxtest_autogen/mocs_compilation.cpp.oScanning dependencies of target kurlrequestertest[ 93%] Building CXX object autotests/CMakeFiles/kurlrequestertest.dir/kurlrequestertest.cpp.o/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kurlnavigatortest.cpp: In member function ‘void KUrlNavigatorTest::testButtonUrl()’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kurlnavigatortest.cpp:252:56: warning: ‘QUrl KUrlNavigator::url(int) const’ is deprecated [-Wdeprecated-declarations] const QUrl buttonUrl = m_navigator->url(buttonIndex);^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kurlnavigatortest.cpp:25:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/kurlnavigator.h:309:36: note: declared here KIOFILEWIDGETS_DEPRECATED QUrl url(int index) const;^~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kurlnavigatortest.cpp: In member function ‘void KUrlNavigatorTest::testInitWithRedundantPathSeparators()’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kurlnavigatortest.cpp:262:42: warning: ‘QUrl KUrlNavigator::url(int) const’ is deprecated [-Wdeprecated-declarations] const QUrl buttonUrl = temp_nav.url(3);  ^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kurlnavigatortest.cpp:25:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/kurlnavigator.h:309:36: note: declared here KIOFILEWIDGETS_DEPRECATED QUrl url(int index) const;^~~/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kfilewidgettest.cpp: In member function ‘void KFileWidgetTest::testSetSelection()’:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kfilewidgettest.cpp:162:34: warning: ‘void KFileWidget::setSelection(const QString&)’ is deprecated [-Wdeprecated-declarations] fw.setSelection(selection); // now deprecated, this test shows why ;)  ^In file included from /home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/autotests/kfilewidgettest.cpp:22:/home/jenkins/workspace/Frameworks kio kf5-qt5 SUSEQt5.9/src/filewidgets/kfilewidget.h:159:36: note: declared here KIOFILEWIDGETS_DEPRECATED void setSelection(const QString );^~~~[ 93%] Linking CXX executable ../bin/kfilecustomdialogtestScanning dependencies of target kfileplacesviewtest[ 93%] Building CXX object autotests/CMakeFiles/kfileplacesviewtest.dir/kfileplacesviewtest.cpp.o[ 93%] Linking CXX executable ../bin/kurlcomboboxtest[ 94%] Linking CXX executable ../bin/kurlnavigatortest[ 94%] Built target kfilecustomdialogtestScanning dependencies of target kdiroperatortest[ 94%] Building CXX object autotests/CMakeFiles/kdiroperatortest.dir/kdiroperatortest.cpp.o[ 94%] Linking CXX executable ../bin/kfilecopytomenutestCMakeFiles/kurlcomboboxtest.dir/kurlcomboboxtest.cpp.o: In function 

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/46/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 10 Aug 2018 10:14:11 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6323/8421)43%
(10131/23403)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5797/11895)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(653/769)42%
(969/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(826/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/44/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 10 Aug 2018 10:22:52 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)82%
(68/83)82%
(68/83)68%
(5507/8096)48%
(2732/5716)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)84%
(1317/1565)44%
(626/1416)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/333)0%
(0/241)src.plugin67%
(2/3)67%
(2/3)46%
(40/87)41%
(31/76)src.services97%
(28/29)97%
(28/29)61%
(1870/3047)42%
(791/1884)src.sycoca83%
(24/29)83%
(24/29)77%
(2121/2772)62%
(1236/1989)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(2/2)100%
(2/2)91%
(105/115)69%
(33/48)

D14666: Fixes memory leak in KUrlComboBox::setUrl

[David Hallas]

hallas closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14666

To: hallas, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/101/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 10 Aug 2018 10:14:11 +
 Build duration:
5 min 48 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6324/8421)43%
(10141/23407)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2698/2772)49%
(5806/11893)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(653/769)42%
(969/2307)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/24/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 10 Aug 2018 10:14:11 +
 Build duration:
50 sec and counting

D14722: KPluginMetaData: convert empty string to empty stringlist.

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:6be0ee1d0e6e: KPluginMetaData: convert empty string to 
empty stringlist. (authored by dfaure).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14722?vs=39395=39398

REVISION DETAIL
  https://phabricator.kde.org/D14722

AFFECTED FILES
  src/lib/plugin/kpluginmetadata.cpp

To: dfaure, apol, mpyne, davidedmundson, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14724: autotests: don't fail if an unrelated window shows up.

[David Faure]

dfaure created this revision.
dfaure added reviewers: hein, drosca.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Running anything else in parallel to this test would make it fail,
  because windowAdded() would be emitted with an unrelated window.
  If we couldn't find our dialog when the signal is emitted,
  just keep waiting for the signal to be emitted again.

TEST PLAN
  ctest -j 8 .

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14724

AFFECTED FILES
  autotests/dialogstatetest.cpp

To: dfaure, hein, drosca
Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D14722: KPluginMetaData: convert empty string to empty stringlist.

[Alex Richardson]

arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R244 KCoreAddons

BRANCH
  convert_empty_string_to_stringlist

REVISION DETAIL
  https://phabricator.kde.org/D14722

To: dfaure, apol, mpyne, davidedmundson, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Fabian Vogt]

fvogt added a comment.


  This fixes part of a downstream bug report: 
https://bugzilla.opensuse.org/show_bug.cgi?id=1104462

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  Users are greeted by this dialog on the first request by any application.
  Even if they press cancel, the dialog will pop up on subsequent requests 
again.
  The only way to disable this is using the KCM, which is not intuitive enough.
  So add a new option to the new wallet creation dialog.

TEST PLAN
  Selected the option, kwallet is now disabled.

REPOSITORY
  R311 KWallet

BRANCH
  disableopt

REVISION DETAIL
  https://phabricator.kde.org/D14723

AFFECTED FILES
  src/runtime/kwalletd/knewwalletdialog.cpp
  src/runtime/kwalletd/knewwalletdialog.h
  src/runtime/kwalletd/knewwalletdialogintro.ui
  src/runtime/kwalletd/kwalletd.cpp

To: fvogt, #frameworks
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/18/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 10 Aug 2018 09:56:46 +
 Build duration:
54 sec and counting

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 12 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/12/
 Project:
Frameworks kpackage kf5-qt5 AndroidQt5.11
 Date of build:
Fri, 10 Aug 2018 09:56:46 +
 Build duration:
33 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.43 KB...]  "KF5DocTools_DIR" to a directory containing one of the above files.  If  "KF5DocTools" provides a separate development package or SDK, be sure it  has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5 (required version >= 5.8.0) * KF5Archive (required version >= 5.49.0) * Gettext * KF5I18n (required version >= 5.49.0) * KF5CoreAddons (required version >= 5.49.0) * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Core * Qt5Test (required version >= 5.8.0)   Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.49.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks kpackage kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kpackage kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5Package_autogenScanning dependencies of target testpackage-rccScanning dependencies of target mockhandler_autogen[  3%] Automatic MOC for target mockhandler[  3%] Automatic MOC for target KF5Package[  5%] Generating testpackage-rcc/contents.rcc[  5%] Built target testpackage-rcc[  5%] Built target mockhandler_autogenScanning dependencies of target mockhandler[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.o[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.o[  8%] Built target KF5Package_autogen[ 10%] Automatic RCC for kpackage.qrcScanning dependencies of target KF5Package[ 11%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 13%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 15%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.o[ 20%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejobthread.cpp.o[ 22%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/versionparser.cpp.o[ 23%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/version.cpp.o[ 25%] Linking CXX executable ../../bin/mockhandler[ 27%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/kpackage_debug.cpp.o[ 27%] Built target mockhandler[ 28%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/mocs_compilation.cpp.o[ 30%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/EWIEGA46WW/qrc_kpackage.cpp.o[ 32%] Linking CXX shared library ../../bin/libKF5Package.so/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference 

D14722: KPluginMetaData: convert empty string to empty stringlist.

[David Faure]

dfaure created this revision.
dfaure added reviewers: apol, mpyne, davidedmundson, arichardson.
Restricted Application added a project: Frameworks.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  As a fallback when the property type is unknown, we use string.
  When reading a stringlist, if the key is absent or empty, this method
  was returning QStringList(""), which was rather unexpected.

TEST PLAN
  XDG_DATA_DIRS='foo' ../bin/kplugininfotest in kservice:
  Got dependencies ("")
  FAIL!  : KPluginInfoTest::testLoadDesktop(from KService::Ptr) Compared lists 
have different sizes.
  
Actual   (info.dependencies()) size: 1
Expected (QStringList()) size: 0

REPOSITORY
  R244 KCoreAddons

BRANCH
  convert_empty_string_to_stringlist

REVISION DETAIL
  https://phabricator.kde.org/D14722

AFFECTED FILES
  src/lib/plugin/kpluginmetadata.cpp

To: dfaure, apol, mpyne, davidedmundson, arichardson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14666: Fixes memory leak in KUrlComboBox::setUrl

[David Hallas]

hallas updated this revision to Diff 39393.
hallas added a comment.


  Rebased

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14666?vs=39265=39393

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14666

AFFECTED FILES
  autotests/kurlcomboboxtest.cpp
  autotests/kurlcomboboxtest.h
  src/widgets/kurlcombobox.cpp

To: hallas, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

purpose unittests on Windows

[David Faure]

Any idea why purpose can't find the KIO http and file protocols -- on Windows?

https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.10/76/testReport/junit/(root)/TestSuite/alternativesmodeltest/

That's very odd, because the dependency from purpose on kio is there in 
kde-build-metadata
(it wouldn't build otherwise), and using kio_file from other frameworks surely 
works (e.g. in KParts).

The lookup for protocols looks for "kf5/kio" under all Qt plugin directories, 
i.e. $QT_PLUGIN_PATH.

The CI log says
QT_PLUGIN_PATH= 'C:\CI\workspace\Frameworks purpose kf5-qt5 
WindowsMSVCQt5.10\install-prefix\lib\plugins;C:\Craft\CI\windows-msvc2017_64-cl-debug\lib\qca-qt5'

Is that supposed to include KIO's plugins?

I guess so, given that a Unix CI job for purpose says
QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'

=> is there a kf5\kio subdir in C:\CI\workspace\Frameworks purpose kf5-qt5 
WindowsMSVCQt5.10\install-prefix\lib\plugins ?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5