D14856: Search: Add workaround for missing icons in Gnome icon-theme

sars edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14856 To: sars Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14856: Search: Add workaround for missing icons in Gnome icon-theme

sars added a reviewer: Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14856 To: sars, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309370 , @bcooksley wrote: > On Windows the correct path to use is $prefix/bin/data/... as that is what QStandardPaths expects. > The location $prefix/share/ won't work on Windows, so the test will need

D14856: Search: Add workaround for missing icons in Gnome icon-theme

sars created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sars requested review of this revision. TEST PLAN Install Gnome-icon-theme and start kate using that theme REPOSITORY R39 KTextEditor BRANCH master REVISION

D14856: Search: Add workaround for missing icons in Gnome icon-theme

broulik added inline comments. INLINE COMMENTS > katesearchbar.cpp:1332 > +// Gnome does not seem to have all icons we want, so we use > fall-back icons for those that are missing. > +QIcon mutateIcon = > QIcon::hasThemeIcon(QStringLiteral("games-config-options")) ? >

D8964: Fix two bugs in KMessageWidget

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R236:e3368be660e3: Fix two bugs in KMessageWidget (authored by aacid). CHANGED PRIOR TO COMMIT

D14859: Don't try to call transaction documentUrl with a 0 id

jtamate created this revision. jtamate added a reviewer: Frameworks. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY In Transaction::documentUrl(quint64 id) const, there is Q_ASSERT(id

D14859: Don't try to call transaction documentUrl with a 0 id

pino requested changes to this revision. pino added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:140 > fid = Baloo::devIdAndInodeToId(devId, inode); > -url = QFile::decodeName(tr.documentUrl(fid)); > +if (fid) { >

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. @mwolff @dhaumann @brauch I'm sorry for my silence — I stopped using KDE/KDevelop some time ago and did not track this changeset properly. Could you please reiterate what was the conclusion and what were @mwolff's requested changes? > The idea is to have just

D11838: Turn on line numbers by default

dhaumann added a comment. Just to make everyone aware of what this implies: 1. Every application now has a separate KTextEditor configuration 2. Every application now has line numbers on by default (that includes Kile) Especially 2. is something that was @mludwig definitely wanted

D14856: Search: Add workaround for missing icons in Gnome icon-theme

dhaumann added inline comments. INLINE COMMENTS > broulik wrote in katesearchbar.cpp:1332 > `hasThemeIcon)foo)` just does `!QIcon::fromTheme(foo).isNull()` so you might > as well just do the same and safe a lookup What would also be possible: QIcon mutateIcon =

D14817: Convert manual install test to an autotest

bcooksley added a comment. On Windows the correct path to use is $prefix/bin/data/... as that is what QStandardPaths expects. The location $prefix/share/ won't work on Windows, so the test will need to handle that case. REPOSITORY R238 KDocTools REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 125 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/125/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 15 Aug 2018 08:19:28 + Build duration: 42 min and counting

D14856: Search: Add workaround for missing icons in Gnome icon-theme

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e63efbdb8e4c: Search: Add workaround for missing icons in Gnome icon-theme (authored by sars). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309285 , @habacker wrote: > Funny, that this works with Qt 5.9 https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/ and Qt 5.11 (locally tested) - it only happens with Qt 5.10

D14817: Convert manual install test to an autotest

bcooksley added a comment. The Windows failure looks like a problem with handling of DESTDIR - probably due to reliance on it being handled by $DESTDIR instead of %DESTDIR% (which is the correct syntax for Windows) REPOSITORY R238 KDocTools REVISION DETAIL

D13813: Make this test work again with new uds implementation

elvisangelaccio added a comment. @jtamate Any updates on this? Can you use the new `fastInsert()` calls here? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks, elvisangelaccio Cc: dfaure, aacid, ngraham, bruns,

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309388 , @habacker wrote: > Agreed, as long as there is Qt on Windows not patched to also use unix style path layout, which is the case on OBS but this case should be covered by ECM module

D11838: Turn on line numbers by default

dhaumann added a comment. @mludwig @cullmann Sorry, what I wrote is not correct, since this change is in Kate, not KTextEditor. Sorry for the noise... :) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D11838 To: ngraham, #kate, #ktexteditor, dhaumann, mludwig Cc:

D12587: Indentation script for R

devillemereuil added a comment. Just to say: this didn't fall off my radar. I'm just incredibly busy nowadays and it never quite make it to the top of my todo list... But I think about doing it regularly, which is a good sign it'll happen! REPOSITORY R39 KTextEditor REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 374 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/374/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 08:19:36 + Build duration: 22 min and counting JUnit Tests Name: (root)

D12587: Indentation script for R

devillemereuil added a comment. I might get to that around September (no promise). If people are willing to help, my not-unit-at-all test code for indentation can be found here: https://github.com/devillemereuil/rindent/blob/master/example.R Automatic indent should not impact the code

D14817: Convert manual install test to an autotest

habacker added a comment. Because test.qmake do not anything about KDE install path layout those pathes need to be specified in the ctest config in autotests/CMakeLists.txt I guess --test-command ${CMAKE_COMMAND} "-DKDE_INSTALL_MANDIR=${KDE_INSTALL_MANDIR}"

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309281 , @bcooksley wrote: > Dependency Builds triggered to roll it out to all the non Frameworks jobs which have already picked this up. How to do this ? REPOSITORY R238 KDocTools REVISION DETAIL

D14817: Convert manual install test to an autotest

bcooksley added a comment. You aren't seeing the error the CI system sees because your build prefix still exists. Try removing that and the error it has should show up on your local system REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D14817 To: habacker,

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/50/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 07:52:38 + Build duration: 3 min 44 sec and counting JUnit Tests

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309295 , @habacker wrote: > According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 uses meinproc5 qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ? Got it - see

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309303 , @bcooksley wrote: > Try removing that and the error it has should show up on your local system I see. Since this problem has been fixed in kdoctools git repo and kdoctools has been rebuilt

D13813: Make this test work again with new uds implementation

jtamate added a comment. In D13813#309371 , @elvisangelaccio wrote: > @jtamate Any updates on this? Can you use the new `fastInsert()` calls here? Not until dolphin depends on KIO 5.47, currently its minimum required kio version is

D14817: Convert manual install test to an autotest

habacker added a comment. According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 uses meinproc5 qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D14817 To: habacker, ltoscano Cc:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 122 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/122/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Wed, 15 Aug 2018 08:19:29 + Build duration: 6 min 7 sec and counting JUnit

D14856: Search: Add workaround for missing icons in Gnome icon-theme

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Albeit a bi hacky, if that helps Kate users on Gnome, I am fine with this. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D14856 To: sars,

D14817: Convert manual install test to an autotest

habacker added a comment. another option would be to force the install path in the cmake call add_test(kdoctools_install ${CMAKE_CTEST_COMMAND} --build-and-test "${CMAKE_CURRENT_SOURCE_DIR}/kdoctools-install" "${CMAKE_CURRENT_BINARY_DIR}/kdoctools-install"

D14856: Search: Add workaround for missing icons in Gnome icon-theme

broulik accepted this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14856 To: sars, #kate, dhaumann, broulik Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 219 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/219/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 15 Aug 2018 08:19:35 + Build duration: 7 min 39 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 199 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/199/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 08:19:30 + Build duration: 6 min 41 sec and counting

D14856: Search: Add workaround for missing icons in Gnome icon-theme

sars updated this revision to Diff 39772. sars added a comment. use fromTheme("foo", fromTheme("fall-back")); REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14856?vs=39766=39772 REVISION DETAIL https://phabricator.kde.org/D14856 AFFECTED FILES

D14859: Don't try to call transaction documentUrl with a 0 id

jtamate updated this revision to Diff 39788. jtamate added a comment. Done requested changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14859?vs=39784=39788 REVISION DETAIL https://phabricator.kde.org/D14859 AFFECTED FILES

D14274: Modelines: add byte-order-mark & small fixes

nibags updated this revision to Diff 39789. nibags added a comment. - Fix test (use Modelines in Python instead of Bash) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14274?vs=39717=39789 BRANCH arcpatch-D14274 REVISION DETAIL

D14237: Make Konqi look good in HiDPI

cfeck added a reviewer: VDG. cfeck added a comment. Does someone from the VDG use professional tools that are able to trace to SVG? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg Cc: aacid, bruns,

D14237: Make Konqi look good in HiDPI

bruns added a comment. In D14237#309615 , @cfeck wrote: > In D14237#299303 , @bruns wrote: > > > I have traced the image with GIMPs selection tool, "convert selection to path" and export path as

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

cfeck resigned from this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14779 To: habacker, #frameworks Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14237: Make Konqi look good in HiDPI

cfeck added a comment. In D14237#299303 , @bruns wrote: > I have traced the image with GIMPs selection tool, "convert selection to path" and export path as SVG. If I understand it correctly, the SVG only contains the outline of the

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker added a comment. In D14779#308603 , @aacid wrote: > I think that in the test we just need to call > > bool QCoreApplication::installTranslator(QTranslator *translationFile) > > with the location of the fake translation

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

cfeck removed a reviewer: cfeck. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14779 To: habacker, #frameworks Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

cfeck added a comment. Is this still needed after https://phabricator.kde.org/D14454? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: anthonyfieroni, marten, asturmlechner, wbauer,

D14757: Warn user before copy operation if available space is not enough

shubham added a reviewer: cfeck. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, cfeck Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14856: Search: Add workaround for missing icons in Gnome icon-theme

bruns added inline comments. INLINE COMMENTS > katesearchbar.cpp:1332 > +// Gnome does not seem to have all icons we want, so we use > fall-back icons for those that are missing. > +QIcon mutateIcon = > QIcon::fromTheme(QStringLiteral("games-config-options"), >

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

cullmann added a comment. I think we don't want to change that now. We perhaps will port all things to the KSyntaxHighlighting theming and then we will alter this behavior anyways. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: intelfx, #kdevelop,

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham updated this revision to Diff 39816. ngraham added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13804?vs=36920=39816 BRANCH more-liberal-recent-document-duplicate-detection (branched from master) REVISION DETAIL

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309332 , @bcooksley wrote: > The Windows failure looks like a problem with handling of DESTDIR - probably due to reliance on it being handled by $DESTDIR instead of %DESTDIR% (which is the correct syntax for

D12587: Indentation script for R

dhaumann added a comment. @devillemereuil That is good to hear. If you can, feel free to paste a MIT-licensed snippet of R-code with a function, a loop, a if-condition etc. Maybe we find the time to turn this into a unit test. The code does not need to run, it just needs to be syntactically

D14856: Search: Add workaround for missing icons in Gnome icon-theme

sars marked an inline comment as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14856 To: sars, #kate, dhaumann Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. Still works, and the same document is still available in the Open Recent... menu of multiple apps if you open it in multiple apps. Been using this for a month and a half. I'm hesitant to land it without more reviews, though. REPOSITORY R241 KIO BRANCH

D14828: remove highlighting download dialog

cullmann added a comment. Independent of mom/dad/somebody else, for highlighting files you create on your own, you just can perfectly add them to the local directories as specified in the manual. If you really want to have new highlighting files and risk that stuff like indenters or

D14826: inline note interface wip #2

brauch updated this revision to Diff 39815. brauch added a comment. address Dominik's suggestion and split focus handling and click handling REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39802=39815 BRANCH inlinenotes REVISION DETAIL

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

aacid added a comment. In D14779#309643 , @habacker wrote: > In D14779#308603 , @aacid wrote: > > > I think that in the test we just need to call > > > > bool

D14856: Search: Add workaround for missing icons in Gnome icon-theme

dfaure added a comment. I don't think so, because QIcon::fromTheme just creates an icon engine. The actual lookup happens when the first call to isNull or paint (etc) is made. None of which are going to be done on the fallback icon if the main icon can be found. So this looks fine to

D13808: Fix KMainWindow saving incorrect widget settings

dfaure added a comment. I don't understand your question. By "this", do you mean the KMainWindow fix that was posted in a previous iteration here and that was pushed? That one is very much needed, yes, to make setAutoSaveSettings work. The change that you link to, is about porting KMail

D13808: Fix KMainWindow saving incorrect widget settings

cfeck added a comment. Ah, unit tests are still open. Thanks for the clarification. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid,

D14826: inline note interface wip #2

dhaumann added a comment. I think this goes into the right direction :-) INLINE COMMENTS > inlinenoteinterface.h:2 > +/* This file is part of the KDE libraries > + > + This library is free software; you can redistribute it and/or author missing > inlinenoteinterface.h:73 > + * \see

D14237: Make Konqi look good in HiDPI

cfeck added a comment. My viewer is QtSVG. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14274: Modelines: add byte-order-mark & small fixes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Works, will integrate, thanks for the patch! REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D14274 REVISION DETAIL https://phabricator.kde.org/D14274 To: nibags, turbov,

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 39801. jtamate edited the summary of this revision. jtamate added a comment. Herald added a subscriber: kde-frameworks-devel. Removed the use of enterLoop and exitLoop in favor of QTRY_COMPARE and QTRY_VERIFY. Removed some waits Changed all the

D14856: Search: Add workaround for missing icons in Gnome icon-theme

dhaumann added a comment. True... Is this a performance issue? ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14856 To: sars, #kate, dhaumann, broulik Cc: bruns, broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, demsking,

D14826: inline note interface wip #2

brauch updated this revision to Diff 39802. brauch added a comment. I added the rest of the interaction interface (click, mouseover) and reduced the API a bit by moving a few hints into the InlineNote object. Only thing I still intend to change about the API would be that we use the

D14826: inline note interface wip #2

cullmann added a comment. I would not implement any function inline and just hide their implementation in the .cpp to be able to alter them later (for InlineNote). For the activation, I would like to be able to differentiate between the different mouse buttons like the qt mousepressed

D11604: kdirlistertest doesn't fail at random

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdirlistertest.cpp:530 > +const QMimeType htmlType = > db.mimeTypeForUrl(QUrl(QLatin1String("file:///index.html"))); > +qDebug() << "html mimeType="

D14274: Modelines: add byte-order-mark & small fixes

cullmann closed this revision. cullmann added a comment. Git commit e1c3d16a35ddae90de6e457a31f54d899abb84c8 by Christoph Cullmann, on behalf of Nibaldo González. Committed on 15/08/2018 at 18:22. Pushed by cullmann into branch 'master'. Modelines: add byte-order-mark & small fixes

D14274: Modelines: add byte-order-mark & small fixes

cullmann added a comment. Will try that out again. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14274 To: nibags, turbov, dhaumann, cullmann, vkrause, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D14237: Make Konqi look good in HiDPI

bruns added a comment. Works fine in Inkscape, Gwenview, ShowFoto, Konqueror (KHTML mode) ... REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D14237 To: ngraham, broulik, cfeck, #frameworks, #vdg Cc: aacid, bruns, kde-frameworks-devel, michaelh, ngraham

D14237: Make Konqi look good in HiDPI

bruns added a comment. Minimal working application: #include #include int main(int argc, char* argv[]) { QGuiApplication app(argc, argv); QIcon icon(QStringLiteral("./konqui.svg")); QPixmap pixmap = icon.pixmap(64, 64);

D14856: Search: Add workaround for missing icons in Gnome icon-theme

bruns added a comment. In D14856#309714 , @dfaure wrote: > I don't think so, because QIcon::fromTheme just creates an icon engine. The actual lookup happens when the first call to isNull or paint (etc) is made. None of which are going to be

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 06:44:08 + Build duration: 1 min 3 sec and counting JUnit Tests

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 07:01:43 + Build duration: 1 min 8 sec and counting JUnit Tests

D14817: Convert manual install test to an autotest

bcooksley added a comment. This change has caused CI wide breakage and makes kdoctools unrelocatable. It needs to be reverted urgently, and Dependency Builds triggered to roll it out to all the non Frameworks jobs which have already picked this up. REPOSITORY R238 KDocTools REVISION

D14817: Convert manual install test to an autotest

habacker added a comment. This is the remaining issue on non Windows KDE CI Qt 5.10 https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull 07:02:43 cd "/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/autotests/kdoctools-install" &&

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309281 , @bcooksley wrote: > This change has caused CI wide breakage and makes kdoctools unrelocatable. This has been fixed with commit

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309283 , @habacker wrote: > This is the remaining issue on non Windows KDE CI Qt 5.10 > > https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull > > 07:02:43 cd