KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/47/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Oct 2018 05:28:20 + Build duration: 5 min 39 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/35/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 18 Oct 2018 05:28:21 + Build duration: 2 min 12 sec and counting JUnit Tests Name: (root) F

D16281: update epub test data and test for comment property

bruns added a comment. In D16281#344995 , @cfeck wrote: > Phabricator says the MIME Type was changed from application/epub+zip to application/zip. Is this a problem in Phabricator or in your file? The file no longer is spec compliant, as

D16281: update epub test data and test for comment property

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16281 To: astippich, bruns Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D16281: update epub test data and test for comment property

cfeck added a comment. Phabricator says the MIME Type was changed from application/epub+zip to application/zip. Is this is problem in Phabricator or in your file? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16281 To: astippich, bruns Cc: cfeck, kde-framewo

D16283: implement more tags for asf metadata

bruns added inline comments. INLINE COMMENTS > taglibextractor.cpp:720 > +//map the rating values of WMP to Baloo rating > +//0->0, 1->2, 25->4, 50->6,7 5->8, 99->10 > +if (rating == 0) { `// 0->0, 1->2, 25->4, 50->6, 75->8, 99->10` > taglibextractor.cpp:736 > +lstAS

D16283: implement more tags for asf metadata

astippich added a comment. for some reason the TagLib::ASF::File tag() function returns only an invalid pointer, so I decided to use the dynamic_cast here. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16283 To: astippich, mgallien, bruns Cc: kde-frameworks-

D16283: implement more tags for asf metadata

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add some more tags for asf audio files REPOSITORY R286 KF

D16282: extract ape tags from ape and wavpack files

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY extend the existing support of ape tags to all types that

D16281: update epub test data and test for comment property

astippich added a comment. In preparation of D12114 , which I plan to commandeer REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16281 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich

D16281: update epub test data and test for comment property

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY update the test data for epub and test for the comment property in

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in embeddedimagedata.cpp:73 > `supportedMimeTypes()` ? > capital `T`, see `ImageType` and `QMimeType` The "read" is supposed to mark that only read operations for these mimetypes are suppo

D16197: provide a list of supported mimetypes for embeddedimagedata

astippich updated this revision to Diff 43819. astippich added a comment. - use QVERIFY - use capital T - add since 5.52 tag and rephrase documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43601&id=43819 BRANCH mimetypes_embe

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. In D15070#344884 , @cgiboudeaux wrote: > In D15070#344871 , @bruns wrote: > > > As all the raised concerns have been dealed with, can we give this a try while the next KF rele

D16196: add a description property to KFileMetaData

astippich added a comment. ping. would be great to get this in before the string freeze REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16196 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16179: compare with QLatin1String and harmonize handling of all types

This revision was automatically updated to reflect the committed changes. Closed by commit R286:fd9ce3a4e1d2: compare with QLatin1String and harmonize handling of all types (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16179?vs=

D16179: compare with QLatin1String and harmonize handling of all types

astippich added a comment. Ok. Thanks! REPOSITORY R286 KFileMetaData BRANCH harmonize_optimize REVISION DETAIL https://phabricator.kde.org/D16179 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15070: Bindings: Support using sys paths for python install directory

cgiboudeaux added a comment. In D15070#344871 , @bruns wrote: > As all the raised concerns have been dealed with, can we give this a try while the next KF release is still somewhat in the future? No, the empty if must be removed. Code tha

D16179: compare with QLatin1String and harmonize handling of all types

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Preferably, do such independent changes (restructuring, coding style/optimization) as two separate reviews. REPOSITORY R286 KFileMetaData BRANCH harmonize_optimize REVISION DETAIL htt

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Feel free to push this for 5.52 (you'd have to adapt the @since 5.53 again). I only have minor comments that should not hold back this patch. One thing that pops into my eyes is tha

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. As all the raised concerns have been dealed with, can we give this a try while the next KF release is still somewhat in the future? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15070 To: bruns, #frameworks Cc: cgiboudeaux, bcook

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 243 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/243/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Oct 2018 16:07:20 + Build duration: 6 min 9 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 168 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/168/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 17 Oct 2018 15:59:10 + Build duration: 13 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 242 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/242/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Oct 2018 15:55:18 + Build duration: 12 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 167 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/167/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 17 Oct 2018 15:55:18 + Build duration: 3 min 51 sec and counting JUnit Tests Name: (roo

D16272: apply eexist workaround from listDir to stat as well

This revision was automatically updated to reflect the committed changes. Closed by commit R320:cf34ba609dc4: apply eexist workaround from listDir to stat as well (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16272?vs=43793&id=43795

D16272: apply eexist workaround from listDir to stat as well

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH Applications/18.08 REVISION DETAIL https://phabricator.kde.org/D16272 To: sitter, broulik Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, f

D16272: apply eexist workaround from listDir to stat as well

sitter edited the test plan for this revision. sitter added a reviewer: broulik. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16272 To: sitter, broulik Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, b

D16272: apply eexist workaround from listDir to stat as well

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY knetattach stats() without first doing a listDir() so in the event that the url requires authenticatio

D16266: [Extractor] Make extractor crash resilient

bruns marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16266 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: broulik, apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16266: [Extractor] Make extractor crash resilient

bruns marked 3 inline comments as done. bruns added inline comments. INLINE COMMENTS > poboiko wrote in filecontentindexer.cpp:91 > There is `Transaction::documentId(const QByteArray& path)`, which can resolve > it using `DocumentUrlDB`. > I believe it still would be cheaper than reindexing seve

D16266: [Extractor] Make extractor crash resilient

poboiko added inline comments. INLINE COMMENTS > bruns wrote in filecontentindexer.cpp:91 > Yes, its a binary search. > Because we only have IDs here, and the progress reporting works on strings. There is `Transaction::documentId(const QByteArray& path)`, which can resolve it using `DocumentUrl

D16237: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

bruns closed this revision. bruns added a comment. Sorry, submitted this one twice - D16254 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16237 To: bruns, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, micha

D16266: [Extractor] Make extractor crash resilient

bruns added inline comments. INLINE COMMENTS > poboiko wrote in filecontentindexer.cpp:91 > Do I understand correctly, that's a binary-search-like way to find the file > actually causing `extractor` to crash, and it will reindex some of the files > in a batch ~log2(batchsize) times? > Why don't

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 241 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/241/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Oct 2018 11:43:12 + Build duration: 14 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 166 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/166/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 17 Oct 2018 11:43:12 + Build duration: 2 min 28 sec and counting JUnit Tests Name: (roo

D16266: [Extractor] Make extractor crash resilient

broulik added inline comments. INLINE COMMENTS > poboiko wrote in filecontentindexer.cpp:75 > Is it OK to use `QObject::connect` inside a `while` loop? Those are not > `Qt::UniqueConnection`, won't they fire multiple times (more and more, > actually)? given `loop` lives on the stack it is dest

D16266: [Extractor] Make extractor crash resilient

poboiko added inline comments. INLINE COMMENTS > filecontentindexer.cpp:75 > +bool hadErrors = false; > +connect(&process, &ExtractorProcess::failed, &loop, [&hadErrors, > &loop]() { hadErrors = true; loop.quit(); }); > + Is it OK to use `QObject::connect` inside a `while` loop?

D16255: [Scheduler] Fix wrong usage of obsolete QFileInfo::created() timestamp

lbeltrame added a comment. +1, looks fine to me as far as I understand. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16255 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, br

D16237: [Scheduler] Reuse mimetype from UnindexedFileIterator in indexer

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH mimetype_handling REVISION DETAIL https://phabricator.kde.org/D16237 To: bruns, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 283 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/283/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 17 Oct 2018 04:34:15 + Build duration: 4 hr 25 min and counting JUnit Tests Name: (root) Failed: 1 t

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 155 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/155/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 17 Oct 2018 07:01:06 + Build duration: 2 min 23 sec and counting JUnit Tests Name: (root) Failed: