BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/97/
Project:
kf5-qt5 SUSEQt5.9
Date of build:
Thu, 27 Dec 2018 18:03:12 +
Build duration:
6 min 25 sec and counting
JUnit Tests
Name: (root)
GB_2 added a comment.
Ping?
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D17641
To: GB_2, #frameworks, #vdg
Cc: filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes, alexde,
IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis,
cochise updated this revision to Diff 48255.
cochise added a comment.
Support for preserving xattrs on dirs, bugfix
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17816?vs=48239=48255
BRANCH
xattr-copy-support (branched from master)
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/10/
Project:
kf5-qt5 SUSEQt5.11
Date of build:
Thu, 27 Dec 2018 18:03:12 +
Build duration:
5 min 18 sec and counting
JUnit Tests
Name: (root)
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
This seems like a reasonable enhancement to me. Do you have commit access yet?
If not, consider applying! :)
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
REPOSITORY
GB_2 added a comment.
Thanks.
I will apply when when I have time!
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D17641
To: GB_2, #frameworks, #vdg, ngraham
Cc: ngraham, filipf, #vdg, kde-frameworks-devel, #frameworks, squeakypancakes,
alexde, IohannesPetros,
loh.tar added a comment.
His original post with some more text/hints/questions
https://mail.kde.org/pipermail/kwrite-devel/2018-April/000345.html
He got the advice from @brauch to post here.
For me a little bit hard to follow, not only there but also here.
I could apply this
loh.tar added a comment.
> ..as soon as you split (and as the statusbar dictates the minimum size),
you will get in trouble.
My first thought was, "Oops, right!"
But while I verifying this I notice that the status bar has the full width of
the window, not only the split view.
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:bd398cc43389: Change default sort order in the download
dialog to Most downloads (authored by GB_2, committed by ngraham).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
ngraham added a reviewer: broulik.
ngraham added a subscriber: broulik.
ngraham added a comment.
@broulik I believe you were the one who found a bunch of issues last time;
can you re-test? I can't remember what your concerns were, sorry!
REPOSITORY
R241 KIO
REVISION DETAIL
cullmann added a comment.
Ah, you are right :=) Since we handle that differently the status bar has
already full length.
For the button issue: if you convert it and it looks the same as now with the
normal breeze style, one could give it a try, thought I think that the labels
are ok,
ngraham added a comment.
Bugs found:
- If there are no tags, creating one does not cause the Tags section to
appear in the Places panel until Dolphin is restarted.
- If the Tags section is already visible because there are already some tags,
creating a new tag does not cause that new
ndavis added a comment.
We still haven't figured out where to put all of the `yast-*` icons. Most of
them are now symlinks to preferences icons, but that doesn't fix the fact that
this patch can't pass the scalable test. This is because `apps/32` is a fixed
size directory. I don't think
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
It's done by iconName() as well as by the method itself.
TEST PLAN
Tests pass, apps
cfeck accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R302 KIconThemes
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17828
To: apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
nicolasfella added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17816
To: cochise, dfaure
Cc: nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
cochise added a comment.
Tested coping from e to VFAT and btrfs.
Successfully copy/move to and from VFAT, losing the xattrs due to lack of
support, but don't crash.
Successfully copy/move to and from btrfs, preserving xattrs.
REPOSITORY
R241 KIO
REVISION DETAIL
loh.tar added a comment.
@cullmann wrote:
> Actually, if there is a astyle commandline that enforces the right style,
could you paste it here?
Um (?) I had in mind it was on the Kate HP but couln'd find it now. But it's
there
cochise created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cochise requested review of this revision.
REVISION SUMMARY
Working for simple file copy. Not working for directories yet.
Commands for MacOS and *BSD copied from Baloo and not
nicolasfella updated this revision to Diff 48246.
nicolasfella added a comment.
- Fix
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7700?vs=48245=48246
BRANCH
arcpatch-D7700
REVISION DETAIL
https://phabricator.kde.org/D7700
AFFECTED FILES
nicolasfella updated this revision to Diff 48245.
nicolasfella added a comment.
- Whitespace--
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7700?vs=48244=48245
BRANCH
arcpatch-D7700
REVISION DETAIL
https://phabricator.kde.org/D7700
AFFECTED FILES
loh.tar added a comment.
> For the "should we use buttons": I think I tried that in the past and it
did look horrible in many styles, but perhaps I am wrong ;)
I see. May it in the meantime not an issue anymore, due to new designs
elsewhere? And what's up with the existing buttons, they
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:68a88913a81a: Clean up tests build system (authored by
vkrause).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17812?vs=48227=48240
REVISION DETAIL
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.
REVISION SUMMARY
This is probably the most invasive part of the Android support,
the remainder is implementing the native Android
nicolasfella reopened this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7700
To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham
Cc: kde-frameworks-devel, bruns, rkflx, mmustac, spoorun, michaelh,
nicolasfella updated this revision to Diff 48244.
nicolasfella added a comment.
Tags List v2.0
Deleted tags are automatically removed from the panel
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7700?vs=45426=48244
BRANCH
arcpatch-D7700
REVISION
trmdi added a comment.
!ping
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D15839
To: mvourlakos, #plasma, davidedmundson, mart
Cc: trmdi, kde-frameworks-devel, michaelh, ngraham, bruns
cullmann added a comment.
> - Most of them have an answer now ;-) Will add more stuff here
> - Your comment to @zetazeta request ? I have tried to add a QScrollArea but
without success :-/ Ideas? Perhaps is a second level of layout/widget needed(?)
>
> ``` updateStatus();
cfeck added inline comments.
INLINE COMMENTS
> ktitlewidget.cpp:132
> titleFrame->setBackgroundRole(QPalette::Base);
> +titleFrame->setContentsMargins(0, 0, 0, 0);
>
Setting 0 margins effectively disables the frame; the Breeze setting to keep
frames around page titles is no longer
cfeck added a comment.
Maybe add 'const found = ', while you are at it.
REPOSITORY
R302 KIconThemes
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17828
To: apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
30 matches
Mail list logo
