D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fake-input.xml:19 >]]> > > Version of the interface has to be bumped. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: zzag, kde-frameworks-devel, michaelh, ngraham,

D17730: Review KateStatusBar

loh.tar added a comment. > It was stated that it broke tests, should this be addressed now? As shown in the pic, the bar forces no width anymore (at least it seems so) Your comments at the bug report are interesting, but I'm not sure to do it. I had Christoph promised to add options to

D18079: Use (and suggest using) the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18079 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17730: Review KateStatusBar

This revision was automatically updated to reflect the committed changes. Closed by commit R39:dce48b397818: Review KateStatusBar (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17730?vs=48813=49037 REVISION

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 08 Jan 2019 21:00:05 + Build duration: 2 min 22 sec and counting JUnit Tests Name:

D10446: Add KLanguageName

aacid added a comment. Two more small comments from my side, otherwise looks cool :) Thanks for the perseverance! I can't approve it because the review is on my name ^_^ Maybe @apol can give it the ship it? INLINE COMMENTS > klanguagenametest.cpp:80 > +} > +}; > + Do you

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 08 Jan 2019 21:39:45 + Build duration: 51 min and counting JUnit Tests Name:

D18116: Don't show document load trouble twice

loh.tar added a comment. I have it only poor tested with our big S file, so no test was made with other trouble causing stuff. This need a patch in Kate, will try to link that KateBuffer::openFile - There is no distingues from 1. "create new file by command line" and 2.

D18076: Suggest people to use K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D18076 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle process dying with exitStatus 0

dfaure added a comment. Looks good. This assumes that no process exits cleanly (code 0) while not showing anything to the user, but even if that happened, better no klauncher error in that case, than an error in a normal case like the kate one. INLINE COMMENTS > klauncher.cpp:340 > +

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a reviewer: davidedmundson. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY For remote desktop support, we need to move with the pointer using absolute position. TEST PLAN I tested this

D17730: Review KateStatusBar

dhaumann added a comment. Hm, what is the current state of this patch? It was stated that it broke tests, should this be addressed now? Btw, I added a detailed comment to https://bugs.kde.org/show_bug.cgi?id=402904 that explains a proper solution to shrinking the statusbar: 1.

D4716: Add some more directives to MIPS assembler highlighting

dhaumann added a comment. @arichardson friendly ping :-) In case you don't have the time, it's also OK to paste some example code in a comment here (MIT licensed, please). Then, we can proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To:

D18081: Make translations work

aacid updated this revision to Diff 49034. aacid added a comment. remove unrelated cmake changes REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18081?vs=48932=49034 BRANCH arcpatch-D18081 REVISION DETAIL https://phabricator.kde.org/D18081 AFFECTED

D17730: Review KateStatusBar

cullmann added a comment. Btw., I can resize both Kate and KWrite like I want, like in the screenshots visible above. REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor,

D10621: Highlighting Indexer: list of suggestions

dhaumann added a comment. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. What do we do with this? I think some of the checks are a bit too aggressive, such as folding multiple regexps into a single one: This makes

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 08 Jan 2019 20:35:10 + Build duration: 6 min 32 sec and counting JUnit Tests Name:

D18114: FakeInput: add support for pointer move with absolute coordinates

zzag added inline comments. INLINE COMMENTS > fakeinput.h:139 > + **/ > +void requestPointerMoveAbsolute(const QSizeF ); > /** Wouldn't QPointF be a better choice? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc:

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

dhaumann added a comment. I think this change makes sense. I would like to have a unit test for this. Doing so is simple: Add a function in autotest/src/kateview_test.h/cpp and add one bracket matching call, then check the new cursor position. Then, do the same in overwrite mode.

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a dependent revision: D18115: Add support for fake pointer move with absolute coordinates. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18116: Don't show document load trouble twice

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Since there are fancy "in view" messages

D4716: Add some more directives to MIPS assembler highlighting

arichardson added a comment. Sorry, was busy with other stuff so completely forgot about this. I'll update this soon. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4716 To: arichardson, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, hase,

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar added a comment. Nice trick ;-) Can't promise to do it, will see REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17852 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking,

D17730: Review KateStatusBar

cullmann accepted this revision. cullmann added a comment. I think the current state can go in. Here with and without this patch two tests fail: The following tests FAILED: 24 - kateindenttest_testCppstyle (Failed) 67 - vimode_emulatedcommandbar (Failed) (perhaps due

D17816: Support for xattrs on kio copy/move

bruns added inline comments. INLINE COMMENTS > copyxattrjob.cpp:114 > +} > +QByteArray keylist(listlen, Qt::Uninitialized); > +// get the key list indentation > copyxattrjob.h:33 > + * > + * The CopyXattrJob copies extended attributes from a file or dir o another > + * @see

D17816: Support for xattrs on kio copy/move

cfeck added inline comments. INLINE COMMENTS > filecopyjob.cpp:519 > +KJob *job = KIO::copy_xattr(d->m_src, d->m_dest); > +job->exec(); > if (d->m_move) { This waits (i.e. spawns a separate event loop) until the job is finished. Should use a subjob. REPOSITORY R241

D17816: Support for xattrs on kio copy/move

cfeck added inline comments. INLINE COMMENTS > copyjob.cpp:1119 > +KJob *job = KIO::copy_xattr((*it).uSource, (*it).uDest); > +job->exec(); > //this is required for the undo feature Here, too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich updated this revision to Diff 49046. jgrulich added a comment. Use QPointF instead of QSizeF and bump interface version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18114?vs=49028=49046 BRANCH master REVISION DETAIL

D18081: Make translations work

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH arcpatch-D18081 REVISION DETAIL https://phabricator.kde.org/D18081 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D10446 REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid, apol Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

cfeck added a comment. What is the status of this patch? It missed the 5.54 deadline, so the version would need to be adjusted. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17596 To: ngraham, #frameworks, #dolphin Cc: cfeck, emateli, elvisangelaccio, markuss,

D18114: FakeInput: add support for pointer move with absolute coordinates

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fake-input.xml:44 > > + > + New requests can only be added at end. Since is missing. > fakeinput_interface.cpp:85 >

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

rooty updated this revision to Diff 49041. rooty added a comment. Fix blunder and bring back search field, place "Search..." in search field REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18046?vs=48876=49041 BRANCH master REVISION DETAIL

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 48960. cochise added a comment. For some reason the added kio was not included REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=48959=48960 BRANCH xattr-copy-support (branched from master) REVISION DETAIL

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar updated this revision to Diff 48994. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. Try to be smart REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17128?vs=48486=48994 REVISION DETAIL

D18089: KLauncher: handle process dying with exitStatus 0

ahmadsamir updated this revision to Diff 48948. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Fix commit message REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18089?vs=48947=48948 BRANCH klauncher-kateSessionManager

D10446: Add KLanguageName

sitter added inline comments. INLINE COMMENTS > aacid wrote in klanguagename.cpp:30 > should the second param be code too? > > I mean if we read the docs we say both are code (ISO 639-1), so both should > be the same and not only the first part? Do you mean both being **a** code or both being

D17999: ViewConfig: Add option to paste at cursor position by mouse

cullmann added a comment. I can live with the checkbox, too, as the first iteration, but I think you need to change the text in the UI file, atm there is still that "mouse cursor position", should it no be "cursor position"? REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar,

D17999: ViewConfig: Add option to paste at cursor position by mouse

cullmann added a comment. "Paste by mouse at cursor position" should be ok, then I will push this, ok? REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#389148 , @cullmann wrote: > "Paste by mouse at cursor position" should be ok, then I will push this, ok? Well, a last close look is nerver bad. REVISION DETAIL https://phabricator.kde.org/D17999 To:

D17999: ViewConfig: Add option to paste at cursor position by mouse

dhaumann accepted this revision. REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, bruns, demsking, sars

D17951: Haskell: Make = a special symbol

xialiyao updated this revision to Diff 49016. xialiyao added a comment. Bumped version number REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17951?vs=48642=49016 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17951 AFFECTED

D17998: test to fix cpp indenter

cullmann abandoned this revision. cullmann added a comment. See https://codereview.qt-project.org/#/c/249358/ There will be a fix in Qt (perhaps 5.12.1) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17998 To: cullmann, dhaumann, carewolf, #frameworks

D17951: Haskell: Make = a special symbol

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D17951 To: xialiyao, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D17951: Haskell: Make = a special symbol

This revision was automatically updated to reflect the committed changes. Closed by commit R216:8d0af2fe0d22: Haskell: Make = a special symbol (authored by xialiyao, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich marked 4 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17986: Build the Java side with Gradle, as AAR instead of JAR

This revision was automatically updated to reflect the committed changes. Closed by commit R289:054b4548ce1e: Build the Java side with Gradle, as AAR instead of JAR (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17986?vs=48881=49026#toc REPOSITORY R289

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added inline comments. INLINE COMMENTS > katedocument.cpp:4016 > // behavior when deleting from the start of a line, just when > explicitly > // calling the join command > Kate::TextLine tl = kateTextLine(line + 1); Can one point me why this is

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar updated this revision to Diff 48999. loh.tar added a comment. Back to "Paste by mouse at cursor position" CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17999?vs=48778=48999 REVISION DETAIL https://phabricator.kde.org/D17999 AFFECTED FILES

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 08 Jan 2019 16:46:44 + Build duration: 5 min 48 sec and counting JUnit Tests Name:

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. To avoid further comments I like to add that I don't like to do the requested change. Please improve it later, if needed. REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel,

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Sure, can do it. Which one have it to be ? - Paste clipboard contents at cursor location - Paste clipboard contents at cursor position - Paste by mouse at cursor position (This one was liked by Dominik, IIRC) REVISION DETAIL

D17999: ViewConfig: Add option to paste at cursor position by mouse

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e1b5f3177d42: ViewConfig: Add option to paste at cursor position by mouse (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17951: Haskell: Make = a special symbol

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Beside the missing version increase, this looks good for me. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17951 To: xialiyao,

D17932: Improvements to completion

cullmann added a reviewer: KDevelop. cullmann added a comment. Perhaps some KDevelop people have feedback, given they use that mostly ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop Cc: cullmann, kwrite-devel,

D18089: KLauncher: handle process dying with exitStatus 0

ahmadsamir added a reviewer: dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D18089 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle process dying with exitStatus 0

ahmadsamir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY When a process dies with exitStatus 0, it could well be the app exited cleanly, and there's no need to display

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 28 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/28/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 08 Jan 2019 09:17:23 + Build duration: 49 min and counting JUnit Tests

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel added a comment. I'm on strike until my device notifier patches are reviewed ;) More seriously, I did not have the time to look into gammaray. I will as soon as I can, but don't hesitate to tell me if you want to take over this patch. REPOSITORY R295 KCMUtils REVISION DETAIL

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 48959. cochise marked an inline comment as done. cochise added a comment. All use cases working, added a new KIO to copy xattr Working on copy and move with or without overwrite for calls of KIO::copy, KIO::copyAs and KIO::file_copy of files and