KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 04:36:10 + Build duration: 9 min 53 sec and counting JUnit Tests Name:

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

fvogt added a comment. Can you add context to this diff by either using arc or git diff with more context? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19027 To: Lekensteyn, ngraham, dfaure, fvogt Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

broulik added a comment. What's the air conditioning do? suspend to disk? +1 on the moon for suspend REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: broulik, kde-frameworks-devel, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/23/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Feb 2019 04:36:10 + Build duration: 7 min 39 sec and counting BUILD ARTIFACTS

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

rooty added reviewers: hein, VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19030 To: rooty, hein, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH gamepad-icon-16-22-px (branched from master) REVISION DETAIL https://phabricator.kde.org/D19030

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

hein added a comment. Could this maybe be input-games-symbolic (too)? Because I want a monochrome version always (my app recolors icons using the Kirigami feature, and that only works with monochrome icons). REPOSITORY R266 Breeze Icons REVISION DETAIL

D18998: update literate haskell mimetype

This revision was automatically updated to reflect the committed changes. Closed by commit R216:fe00f62078ea: update literate haskell mimetype (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D18996: Fix building with namespaced Qt

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18996 To: davschul, vkrause Cc: cullmann, kwrite-devel,

D18933: Send optional events from wl_pointer v5

zzag added a comment. In D18933#411966 , @davidedmundson wrote: > IMHO we should make frame() explicitly sent from the caller. Yeah, I'd prefer this way as well to be honest... > Hard to add retroactively in KF5 though :/ So,

D18998: update literate haskell mimetype

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Makes sense ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18998 To: davschul, vkrause, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D18986: [breeze-icons] Add video camera icons

rooty added a comment. In D18986#411807 , @ngraham wrote: > I like the head-on camcorder style, but there's the risk that it's less recognizable than the "classic" style of video recorder icon that's used pretty much everywhere. If we go with

D18883: Add PDF thumbnailer

broulik added a comment. Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef,

D18933: Send optional events from wl_pointer v5

zzag added a subscriber: davidedmundson. zzag added a comment. @davidedmundson Would it make sense to have something like void pointerAxisV5(Qt::Orientations orientations, const QPointF , const QPoint , PointerAxisSource source); so we could send a diagonal

D18996: Fix building with namespaced Qt

This revision was automatically updated to reflect the committed changes. Closed by commit R216:96466afebf63: Fix building with namespaced Qt (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D18933: Send optional events from wl_pointer v5

zzag updated this revision to Diff 51659. zzag added a comment. Add Unknown axis source. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18933?vs=51438=51659 BRANCH pointer-axis-value-discrete REVISION DETAIL https://phabricator.kde.org/D18933

D18933: Send optional events from wl_pointer v5

davidedmundson added a comment. > so we could send a diagonal scroll motion in one frame? We have this for a few things, such as clicking and moving. IMHO we should make frame() explicitly sent from the caller. I've hit this a few times (mostly wl_output) where KWayland tries to

D18998: update literate haskell mimetype

davschul created this revision. davschul added reviewers: vkrause, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION SUMMARY According to the freedesktop mimetypes literate

D18998: update literate haskell mimetype

davschul added a comment. see https://cgit.freedesktop.org/xdg/shared-mime-info/tree/freedesktop.org.xml.in?h=Release-1-12#n6074 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18998 To: davschul, vkrause, cullmann Cc: kwrite-devel,

D18997: Add functions returning all definitions for a mimetype or file name

davschul added a comment. Nice respond times here, and thanks for the reviews :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh,

D18997: Add functions returning all definitions for a mimetype or file name

cullmann added a comment. Thanks. Nice that we get the patches, then all can benefit from the improvements. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D18997: Add functions returning all definitions for a mimetype or file name

davschul updated this revision to Diff 51649. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18997?vs=51645=51649 REVISION DETAIL https://phabricator.kde.org/D18997 AFFECTED FILES src/lib/repository.cpp src/lib/repository.h To: davschul, vkrause, cullmann Cc: cullmann,

D18997: Add functions returning all definitions for a mimetype or file name

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0e94e0006005: Add functions returning all definitions for a mimetype or file name (authored by davschul, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D18997: Add functions returning all definitions for a mimetype or file name

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks => will push that. REVISION DETAIL https://phabricator.kde.org/D18997 To: davschul, vkrause, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer,

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

mgerstner created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mgerstner requested review of this revision. REVISION SUMMARY This change breaks up the rather large `TextBuffer::save()` into separate functions. Most

D18114: FakeInput: add support for pointer move with absolute coordinates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:12b58edd254a: FakeInput: add support for pointer move with absolute coordinates (authored by jgrulich). REPOSITORY

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 14 Feb 2019 12:45:00 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Feb 2019 12:45:00 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Thu, 14 Feb 2019 13:00:51 + Build duration: 35 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/3/ Project: kf5-qt5 AndroidQt5.12 Date of build: Thu, 14 Feb 2019 13:52:14 + Build duration: 26 sec and counting CONSOLE OUTPUT

D18997: Add functions returning all definitions for a mimetype or file name

dhaumann added inline comments. INLINE COMMENTS > repository.h:176 > + */ > +QVector definitionsForFileName(const QString ) > const; > + As I understand, this currently is unsorted. Wouldn't it make sense to sort the returned vector by priority? This information is also missing

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R216:eda235463cd2: Avoid duplicate *-php.xml files in data/CMakeLists.txt (authored by cullmann). REPOSITORY R216 Syntax

D18114: FakeInput: add support for pointer move with absolute coordinates

davidedmundson accepted this revision. davidedmundson added a comment. Given we have absolute events for other input, this makes sense. Ship it REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin,

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/1/ Project: kf5-qt5 AndroidQt5.12 Date of build: Thu, 14 Feb 2019 12:57:53 + Build duration: 39 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 2 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/2/ Project: kf5-qt5 AndroidQt5.12 Date of build: Thu, 14 Feb 2019 13:35:49 + Build duration: 33 sec and counting CONSOLE OUTPUT

D18845: authority: add support for passing details to polkit

lbeltrame added a reviewer: Frameworks. lbeltrame added a subscriber: kde-frameworks-devel. REPOSITORY R563 Polkit-1 Qt Library REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks Cc: kde-frameworks-devel

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 51680. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Add autotest - Don't wrap twice when static wrap is set to

D19005: android: don't default to gcc anymore

apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's deprecated REPOSITORY R240 Extra CMake Modules

D18986: [breeze-icons] Add video camera icons

ngraham added a comment. In D18986#411922 , @rooty wrote: > But I have the feeling you want me to do the opposite - F6614356: image.png Yeah in general I think using some permutation of the

D18940: Add battery icons

ngraham added a comment. In D18940#411818 , @ndavis wrote: > Would changing `status/22` to Fixed cause a problem? It doesn't appear to cause any real issue when I look at the change through Cuttlefish. Run dolphin with

D19007: Wait for DBus Reply Before Performing Computations

narvaez added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18986: [breeze-icons] Add video camera icons

rooty added a comment. > It's not that the Plasma logo is bad, it's that it doesn't make sense to put it everywhere; doing so dilutes its branding power in fact. Also, it doesn't make sense to put it on icons that have nothing to do with Plasma. Sure. But I see a big blue display and

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

lbeltrame added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

lbeltrame added reviewers: dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

ngraham added reviewers: chinmoyr, fvogt. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19001 To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars,

D18845: authority: add support for passing details to polkit

ngraham added reviewers: chinmoyr, fvogt, bruns. REPOSITORY R563 Polkit-1 Qt Library REVISION DETAIL https://phabricator.kde.org/D18845 To: mgerstner, #frameworks, chinmoyr, fvogt, bruns Cc: kde-frameworks-devel

D19005: android: don't default to gcc anymore

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19007: Wait for DBus Reply Before Performing Computations

narvaez created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. narvaez requested review of this revision. REVISION SUMMARY If the scheduler has not replied by the time the batch size is used, the default value is 0 and the mod

D18995: Explicitly link against KAuth

This revision was automatically updated to reflect the committed changes. Closed by commit R39:d7dcbb26ec20: Explicitly link against KAuth (authored by apol). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18995?vs=51641=51673 REVISION DETAIL

D19007: Wait for DBus Reply Before Performing Computations

ngraham added reviewers: bruns, astippich, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo, bruns, astippich, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18940: Add battery icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH battery-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein, ngraham Cc: broulik, ngraham, filipf, trickyricky26, kde-frameworks-devel, hein, michaelh,

D18940: Add battery icons

ndavis updated this revision to Diff 51712. ndavis added a comment. Change `status/22` and `status/22@2x` from Scalable to Fixed REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51462=51712 BRANCH battery-icons (branched from master)

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger updated this revision to Diff 51709. ekurzinger added a comment. Thanks for taking a look, Roman. I've addressed your style suggestions and added support for passing stream attributes to the compositor. I had ignored these initially since the driver doesn't actually use this

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger marked 7 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, zzag, #kwin Cc: schernikov, guilhermesi, kde-frameworks-devel, michaelh, ngraham, bruns

D18940: Add battery icons

ndavis added a comment. In D18940#412125 , @ngraham wrote: > In D18940#411818 , @ndavis wrote: > > > Would changing `status/22` to Fixed cause a problem? It doesn't appear to cause any real issue

D19016: Update Android toolchain files to reality

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY - NDK r18 does not ship GCC anymore, it's only clang now - same for STL, there's only

D19007: Wait for DBus Reply Before Performing Computations

narvaez edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19005: android: don't default to gcc anymore

vkrause added a comment. In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D19005: android: don't default to gcc anymore

vkrause added a comment. Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc:

D19020: Add "Type User" and "List Users" icons

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds new icons for the action buttons modified/added in D18893 .

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

abetts added a comment. Would an icon like this work? F6615590: Group 3.png Just trying to get to a good final icon for typing your user. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To:

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty updated this revision to Diff 51718. rooty added a comment. Fix glitch REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51716=51718 BRANCH user-prompt-list-icons (branched from master) REVISION DETAIL

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

ngraham added a comment. The only problem here that is that the label says "Type User" but the icon depicts a password field. Maybe the icon could depict both a username field and a password field, one on top of the other. Then I bet it would be tall enough that we wouldn't feel the need to

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty added a comment. In D19020#412431 , @ngraham wrote: > The only problem here that is that the label says "Type User" but the icon depicts a password field. Maybe the icon could depict both a username field and a password field, one on top

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty added a comment. F6615636: image.png P.s. are you sure about the I beam and the dots inside a password field? It might turn out small to make out / appreciate REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty retitled this revision from "Add "Type User" and "List Users" icons" to "[breeze-icons] WIP, Add "Type User" and "List Users" icons". rooty edited the test plan for this revision. rooty added reviewers: VDG, Plasma, ngraham, abetts. REPOSITORY R242 Plasma Framework (Library) REVISION

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

ngraham added a comment. +1 on that "List Users" icon! Very nice. For the "Type User" icon, I wonder how much we really need that background circle. Especially if we wind up improving the suspend icon to have a moon and stars or some other kind of sleepytime iconography, then it would

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty updated this revision to Diff 51716. rooty added a comment. Improve List Users 22 px version REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51714=51716 BRANCH user-prompt-list-icons (branched from master) REVISION

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty added a comment. In D19020#412387 , @ngraham wrote: > +1 on that "List Users" icon! Very nice. > > For the "Type User" icon, I wonder how much we really need that background circle. Especially if we wind up improving the suspend icon

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

rooty added a comment. In D19020#412412 , @abetts wrote: > Would an icon like this work? > > F6615590: Group 3.png > > Just trying to get to a good final icon for typing your user. hey i like

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

abetts added a comment. In D19020#412418 , @rooty wrote: > In D19020#412412 , @abetts wrote: > > > Would an icon like this work? > > > > F6615590: Group 3.png

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

abetts added a comment. In D19020#412431 , @ngraham wrote: > The only problem here that is that the label says "Type User" but the icon depicts a password field. Maybe the icon could depict both a username field and a password field, one on top

D19020: [breeze-icons] Revamp system.svgz

rooty retitled this revision from "[breeze-icons] WIP, Add "Type User" and "List Users" icons" to "[breeze-icons] Revamp system.svgz". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc:

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

Lekensteyn created this revision. Lekensteyn added reviewers: ngraham, dfaure, fvogt. Lekensteyn added a project: Frameworks. Lekensteyn requested review of this revision. REVISION SUMMARY When the Save File dialog is in use with filters, any relative path would trigger warnings due to

D19007: Wait for DBus Reply Before Performing Computations

bruns added a comment. good catch, but the fix is overengineered ... INLINE COMMENTS > monitor.cpp:90 > +batchSize.waitForFinished(); > > +if (!batchSize.isError()) { much more trivial: auto updateInterval = std::max(100, 5 * m_scheduler->getBatchSize()); if (m_filesIndexed %

D19007: Wait for DBus Reply Before Performing Computations

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo, bruns, astippich, poboiko Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D19007: Wait for DBus Reply Before Performing Computations

davidedmundson added inline comments. INLINE COMMENTS > bruns wrote in monitor.cpp:90 > much more trivial: > > auto updateInterval = std::max(100, 5 * m_scheduler->getBatchSize()); > if (m_filesIndexed % updateInterval == 0) { ... That won't fix the issue. getBatchSize is still returning

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 15 Feb 2019 02:05:58 + Build duration: 6 min 26 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 15 Feb 2019 02:05:59 + Build duration: 6 min 19 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 15 Feb 2019 02:05:59 + Build duration: 8 min 43 sec and counting JUnit Tests Name:

D19020: [breeze-icons] Revamp system.svgz

rooty edited the summary of this revision. rooty edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19020 To: rooty, #vdg, #plasma, ngraham, abetts Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

rooty updated this revision to Diff 51727. rooty added a comment. Add suspend moon/crescent and hibernate snowflake (thanks Noah!) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19020?vs=51718=51727 BRANCH user-prompt-list-icons

D18845: authority: add support for passing details to polkit

bruns added inline comments. INLINE COMMENTS > polkitqt1-authority.cpp:130 > + * The returned pointer needs to be freed via g_object_unref when no > + * longer needed. Returns NULL if details is empty. > + */ nullptr > polkitqt1-authority.cpp:328 > +if ( details.empty() ) > +

D18940: Add battery icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b04959059668: Add battery icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51712=51730 REVISION DETAIL

D14661: Force reevaluation of Predicates if interfaces are removed

bruns added a comment. In D14661#410848 , @volkov wrote: > I guess that there is a short period of time when UDisks daemon is in inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is removed for CD-ROM device, but the

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added inline comments. INLINE COMMENTS > poboiko wrote in kinotify.cpp:390 > Right, sorry, misprinted. > Actually, since there are a lot of `decodeName` calls around, probably it > would be better to decode it just once, right before `event->mask` matching > then, and then pass it

D19007: Wait for DBus Reply Before Performing Computations

narvaez added inline comments. INLINE COMMENTS > davidedmundson wrote in monitor.cpp:90 > That won't fix the issue. > > getBatchSize is still returning a QDBusPendingReply, using the value before > it's loaded will always be zero. It does fix the issue because if getBatchSize returns 0 then

D19007: Wait for DBus Reply Before Performing Computations

bruns added inline comments. INLINE COMMENTS > narvaez wrote in monitor.cpp:90 > It does fix the issue because if getBatchSize returns 0 then updateInterval > is set to 100. It does introduce another issue which is that it won't allow > for an update interval under 100 (say, if the batch size