D20011: Be more precise with mimetype detection

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a256687a1d11: Be more precise with mimetype detection (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20011?vs=54959=55055 REVISION DETAIL

D17302: Add test for adding properties to result

astippich added a comment. In D17302#439605 , @bruns wrote: > IMHO this test is pointless, as the contents of the variant map is inaccessible, it is only an intermediate storage. The correct way to retrieve the data is via `Result::document()`.

D19764: Fix Minimap with QtCurve style

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2b53012b3b50: Fix Minimap with QtCurve style (authored by sars). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19764?vs=53895=55057 REVISION DETAIL

Re: CI system maintainability

On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote: > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl > > I fear that a mandatory reviews would add too juch strain on smaller > > teams. If there's just one person with an intimate knowledge of the > > code-base, plus two co-developers,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/68/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 11:00:07 + Build duration: 7 min 13 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/69/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 11:12:37 + Build duration: 9 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 11:55:42 + Build duration: 4 min 58 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 11:55:42 + Build duration: 2 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/27/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 14:19:43 + Build duration: 9 min 54 sec and counting BUILD ARTIFACTS

D18604: Implement support for writing rating information for taglib writer

bruns added a comment. Can you change the id3v2 rating QHash with range checks and a plain array? Then its fine to go. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18604 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, gennad, domson,

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In particular, is there a way to test changes in ioslaves locally (within plasma/kde) ? I would love to have some direction, is there a flag for this, a trick ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks Cc:

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added a comment. In D20096#440434 , @meven wrote: > In particular, is there a way to test changes in ioslaves locally (within plasma/kde) ? > I would love to have some direction, is there a flag for this, a trick ? You mean

D18845: authority: add support for passing details to polkit

elvisangelaccio added inline comments. INLINE COMMENTS > polkitqt1-authority.h:226 > + */ > +// TODO KF6: merge with checkAuthorization > +void checkAuthorizationWithDetails( @bruns The `polkit-qt-1` repository is not a framework, so "KF6" could be misleading here. What about

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added inline comments. INLINE COMMENTS > file.cpp:955 > +// For FreeBSD and NetBSD, use st_birthtime. For OpenBSD, > +// use __st_birthtime. > + This comment is no longer relevant. > kioslavetest.cpp:390 > +case KIO::UDSEntry::UDS_CREATION_TIME: > +

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

dfaure added a comment. In D20096#440440 , @bruns wrote: > 2. Tell the application where the slave library is located: `QT_PLUGIN_PATH=...` There **must** be a subdirectory `kf5/kio/` containing the slave plugin `file.so` below the plugin path

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. This still alters the map during deserialization. Lists are converted into multi single properties afterwards. As I said, due to backwards-compatibility lists should stay

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/72/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 12:24:44 + Build duration: 24 min and counting BUILD ARTIFACTS

D20121: Test ffmpeg extractor using mime type helper

astippich added inline comments. INLINE COMMENTS > ffmpegextractor.cpp:64 > QStringLiteral("video/x-msvideo"), > +QStringLiteral("video/x-theora+ogg"), > }; This is quite specific to the codec. ExtractorCollection should handle this case I think (mime type of file is more specific

Re: CI system maintainability

Am 29.03.19 um 21:01 schrieb Ben Cooksley: > With the shift to Gitlab we should be able to provide this hopefully. > > We're still figuring out how to be able to provide CI in an easy to > maintain manner (in terms of controlling platforms builds are done > for, which branches, etc). In case, an

D19960: bluez-qt: remove warnings

pino added a comment. Please describe what are the warnings: otherwise it is not clear what the problem was, and what was the solution implemented. Remember: just because you see something on your system, it does not necessarly mean everybody else will, so each commit needs a proper

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/55/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 11:12:37 + Build duration: 7 min 40 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/73/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 11:12:37 + Build duration: 7 min 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 12:09:02 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 75 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/75/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 14:34:18 + Build duration: 6 min 58 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 76 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/76/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 14:41:17 + Build duration: 7 min 24 sec and counting BUILD ARTIFACTS

D18604: Implement support for writing rating information for taglib writer

astippich added a comment. After some thinking, I have split up the function for writing specific Ape and Vorbis tags, as many more tags like "Opus" etc. are in use for Vorbis tags and not for Ape, and can be easily added this way. I am still using the property map, though. Are you fine

D20121: Test ffmpeg extractor using mime type helper

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Use mime type helper to test ffmpeg extractor and add new mime

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/54/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 11:00:07 + Build duration: 8 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/72/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 11:00:07 + Build duration: 7 min 57 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/57/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 11:57:37 + Build duration: 7 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/75/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 11:57:37 + Build duration: 7 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/71/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 11:57:37 + Build duration: 27 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 74 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/74/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 14:15:08 + Build duration: 7 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 60 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/60/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 14:15:08 + Build duration: 7 min 36 sec and counting BUILD ARTIFACTS

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

ngraham added reviewers: dfaure, fvogt, bruns, broulik. ngraham added a comment. Wow, this is like the better, probably-has-a-chance-of-working version of my patch. :) I've added some reviewers who are familiar with this low-level stuff; hopefully some of them can help. REPOSITORY R241

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added a comment. I think the regular stat and statx implementations should be merged. This requires a little bit of refactoring, but avoids a lot of code duplication. INLINE COMMENTS > file.cpp:878 > +const __uint64_t upperLimit = 1024; > +size_t bufferSize =

D18604: Implement support for writing rating information for taglib writer

astippich updated this revision to Diff 55056. astippich added a comment. - split ape and vorbis tag writing functions REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18604?vs=50709=55056 BRANCH rating_write2 REVISION DETAIL

D20120: Use new mimetype helper in taglib extractor test

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Use the new mimetype helper in the taglib extractor test and fix

D19764: Fix Minimap with QtCurve style

sars added a comment. Yes I also have a memory that there was a bug report about it, but I can't find it now REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19764 To: sars, brauch, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/56/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 11:20:18 + Build duration: 9 min 30 sec and counting BUILD ARTIFACTS

D19784: Avoid calling QT_LSTAT and accessing recent documents

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This needs a KIO version ifdef for KIO >= 5.57. `#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0)` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0ba76d410a7c: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option (authored by hoffmannrobert, committed by dfaure). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 08:28:59 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/70/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 11:21:38 + Build duration: 7 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/74/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 11:20:39 + Build duration: 6 min 59 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/26/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 11:55:42 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/73/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 13:06:18 + Build duration: 8 min 7 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/59/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 13:06:18 + Build duration: 22 min and counting BUILD ARTIFACTS

D20121: Test ffmpeg extractor using mime type helper

bruns added inline comments. INLINE COMMENTS > ffmpegextractortest.cpp:27 > #include > +//#include > remove comment > astippich wrote in ffmpegextractor.cpp:64 > This is quite specific to the codec. ExtractorCollection should handle this > case I think (mime type of file is more specific

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In D20096#440440 , @bruns wrote: > In D20096#440434 , @meven wrote: > > > In particular, is there a way to test changes in ioslaves locally (within plasma/kde) ? > > I

D20092: New class KOSRelease - a parser for os-release files

pino added inline comments. INLINE COMMENTS > kosrelease.cpp:120-126 > +if (parts.size() != 2 || line.contains(QLatin1Char('#'))) { > +// Invalid line... > +// For the purposes of simple parsing we'll not support >2 = > +// or >1 #

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns added a comment. In D19087#440361 , @astippich wrote: > This still alters the map during deserialization. Lists are converted into multi single properties afterwards. As I said, due to backwards-compatibility lists should stay lists.

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns added a comment. On the topic of "multiple values from one extractor" vs "multiple values from different extractors": I think, when this problem arrives, it should be solved by using one PropertyMap per extractor and explicitly merging these. 1. For per-extractor unique

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55067. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55066=55067 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20129: [taglibextractor] Test extraction of properties with multiple values

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The taglib extractor can extract multiple values for

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55074. meven added a comment. Avoid duplicating code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55068=55074 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/55/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 18:59:49 + Build duration: 2 min 41 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/50/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 18:59:49 + Build duration: 2 min 27 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 21:40:36 + Build duration: 6 min 28 sec and counting BUILD ARTIFACTS

D20092: New class KOSRelease - a parser for os-release files

mpyne accepted this revision. mpyne added a comment. +1 to @aacid's comment about relicensing. The code is good and easy to review. Only comment I had was to think about using a warning or error when unable to parse the file. I think that the `ID_LIKE` handling could be done by

D20063: Sublime Merge Icon.

otavva added a comment. @ndavis Should I to put it here? Sorry for stupid question, but I don't understand you fully. And what is Arcanist tool? I'm a first time here. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc:

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added a comment. In D20096#440443 , @bruns wrote: > I think the regular stat and statx implementations should be merged. This requires a little bit of refactoring, but avoids a lot of code duplication. I thought about it, but the

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55064. meven added a comment. Fix timestamp value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=54997=55064 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55068. meven marked an inline comment as done. meven added a comment. Avoid obsolete method REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55067=55068 BRANCH creation-date REVISION DETAIL

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added inline comments. INLINE COMMENTS > file.cpp:855 > assert(entry.count() == 0); // by contract :-) > entry.reserve(8); > +entry.fastInsert(KIO::UDSEntry::UDS_NAME, filename); This can be up to 12 now, if I counted correctly. Conditionalize this on details. REPOSITORY

D20127: Fix finding the host tools targets file in the Android docker environment

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This worked on Yocto, the Android setup is apparently a bit more picky. Same approach is taken by KCoreAddons too.

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven retitled this revision from "[WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28" to "Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28". meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/17/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 30 Mar 2019 21:40:36 + Build duration: 7 min 26 sec and counting BUILD ARTIFACTS

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added a comment. In D20096#440470 , @meven wrote: > In D20096#440443 , @bruns wrote: > > > I think the regular stat and statx implementations should be merged. This requires a little bit of

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55077. meven marked 2 inline comments as done. meven added a comment. Fix in case of symlinks resolution, add inlines REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55074=55077 BRANCH creation-date REVISION

D20129: [taglibextractor] Test extraction of properties with multiple values

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20129 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55079. meven added a comment. Rename function get_stat to STAT REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55077=55079 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bcooksley added a comment. In D20096#440451 , @dfaure wrote: > In D20096#440440 , @bruns wrote: > > > 2. Tell the application where the slave library is located: `QT_PLUGIN_PATH=...` There **must**

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added inline comments. INLINE COMMENTS > file.cpp:880 > assert(entry.count() == 0); // by contract :-) > -entry.reserve(8); > - > +if (details > 0) { > +// uid, gid, atime, mtime, btime `switch (details) { ...}` > file.cpp:922 > // Use readlink on Unix

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

bruns added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:880 > `switch (details) { ...}` You are off by 1 for dev/inode, these are only added with details >= 3. details >= 2 is ACL data. As the ACL are commonly empty, add +0. Handle 0 explicitly, and make 3 (>=3) the default, to

D12327: [KDirOperator] Show Detailed Tree View by default

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:4dc2a7048e71: [KDirOperator] Show Detailed Tree View by default (authored by ngraham). REPOSITORY R241 KIO CHANGES

D12327: [KDirOperator] Show Detailed Tree View by default

ngraham retitled this revision from "Show Detailed Tree View by default" to "[KDirOperator] Show Detailed Tree View by default". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham, #frameworks, #vdg, apol Cc: ndavis, kde-frameworks-devel, elvisangelaccio,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/76/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 12:09:02 + Build duration: 8 hr 50 min and counting JUnit Tests Name:

D20127: Fix finding the host tools targets file in the Android docker environment

This revision was automatically updated to reflect the committed changes. Closed by commit R290:cee6a3d1755d: Fix finding the host tools targets file in the Android docker environment (authored by vkrause). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55066. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55064=55066 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES CMakeLists.txt

D20063: Sublime Merge Icon.

ngraham added a comment. In D20063#440460 , @otavva wrote: > @ndavis > Should I to put it here? Yeah just put it in a comment. > And what is Arcanist tool? I'm a first time here.

D20129: [taglibextractor] Test extraction of properties with multiple values

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e1aae1f66117: [taglibextractor] Test extraction of properties with multiple values (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:855 > This can be up to 12 now, if I counted correctly. Conditionalize this on > details. This code was just copied, but I will be happy to take care of this along the way. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/55/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 18:59:49 + Build duration: 1 min 25 sec and counting JUnit Tests Name:

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55082. meven added a comment. Use switch statement, +1 to the qbound comparison of the buffer size REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55079=55082 BRANCH creation-date REVISION DETAIL

D20032: Convert string formatting tests to be data driven

bruns updated this revision to Diff 55073. bruns added a comment. rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20032?vs=54741=55073 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20032 AFFECTED FILES

D20127: Fix finding the host tools targets file in the Android docker environment

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D20127 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20138: Add a helper to determine actual supported parent mime type

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The ExtractorCollection::fetchExtractors method falls

D20139: [TagLibExtractor] Use the correct mimetype in case of inheritance

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The passed in mimetype may not match one of the

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/77/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 20:59:40 + Build duration: 59 min and counting JUnit Tests Name: projectroot

D20136: [UserMetaData] Handle changes in attribute data size correctly

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no guarantee the attribute size does not

D20136: [UserMetaData] Handle changes in attribute data size correctly

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20136 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20137: [XmlExtractor] Add MathML test case

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH submit2 REVISION DETAIL https://phabricator.kde.org/D20137 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

ndavis updated this revision to Diff 55106. ndavis added a comment. - Remove radius from thumbnailArea highlight REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20140?vs=55105=55106 BRANCH grid-delegate-rectangle (branched from master) REVISION

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 30 Mar 2019 21:40:36 + Build duration: 19 min and counting JUnit Tests Name:

D20137: [XmlExtractor] Add MathML test case

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Trivial test case TEST PLAN ctest REPOSITORY R286

D20138: Add a helper to determine actual supported parent mime type

bruns added a dependent revision: D20139: [TagLibExtractor] Use the correct mimetype in case of inheritance. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20138 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson,

  1   2   >