KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 118 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/118/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 22 May 2019 07:58:24 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 22 May 2019 08:11:54 + Build duration: 2 min 3 sec and counting JUnit Tests Name:

D21317: Manipulate bytes instead of characters

dfaure added a reviewer: thiago. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21317 To: chinmoyr, bruns, dfaure, thiago Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21314: Don't enable QT_STRICT_ITERATORS on Windows.

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21314 To: dfaure, vkrause, dvratil Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 22 May 2019 07:57:59 + Build duration: 2 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 22 May 2019 08:27:24 + Build duration: 2 min 6 sec and counting JUnit Tests Name:

D20197: Fix desktop link to file or directory

michaelweghorn added a comment. In D20197#443689 , @hoffmannrobert wrote: > Thanks, I've learned that QFileDialog only creates a well behaving directory chooser, if the QFileDialog::ShowDirsOnly option is set to true _after_ having set the

D21328: Add qml import for KItemModels

vkrause added a comment. +1 too, having the QML bindings as part of the corresponding framework is IMHO the way to go, compared to the KDeclarative approach. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson Cc: vkrause, apol,

D21331: Fix: don't reset Highlight when saving some files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Lets give this a try. REPOSITORY R39 KTextEditor BRANCH fix-save-hl REVISION DETAIL https://phabricator.kde.org/D21331 To: nibags, #ktexteditor, cullmann Cc: kwrite-devel,

D21331: Fix: don't reset Highlight when saving some files

nibags created this revision. nibags added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 407763 Fix the regression of patch D20959

D21331: Fix: don't reset Highlight when saving some files

nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21331 To: nibags, #ktexteditor, cullmann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20815: Ensure highlighted folding marker after unfold

cullmann added a comment. I must confess, I am a bit confused what this patch should improve. Could you tell again which concrete issue it fixes? And why is the delete not useful? REVISION DETAIL https://phabricator.kde.org/D20815 To: loh.tar, #ktexteditor Cc: cullmann, kwrite-devel,

D20815: Ensure highlighted folding marker after unfold

cullmann added a comment. Ok, I see, I tried it a bit more and yes, now the folding start/end tokens are highlighted on unfold. Btw., is it intentional that the folding start/end tokens are only sometimes highlighted on folding, still? e.g. not for the if

D21327: Support installing multiple Samba packages

bruns added a comment. There are two executables required two run the samba integration properly: - smbd - net But this is actually an implementation detail of KSambaShare from KIOCore. Wouldn't it be better to query the required packages from KSambaShare instead? REPOSITORY

D21339: Block a bit less when introspecting udisks

ngraham added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21339 To: apol, #frameworks, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21339: Block a bit less when introspecting udisks

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Allow both introspections to happen in parallel TEST PLAN tests still pass,

D21327: Support installing multiple Samba packages

ngraham added a comment. In D21327#468390 , @bruns wrote: > There are two executables required two run the samba integration properly: > > - smbd > - net > > But this is actually an implementation detail of KSambaShare from KIOCore.

D21287: Try to find always an unique visible document name without a number suffix

cullmann added a comment. I think for 2 one still needs a clever way to compute the "short" path. I think the document list tries to create shortest unique "suffixes". For 1) to be efficient one could hash all documents with "filename" => documents with that if file names changes, that

D19771: Use placeholder instead of label

cullmann added a comment. Hi, any more feedback on this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, sars,

D19771: Use placeholder instead of label

ngraham added a comment. In D19771#440886 , @cullmann wrote: > Hi, if we do that: Could we then remove the "Mode:", too and move that into the combobox? > Perhaps like "Plain text search", "Whole words search", ... > Otherwise the search

D21339: Block a bit less when introspecting udisks

apol updated this revision to Diff 58469. apol added a comment. iteration REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21339?vs=58468=58469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21339 AFFECTED FILES

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given nobody proposes a working alternative, lets go with this. REPOSITORY R216 Syntax Highlighting BRANCH fix-syntax-highlighter-default-color REVISION DETAIL

D20959: Allow to change the Mode, after changing the Highlighting

cullmann closed this revision. cullmann added a comment. Ok, regression taken care of in D21331 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20959 To: nibags, #ktexteditor, #kate, cullmann Cc: cullmann, kwrite-devel,

D21327: Support installing multiple Samba packages

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I wouldn't have made it better :D REPOSITORY R432 File Sharing (Samba) integration BRANCH support-multiple-samba-packages (branched from master) REVISION DETAIL

D21327: Support installing multiple Samba packages

This revision was automatically updated to reflect the committed changes. Closed by commit R432:0b2e51981044: Support installing multiple Samba packages (authored by ngraham). REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE

D21349: Use simply configure_file to generate the plasmacomponents3 files

apol added a comment. Won't it need installing then? What are we fixing here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21349 To: kossebau, #plasma, mart Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21349: Use simply configure_file to generate the plasmacomponents3 files

kossebau added a comment. In D21349#468698 , @apol wrote: > Won't it need installing then? It is installed as before, by code below install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/plasmacomponents3/ DESTINATION

D19677: WIP: Port UDisks to using DBus ObjectManager

apol added a comment. +1 do we know what's stopping this to move forward? At least the commit message needs addressing. INLINE COMMENTS > udisksmanager.h:41 > > +// interface -> [ {property: key}, {property: key}, ... ] > +using PropertyMap = QMap; This comment looks wrong. If this

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 111 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/111/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 22 May 2019 22:18:21 + Build duration: 8 min 9 sec and counting JUnit Tests

D21354: Port to new connect syntax

bruns added inline comments. INLINE COMMENTS > sambausershareplugin.cpp:126 > +connect(propertiesUi.sambaChk, ::toggled, > +this, ::changed); > +connect(propertiesUi.sambaNameEdit, ::textChanged, I think instead of emiting `KFilePropertiesPlugin::changed()` it would be

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 101 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 22 May 2019 22:18:21 + Build duration: 12 min and counting BUILD ARTIFACTS

D21354: Port to new connect syntax

bruns added inline comments. INLINE COMMENTS > ngraham wrote in delegate.cpp:46 > I'd love to, and I tried, but this stuff is pretty new to me and I kept > getting `error: cannot define member function` What's wrong with this? > > connect(comboBox, ::activated, > [comboBox]() {

D21349: Use simply configure_file to generate the plasmacomponents3 files

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b0850b1f6fc7: Use simply configure_file to generate the plasmacomponents3 files (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D21354: Port to new connect syntax

bruns added inline comments. INLINE COMMENTS > delegate.cpp:46 > +connect(comboBox, QOverload::of(::activated), > +this, ::emitCommitData); > use a lambda here: - avoids the single-use `emitCommitData` wrapper - avoids the need for `qobject_cast(sender())`, which is the

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/108/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 22 May 2019 22:18:21 + Build duration: 14 min and counting BUILD ARTIFACTS

D21354: Port to new connect syntax

ngraham added inline comments. INLINE COMMENTS > bruns wrote in delegate.cpp:46 > use a lambda here: > > - avoids the single-use `emitCommitData` wrapper > - avoids the need for `qobject_cast(sender())`, which is the > combobox (just capture it). I'd love to, and I tried, but this stuff is

D20197: Fix desktop link to file or directory

bruns added a comment. I think this can go in now, as the i18n strings are not actually new - grep src/widgets/fileundomanager.cpp for `i18n("File")` and `i18n("Directory")`. REPOSITORY R241 KIO BRANCH fix_desktop_link_filter REVISION DETAIL https://phabricator.kde.org/D20197 To:

D21354: Port to new connect syntax

aacid added inline comments. INLINE COMMENTS > ngraham wrote in delegate.cpp:46 > I'd love to, and I tried, but this stuff is pretty new to me and I kept > getting `error: cannot define member function` What's wrong with this? > > connect(comboBox, ::activated, > [comboBox]() {

D21355: Fix qmldir files

kossebau created this revision. kossebau added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY By what I learned the last weeks about the requirements with qmldir

D20197: Fix desktop link to file or directory

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oops, sorry I lost track of this. LGTM now. Let's get it in. REPOSITORY R241 KIO BRANCH fix_desktop_link_filter REVISION DETAIL https://phabricator.kde.org/D20197 To:

D21327: Support installing multiple Samba packages

ngraham marked an inline comment as done. REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21327 To: ngraham, apol, #frameworks Cc: bruns

D21327: Support installing multiple Samba packages

ngraham updated this revision to Diff 58484. ngraham added a comment. Make it work (Thanks @apol for contributing virtually all of this code) REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21327?vs=58445=58484 BRANCH

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 58490. kossebau added a comment. Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20984?vs=57481=58490 BRANCH addinstallqmlplugin

D21344: Port to ECMAddQmlModule

kossebau updated this revision to Diff 58492. kossebau added a comment. also remove include of ECMGenerateQmlTypes, newer macros cover that as well REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21344?vs=58491=58492 BRANCH

D21349: Use simply configure_file to generate the plasmacomponents3 files

kossebau created this revision. kossebau added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH simplefileconfigure REVISION DETAIL

D20197: Fix desktop link to file or directory

ngraham added a comment. Because it has new strings though, I'm afraid this is 5.60 material because we're past the 5.59 string freeze. Making a note on my calendar so it doesn't get lost again... REPOSITORY R241 KIO BRANCH fix_desktop_link_filter REVISION DETAIL

D21344: Port to ECMAddQmlModule

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY While the current logic for Plasma QML modules is stable and all repeated data

D20984: Add ECMAddQmlModule

kossebau retitled this revision from "Add ECMInstallQmlModules, with ecm_install_qmlplugin as start" to "Add ECMAddQmlModule". kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma Cc:

D21344: Port to ECMAddQmlModule

kossebau added a comment. The diff between the generated qmldir files and the manually written ones looks good. And also showed the one of plasmacore has some left-over. INLINE COMMENTS > CMakeLists.txt:37 > +OBJECT_TYPES > +BusyIndicator qml/BusyIndicator.qml > +Button

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R296 KDeclarative BRANCH porttoECMInstallQmlModules REVISION DETAIL

D19771: Use placeholder instead of label

loh.tar added a comment. > Hi, any more feedback on this? When in power mode, and the fields are filled, it is not clear what which field is. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cullmann, cfeck, loh.tar,

D21287: Try to find always an unique visible document name without a number suffix

loh.tar added a comment. > the path is appended behind the document name. What about this solution? Don't like that idea. And fit not well to the shown "Document List" problem. > to be efficient one could hash all documents I'm always in favor for such. But here I had no idea

D21295: SyntaxHighlighter: Fix foreground color for text without special highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bbc465981bd5: SyntaxHighlighter: Fix foreground color for text without special highlighting (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21295?vs=58315=58511#toc

D21354: Port to new connect syntax

aacid added inline comments. INLINE COMMENTS > delegate.h:41 > +private: > +void emitCommitData(int index); > }; why add the int if you're not going to use it? REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21354 To: ngraham,

D21327: Support installing multiple Samba packages

bruns added inline comments. INLINE COMMENTS > sambausershareplugin.cpp:43 > > // copied from kio/src/core/ksambashare.cpp, > KSambaSharePrivate::isSambaInstalled() > static bool isSambaInstalled() see here ^ `net` is not checked for at all, it just tries to execute it using

D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module

kossebau created this revision. kossebau added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH cleancoreqmldir REVISION DETAIL

D20655: Use generated DBus interface

apol added a comment. UPower already installs the xml files. Wouldn't it be better to use the installed xml instead of providing our own? INLINE COMMENTS > upowerdevice.cpp:35 > > +#include > + unneeded? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20655 To:

D21354: Port to new connect syntax

ngraham created this revision. ngraham added reviewers: Frameworks, apol. ngraham requested review of this revision. TEST PLAN - It compiles - Tested all functionality; everything works (well... at least everything that was working before is still working now :) ) REPOSITORY R432 File

D21354: Port to new connect syntax

ngraham updated this revision to Diff 58513. ngraham added a comment. Remove extra space REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21354?vs=58512=58513 BRANCH port-to-new-connect-symtax (branched from master) REVISION

D21349: Use simply configure_file to generate the plasmacomponents3 files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH simplefileconfigure REVISION DETAIL https://phabricator.kde.org/D21349 To: kossebau, #plasma, mart, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham,