D22061: Add a logging category for logs warnings

mikeroyal added a comment. This would be nice to have. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

mikeroyal added a comment. Nice work! :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 22:00:01 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 118 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 19:46:34 + Build duration: 2 hr 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/130/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 19:55:29 + Build duration: 1 hr 55 min and counting BUILD ARTIFACTS

D22069: Localize long number strings

ngraham updated this revision to Diff 60622. ngraham added a comment. Imagine that, a unit test exposing a bug in the code :) REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22069?vs=60562=60622 BRANCH localized-long-number-strings (branched from master)

D22069: Localize long number strings

ngraham added a comment. LOL REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/135/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 24 Jun 2019 21:00:35 + Build duration: 26 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 134 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/134/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 24 Jun 2019 19:46:34 + Build duration: 1 hr 13 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 140 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/140/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 24 Jun 2019 19:55:29 + Build duration: 58 min and counting BUILD ARTIFACTS

D22071: Fixing autoscroll down in katepart

This revision was automatically updated to reflect the committed changes. Closed by commit R39:4f4d1ad9b789: fix autoscrolling down speed (authored by axkibe, committed by cullmann). Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. CHANGED

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 140 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/140/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 24 Jun 2019 19:55:29 + Build duration: 8 min 4 sec and counting JUnit Tests Name:

D22018: Install KFileCustomDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ae84a6709389: Install KFileCustomDialog (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22018?vs=60422=60615 REVISION DETAIL

D21861: Add default variables for variables interface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:cf85a33e1ff0: Add default variables for variables interface (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21861?vs=60393=60614 REVISION

D21861: Add default variables for variables interface

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH add-default-variables REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson,

D22069: Localize long number strings

aspotashev added a comment. Dammit, I'm still not on the same page with the review request. In fact you had to trust your unit test and go fix the code :) diff --git a/src/klocalizedstring.cpp b/src/klocalizedstring.cpp index b1ba745..fed5b8a 100644 ---

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 117 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/117/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 18:59:14 + Build duration: 4 min 12 sec and counting CONSOLE OUTPUT

D22069: Localize long number strings

aspotashev added a comment. In D22069#485921 , @ngraham wrote: > Actual (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20" > Expected (QString(" 4,20")) : " 4,20" > > > What am I doing wrong?

D21940: Make automatic spellcheck work after reloading a document

This revision was automatically updated to reflect the committed changes. Closed by commit R39:42c64e1e081c: Make automatic spellcheck work after reloading a document (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D22073: [KCM GridDelegate] Silence warning

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22073 To: broulik, #plasma, mart, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60610. meven added a comment. Add logging category for all kconfig core warnings message REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60558=60610 BRANCH master REVISION DETAIL

D22081: [Fstab] Select appropriate icon for home or root directory

broulik added a comment. +1 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22081 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

mart added a comment. white background and part of margins removal will have to probably be in breeze style F6931480: Screenshot_20190624_184812.png REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart,

D22083: introduce concept of header and footer for kpageview

mart created this revision. mart added reviewers: Plasma, Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY put the dialog buttons in the footer for kpagedialog this is the first step

D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#486047 , @fvogt wrote: > If adding such a special case makes sense, yes. I'd even argue about 'mntent.mnt_dir == "/" && !isKnownFilesystem(mntent)' or something like that to ensure that an entry for `/` is

D22082: WIP Add an ioslave to access KActivityStat data

meven edited the summary of this revision. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY To accomplish D7446 , we want to add a

D22080: [Fstab] Show mounted "overlay" filesystems

bruns added a dependent revision: D22081: [Fstab] Select appropriate icon for home or root directory. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22080 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

bruns created this revision. bruns added reviewers: ngraham, fvogt, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Depends on D22080 REPOSITORY R245

D22080: [Fstab] Show mounted "overlay" filesystems

bruns created this revision. bruns added reviewers: ngraham, fvogt, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Overlay filesystems are not enumerated by udisks, so add support for these

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 61 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/61/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 24 Jun 2019 16:10:21 + Build duration: 2 min 44 sec and counting BUILD ARTIFACTS

D21986: Change initial size of the config dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R495:e6e0be782237: Change initial size of the config dialog (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21986?vs=60310=60599

D21986: Change initial size of the config dialog

nicolasfella retitled this revision from "RFC: Change initial size of the config dialog" to "Change initial size of the config dialog". REPOSITORY R495 Purpose Library BRANCH size REVISION DETAIL https://phabricator.kde.org/D21986 To: nicolasfella, #vdg, apol, ngraham Cc: aacid,

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22076 To: broulik, #plasma, mart, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

broulik added a dependent revision: D22077: [Colors KCM] Add title bar to preview delegate. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22076 To: broulik, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It only affected the `cellHeight` of the `GridView` but not the actual size of

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#486043 , @bruns wrote: > In D15739#486020 , @fvogt wrote: > > > In D15739#486009 , @bruns wrote: > > > > > It actually

D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#486020 , @fvogt wrote: > In D15739#486009 , @bruns wrote: > > > It actually already does, via the fstab backend (currently network (SMB/NFS) and various fuse

D22073: [KCM GridDelegate] Silence warning

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When the model doesn't have a `pluginName` property TEST PLAN Color kcm no

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#486009 , @bruns wrote: > In D15739#485983 , @fvogt wrote: > > > Even if all (block) devices and their mountpoints were shown in the devices view, there would be no

D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#485983 , @fvogt wrote: > Even if all (block) devices and their mountpoints were shown in the devices view, there would be no equivalent of "/". One loop device provides the read-only base for /, but that's

D15739: [Places panel] Don't show Root by default

andriusr added a comment. In D15739#485978 , @fvogt wrote: > In D15739#485976 , @ngraham wrote: > > > In D15739#485975 , @fvogt wrote: > > > > > No,

D15739: [Places panel] Don't show Root by default

ngraham added a comment. Could be. I'm not at all an expert on Solid; I just think that it never makes sense to have a Places Panel with no Devices section. How to fix that is definitely best left up to people far smarter than me. :) REPOSITORY R241 KIO REVISION DETAIL

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#485979 , @ngraham wrote: > In D15739#485978 , @fvogt wrote: > > > Well, the only mount of interest is the overlay mount of /, which is not backed by any (block)

D15739: [Places panel] Don't show Root by default

ngraham added a comment. In D15739#485978 , @fvogt wrote: > Well, the only mount of interest is the overlay mount of /, which is not backed by any (block) device but rather by two filesystems. AFAICT udisks doesn't care about this kind of

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#485976 , @ngraham wrote: > In D15739#485975 , @fvogt wrote: > > > No, there's in fact no devices section at all as it would be empty. The live cd itself is marked as

D15739: [Places panel] Don't show Root by default

ngraham added a comment. In D15739#485975 , @fvogt wrote: > No, there's in fact no devices section at all as it would be empty. The live cd itself is marked as ignored as there's nothing useful on there and it can't be ejected and the other

D15739: [Places panel] Don't show Root by default

fvogt added a comment. In D15739#485960 , @ngraham wrote: > In D15739#485949 , @fvogt wrote: > > > I just noticed this in openQA runs from a live medium. There is no single-click way to get to the

D15739: [Places panel] Don't show Root by default

ngraham added a comment. In D15739#485949 , @fvogt wrote: > I just noticed this in openQA runs from a live medium. There is no single-click way to get to the root directory anymore, as / is mounted as an overlayfs of a tmpfs and a squashfs

D15739: [Places panel] Don't show Root by default

fvogt added a comment. I just noticed this in openQA runs from a live medium. There is no single-click way to get to the root directory anymore, as / is mounted as an overlayfs of a tmpfs and a squashfs container. Not sure what the best way to improve this is, any idea? REPOSITORY

D22069: Localize long number strings

ngraham added a comment. So I'm trying this: P421 localized number tests But it doesn't seem to work: FAIL! : KLocalizedStringTest::correctSubs() Compared values are not the same Actual (ki18n("%1").subs(4.2, 5, 'f',

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. After some discussion, we realized we have three different sets of "recent documents" backends : - recentdocument ioslave using KDirWatch that miss accessed dir and files (used in places) - baloo's timeline ioslave using baloo extractor, that requires baloo but

D22069: Localize long number strings

aspotashev added a comment. You might want to test against different locales, like this: https://cgit.kde.org/ktimetracker.git/tree/src/tests/formattimetest.cpp REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc:

D22069: Localize long number strings

ngraham added a comment. The test passes for me, but I guess because I'm using English, right? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham,

D22069: Localize long number strings

ilic added a comment. Still lacks the change in unit test in autotests/klocalizedstringtest.cpp, from " 4.20" to " 4,20". REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: ilic, kde-frameworks-devel, broulik,

D22069: Localize long number strings

ngraham created this revision. ngraham added reviewers: Localization, Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Localize long number strings so that they get the proper

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

This revision was automatically updated to reflect the committed changes. Closed by commit R236:1772904c2980: set the focusPolicy of kpasswordlineedit to the policy of its proxy (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert added a comment. Can you please push it for me, I don't have commit access. Thanks. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fix_selectedNameFilter REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure

D22061: Add a logging category for logs warnings

apol added a comment. The patch looks good to me. I see that you're just doing KDesktopFile, but there's many others available, can you port the rest too? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol,

D22061: Add a logging category for logs warnings

meven marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D22061 To: meven, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

meven updated this revision to Diff 60558. meven added a comment. Use KCONF_CORE_LOG as identifier and kf5.kconfig.core as category_name REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22061?vs=60547=60558 BRANCH master REVISION DETAIL

D22061: Add a logging category for logs warnings

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:19 > +IDENTIFIER KCONF_DESKTOP_LOG > +CATEGORY_NAME kf5.kconfig.desktop) > + This is for KF5ConfigCore, I'd call it kf5.kconfig.core. REPOSITORY R237 KConfig REVISION