D22061: Add a logging category for logs warnings

[Mike Royal]

mikeroyal added a comment.


  This would be nice to have.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

[Mike Royal]

mikeroyal added a comment.


  Nice work! :)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, 
michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 119 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/119/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 22:00:01 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.60.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.variable_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33276/48868)51%
(15786/31189)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4766/5063)49%
(1807/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5472/5513)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/814)0%
(0/208)src.document100%
(4/4)100%
(4/4)61%
(1941/3183)50%
(1593/3209)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(949/1238)67%
(608/912)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
 

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 118 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/118/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 19:46:34 +
 Build duration:
2 hr 13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.60.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.variable_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33276/48868)51%
(15786/31189)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4766/5063)49%
(1807/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5472/5513)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/814)0%
(0/208)src.document100%
(4/4)100%
(4/4)61%
(1941/3183)50%
(1593/3209)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(949/1238)67%
(608/912)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 130 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/130/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 19:55:29 +
 Build duration:
1 hr 55 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33318/61096)39%
(17021/43989)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9364/9820)48%
(4287/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8463/14459)51%
(4706/9239)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)55%
(4510/8212)41%
(1957/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D22069: Localize long number strings

[Nathaniel Graham]

ngraham updated this revision to Diff 60622.
ngraham added a comment.


  Imagine that, a unit test exposing a bug in the code :)

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22069?vs=60562=60622

BRANCH
  localized-long-number-strings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22069

AFFECTED FILES
  autotests/klocalizedstringtest.cpp
  src/klocalizedstring.cpp

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

D22069: Localize long number strings

[Nathaniel Graham]

ngraham added a comment.


  LOL

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 135 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/135/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 24 Jun 2019 21:00:35 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.60.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.variable_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33248/48872)51%
(15760/31193)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4766/5063)49%
(1807/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5472/5513)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/814)0%
(0/208)src.document100%
(4/4)100%
(4/4)61%
(1939/3183)50%
(1593/3209)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)78%
(964/1238)68%
(617/912)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
 

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 134 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/134/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 24 Jun 2019 19:46:34 +
 Build duration:
1 hr 13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.60.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.variable_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33230/48872)50%
(15750/31193)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4766/5063)49%
(1807/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5472/5513)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/814)0%
(0/208)src.document100%
(4/4)100%
(4/4)61%
(1939/3183)50%
(1593/3209)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(949/1238)67%
(608/912)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 140 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/140/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 24 Jun 2019 19:55:29 +
 Build duration:
58 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report61%
(22/36)64%
(257/402)64%
(257/402)53%
(32540/61072)38%
(16597/43986)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9364/9820)48%
(4287/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8331/14447)50%
(4647/9236)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)55%
(4508/8212)41%
(1957/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file0%
(0/7)0%
(0/7)0%
(0/1192)0%
(0/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D22071: Fixing autoscroll down in katepart

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:4f4d1ad9b789: fix autoscrolling down speed (authored by 
axkibe, committed by cullmann).
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22071?vs=60572=60617#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22071?vs=60572=60617

REVISION DETAIL
  https://phabricator.kde.org/D22071

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: axkibe, #kate, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, cullmann, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 140 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/140/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 24 Jun 2019 19:55:29 +
 Build duration:
8 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_kprotocolinfotestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22018: Install KFileCustomDialog

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ae84a6709389: Install KFileCustomDialog (authored by 
vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22018?vs=60422=60615

REVISION DETAIL
  https://phabricator.kde.org/D22018

AFFECTED FILES
  src/filewidgets/CMakeLists.txt

To: vkrause, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21861: Add default variables for variables interface

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:cf85a33e1ff0: Add default variables for variables 
interface (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21861?vs=60393=60614

REVISION DETAIL
  https://phabricator.kde.org/D21861

AFFECTED FILES
  autotests/src/variable_test.cpp
  autotests/src/variable_test.h
  src/utils/kateglobal.cpp

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21861: Add default variables for variables interface

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  add-default-variables

REVISION DETAIL
  https://phabricator.kde.org/D21861

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D22069: Localize long number strings

[Alexander Potashev]

aspotashev added a comment.


  Dammit, I'm still not on the same page with the review request.
  
  In fact you had to trust your unit test and go fix the code :)
  
diff --git a/src/klocalizedstring.cpp b/src/klocalizedstring.cpp
index b1ba745..fed5b8a 100644
--- a/src/klocalizedstring.cpp
+++ b/src/klocalizedstring.cpp
@@ -1198,7 +1198,7 @@ KLocalizedString KLocalizedString::subs(double a, int 
fieldWidth,
 QChar fillChar) const
 {
 KLocalizedString kls(*this);
-kls.d->arguments.append(QStringLiteral("%1").arg(a, fieldWidth, 
format, precision, fillChar));
+kls.d->arguments.append(QStringLiteral("%L1").arg(a, fieldWidth, 
format, precision, fillChar));
 kls.d->values.append(static_cast(a));
 return kls;
 }

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 117 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/117/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 18:59:14 +
 Build duration:
4 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 651 lines...][2019-06-24T19:03:17.255Z] [ 52%] Built target kateindenttest_autogen[2019-06-24T19:03:17.255Z] [ 53%] Automatic MOC for target kte_documentcursor[2019-06-24T19:03:17.255Z] [ 53%] Automatic MOC for target scriptdocument_test[2019-06-24T19:03:17.255Z] Scanning dependencies of target templatehandler_test_autogen[2019-06-24T19:03:17.255Z] [ 53%] Automatic MOC for target templatehandler_test[2019-06-24T19:03:17.255Z] [ 53%] Built target scriptdocument_test_autogen[2019-06-24T19:03:17.255Z] Scanning dependencies of target kateencodingtest_autogen[2019-06-24T19:03:17.255Z] [ 53%] Automatic MOC for target kateencodingtest[2019-06-24T19:03:17.518Z] [ 53%] Built target kte_documentcursor_autogen[2019-06-24T19:03:17.518Z] [ 53%] Built target templatehandler_test_autogen[2019-06-24T19:03:17.518Z] Scanning dependencies of target bug205447_autogen[2019-06-24T19:03:17.518Z] Scanning dependencies of target wordcompletiontest_autogen[2019-06-24T19:03:17.518Z] [ 53%] Automatic MOC for target bug205447[2019-06-24T19:03:17.518Z] [ 54%] Automatic MOC for target wordcompletiontest[2019-06-24T19:03:17.518Z] [ 54%] Built target kateencodingtest_autogen[2019-06-24T19:03:17.518Z] Scanning dependencies of target range_test_autogen[2019-06-24T19:03:17.518Z] [ 54%] Automatic MOC for target range_test[2019-06-24T19:03:17.518Z] [ 54%] Built target bug205447_autogen[2019-06-24T19:03:17.518Z] [ 54%] Built target wordcompletiontest_autogen[2019-06-24T19:03:17.518Z] Scanning dependencies of target messagetest_autogen[2019-06-24T19:03:17.518Z] Scanning dependencies of target undomanager_test_autogen[2019-06-24T19:03:17.518Z] [ 54%] Automatic MOC for target messagetest[2019-06-24T19:03:17.518Z] [ 54%] Automatic MOC for target undomanager_test[2019-06-24T19:03:17.518Z] [ 54%] Built target range_test_autogen[2019-06-24T19:03:17.783Z] Scanning dependencies of target configinterface_test_autogen[2019-06-24T19:03:17.783Z] [ 54%] Automatic MOC for target configinterface_test[2019-06-24T19:03:17.783Z] [ 54%] Built target messagetest_autogen[2019-06-24T19:03:17.783Z] Scanning dependencies of target bug313769_autogen[2019-06-24T19:03:17.783Z] [ 54%] Built target undomanager_test_autogen[2019-06-24T19:03:17.783Z] [ 55%] Automatic MOC for target bug313769[2019-06-24T19:03:17.783Z] Scanning dependencies of target modificationsystem_test_autogen[2019-06-24T19:03:17.783Z] [ 55%] Automatic MOC for target modificationsystem_test[2019-06-24T19:03:17.783Z] [ 55%] Built target configinterface_test_autogen[2019-06-24T19:03:17.783Z] Scanning dependencies of target katedocument_test_autogen[2019-06-24T19:03:17.783Z] [ 55%] Automatic MOC for target katedocument_test[2019-06-24T19:03:17.783Z] [ 55%] Built target bug313769_autogen[2019-06-24T19:03:18.047Z] Scanning dependencies of target kateview_test_autogen[2019-06-24T19:03:18.047Z] [ 55%] Automatic MOC for target kateview_test[2019-06-24T19:03:18.047Z] [ 55%] Built target modificationsystem_test_autogen[2019-06-24T19:03:18.047Z] Scanning dependencies of target bug313759_autogen[2019-06-24T19:03:18.047Z] [ 56%] Automatic MOC for target bug313759[2019-06-24T19:03:18.047Z] [ 56%] Built target kateview_test_autogen[2019-06-24T19:03:18.047Z] [ 56%] Built target katedocument_test_autogen[2019-06-24T19:03:18.047Z] Scanning dependencies of target katewildcardmatcher_test_autogen[2019-06-24T19:03:18.047Z] Scanning dependencies of target regexpsearch_test_autogen[2019-06-24T19:03:18.047Z] [ 57%] Automatic MOC for target katewildcardmatcher_test[2019-06-24T19:03:18.047Z] [ 57%] Automatic MOC for target regexpsearch_test[2019-06-24T19:03:18.308Z] [ 57%] Built target bug313759_autogen[2019-06-24T19:03:18.308Z] Scanning dependencies of target movingrange_test_autogen[2019-06-24T19:03:18.308Z] Scanning dependencies of target inlinenote_test_autogen[2019-06-24T19:03:18.308Z] [ 57%] Automatic MOC for target movingrange_test[2019-06-24T19:03:18.308Z] [ 57%] Built target katewildcardmatcher_test_autogen[2019-06-24T19:03:18.308Z] [ 57%] Automatic MOC for target inlinenote_test[2019-06-24T19:03:18.308Z] Scanning dependencies of target revision_test_autogen[2019-06-24T19:03:18.308Z] [ 57%] Built target regexpsearch_test_autogen[2019-06-24T19:03:18.308Z] [ 57%] Automatic MOC for target revision_test[2019-06-24T19:03:18.308Z] Scanning dependencies of target variable_test_autogen[2019-06-24T19:03:18.308Z] [ 57%] Automatic MOC for target variable_test[2019-06-24T19:03:18.308Z] [ 57%] Built target movingrange_test_autogen[2019-06-24T19:03:18.308Z] Scanning dependencies of target vimode_emulatedcommandbar_autogen[2019-06-24T19:03:18.308Z] [ 57%] Automatic MOC for target vimode_emulatedcommandbar[2019-06-24T19:03:18.308Z] [ 57%] 

D22069: Localize long number strings

[Alexander Potashev]

aspotashev added a comment.


  In D22069#485921 , @ngraham wrote:
  
  >   Actual   (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20"
  >   Expected (QString(" 4,20"))   : " 4,20"
  >   
  >
  > What am I doing wrong?
  
  
  Oops, I answered without looking at the code.
  
  This subs() call in turn calls QString::arg() overload for double: 
https://doc.qt.io/qt-5/qstring.html#arg-9
  I'm not sure how to interpret this part of Qt documentation, may be the 
authors meant that "%L1 ".subs(4.2, 5, 'f', 2) 
would produce locale-aware " 4.20"/" 4,20" and just "%1".subs(... 'f' ...) 
always uses a decimal **point**.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

D21940: Make automatic spellcheck work after reloading a document

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:42c64e1e081c: Make automatic spellcheck work after 
reloading a document (authored by ahmadsamir, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21940?vs=60467=60611

REVISION DETAIL
  https://phabricator.kde.org/D21940

AFFECTED FILES
  src/spellcheck/ontheflycheck.cpp

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

D22073: [KCM GridDelegate] Silence warning

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22073

To: broulik, #plasma, mart, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven updated this revision to Diff 60610.
meven added a comment.


  Add logging category for all kconfig core warnings message

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60558=60610

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22081

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

[Marco Martin]

mart added a comment.


  white background and part of margins removal will have to probably be in 
breeze style
  F6931480: Screenshot_20190624_184812.png 


REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  put the dialog buttons in the footer for kpagedialog
  this is the first step for the new setting dialog windows.
  note that the look is still not that, but the changes will have to
  come probably from Breeze

TEST PLAN
  tested some application f=config windows

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  mart/pageviewfooter

REVISION DETAIL
  https://phabricator.kde.org/D22083

AFFECTED FILES
  src/kpagedialog_p.h
  src/kpageview.cpp
  src/kpageview.h
  src/kpageview_p.h

To: mart, #plasma, #frameworks, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D15739: [Places panel] Don't show Root by default

[Stefan Brüns]

bruns added a comment.


  In D15739#486047 , @fvogt wrote:
  
  > If adding such a special case makes sense, yes. I'd even argue about 
'mntent.mnt_dir == "/" && !isKnownFilesystem(mntent)' or something like that to 
ensure that an entry for `/` is always provided.
  
  
  Guaranteeing there will be an "/" entry is hard, as this can be provided by 
different backends. And I am not sure how e.g. dolphin would deal with multiple 
devices providing "/".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: andriusr, fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, 
ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  To accomplish D7446 , we want to add a 
better recent document ioslave to Dolphin/KFileWidgets than current 
recentdocuments:/
  This adds activity awareness to recent documents.
  
  The code started out of kio-extras recent-documents and Kicker/Kickoff.
  This is my first ioslave so I think I will need a bit of mentoring, if anyone 
feels like it to guide me a little.
  
  This repository may not be the appropriate one, the other obvious candidate 
would be kio-extras.
  
  Future features would allow users to filter parent dir, switch only-folders, 
number of elements returned.

TEST PLAN
  compile
  open recentdocumentsactivities:/ in Dolphin/KFileWidgetItem

REPOSITORY
  R159 KActivities Statistics

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

[Stefan Brüns]

bruns added a dependent revision: D22081: [Fstab] Select appropriate icon for 
home or root directory.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22080

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: ngraham, fvogt, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Depends on D22080 

REPOSITORY
  R245 Solid

BRANCH
  fstab_overlayfs

REVISION DETAIL
  https://phabricator.kde.org/D22081

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: ngraham, fvogt, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Overlay filesystems are not enumerated by udisks, so add support for these
  to the fstab backend
  
  See also D15739 

TEST PLAN
  $> grep overlay /proc/self/mounts
  
  NAME /mnt overlay 
rw,relatime,lowerdir=/home/stefan/tmp/,upperdir=/tmp/overlay/rw,workdir=/tmp/overlay/work
 0 0
  NAME /home/stefan/tmp2 overlay 
rw,relatime,lowerdir=/home/stefan/tmp/,upperdir=/tmp/overlay2/rw,workdir=/tmp/overlay2/work
 0 0
  
  $> solid-hardware5 list details
  ...
  udi = '/org/kde/fstab/overlay/mnt'
  
parent = '/org/kde/fstab'  (string)
vendor = 'overlay'  (string)
product = '/mnt'  (string)
description = '/mnt (overlay)'  (string)
icon = 'folder'  (string)
StorageAccess.accessible = true  (bool)
StorageAccess.filePath = '/mnt'  (string)
StorageAccess.ignored = false  (bool)
  
  udi = '/org/kde/fstab/overlay/home/stefan/tmp2'
  
parent = '/org/kde/fstab'  (string)
vendor = 'overlay'  (string)
product = '~/tmp2'  (string)
description = '~/tmp2 (overlay)'  (string)
icon = 'folder'  (string)
StorageAccess.accessible = true  (bool)
StorageAccess.filePath = '/home/stefan/tmp2'  (string)
StorageAccess.ignored = false  (bool)

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D22080

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 61 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/61/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 16:10:21 +
 Build duration:
2 min 44 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2246)18%
(178/1001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)60%
(60/100)src100%
(8/8)100%
(8/8)68%
(226/331)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
 

D21986: Change initial size of the config dialog

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:e6e0be782237: Change initial size of the config dialog 
(authored by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21986?vs=60310=60599

REVISION DETAIL
  https://phabricator.kde.org/D21986

AFFECTED FILES
  src/widgets/JobDialog.qml

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21986: Change initial size of the config dialog

[Nicolas Fella]

nicolasfella retitled this revision from "RFC: Change initial size of the 
config dialog" to "Change initial size of the config dialog".

REPOSITORY
  R495 Purpose Library

BRANCH
  size

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22076

To: broulik, #plasma, mart, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

[Kai Uwe Broulik]

broulik added a dependent revision: D22077: [Colors KCM] Add title bar to 
preview delegate.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22076

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It only affected the `cellHeight` of the `GridView` but not the actual size 
of the delegate contents container inside.
  The `- 2 * gridUnit` undoes the `+ 2 * gridUnit` in the `GridView`'s default 
`implicitCellHeight`

TEST PLAN
  - Changed `view.implicitCellHeight` to some arbitrary value: had the cell 
delegate look perfect without the contents overflowing
  - Normal KCMs like icons still look fine

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22076

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D15739: [Places panel] Don't show Root by default

[Fabian Vogt]

fvogt added a comment.


  In D15739#486043 , @bruns wrote:
  
  > In D15739#486020 , @fvogt wrote:
  >
  > > In D15739#486009 , @bruns 
wrote:
  > >
  > > > It actually already does, via the fstab backend (currently network 
(SMB/NFS) and various fuse mounts). Fstab in this case also includes everything 
in MTAB, should be quite easy to extend this.
  > > >
  > > > What is the output of `cat /proc/self/mounts` (fell free to remove 
anything irrelevant, like cgroups)?
  > >
  > >
  > > The entries involved in / are these:
  > >
  > >   /dev/sr0 /run/initramfs/live iso9660 ro,relatime 0 0
  > >   /dev/loop0 /run/initramfs/squashfs_container squashfs ro,relatime 0 0
  > >   /dev/loop1 /run/rootfsbase ext4 ro,relatime,data=ordered 0 0
  > >   LiveOS_rootfs / overlay 
rw,relatime,lowerdir=/run/rootfsbase,upperdir=/run/overlayfs/rw,workdir=/run/overlayfs/work
 0 0
  > >
  >
  >
  > Hm, loop1 is the `lowerdir` of the overlay - how are loop0 and sr0 
involved, are these the backing files?
  
  
  /dev/sr0 contains a squashfs, which is visible as /dev/loop0.
  /dev/loop0 contains an ext4 image, which is visible as /dev/loop1.
  
  So it's doubly indirect.
  
  > Though, the relevant part is `mntent.mnt.type == "overlay"` and 
`mntent.mnt_dir == "/"`. Matching for "overlay" is probably sufficient.
  
  If adding such a special case makes sense, yes. I'd even argue about 
'mntent.mnt_dir == "/" && isKnownFilesystem(mntent)' or something like that to 
ensure that an entry for `/` is always provided.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: andriusr, fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, 
ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Stefan Brüns]

bruns added a comment.


  In D15739#486020 , @fvogt wrote:
  
  > In D15739#486009 , @bruns wrote:
  >
  > > It actually already does, via the fstab backend (currently network 
(SMB/NFS) and various fuse mounts). Fstab in this case also includes everything 
in MTAB, should be quite easy to extend this.
  > >
  > > What is the output of `cat /proc/self/mounts` (fell free to remove 
anything irrelevant, like cgroups)?
  >
  >
  > The entries involved in / are these:
  >
  >   /dev/sr0 /run/initramfs/live iso9660 ro,relatime 0 0
  >   /dev/loop0 /run/initramfs/squashfs_container squashfs ro,relatime 0 0
  >   /dev/loop1 /run/rootfsbase ext4 ro,relatime,data=ordered 0 0
  >   LiveOS_rootfs / overlay 
rw,relatime,lowerdir=/run/rootfsbase,upperdir=/run/overlayfs/rw,workdir=/run/overlayfs/work
 0 0
  >
  
  
  Hm, loop1 is the `lowerdir` of the overlay - how are loop0 and sr0 involved, 
are these the backing files?
  
  Though, the relevant part is `mntent.mnt.type == "overlay"` and 
`mntent.mnt_dir == "/"`. Matching for "overlay" is probably sufficient.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: andriusr, fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, 
ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22073: [KCM GridDelegate] Silence warning

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When the model doesn't have a `pluginName` property

TEST PLAN
  Color kcm no longer prints warnings, ksplash "none" still shows X

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22073

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D15739: [Places panel] Don't show Root by default

[Fabian Vogt]

fvogt added a comment.


  In D15739#486009 , @bruns wrote:
  
  > In D15739#485983 , @fvogt wrote:
  >
  > > Even if all (block) devices and their mountpoints were shown in the 
devices view, there would be no equivalent of "/". One loop device provides the 
read-only base for /, but that's actually more confusing than the current state 
as it looks like /, but is only a read-only view of "the past".
  > >
  > > I guess solid needs to gain support for mountpoints not backed by devices?
  >
  >
  > It actually already does, via the fstab backend (currently network 
(SMB/NFS) and various fuse mounts). Fstab in this case also includes everything 
in MTAB, should be quite easy to extend this.
  >
  > What is the output of `cat /proc/self/mounts` (fell free to remove anything 
irrelevant, like cgroups)?
  
  
  The entries involved in / are these:
  
/dev/sr0 /run/initramfs/live iso9660 ro,relatime 0 0
/dev/loop0 /run/initramfs/squashfs_container squashfs ro,relatime 0 0
/dev/loop1 /run/rootfsbase ext4 ro,relatime,data=ordered 0 0
LiveOS_rootfs / overlay 
rw,relatime,lowerdir=/run/rootfsbase,upperdir=/run/overlayfs/rw,workdir=/run/overlayfs/work
 0 0

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: andriusr, fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, 
ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Stefan Brüns]

bruns added a comment.


  In D15739#485983 , @fvogt wrote:
  
  > Even if all (block) devices and their mountpoints were shown in the devices 
view, there would be no equivalent of "/". One loop device provides the 
read-only base for /, but that's actually more confusing than the current state 
as it looks like /, but is only a read-only view of "the past".
  >
  > I guess solid needs to gain support for mountpoints not backed by devices?
  
  
  It actually already does, via the fstab backend (currently network (SMB/NFS) 
and various fuse mounts). Fstab in this case also includes everything in MTAB, 
should be quite easy to extend this.
  
  What is the output of `cat /proc/self/mounts` (fell free to remove anything 
irrelevant, like cgroups)?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: andriusr, fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, 
ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Andrius da Costa Ribas]

andriusr added a comment.


  In D15739#485978 , @fvogt wrote:
  
  > In D15739#485976 , @ngraham 
wrote:
  >
  > > In D15739#485975 , @fvogt 
wrote:
  > >
  > > > No, there's in fact no devices section at all as it would be empty. The 
live cd itself is marked as ignored as there's nothing useful on there and it 
can't be ejected and the other layers are mounted from loop devices which 
udisks apparently ignores as well.
  > >
  > >
  > > That seems like a bug in the way the devices list is populated or 
displayed. There can't be no devices, that's silly.
  >
  >
  > Well, the only mount of interest is the overlay mount of /, which is not 
backed by any (block) device but rather by two filesystems. AFAICT udisks 
doesn't care about this kind of mount, not sure what solid does.
  >
  > Showing an overlay mount as "Device" is also somewhat wrong IMO.
  
  
  On Windows, we show "subst" drives as a Device, which is a bit similar to 
that, if solid could list those "virtual" devices so they're available on the 
places panel it would be useful for easy access to those mountpoints imho.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: andriusr, fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, 
ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  Could be. I'm not at all an expert on Solid; I just think that it never makes 
sense to have a Places Panel with no Devices section. How to fix that is 
definitely best left up to people far smarter than me. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Fabian Vogt]

fvogt added a comment.


  In D15739#485979 , @ngraham wrote:
  
  > In D15739#485978 , @fvogt wrote:
  >
  > > Well, the only mount of interest is the overlay mount of /, which is not 
backed by any (block) device but rather by two filesystems. AFAICT udisks 
doesn't care about this kind of mount, not sure what solid does.
  > >
  > > Showing an overlay mount as "Device" is also somewhat wrong IMO.
  >
  >
  > I'm saying that regardless of the technical details of the backend, it 
never makes sense to not show any devices. From the user's perspective, there 
is always a device of some sort, regardless of its underlying configuration. 
There can't not be a device. That doesn't make sense; software requires 
hardware.
  
  
  Even if all (block) devices and their mountpoints were shown in the devices 
view, there would be no equivalent of "/". One loop device provides the 
read-only base for /, but that's actually more confusing than the current state 
as it looks like /, but is only a read-only view of "the past".
  
  I guess solid needs to gain support for mountpoints not backed by devices?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  In D15739#485978 , @fvogt wrote:
  
  > Well, the only mount of interest is the overlay mount of /, which is not 
backed by any (block) device but rather by two filesystems. AFAICT udisks 
doesn't care about this kind of mount, not sure what solid does.
  >
  > Showing an overlay mount as "Device" is also somewhat wrong IMO.
  
  
  I'm saying that regardless of the technical details of the backend, it never 
makes sense to not show any devices. From the user's perspective, there is 
always a device of some sort, regardless of its underlying configuration. There 
can't not be a device. That doesn't make sense; software requires hardware.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Fabian Vogt]

fvogt added a comment.


  In D15739#485976 , @ngraham wrote:
  
  > In D15739#485975 , @fvogt wrote:
  >
  > > No, there's in fact no devices section at all as it would be empty. The 
live cd itself is marked as ignored as there's nothing useful on there and it 
can't be ejected and the other layers are mounted from loop devices which 
udisks apparently ignores as well.
  >
  >
  > That seems like a bug in the way the devices list is populated or 
displayed. There can't be no devices, that's silly.
  
  
  Well, the only mount of interest is the overlay mount of /, which is not 
backed by any (block) device but rather by two filesystems. AFAICT udisks 
doesn't care about this kind of mount, not sure what solid does.
  
  Showing an overlay mount as "Device" is also somewhat wrong IMO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  In D15739#485975 , @fvogt wrote:
  
  > No, there's in fact no devices section at all as it would be empty. The 
live cd itself is marked as ignored as there's nothing useful on there and it 
can't be ejected and the other layers are mounted from loop devices which 
udisks apparently ignores as well.
  
  
  That seems like a bug in the way the devices list is populated or displayed. 
There can't be no devices, that's silly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Fabian Vogt]

fvogt added a comment.


  In D15739#485960 , @ngraham wrote:
  
  > In D15739#485949 , @fvogt wrote:
  >
  > > I just noticed this in openQA runs from a live medium. There is no 
single-click way to get to the root directory anymore, as / is mounted as an 
overlayfs of a tmpfs and a squashfs container.
  > >
  > > Not sure what the best way to improve this is, any idea?
  >
  >
  > So there's no entry in the Devices section that goes to `/`?
  
  
  No, there's in fact no devices section at all as it would be empty. The live 
cd itself is marked as ignored as there's nothing useful on there and it can't 
be ejected and the other layers are mounted from loop devices which udisks 
apparently ignores as well.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  In D15739#485949 , @fvogt wrote:
  
  > I just noticed this in openQA runs from a live medium. There is no 
single-click way to get to the root directory anymore, as / is mounted as an 
overlayfs of a tmpfs and a squashfs container.
  >
  > Not sure what the best way to improve this is, any idea?
  
  
  So there's no entry in the Devices section that goes to `/`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Fabian Vogt]

fvogt added a comment.


  I just noticed this in openQA runs from a live medium. There is no 
single-click way to get to the root directory anymore, as / is mounted as an 
overlayfs of a tmpfs and a squashfs container.
  
  Not sure what the best way to improve this is, any idea?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, 
romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22069: Localize long number strings

[Nathaniel Graham]

ngraham added a comment.


  So I'm trying this:
  
  P421 localized  number tests 
  
  But it doesn't seem to work:
  
FAIL!  : KLocalizedStringTest::correctSubs() Compared values are not the 
same
   Actual   (ki18n("%1").subs(4.2, 5, 'f', 2).toString()): " 4.20"
   Expected (QString(" 4,20"))   : " 4,20"
   Loc: [/home/nate/kde/src/ki18n/autotests/klocalizedstringtest.cpp(226)]
  
  What am I doing wrong?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  After some discussion, we realized we have three different sets of "recent 
documents" backends :
  
  - recentdocument ioslave using KDirWatch that miss accessed dir and files 
(used in places)
  - baloo's timeline ioslave using baloo extractor, that requires baloo but has 
indexing and filtering capatibilities (used in places)
  - kactivities-stats that has activity context, and works for modified or 
accessed files, but that has no ioslave (used in kickoff and kicker)
  
  It appears kactivities-stats has the best feature set compare to 
recentdocuments.
  
  So my plan is to create a kacitity-stats "recentdocuments" ioslave and 
overwrite current recentdocumenst ioslave with it.
  And then used this primarly in dolphin/kfilewidgets with baloo still 
optionally around for its advanced features.
  
  CC @davidedmundson @kbroulik

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22069: Localize long number strings

[Alexander Potashev]

aspotashev added a comment.


  You might want to test against different locales, like this: 
https://cgit.kde.org/ktimetracker.git/tree/src/tests/formattimetest.cpp

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, 
ngraham, bruns

D22069: Localize long number strings

[Nathaniel Graham]

ngraham added a comment.


  The test passes for me, but I guess because I'm using English, right?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

[Chusslove Illich]

ilic added a comment.


  Still lacks the change in unit test in autotests/klocalizedstringtest.cpp, 
from " 4.20" to " 4,20".

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Localization, Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Localize long number strings so that they get the proper locale-specific 
separator.
  
  This is @broulik's old patch from https://git.reviewboard.kde.org/r/127800/, 
which
  works just fine. Will commit with his authorship if this lands.
  
  BUG: 409077
  FIXED-IN: 5.60

TEST PLAN
  Unit tests pass.
  
  With US English locale, before: F6930198: Before.png 

  
  With US English locale, after: F6930199: After.png 


REPOSITORY
  R249 KI18n

BRANCH
  localized-long-number-strings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22069

AFFECTED FILES
  src/klocalizedstring.cpp

To: ngraham, #localization, #frameworks, broulik
Cc: kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:1772904c2980: set the focusPolicy of kpasswordlineedit to 
the policy of its proxy (authored by sitter).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21894?vs=60048=60561

REVISION DETAIL
  https://phabricator.kde.org/D21894

AFFECTED FILES
  src/kpasswordlineedit.cpp

To: sitter, cfeck
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21959: Fix selectedNameFilter() multiple matches

[Robert Hoffmann]

hoffmannrobert added a comment.


  Can you please push it for me, I don't have commit access. Thanks.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  fix_selectedNameFilter

REVISION DETAIL
  https://phabricator.kde.org/D21959

To: hoffmannrobert, #frameworks, apol, dfaure
Cc: michaelweghorn, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22061: Add a logging category for logs warnings

[Aleix Pol Gonzalez]

apol added a comment.


  The patch looks good to me.
  
  I see that you're just doing KDesktopFile, but there's many others available, 
can you port the rest too?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven updated this revision to Diff 60558.
meven added a comment.


  Use KCONF_CORE_LOG as identifier and kf5.kconfig.core as category_name

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60547=60558

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:19
> +IDENTIFIER KCONF_DESKTOP_LOG
> +CATEGORY_NAME kf5.kconfig.desktop)
> +

This is for KF5ConfigCore, I'd call it kf5.kconfig.core.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns