D23420: Use solid to check if a a KFileItem is located on a network mount

anthonyfieroni added inline comments. INLINE COMMENTS > meven wrote in kfileitem.cpp:764 > Can't because of > > Solid::StorageAccess *storageAccess = device.as(); Get it as `const Solid::StorageAccess`, you can use `auto storageAccess = ...` REPOSITORY R241 KIO BRANCH solid-network-fs-c

D23420: Use solid to check if a a KFileItem is located on a network mount

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:764 > const & Can't because of Solid::StorageAccess *storageAccess = device.as(); REPOSITORY R241 KIO BRANCH solid-network-fs-check REVISION DETAIL https://phabricator

D23372: Add operator |= for Query Terms

meven abandoned this revision. meven added a comment. Abandoned in favor of D23399 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23372 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

asturmlechner marked 2 inline comments as done. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D21795: [KAuth] Add support for action details in Polkit1 backend.

chinmoyr added inline comments. INLINE COMMENTS > sitter wrote in Polkit1Backend.cpp:193 > looks to me this was only added 4 months ago. so this would probably require > a version bump. seeing as we are fairly conservative with frameworks' > requirements it may be better to `if version>=whatevs

D23444: Remove applets/22/computer

ndavis added a comment. In D23444#518948 , @ngraham wrote: > Are you sure this fixes the issue? I tried out the patch and deleted the removed files manually, but it didn't make a difference. Yes, but verifying the fix is a little tricky.

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what the abundance of online pcre docs say, and how other editors that use pcre behave? IIUC, '\s' was workedaround so as not to match a newline so that the search pattern wouldn'

D23447: Set the OpenSCAD indenter to C-style instead of none.

This revision was automatically updated to reflect the committed changes. Closed by commit R216:8a50002871dc: Set the OpenSCAD indenter to C-style instead of none. (authored by mickaelbo, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricato

D23457: Port regex search to QRegularExpression

cullmann added a comment. In D23457#519206 , @ahmadsamir wrote: > In D23457#519205 , @cullmann wrote: > > > Hi, without any further look at the code changes, I don't think an behavior change like "

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#519205 , @cullmann wrote: > Hi, without any further look at the code changes, I don't think an behavior change like "\s can match a newline" is a good idea. > Or do I misunderstand that? It's exact

D23457: Port regex search to QRegularExpression

cullmann added a comment. Hi, without any further look at the code changes, I don't think an behavior change like "\s can match a newline" is a good idea. Or do I misunderstand that? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexted

D23447: Set the OpenSCAD indenter to C-style instead of none.

mickaelbo added a comment. Yup, Mickael Bosch mickael.bo...@linux.com Thanks, REVISION DETAIL https://phabricator.kde.org/D23447 To: mickaelbo, #framework_syntax_highlighting, cullmann Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, julianstirling, LeGast00n, GB_2, domson

D23447: Set the OpenSCAD indenter to C-style instead of none.

cullmann added a comment. Can you pass me name + mail address for the commit? REVISION DETAIL https://phabricator.kde.org/D23447 To: mickaelbo, #framework_syntax_highlighting, cullmann Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, julianstirling, LeGast00n, GB_2, domson, micha

D23447: Set the OpenSCAD indenter to C-style instead of none.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I see, I missed that you did only change the indentation of the file, I thought you did alter some highlighting rules, too ;) REVISION DETAIL https://phabricator.kde.org/D23447 To: m

D23457: Port regex search to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Do away with the kateregexp class; move isMultiLine() to kateregexpsearch - \s can match a ne

D23447: Set the OpenSCAD indenter to C-style instead of none.

mickaelbo added a comment. Thank you for the "js way" to modify the indentation. I will have a look at this tomorrow. From what I see, the *.scad* files in the autotest directory are exclusively related to hightlighting and folding, nothing is related to the indenter expected behavior (

D23447: Set the OpenSCAD indenter to C-style instead of none.

cullmann added a comment. For the cstyle + additional keywords: at the moment there is no way to "automatically propagate that", but one could alter the js code to use different trigger words for different highlightings. Btw., how do one see that this is nicer? Does the highlighting of t

D23447: Set the OpenSCAD indenter to C-style instead of none.

ngraham added a comment. +1, this is nicer. REVISION DETAIL https://phabricator.kde.org/D23447 To: mickaelbo, #framework_syntax_highlighting Cc: ngraham, kwrite-devel, kde-frameworks-devel, julianstirling, LeGast00n, GB_2, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D23194: Making FileJob behave consistently.

feverfew added inline comments. INLINE COMMENTS > dfaure wrote in filejob.h:112 > Why would someone request reading 0 bytes? That doesn't seem sensible to me. Well it can happen and this is technically more correct than saying that an empty `QByteArray()` is always EOD. In fact, the one of the

D23450: Icons for ROOT cern files.

yurchor added a comment. In D23450#519095 , @alexde wrote: > For some reason if I try to set the icons for ".root" files, they are shown in the dialog box, the icon can be set, but they are not shown in Dolphin. Has anyone an idea what I am doin

D23454: Fixing bug where MTP slave does not return error in stat()/mimetype()

feverfew created this revision. feverfew added reviewers: chinmoyr, akrutzler, elvisangelaccio, dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This patch fixes two cases w

D22477: With auto completion don't show completions that don't match from beginning of typed word

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Actually, I did read the bug once more and tried it out myself. I think we should not unconditionally remove that feature. If you read the bug, one user complaints about it,

D23450: Icons for ROOT cern files.

alexde added reviewers: ngraham, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23450 To: alexde, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23450: Icons for ROOT cern files.

alexde added a comment. For some reason if I try to set the icons for ".root" files, they are shown in the dialog box, the icon can be set, but they are not shown in Dolphin. Has anyone an idea what I am doing wrong? Those files I have submitted are compressed. I attach the uncompressed

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

dhaumann added a comment. In D23323#516317 , @apol wrote: > Makes sense, but I feel some explanation is missing ^^' > > Put it in the commit message? Better: put it into the API documentation? REPOSITORY R241 KIO REVISION DETAIL

D23447: Set the OpenSCAD indenter to C-style instead of none.

mickaelbo updated this revision to Diff 64607. mickaelbo added a comment. Set the section to 3D and few style changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23447?vs=64598&id=64607 REVISION DETAIL https://phabricator.kde.org/D23447 AFFECTED FILES data/syntax/openscad.x

D23450: Icons for ROOT cern files.

alexde edited the summary of this revision. alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23450 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23450: Icons for ROOT cern files.

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH root-cern-icons (branched from master) REVISION DETAIL https://phab

D22477: With auto completion don't show completions that don't match from beginning of typed word

cullmann added a comment. Any feedback on that from others? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, kfunk Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D23400: reST: handle some more corner cases, add an actual test file

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Feel free to push this. (if you have no commit rights, please provide name + mail address, then we push) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.k

D23061: Possiblity to change Definition data after loading

This revision was automatically updated to reflect the committed changes. Closed by commit R216:21c3f38f6091: Possiblity to change Definition data after loading (authored by sirgienko, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.k

D23061: Possiblity to change Definition data after loading

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this is ok. One can fine-tune the API docs still afterwards. I see no "this is all evil" comments, therefore I approve this now! Thanks for the contribution and I hope this

D23447: Set the OpenSCAD indenter to C-style instead of none.

mickaelbo created this revision. mickaelbo added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added a subscriber: kde-frameworks-devel. mickaelbo requested review of this revision. REVISION SUMMARY OpenSCAD uses braces enclosed blocks, you can see e

D23061: Possiblity to change Definition data after loading

sirgienko added inline comments. INLINE COMMENTS > dhaumann wrote in definition.h:339 > Fair enough :-) What you just described here is missing in the API > documentation. Can you add this to setKeywordList()? Then it's clear to the > user of KSyntaxHighlighting (e.g. that you have to force a r

D23061: Possiblity to change Definition data after loading

sirgienko updated this revision to Diff 64595. sirgienko added a comment. Add explanation, how setKeywordList can be used REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23061?vs=63599&id=64595 BRANCH read-write REVISION DETAIL https://phab

D21897: Address some issues reported by Krazy analysis

elvisangelaccio accepted this revision. elvisangelaccio added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > vkrause wrote in krichtextwidget.cpp:638 > This is unusual, but it's the right way around. The point of this is to check > if the dialog has been dele

D21897: Address some issues reported by Krazy analysis

vkrause added inline comments. INLINE COMMENTS > elvisangelaccio wrote in krichtextwidget.cpp:638 > This should be `linkDialog && linkDialog->exec()` This is unusual, but it's the right way around. The point of this is to check if the dialog has been deleted during the sub-eventloop behind exec

D23444: Remove applets/22/computer

ngraham added a comment. Are you sure this fixes the issue? I tried out the patch and deleted the removed files manually, but it didn't make a difference. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23444 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel,

D21695: Add FindTaglib.cmake

ngraham added a comment. @heikobecker ping! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21695 To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure Cc: ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n, GB_2, bencreasy, michaelh, brun

D21897: Address some issues reported by Krazy analysis

elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtextwidget.cpp:638 > > -if (linkDialog->exec()) { > +if (linkDialog->exec() && linkDialog) { > q->updateLink(linkDial

D23444: Remove applets/22/computer

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23444 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23444: Remove applets/22/computer

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23444 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23444: Remove applets/22/computer

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG:410854 REPOSITORY R266 Breeze Icons BRANCH remove-applet-computer (branched from m

D22653: Add view-barcode-qr icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7461f90af829: Add view-barcode-qr icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=64574&id=64575 REVISION DETAIL https:/

D22653: Add view-barcode-qr icons

ndavis marked 6 inline comments as done. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D22653 REVISION DETAIL https://phabricator.kde.org/D22653 To: ndavis, #breeze, ngraham, mbruchert Cc: lavender, ngraham, broulik, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22653: Add view-barcode-qr icons

ndavis updated this revision to Diff 64574. ndavis added a comment. - Make 32px be 32px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62915&id=64574 BRANCH arcpatch-D22653 REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FIL

D22653: Add view-barcode-qr icons

ndavis commandeered this revision. ndavis edited reviewers, added: mbruchert; removed: ndavis. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 To: ndavis, #breeze, ngraham, mbruchert Cc: lavende

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 25 Aug 2019 12:20:47 + Build duration: 7 min 49 sec and counting JUnit Tests Name: projectroo

D23336: [KDirOperator] Add follow new directories options

dhaumann added a comment. Thanks for the explanation. Such details could also be mentioned in the class description as a separate \section. The explanation in the review request will be lost at some point, since we unlikely will stay on phabricator forever. REPOSITORY R241 KIO REVISION DE

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:ce148291392c: rename internal 'kioslave' helper executable to 'kioslave5' (authored by cullmann). REPOSITORY R241 KI

D23416: Highlighting indexer: check kateversion

dhaumann added a comment. Thanks for pushing this forward, very much appreciated! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23416 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2

D23422: Fix: allow turn off attributes in XML highlighting files

dhaumann added a comment. Yes, thanks a lot! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23422 To: nibags, #ktexteditor, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dh

D23269: Fix creating archives on Android content: URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R243:9cdcc8afdcc8: Fix creating archives on Android content: URLs (authored by vkrause). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23269?vs=64055&id=64544 REVISIO

D23411: Fix crash in writer collection and cleanup

astippich updated this revision to Diff 64543. astippich added a comment. - further improvements REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23411?vs=64514&id=64543 BRANCH fixWriterCollection REVISION DETAIL https://phabricator.kde.org/D23411

D23422: Fix: allow turn off attributes in XML highlighting files

cullmann added a comment. Great! Feel free to commit this. Btw., I really appreciate all the work you do to improve the highlighting! I was astonished that we already amassed more than 300 highlighting files in total: https://kate-editor.org/syntax/ REPOSITORY R39 KTextE

D23422: Fix: allow turn off attributes in XML highlighting files

nibags closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23422 To: nibags, #ktexteditor, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23422: Fix: allow turn off attributes in XML highlighting files

nibags added a comment. Yes, it has to do with that bug. Later I will add the functions to the KSyntaxHighlighting API to correct this. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D23422 To: nibags, #ktexteditor, dhaumann, cullmann Cc: kwrite

D23416: Highlighting indexer: check kateversion

This revision was automatically updated to reflect the committed changes. Closed by commit R216:263907f0fd1c: Highlighting indexer: check kateversion (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23416?vs=64528&id=64542#toc REPOSITORY R216

D23416: Highlighting indexer: check kateversion

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice! I have no idea why the diff looks here that big, locally after arc patch I have a nicer diff that shows the added code is fine. Thanks that you take care of such things! REPOS

D23420: Use solid to check if a a KFileItem is located on a network mount

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfileitem.cpp:764 > +const QList devices = > Solid::Device::listFromType(Solid::DeviceInterface::NetworkShare); > +for (Solid::Device device : devices)

D23422: Fix: allow turn off attributes in XML highlighting files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this is a good start to fix this issue. Would you be willing to provide the needed extensions to the KSyntaxHighlighting API, too? This is related to this bug. or?

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure added inline comments. INLINE COMMENTS > recentlyused.cpp:186 > +{ > +qCDebug(KIO_RECENTLYUSED_LOG) << "udsEntryFromResource" << " " << > resource; > + You don't need spaces between items, when using q[C]Debug > meven wrote in recentlyused.h:57 > It is path currently due to limitati

D23422: Fix: allow turn off attributes in XML highlighting files

nibags created this revision. nibags added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In syntax highlighting XML files, it doesn't wo

D22510: Added dialog to set execute permission for executable file when trying to run it.

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krun.cpp:1105 > const bool isFileExecutable = (isExecutableFile(m_strURL, mime.name()) || > > mime.inherits(QStringLi

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 25 Aug 2019 09:52:14 + Build duration: 7 min 38 sec and counting JUnit Tests Name: pro

D23410: improve word completion to use highlighting to detect word boundaries

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8d0f6ff8014c: improve word completion to use highlighting to detect word boundaries (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23410?v

D23420: Use solid to check if a a KFileItem is located on a network mount

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23420 To: meven, dfaure, #frameworks Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23420: Use solid to check if a a KFileItem is located on a network mount

meven updated this revision to Diff 64538. meven added a comment. Fix logic REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23420?vs=64537&id=64538 BRANCH solid-network-fs-check REVISION DETAIL https://phabricator.kde.org/D23420 AFFECTED FILES src/core/

D23420: Use solid to check if a a KFileItem is located on a network mount

anthonyfieroni added inline comments. INLINE COMMENTS > kfileitem.cpp:767-771 > +m_slow = Slow; > +break; > +} > } > +m_slow = Fast; Wrong logic, when you set it to Slow, after break it will go to line 771 and became Fast again. Set i

D23420: Use solid to check if a a KFileItem is located on a network mount

meven created this revision. meven added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY KFileSystemType uses statvfs syscall that blocks when a network fs mount becomes

D22144: Add kio recentlyused:/ to access KActivityStats data

meven planned changes to this revision. meven added a comment. inherit from SlaveBase instead of ForwardingSlaveBase REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-d

D23410: improve word completion to use highlighting to detect word boundaries

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Using isInWord() is what I would have expected. It's wrong that it does not use isInWord (). I had to read about isMark() first, but I think this is correct and we should give it a