D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

kossebau retitled this revision from "Fix pri file: have qmake name of QtGui as dep, to not fail with CamelCase includes" to "Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes". REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27334 To:

D27463: KconfigXT: Add a value attribute to Enum field choices

meven created this revision. meven added reviewers: ervin, bport, crossi, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Allow to write choices such as : TEST

D27357: Fix infinite recursion in xscreensaver plugin

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D27357 To: alnikiforov, davidedmundson, broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master) REVISION DETAIL https://phabricator.kde.org/D27459 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27460: fix layout size hints for button labels

mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27460 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27328: Drop qmake pri file generation & installation, currently broken

This revision was automatically updated to reflect the committed changes. Closed by commit R282:015a4d01140e: Drop qmake pri file generation installation, currently broken (authored by kossebau). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D27327: Drop qmake pri file generation & installation, currently broken

This revision was automatically updated to reflect the committed changes. Closed by commit R281:3b16da10e770: Drop qmake pri file generation installation, currently broken (authored by kossebau). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D27334: Fix pri file: have qmake name of QtGui as dep, do not fail with CamelCase includes

kossebau added a comment. Ping? Will land on Thursday otherwise, given I am sure about these 2 fixes to make prison usable with qmake at all. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27334 To: kossebau, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack,

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 75852. meven added a comment. update xsd REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=75837=75852 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

Standardizing Qt logging categories used in KF

Hi, while going through the KF modules to adapt to the new ecm_qt_install_logging_categories() macro* to auto-generate KDebugSettings .categories (& .renamecategories) files I once more found there is no real naming pattern for the logging categories. *

D27451: Drop KToolInvocation support from KRun::runService

davidedmundson updated this revision to Diff 75867. davidedmundson added a comment. Remove extra include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27451?vs=75811=75867 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27451 AFFECTED FILES

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack created this revision. cblack added reviewers: KWin, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This patch adds an interface allowing a compositor to send the service name and

D27065: Fix inverted logic in IOKitStorage::isRemovable

This revision was automatically updated to reflect the committed changes. Closed by commit R245:d2172d3c0843: Fix inverted logic in IOKitStorage::isRemovable (authored by mwolff). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27065?vs=74772=75857 REVISION

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > kcoreconfigskeleton.h:459 > +// given we can't, I've shadowed the method. This isn't pretty, but given > +// the docs say it should generally only be used from auto generated > code, > void

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 75855. cblack added a comment. Figure out how to use arc correctly REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=75854=75855 BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack planned changes to this revision. cblack added a comment. whoops, I seem to have forgotten how to use arc REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27223: add kirigami-gallery icon

mbruchert added a comment. thank you so much! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis Cc: ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

mbruchert updated this revision to Diff 75859. mbruchert added a comment. - fix issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=75772=75859 BRANCH arcpatch-D27223 REVISION DETAIL https://phabricator.kde.org/D27223 AFFECTED FILES

D27468: Don't double delete CommentsModel

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY CommentsModel instances are owned by the engine. They are fetched through a getter with a cache, so

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/62/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 17 Feb 2020 19:10:20 + Build duration: 1 min 57 sec and counting JUnit Tests Name:

D27463: KconfigXT: Add a value attribute to Enum field choices

davidre added a comment. If you touch the xsd do you neeed to increase the version number? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 309 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/309/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 18 Feb 2020 05:03:58 + Build duration: 17 min and counting BUILD ARTIFACTS

D27455: FileWidgets: Ignore Return events from KDirOperator

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, works for me. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: kde-frameworks-devel,

Re: 2 kirigami fixes for a point release

Am Dienstag, 18. Februar 2020, 04:03:05 CET schrieb Nate Graham: > On 2020-02-16 14:43, Albert Astals Cid wrote: > > Maybe i explain myself wrongly, i'm not blaming distros at all. > > > > They made a decision, we/I may agree with them or not, that's *my/our* > > problem, what I was disagreeing

D27459: Port QLinkedList which is deprecated in qt5.15

aacid added a comment. Are we sure we can lose the features of QLinkedList here? maybe makes more sense to use std::list that has the same features as QLinkedList? REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master) REVISION DETAIL

Re: 2 kirigami fixes for a point release

In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto: > think KDE software should be presented to users. Basically, we > acknowledge that Neon is already an actual OS--the "KDE OS"--and we Please don't suggest such downstream-hostile solutions, in particular because this

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 434 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/434/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 05:04:02 + Build duration: 9 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 301 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/301/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 18 Feb 2020 05:03:58 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

ervin added a comment. Sounds innocuous indeed and I always found that queued connection weird... I mean resetting to false whatever happens during load? That's fine for simple cases but not real complex ones. Still, can we have some more extensive testing on a good chunk of the modules

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

davidedmundson added a comment. I found out why this was added. 7e4b9688d52f55828ba4a5b82e9d8fe5b1a5ff94 In 2008 things changed to being loaded in the showEvent Many people blindly connecting to widgets

D27455: FileWidgets: Ignore Return events from KDirOperator

meven created this revision. meven added reviewers: dfaure, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Activated event is used to handle key returns from KDirOperator. Making a Return

D27455: FileWidgets: Ignore Return events from KDirOperator

meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27455: FileWidgets: Ignore Return events from KDirOperator

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26769: Always strip html if server does not support it

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Also, title must never be HTML, there's a reason the capability is called //body//-markup :) REPOSITORY R289 KNotifications BRANCH stripcorrently REVISION DETAIL

D26769: Always strip html if server does not support it

mart accepted this revision. REPOSITORY R289 KNotifications BRANCH stripcorrently REVISION DETAIL https://phabricator.kde.org/D26769 To: nicolasfella, #frameworks, broulik, mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Taking over KNotifications maintainership

Hi all, I propose to make me the official maintainer of KNotifications given that's pretty much what I've been doing for quite some time already anyway. It still lists Martin Klapetek as maintainer who unfortunately isn't very active anymore. Cheers Kai Uwe

Re: Taking over KNotifications maintainership

El dl., 17 de febr. 2020, 12:19, Kai Uwe Broulik va escriure: > Hi all, > > I propose to make me the official maintainer of KNotifications given > that's pretty much what I've been doing for quite some time already anyway. > > It still lists Martin Klapetek as maintainer who unfortunately isn't

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

ervin added a comment. Yes, we really need a large clean up in this area, we got strata of old cruft layered on top often with duplicated states between them. We also have the widget and QML cases being very different in their state management (one comparing widget content with the settings

D27455: FileWidgets: Ignore Return events from KDirOperator

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27455 To: meven, dfaure, ngraham, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

ahiemstra added a comment. @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? BRANCH master REVISION DETAIL https://phabricator.kde.org/D25794 To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25795: Rename kf5quickcharts_example to kquickcharts_example

ahiemstra added a comment. @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? BRANCH master REVISION DETAIL https://phabricator.kde.org/D25795 To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker added a comment. In D25794#612748 , @ahiemstra wrote: > @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? I have and I already committed it:

D25795: Rename kf5quickcharts_example to kquickcharts_example

heikobecker closed this revision. heikobecker added a comment. In D25795#612749 , @ahiemstra wrote: > @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? I have

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

heikobecker closed this revision. REVISION DETAIL https://phabricator.kde.org/D25794 To: heikobecker, #frameworks, ahiemstra, davidedmundson

Re: 2 kirigami fixes for a point release

On Mon, Feb 17, 2020 at 10:43 AM Albert Astals Cid wrote: > > El diumenge, 16 de febrer de 2020, a les 22:34:51 CET, David Faure va > escriure: > > On dimanche 16 février 2020 22:17:17 CET Albert Astals Cid wrote: > > > This is their fault, they as a distribution have decided to support a > > >

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 183 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/183/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 17 Feb 2020 08:51:40 + Build duration: 19 min and counting BUILD ARTIFACTS

D27452: KCModule remove queued call to changed(false). Broke ConfigModule KCM

bport created this revision. bport added reviewers: Plasma, davidedmundson, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Currently from David Edmundson comment on

Re: 2 kirigami fixes for a point release

On Mon, Feb 17, 2020 at 10:55 AM Friedrich W. H. Kossebau wrote: > > Sorry, no time to rewrite to make this short. > > Am Mittwoch, 12. Februar 2020, 21:59:32 CET schrieb Nate Graham: > > [+ frameworks and plasma mailing lists] > > > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > > El

D27451: Drop KToolInvocation support from KRun::runService

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This drops the use of kinit as per T12140 . Few applications link to

D27451: Drop KToolInvocation support from KRun::runService

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27451 To: davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

wbauer added a comment. In D11880#331450 , @ngraham wrote: > However, there seems to be a problem for the breeze dark versions: > F6283726: Screenshot_20180924_215524.png > > Shouldn't the wall be

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi added a reviewer: mdawson. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27059 To: crossi, ervin, dfaure, #frameworks, mdawson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port QLinkedList (deprecated in qt5.15) REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master)

D27459: Port QLinkedList which is deprecated in qt5.15

mlaurent added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D27459 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27451: Drop KToolInvocation support from KRun::runService

ervin added a comment. For the record, it LGTM and I'm glad to see this point discussing during the sprint coming through. :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27451 To: davidedmundson, dfaure Cc: ervin, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi updated this revision to Diff 75829. crossi added a comment. Comments REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27059?vs=74799=75829 REVISION DETAIL https://phabricator.kde.org/D27059 AFFECTED FILES src/core/kcoreconfigskeleton.cpp

D27355: POC: Make kstatusnotifieritem available without dbus

jjazeix added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27355 To: vonreth, bcooksley, jjazeix, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27444: Added top area

niccolove updated this revision to Diff 75824. niccolove added a comment. Remove hardcoded values REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=75796=75824 BRANCH top_area (branched from master) REVISION DETAIL

D27444: Added top area

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27445: Move tasks from 3px to 2px

niccolove added a comment. With big panels this is not really a problem, but I feel like a 3px lines takes too much space from the icon space, making it a bit cramped. Here's an example of a theme using a 2px line as well (Sweet KDE, the most downloaded Plasma theme): F8108529:

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. > From the viewpoint of baloo_file, the process just hangs, which is bad. Ok, I can add support for passing the error down to baloo_file. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc:

D27444: Added top area

niccolove added a comment. In D27444#612582 , @ngraham wrote: > This will need CMake changes to actually install it. Isn't this automatically done by the glob? FILE(GLOB widgets widgets/*.svg)

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

crossi marked 9 inline comments as done. crossi added inline comments. INLINE COMMENTS > ervin wrote in kcoreconfigskeleton.h:448 > That's my understanding to have them virtuals in KF6 indeed, that was > introduced by David Edmundson a little while ago. This is necessary because > of the way

D26918: Improve KNotification API docs

apol added inline comments. INLINE COMMENTS > jucato wrote in knotification.h:96 > Maybe we should keep this part that the icon name, especially that it has to > be one that can be found by KIconLoader. Since Qt5 KIconLoader is an implementation detail. Even our apps and frameworks use

D26918: Improve KNotification API docs

broulik added inline comments. INLINE COMMENTS > apol wrote in knotification.h:96 > Since Qt5 KIconLoader is an implementation detail. Even our apps and > frameworks use QIcon::fromTheme, I haven't looked at what KNotifications does > but pretty sure it's using QIcon. It actually sends out

D27460: fix layout size hints for button labels

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY icon sizes and label placements tested correct in several scenarios -

D26918: Improve KNotification API docs

apol added inline comments. INLINE COMMENTS > broulik wrote in knotification.h:96 > It actually sends out the icon name as a string and plasmashell then looks it > up. With QIcon? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26918 To: nicolasfella,