D27928: [VIM Mode] Add g g commands

gikari added a comment. I am not sure where I should add it. Is it supposed to be a new pair of `bug418486` `.h/.cpp` files? Or should the test reside inside `keys.cpp` in big intimidating 500 line wide `MappingTest` function? REPOSITORY R39 KTextEditor REVISION DETAIL

D25302: Remove stale symlink

dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D25302 To: sandsmark, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25302: Remove stale symlink

dfaure added inline comments. INLINE COMMENTS > karchive.cpp:986 > +// link target or be non-relative > +if (QFile::exists(linkName) && linkName != > curEntry->symLinkTarget()) { > +QFile::remove(linkName); This is comparing the name of the

D27913: Icons for emoji categories

guoyunhe added a comment. D27915 is for the change. The ibus dict comes with untranslated categories name. The category names may change. But it seems the dict hasn't been updated that often. REPOSITORY R266 Breeze Icons REVISION DETAIL

D23926: Move "Details" tab to second place in Properties dialog

meven added a comment. In D23926#624753 , @mthw wrote: > @meven So, the first version of this diff is good enough? Well no I missed @ngraham points that still stands. And your current code result with the same effect anyway as long as

D27844: Store and fetch complete view config in and from session config

dhaumann added a comment. I guess we can give this a try. As I understand, though, with this patch you will never be able to use e.g. a global zoom once you change the zoom of a view. This was different before this patch. Which brings me to another point: e.g. zoom should simply zoom

D26983: Enable adding place as first child

gvgeo added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:1059 > { > -KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager, > - text, url, iconName); > +KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager, > text,

D27928: [VIM Mode] Add g g commands

dhaumann added a comment. I like the patch, but please add a unit test before we commit this. See https://github.com/KDE/ktexteditor/tree/master/autotests/src/vimode Could you add one? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate,

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27929: CMake syntax fixes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27929 To: turbov, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel,

D27916: Add Overpass QL highlighting

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Almost good, please fix + ship. INLINE COMMENTS > overpassql.xml:7 > +--> > + extensions="*.overpassql" author="Volker Krause (vkra...@kde.org)" > license="MIT"> > + For

D27913: Icons for emoji categories

apol added a comment. In D27913#624990 , @guoyunhe wrote: > D27915 is for the change. The ibus dict comes with untranslated categories name. The category names may change. But it seems the dict hasn't been

D26983: Enable adding place as first child

gvgeo edited the summary of this revision. REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27152: Introduce FilesystemEntry class

hallas marked 4 inline comments as done. hallas added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:374 > For now just keep it here, I can see now benefit of making it public (even > unexported). > > And thanks for baring with my nitpicking ;-), this now is pretty much

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi updated this revision to Diff 77329. trmdi added a comment. - Check possible actions in determineDropAction REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27951?vs=77298=77329 BRANCH add-dndToMove (branched from master) REVISION DETAIL

D27961: GIT_SILENT Upgrade ECM and KF5 version requirements for 5.68.0 release.

trmdi abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27961 To: trmdi Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27961: GIT_SILENT Upgrade ECM and KF5 version requirements for 5.68.0 release.

trmdi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27961 AFFECTED FILES CMakeLists.txt

D27152: Introduce FilesystemEntry class

hallas added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:374 > Why is the id() a property of the entry now? > > - it does not correspond to anything from the fstab/mtab > - it is only used here to generate the key for the cache > > Please move the id generation back

D27357: Fix infinite recursion in xscreensaver plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R274:3dae871e6b89: Fix infinite recursion in xscreensaver plugin (authored by alnikiforov, committed by broulik). REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE

D27708: Cleanup accounts kded module

bshah accepted this revision. REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27708 REVISION DETAIL https://phabricator.kde.org/D27708 To: nicolasfella, #frameworks, bshah, leinir

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27932 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27279: Port away from QWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R274:5b6d26cd758c: Port away from QWidget (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27279?vs=75345=77252#toc REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

meven created this revision. meven added reviewers: cfeck, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Question: Is there a way to get theme colors for kconfigwidgets rather than a

D27152: Introduce FilesystemEntry class

bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabhandling.cpp:374 > I guess the main reason is that the id is a function of a `FilesystemEntry`, > meaning that the id is computed from the contents of it. You are absolutely > right that it is not picked up directly from the

D27695: WIP: Create a new TopArea element using widgets/toparea svg

mart added a comment. In D27695#621985 , @niccolove wrote: > - Is code on line 51 fine? Lines are a bit long there yeah, is fine.. unfortunately sunch superlong lines end up being very common in QML REPOSITORY R242 Plasma Framework

D26983: Enable adding place as first child

gvgeo added a comment. ping #frameworks REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

meven updated this revision to Diff 77257. meven added a comment. Add @since 5.69 REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27940?vs=77256=77257 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27940 AFFECTED FILES

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

meven updated this revision to Diff 77256. meven added a comment. Remove unnecessary changes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27940?vs=77255=77256 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27940 AFFECTED FILES

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

davidre added a comment. Yes that's a problem that KColorScheme currently lives in KConfigWidgets. Maybe similiar to D27038 and D27039 ? Hopefully we can achieve T12218

D27708: Cleanup accounts kded module

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. With the caveat that i'm not a big pile of brains about the plugin system, this looks like pretty sensible to me :) REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27708

D27704: Drop FindAccountsFileDir.cmake

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Removing unused stuff is always nice, well spotted :) REPOSITORY R155 KAccounts Integration BRANCH cma REVISION DETAIL https://phabricator.kde.org/D27704 To: nicolasfella,

D23926: Move "Details" tab to second place in Properties dialog

meven added a comment. In D23926#538778 , @mthw wrote: > > 3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd want to do something more like this: > > > > > > > > if (plugin == "details" /* this is

D27635: Restore kio-webdav plugin

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Minus that little API funniness, looks pretty good from here :) INLINE COMMENTS > CMakeLists.txt:9 > > -add_library(kaccounts_kio_webdav_plugin MODULE ${kio-webdav_SRCS}) > + >

D27947: Port away from deprecated QList::toSet()

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-kcoredirlister-toset (branched from master) REVISION DETAIL

D27635: Restore kio-webdav plugin

nicolasfella updated this revision to Diff 77279. nicolasfella marked an inline comment as done. nicolasfella added a comment. Rebase REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=76416=77279 BRANCH arcpatch-D27635 REVISION

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1687 > Which part of > > > A common mistake is to do > > did you miss? Oh, I'm sorry. My reading comprehension isn't so good. I am not sure what you are asking of me though. errno access in qdebug streaming is used

D23926: Move "Details" tab to second place in Properties dialog

mthw added a comment. @meven So, the first version of this diff is good enough? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: meven, ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel,

D27635: Restore kio-webdav plugin

nicolasfella updated this revision to Diff 77280. nicolasfella added a comment. - Remove whitespace change REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27635?vs=77279=77280 BRANCH arcpatch-D27635 REVISION DETAIL

D27704: Drop FindAccountsFileDir.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit R155:17ff746ba128: Drop FindAccountsFileDir.cmake (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27704?vs=76561=77278

D27708: Cleanup accounts kded module

This revision was automatically updated to reflect the committed changes. Closed by commit R155:4d36ced449f2: Cleanup accounts kded module (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27708?vs=77182=77277#toc REPOSITORY R155 KAccounts Integration CHANGES

D27635: Restore kio-webdav plugin

nicolasfella added inline comments. INLINE COMMENTS > leinir wrote in kaccountsdplugin.h:57 > This still introduces a API break, though... Which seems especially silly > given the arguments aren't actually used. Perhaps add a new ctor, and have > the one without the arguments call the new one,

D27923: [FileIndexScheduler] Cleanup firstRun handling

broulik added inline comments. INLINE COMMENTS > indexerstate.h:41 > Unavailable, > + Startup, > }; Indentation > indexerconfig.cpp:112 > > +// KF6 TODO: remove > bool IndexerConfig::firstRun() const Please mark them as deprecated in the header file REPOSITORY R293 Baloo

D25454: Prevent a crash when deleting a device Interface

meven abandoned this revision. meven added a comment. Was superseeded by D26117 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D25454 To: meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77271. niccolove added a comment. documentation REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77266=77271 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED

D27444: Added top area

niccolove updated this revision to Diff 77272. niccolove added a comment. Renamed file as plasmoidheader and used scour REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27444?vs=76562=77272 BRANCH top_area (branched from master)

D27872: sftp: fix partial transfer resuming when copying to local

sitter added inline comments. INLINE COMMENTS > bruns wrote in kio_sftp.cpp:1935 > Dependent on the file system, this will no longer catch `partFile.isDir()`. > stat.st_size is only defined for regular files and symlinks, for all other > types it is implementation defined. E.g. XFS and Btrfs

D27873: sftp: do not show creation time when we do not know it

sitter added a comment. In D27873#623582 , @bruns wrote: > Please correct the comment in the code - it depends on the server SFTP implementation. Birth time does not depend on the file system? REPOSITORY R320 KIO Extras REVISION

D26560: Fix selection printing

hoffmannrobert added a comment. In case my last comment was mistakable, I fixed this: > 1. Create a document with just one long line that wraps over two printed pages. I this case, I am not able to print only the selected text properly. but I couldn't fix this: > 2. Say you

D27941: [protocoltojson] Replace foreach with range-for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-protocoltojson (branched from master) REVISION DETAIL

D27941: [protocoltojson] Replace foreach with range-for

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH l-protocoltojson (branched from master) REVISION DETAIL https://phabricator.kde.org/D27941 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack,

D26969: fix type namespace requirement

sitter updated this revision to Diff 77262. sitter added a comment. switch to indexOfMethod, also construct a signature from the slotname. indexOf requires a normalized signature (e.g. `save(QVariantMap)`) REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77263. niccolove added a comment. Correct padding and borders REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76947=77263 BRANCH master REVISION DETAIL

D27695: WIP: Create a new TopArea element using widgets/toparea svg

mart added inline comments. INLINE COMMENTS > PlasmoidHeading.qml:52 > +enabledBorders: { > +var borders = new Array() > +borders.push('LeftBorder') this can be an int and instead of borders.push('LeftBorder') borders |= PlasmaCore.FrameSvg.LeftBorder REPOSITORY

D27502: Create ConfigView an unmanaged ConfigWidget

bport updated this revision to Diff 77269. bport added a comment. rename check to skip and add missing negation for default REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=76517=77269 REVISION DETAIL https://phabricator.kde.org/D27502 AFFECTED

D27941: [protocoltojson] Replace foreach with range-for

This revision was automatically updated to reflect the committed changes. Closed by commit R241:283b8fce056e: [protocoltojson] Replace foreach with range-for (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27941?vs=77270=77273 REVISION

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 323 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/323/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Mar 2020 12:33:17 + Build duration: 7 min 9 sec and counting JUnit Tests Name:

D27871: sftp: fix seekPos + file resuming when part file is of size 11

bruns added inline comments. INLINE COMMENTS > sitter wrote in kio_sftp.cpp:1687 > We do that all over the place. Which part of > A common mistake is to do did you miss? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27871 To: sitter, ngraham, feverfew Cc:

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

bruns added a comment. In D26555#591657 , @ngraham wrote: > Looks like this needs a bit of CMake work to stop installing the old icons: > > # from directory: /home/nate/kde/build/plasma-framework > gmake[2]: *** No rule to make target

D27871: sftp: fix seekPos + file resuming when part file is of size 11

sitter added a comment. In D27871#623593 , @bruns wrote: > In D27871#623542 , @sitter wrote: > > > In D27871#622933 , @bruns wrote: > > > > > Can you

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove updated this revision to Diff 77266. niccolove added a comment. using =| REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=77263=77266 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 AFFECTED FILES

D27695: WIP: Create a new TopArea element using widgets/toparea svg

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27695 To: niccolove, mart Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27839: Properly name the content of the kcmcontrols project

meven added a comment. LGTM REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27950: Assign an icon to action submenus

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Currently, action submenus (X-KDE-Submenu) have no icons. This patch makes it inherit

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REVISION SUMMARY Lots of users request to be able to change the default behavior of the drag action to MoveAction. TEST PLAN With

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

trmdi added reviewers: ngraham, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27871: sftp: fix seekPos + file resuming when part file is of size 11

bruns added inline comments. INLINE COMMENTS > sitter wrote in kio_sftp.cpp:1687 > Oh, I'm sorry. My reading comprehension isn't so good. I am not sure what you > are asking of me though. errno access in qdebug streaming is used all over > our software and this line here isn't even new. If the

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. You need to only apply this logic for files. Try dragging a URL from a web browser to the desktop; now that fails because it can't delete the URL (the fact that "Move" is even

Re: KIO: try to assign an icon to action submenus

Hi Chloe, I just submitted the patch on your behalf: https://phabricator.kde.org/D27950 Built it and seems to work. Hope this helps. Aleix On Sat, Mar 7, 2020 at 12:27 AM Chloe Kudryavtsev wrote: > > Currently, action submenus (X-KDE-Submenu) have no icons. > This patch makes it inherit the

D27950: Assign an icon to action submenus

apol updated this revision to Diff 77295. apol added a comment. oops REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27950?vs=77294=77295 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27950 AFFECTED FILES src/widgets/kfileitemactions.cpp

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns updated this revision to Diff 77309. bruns added a comment. Mark as @deprecated since 5.69 whitespace REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27923?vs=77190=77309 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27923 AFFECTED

D26969: fix type namespace requirement

davidedmundson accepted this revision. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D26969 To: sitter, apol, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27923 To: bruns, #baloo, ngraham Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D27913: Icons for emoji categories

apol added a comment. In D27913#624850 , @ngraham wrote: > It seems like there are two goals here: > > - Use monochrome icons > - Be able to choose which icon is shown in the sidebar. > > I don't have strong opinions about #1, but I

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven added a comment. I added the bug wish https://bugs.kde.org/show_bug.cgi?id=224257 althoug it will require a KCM setting to be feature complete. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure Cc: meven, kde-frameworks-devel,

D27926: Add flameshot tray icons

ngraham retitled this revision from "[breeze-icons] Add flameshot tray icons" to "Add flameshot tray icons". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27926 To: axionl, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27926: [breeze-icons] Add flameshot tray icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Derp, silly me. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27926 To: axionl, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel,

D27913: Icons for emoji categories

ngraham added a comment. It seems like there are two goals here: - Use monochrome icons - Be able to choose which icon is shown in the sidebar. I don't have strong opinions about #1, but I agree that #2 is useful. However do we have to use breeze icons for this? Couldn't we adjust

D27952: Simplify minimum size handling

vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY We don't need to track the minimum size separately anymore, so avoid this getting

D27952: Simplify minimum size handling

vkrause added a comment. The deprecation version is off by one, but that will be fixed when rebasing the entire patch set on 5.69 once 5.68 is released. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27952 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n,

D27953: Properly read string lists from desktop files when parsing the files

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY If we know that a field is a StringList, read it with the XDG string list specific codepath. Otherwise we get something

D26983: Enable adding place as first child

ngraham accepted this revision. ngraham added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:1059 > { > -KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager, > - text, url, iconName); > +KBookmark bookmark =

D27951: Allow users to change dropAction to MoveAction through workspace-option kcm

meven added a comment. And BTW I reported a QT bug relating to the keyboard modifiers not working as expected a while back, making this feature more appealing : https://bugreports.qt.io/browse/QTBUG-79919 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To:

D27926: Add flameshot tray icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:8c73f3f445ee: Add flameshot tray icons (authored by axionl, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27926?vs=77223=77301

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 165 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/165/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 09 Mar 2020 17:38:38 + Build duration: 4 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 272 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/272/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 09 Mar 2020 17:38:38 + Build duration: 3 min 52 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 158 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/158/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Mar 2020 17:38:38 + Build duration: 3 min 23 sec and counting JUnit Tests Name:

D27695: WIP: Create a new TopArea element using widgets/toparea svg

ngraham added a comment. Watch your whitespace. This new file is full of cases where there are spaces on on blank lines or trailing spaces. `git show HEAD` will show you for the latest commit: F8167726: Screenshot_20200309_114735.png Also

D27444: Added top area

ngraham added a comment. The actual component is called `PlasmoidHeading`, but this file is `PlasmoisHeader`. Maybe they should match? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart,

D27953: Properly read string lists from desktop files when parsing the files

apol added a dependent revision: D27954: appstreamrunner: Port to KApplicationTrader. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D27953 To: apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26555: Rename 'nepomuk' Plasma Theme icons to 'search'

ngraham accepted this revision. ngraham added a comment. You're right, it was a local cache. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26555 To: The-Feren-OS-Dev, #plasma, #vdg, ndavis, bruns, ngraham Cc: ngraham, bruns, ndavis, davidre,