D29254: [RenameDialog] Add an arrow indicating direction from src to dest

meven requested changes to this revision. meven added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > renamedialog.cpp:143 > QLabel *m_destPreview; > +QLabel *m_srcToDestArrow; > QScrollArea *m_srcArea; You don't need a member variable for this.

D28624: Print a warning if runner is incompatible with KRunner

This revision was automatically updated to reflect the committed changes. Closed by commit R308:e56def21a286: Print a warning if runner is incompatible with KRunner (authored by davidre). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28624?vs=79487=81486

D29256: [server] Introduce mapped() signal

apol accepted this revision. REPOSITORY R127 KWayland BRANCH introduce-mapped-signal REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

alex updated this revision to Diff 81528. alex added a comment. Add missing KRUNNER_DEPRECATED REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81527=81528 BRANCH deprecations (branched from master) REVISION DETAIL

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz updated this revision to Diff 81529. wojnilowicz added a comment. I see. I've updated the patch. Linking to downloaded library is now possible, and there is a fallback if no library is present. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29274: ECMGeneratePriFile: make the pri files relocatable

dfaure created this revision. dfaure added reviewers: vatra, kfunk, apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Instead of generating QT.KArchive.includes =

D29274: ECMGeneratePriFile: make the pri files relocatable

dfaure updated this revision to Diff 81519. dfaure added a comment. Fix error: regex "[^/]*" matched an empty string. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29274?vs=81506=81519 BRANCH master REVISION DETAIL

D29274: ECMGeneratePriFile: make the pri files relocatable

kossebau added a comment. D29096 also wants to touch those entries, for different reasons. You may want to align here. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol Cc:

D29027: Move document corner fold to top right in two icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:db3ec8680b35: Move document corner fold to top right in two icons (authored by davidhurka, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 55 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/55/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 29 Apr 2020 14:01:04 + Build duration: 5 min 55 sec and counting JUnit Tests Name:

D26604: Check if there is an activatable service when notification service owner changes

nicolasfella abandoned this revision. nicolasfella added a comment. I favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack,

D29027: Move document corner fold to top right in two icons

ngraham added a comment. You can do a regular old git push if you cherry-pick the commit onto master. I'll land it for you though. REPOSITORY R266 Breeze Icons BRANCH update-document-close REVISION DETAIL https://phabricator.kde.org/D29027 To: davidhurka, ndavis, ngraham Cc:

D29096: Prefix includes and libs dir with QT_SYSROOT

dfaure added a comment. Hi @ablu, Could you test if my patch in D29274 solves your problem? By making these lines relative to the location of the .pri file, it should work very well in a sysroot context as well. REPOSITORY R240 Extra CMake Modules

D29021: Remove checks for notification service and fallback to KPassivePopup

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Verified that close signal works and that quitting plasma, sending a notification, then has the notification show up when plasma is started. Please wait until after Frameworks tagging

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. looks good! yours is probably a bit more "CMakeish"! So feel free to continue with that one and close this. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure, kossebau,

D29096: Prefix includes and libs dir with QT_SYSROOT

dfaure added a comment. Thanks for the quick test! I'll indeed proceed with the other one, which is more generic (our use case isn't related to QT_SYSROOT). Actually: can you add your comment (that it works for you) in the other review request, so people know it's been tested by

D29281: Deprecate defunct functions

alex created this revision. alex added reviewers: Plasma, broulik, davidedmundson, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY As in T12163 explained

D26605: Remove fallback to KPassivePopup

nicolasfella abandoned this revision. nicolasfella added a comment. In favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26605 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n,

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. Hi @dfaure. It looks pretty much the same and I think it should work for us. I will kick off a build to confirm. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure,

D29281: Deprecate defunct functions

alex updated this revision to Diff 81539. alex added a comment. Use mordern macros Thanks :-) REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81528=81539 BRANCH deprecations (branched from master) REVISION DETAIL

D29281: Deprecate defunct functions

kossebau added a comment. Looks good, almost :) It's a bit complicated on first use (well, also still ater, but no better solution was found to get version-controlled API deprecation with C++ for now). INLINE COMMENTS > abstractrunner.cpp:221 > > void

D29281: Deprecate defunct functions

alex added inline comments. INLINE COMMENTS > kossebau wrote in abstractrunner.h:154 > The text in the API dox can stay "Since 5.0". > > The only crititical thing where the number of an older, already released > version should not be used is the KRUNNER_ENABLE_DEPRECATED_SINCE macro. >

D29281: Deprecate defunct functions

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in abstractrunner.cpp:221 > Given EXCLUDE_DEPRECATED_BEFORE_AND_AT is used with KRunner, you want to also > wrap all the implementations of the now deprecated API with the BUILD variant > of the macro, so here for example: > >

D29281: Deprecate defunct functions

alex updated this revision to Diff 81546. alex added a comment. Wrap macro about single method, change deprecation text And thanks for the feedback and explanations :-). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81543=81546 BRANCH

Re: Having $(framework)_global.h headers (was: Re: building KF5 projects against a different Qt5 version [...])

On lundi 27 avril 2020 14:28:42 CEST Friedrich W. H. Kossebau wrote: > Am Sonntag, 26. April 2020, 16:12:31 CEST schrieb Friedrich W. H. Kossebau: > > Am Sonntag, 26. April 2020, 15:46:35 CEST schrieb David Faure: > > > On Sunday, April 26, 2020 3:21:34 PM CEST René J.V. Bertin wrote: > > > >

Re: Having $(framework)_global.h headers (was: Re: building KF5 projects against a different Qt5 version [...])

Am Mittwoch, 29. April 2020, 21:41:37 CEST schrieb David Faure: > On lundi 27 avril 2020 14:28:42 CEST Friedrich W. H. Kossebau wrote: > > Am Sonntag, 26. April 2020, 16:12:31 CEST schrieb Friedrich W. H. Kossebau: > > > Am Sonntag, 26. April 2020, 15:46:35 CEST schrieb David Faure: > > > > On

D29281: Deprecate defunct functions

alex updated this revision to Diff 81543. alex added a comment. Wrap implementations REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81539=81543 BRANCH deprecations (branched from master) REVISION DETAIL https://phabricator.kde.org/D29281

D29281: Deprecate defunct functions

kossebau added a comment. Be aware that just adding a plain KRUNNER_DEPRECATED is not up-to-modern KF standards :) Please see cf5f7b4040a77ae69452d58bc189dcc3baaedd92 what macros there are now and how to apply

Re: Information regarding upcoming Gitlab Migration

On 2020 prilula d. 28id 13:35:22 CEST Ben Cooksley wrote: > Would some form of git alias/custom command script that works similar > to the following be suitable? > > git kde-clone skrooge > > That script would then search the appropriate groups (ignoring any > personal repositories including

D29274: ECMGeneratePriFile: make the pri files relocatable

ablu added a comment. My reason is basically the same. Will try this version too. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D29278: Port KWin to KWaylandServer

apol created this revision. apol added reviewers: KWin, Plasma, Frameworks. Herald added a project: KWin. Herald added a subscriber: kwin. apol requested review of this revision. REVISION SUMMARY Away from KWayland::Server and KF5WaylandServer. TEST PLAN Builds, ran nested session

D29258: Don't use notifybysnore.h on MSYS2

wojnilowicz added a comment. In D29258#659423 , @brute4s99 wrote: > > SnoreToast fails to build on MSYS2 due to missing > > which apparently is not available for this compiler. > > I'm sorry, missing what exactly? Missing

D29292: Port KKeySequenceItem to QQC2

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This implicitly fixes a bug where space is used in the shortcut

D29292: Port KKeySequenceItem to QQC2

davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in KeySequenceItem.qml:57 > Are we able to use some form of units? Hardcoding this seems wrong. > Can we use the non-attached version here please since it's not likely It's the worst! > Are we able to use some form of units?

D29208: [NestedListHelper] Improve indentation code

dfaure added inline comments. INLINE COMMENTS > nestedlisthelper.cpp:87 > +QTextBlock nextBlock = block.next(); > +if (!block.isValid()) { > +return false; So the last block cannot be unindented? How come? REPOSITORY R310 KTextWidgets REVISION DETAIL

D29292: Port KKeySequenceItem to QQC2

ngraham added a reviewer: davidre. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29292 To: davidedmundson, #plasma, davidre Cc: cblack, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

kossebau added a comment. Looks good to me now, just caring about the use of the deprecation macros (no clue about the actual code, has to be Kai or someone else with krunner knowledge (if there is) to review). Discussing this I see a small flaw in the case of retrospective deprecation

D29292: Port KKeySequenceItem to QQC2

broulik added inline comments. INLINE COMMENTS > KeySequenceItem.qml:57 > +ToolTip.visible: hovered > +ToolTip.delay: 1000 > +ToolTip.text: _tr.i18n("Click on the button, then enter the > shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl > key

D29292: Port KKeySequenceItem to QQC2

cblack added inline comments. INLINE COMMENTS > KeySequenceItem.qml:57 > +ToolTip.visible: hovered > +ToolTip.delay: 1000 > +ToolTip.text: _tr.i18n("Click on the button, then enter the > shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl > key

D29027: Move document corner fold to top right in two icons

davidhurka added a comment. Is it possible to land this without arc? I can’t get arc running on my current system. :( If you want this in the next release, you too may land it for me. Otherwise I will land it when I have my own system back, i. e. in a few weeks. I will change the

D29231: Add keyboard_shortcuts_inhibit protocol

bport retitled this revision from "[WIP] Add keyboard_shortcuts_inhibit protocol" to "Add keyboard_shortcuts_inhibit protocol". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29231 To: bport, zzag, davidedmundson, apol Cc: romangg, crossi, kde-frameworks-devel,

D29163: RFC: Add document-replace icon (Like for Overwrite action)

davidhurka added a comment. Then I will remove the border. I think it looks slightly better, because the bottom-left corner is visible this way; and the 16px version looks to chunky otherwise. I will update this revision when I have my system back. Otherwise, anyone else may take the

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/14/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 29 Apr 2020 09:02:55 + Build duration: 10 min and counting JUnit Tests Name:

D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

bport updated this revision to Diff 81491. bport added a comment. Simplify code arround QHash and QPair REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29231?vs=81386=81491 REVISION DETAIL https://phabricator.kde.org/D29231 AFFECTED FILES

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir updated this revision to Diff 81492. ahmadsamir added a comment. Don't use a member var for an object that's only used in one function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29254?vs=81431=81492 BRANCH l-srt-to-dest (branched from master)

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in renamedialog.cpp:143 > You don't need a member variable for this. Indeed, it's only used in one place (too much copy/paste...). REPOSITORY R241 KIO REVISION DETAIL

D29231: Add keyboard_shortcuts_inhibit protocol

crossi added a comment. some code style related comments INLINE COMMENTS > test_keyboard_shortcuts_inhibitor_interface.cpp:109 > +m_manager = m_display.createKeyboardShortcutsInhibitManager(this); > + QVERIFY(m_serverCompositor->isValid()); > +connect(m_serverCompositor,

D29231: Add keyboard_shortcuts_inhibit protocol

davidedmundson added a comment. Let's wait for the new kwaylandserver repo before pushing. But ++, looks good. INLINE COMMENTS > keyboard_shortcuts_inhibit_interface.cpp:21 > + > +class KeyboardShortcutsInhibitorInterface::Private : public >

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. Sure! Though... How does it come that you do not have SYSROOT set in your case? Won't that break in other cases? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: dfaure,

D29274: ECMGeneratePriFile: make the pri files relocatable

ablu added a comment. The Build worked. So this solves the issue for me! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29274 To: dfaure, vatra, kfunk, apol Cc: ablu, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy,

D28647: Fix KIO::Scheduler::emitReparseSlaveConfiguration() to work if called twice in same process

marten added a comment. I've thought about this a bit more and can't find any explanation as to why the DBus signal does not loop back to the sending process as well as all other listeners. It may be an unspecified detail of the DBus implementation that could possibly change at any time

D29231: Add keyboard_shortcuts_inhibit protocol

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in keyboard_shortcuts_inhibit_interface.cpp:21 > Q_DECL_PRIVATE You've probably meant Q_DECL_HIDDEN, right? On an unrelated note: there are valid arguments against nested private classes so it would be really nice if we

D29231: Add keyboard_shortcuts_inhibit protocol

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:21 > You've probably meant Q_DECL_HIDDEN, right? > > On an unrelated note: there are valid arguments against nested private > classes so it would be really nice if we revisit this

[sysadmin/repo-metadata] projects: projects: move new wayland repos to their final place

Git commit 53d913c3af459024d359c13def87db8913d8ed6b by Bhushan Shah. Committed on 29/04/2020 at 11:09. Pushed by bshah into branch 'master'. projects: move new wayland repos to their final place - plasma-wayland-protocols -> frameworks - kwayland-server -> kde/workspace Ref: T13052 CCMAIL:

Information regarding upcoming Gitlab Migration: clarifications

Good afternoon, [Please keep sysad...@kde.org list or bs...@kde.org in the CC for replies] I want to clarify some bits for which we have gotten a questions about, - Non unique naming: There's some teams which prefer if we dropped the namespace- part from their name which we have added. While