On 25/11/2013 07:45, Stephen Kelly wrote:
Jonathan Riddell wrote:
developer files matter to some people to be co-installable.
Header files and others can probably be moved to a
separate directory
Can you be more specific about why this is easy with header files? Does this
refer to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113975/
---
(Updated Nov. 25, 2013, 11:39 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113996/#review44385
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114003/#review44384
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114003/
---
(Updated Nov. 25, 2013, 12:26 p.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-framework_master_qt5/915/changes
Changes:
[mklapetek] Make the calendar applet follow current locale with first day in
week
[mklapetek] Add some docs to Calendar binginds
--
Started by remote host 127.0.0.1 with note:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113996/
---
(Updated Nov. 25, 2013, 12:26 p.m.)
Status
--
This change has been
See http://build.kde.org/job/kdelibs_frameworks_qt5/1755/changes
Changes:
[aleixpol] Fix some porting notes
[aleixpol] Reduce private headers usage from KDE4Support
[aleixpol] Install needed headers for FrameworksIntegration
--
[...truncated 5607
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113910/
---
(Updated Nov. 25, 2013, 12:35 p.m.)
Review request for KDE Frameworks.
See http://build.kde.org/job/kdelibs_frameworks_qt5/1756/changes
Changes:
[aleixpol] Add superbuild entries for tier4
--
[...truncated 5542 lines...]
Linking CXX executable kptyprocesstest
[ 53%] [ 53%] Built target kdeinit5
Building CXX object
See http://build.kde.org/job/plasma-framework_master_qt5/916/changes
Changes:
[mklapetek] Revert capitalizing the month's name
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 4 in workspace
See http://build.kde.org/job/kdelibs_frameworks_qt5/1757/changes
Changes:
[aleixpol] Rename includes following publication of KIconEngine
--
[...truncated 7489 lines...]
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113877/#review44397
---
Any chance for a review? We really need to tie up loose ends
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
To get in this patch would benefit from being based on the frameworks
branch and go into kdeclarative.
Kevin Ottens wrote:
Any chance for an update?
Denis Kuplyakov wrote:
Yes I will finish it, when have time. There are many
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113503/
---
(Updated Nov. 25, 2013, 1:56 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114004/
---
(Updated Nov. 25, 2013, 1:57 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114037/#review44401
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 22, 2013, 5:52
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114044/#review44402
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114050/#review44403
---
tier1/kwindowsystem/tests/blurbehindtest.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114090/#review44404
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 24, 2013, 10:17
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113910/#review44406
---
tier1/karchive/examples/tarlocalfiles/main.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113910/
---
(Updated Nov. 25, 2013, 2:46 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114111/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
On Nov. 25, 2013, 3:49 p.m., Maarten De Meyer wrote:
Are you sure this is needed? KConfigWidgets already includes KGuiAddons and
KIconThemes doesn't link with KGuiAddons directly.
You say it complains so you are still able to build?
Next version of CMake should fix this.
Bhushan
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114111/
---
(Updated Nov. 25, 2013, 9:50 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114038/
---
(Updated Nov. 25, 2013, 4:26 p.m.)
Review request for KDE Frameworks.
On Nov. 24, 2013, 10:58 a.m., David Faure wrote:
tier1/kcoreaddons/src/lib/kaboutdata.cpp, line 957
http://git.reviewboard.kde.org/r/114038/diff/1/?file=219248#file219248line957
(LOL, most likely someone forgot to call addAuthor, but OK :)
Wrong usage of tr()
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114090/#review3
---
This review has been submitted with commit
On Nov. 25, 2013, 1:48 p.m., Kevin Ottens wrote:
Any chance for a review? We really need to tie up loose ends now.
I think that this is a very nice piece of work, and the new data-driven test
also looks good to me. The only thing I'm concerned about is the run time of
the test - I like
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113877/#review6
---
AFAIK the rule for Qt unittests is that they should run in
See http://build.kde.org/job/kdelibs_frameworks_qt5/1767/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114038/#review44452
---
Ship it!
Ship It!
- David Faure
On Nov. 25, 2013, 4:26
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review44453
---
Ship it!
I understood that it is important not to have to add
Review board doesn't appear to be sending emails for my review requests,
so -- since some of them are a dependency of Kevin's repo splitting --
here they are:
Fix KIO superbuild dependencies
https://git.reviewboard.kde.org/r/114127/
Move kmediaplayer to tier3
It occurred to me that KGuiAddons might not be the best place for the
imageformat plugins, and that they should maybe become their own
framework (either tier1 or tier4).
The only thing that relates the KGuiAddons library and the imageformat
plugins is that they are both to do with QtGui. Each
See http://build.kde.org/job/kdelibs_frameworks_qt5/1768/changes
Changes:
[aleixpol] Integrate KAboutData and QCommandLineParser
[aleixpol] Port makekdewidgets to KAboutData
--
[...truncated 3959 lines...]
[ 32%] Building CXX object
See http://build.kde.org/job/kdelibs_frameworks_qt5/1769/changes
Changes:
[aleixpol] makekdewidgets doesn't depend on i18n
--
[...truncated 5096 lines...]
Linking CXX shared library libKCrash.so
[ 47%] Building CXX object
See http://build.kde.org/job/kdelibs_frameworks_qt5/1770/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
38 matches
Mail list logo
