---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/
---
(Updated Dec. 31, 2013, 6:24 a.m.)
Status
--
This change has been di
Hi!
I'm porting KGeography to KF5, and I found some issues.
*KConfigDialog::setHelp()*
KConfigDialog* dialog = new KConfigDialog(this, "settings",
kgeographySettings::self());
dialog->setHelp("configuration", "kgeography");
It gives me the following error:
/home/david/devel/kgeography/src/kgeo
On Monday 30 December 2013 18:54:45 Hugo Pereira Da Costa wrote:
> No no: in KDE4, oxygen was not inheriting from KStyle but QCommonStyle.
> In KF5 it is inheriting again from the (much cleaned-up) KStyle class.
> So that I'm all for moving it (or any KF5 equivalent) to KStyle.
> (just not the way
On Monday 30 December 2013 23:03:03 David Faure wrote:
> In fact, the current file could just include all this, for compat.
This is blocked by https://bugs.kde.org/329444
So either I remove the current file, or I postpone the splitting.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Wo
> On Dec. 30, 2013, 12:31 p.m., David Faure wrote:
> > I don't really understand why this fails
> >
> > IMHO it *did* make sense for the KToolBar unittest to check which icon size
> > the toolbars will get by default.
> >
> > The value of 2 on build.kde.org, for instance, should never neve
> On Dec. 30, 2013, 9:54 p.m., David Faure wrote:
> > Ah I see, the issue is when calling setLocationText() with a relative URL.
> >
> > The KDE4 code (inside setLocationText) would say
> >
> > if (url.hasPath()) {
> > if (!url.directory().isEmpty()) {
> > q->setUrl(...);
> > }
> On Dec. 30, 2013, 9:54 p.m., David Faure wrote:
> > Ah I see, the issue is when calling setLocationText() with a relative URL.
> >
> > The KDE4 code (inside setLocationText) would say
> >
> > if (url.hasPath()) {
> > if (!url.directory().isEmpty()) {
> > q->setUrl(...);
> > }
On Monday 30 December 2013 14:05:21 Dominik Haumann wrote:
> Hi,
>
> the KTextEditor interfaces as well as Kate and KWrite are ported to the
> frameworks libs and Qt5 for some weeks now (big thanks to Michal!).
> It's quite stable and therefore it can safely be included into kdesrc-build
> by defa
> On Dec. 30, 2013, 9:54 p.m., David Faure wrote:
> > Ah I see, the issue is when calling setLocationText() with a relative URL.
> >
> > The KDE4 code (inside setLocationText) would say
> >
> > if (url.hasPath()) {
> > if (!url.directory().isEmpty()) {
> > q->setUrl(...);
> > }
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/#review46461
---
Ah I see, the issue is when calling setLocationText() with a r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/
---
(Updated Dec. 30, 2013, 9 p.m.)
Review request for KDE Frameworks.
Chan
> On Dec. 30, 2013, 2:23 p.m., David Faure wrote:
> > This looks wrong to me. This code was in KFileWidget in kde4 already. OTOH
> > the port of KEncodingFileDialog to KFileWidget is what's new in frameworks.
> > So I'd be quite tempted to say that the bug is in the way
> > KEncodingFileDialog
On 12/30/2013 06:50 PM, David Faure wrote:
On Monday 30 December 2013 17:20:23 Hugo Pereira Da Costa wrote:
Indeed oxygen (@KDE4) was using:
connect( KGlobalSettings::self(), SIGNAL(kdisplayPaletteChanged()),
this, SLOT(globalPaletteChanged()) );
Interesting, so every style had to do this, rat
On Monday 30 December 2013 17:20:23 Hugo Pereira Da Costa wrote:
> Indeed oxygen (@KDE4) was using:
>
> connect( KGlobalSettings::self(), SIGNAL(kdisplayPaletteChanged()),
> this, SLOT(globalPaletteChanged()) );
Interesting, so every style had to do this, rather than KStyle doing it
centrally.
On 12/30/2013 03:17 PM, David Faure wrote:
On Monday 30 December 2013 14:52:51 Mark Gaiser wrote:
Could something similar be done in kstyle constructor's ?
(though I have no clue about which signal things should connect to).
We just have to decide on a dbus signal name (see further down for exa
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/#review46448
---
This looks wrong to me. This code was in KFileWidget in kde4 a
On Monday 30 December 2013 14:52:51 Mark Gaiser wrote:
> > Could something similar be done in kstyle constructor's ?
> > (though I have no clue about which signal things should connect to).
We just have to decide on a dbus signal name (see further down for examples).
Who emits it? Some kcontrol m
Hello all,
Just a quick reminder:
The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris
time.
See you for the (real) last meeting of 2013!
Regards.
--
Kévin Ottens, http://ervin.ipsquad.net
KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description:
On Monday 30 December 2013 14:59:51 Aleix Pol wrote:
> It only has the lowercase headers, uppercase headers are installed from
> another command:
> install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/KCoreAddons DESTINATION
> ${INCLUDE_INSTALL_DIR} COMPONENT Devel )
Ah, right.
Sounds good to me as it
On Mon, Dec 30, 2013 at 11:42 AM, David Faure wrote:
> On Monday 30 December 2013 01:26:52 Aleix Pol wrote:
> > On Sun, Dec 29, 2013 at 8:10 PM, David Faure wrote:
> > > On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote:
> > > > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote:
>
On Mon, Dec 30, 2013 at 2:11 PM, Hugo Pereira Da Costa
wrote:
> On 12/30/2013 02:08 PM, Hugo Pereira Da Costa wrote:
>
> On 12/30/2013 12:42 PM, David Faure wrote:
>
> On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote:
>
> Hi,
>
> if I play around with Kate on KF5, it laggs like hell th
On 12/30/2013 02:08 PM, Hugo Pereira Da Costa wrote:
On 12/30/2013 12:42 PM, David Faure wrote:
On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote:
Hi,
if I play around with Kate on KF5, it laggs like hell the whole time.
I tried to profile, but guess I am stuck a bit.
#10 0x7f
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114727/#review46446
---
The commit message is a bit misleading btw: these codecs are n
On 12/30/2013 12:42 PM, David Faure wrote:
On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote:
Hi,
if I play around with Kate on KF5, it laggs like hell the whole time.
I tried to profile, but guess I am stuck a bit.
#10 0x73fbeaa0 in KConfig::reparseConfiguration (this=0x68
Hi,
the KTextEditor interfaces as well as Kate and KWrite are ported to the
frameworks libs and Qt5 for some weeks now (big thanks to Michal!).
It's quite stable and therefore it can safely be included into kdesrc-build
by default.
The required change is:
diff --git a/kf5-qt5-build-include b/kf
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114726/#review46444
---
I don't really understand why this fails
IMHO it *did* ma
> On Sun, Dec 29, 2013 at 08:07:38PM +0100, Christoph Cullmann wrote:
> > if I play around with Kate on KF5, it laggs like hell the whole time.
> >
> > I tried to profile, but guess I am stuck a bit.
>
> How did you profile? I'd recommend using 'perf', it's pretty simple to use:
>
> - perf reco
> On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote:
> > Hi,
> >
> > if I play around with Kate on KF5, it laggs like hell the whole time.
> >
> > I tried to profile, but guess I am stuck a bit.
> >
> > #10 0x73fbeaa0 in KConfig::reparseConfiguration (this=0x688130) at
> > /ho
On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote:
> Hi,
>
> if I play around with Kate on KF5, it laggs like hell the whole time.
>
> I tried to profile, but guess I am stuck a bit.
>
> #10 0x73fbeaa0 in KConfig::reparseConfiguration (this=0x688130) at
> /home/cullmann/local/
On Monday 30 December 2013 01:26:52 Aleix Pol wrote:
> On Sun, Dec 29, 2013 at 8:10 PM, David Faure wrote:
> > On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote:
> > > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote:
> > > > > Hi,
> > > > > Here's a patch adding CamelCase headers
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/#review46435
---
Ship it!
Ship It!
- David Faure
On Dec. 29, 2013, 11:50 p.
On 30/12/13 00:26, Aleix Pol wrote:
> No, it creates a variable called KCoreAddons_HEADERS which is passed to
> the install() command. ECM_GENERATE_HEADERS doesn't install anything, we
> decided to do it like that to minimize the magic factor.
>
> Please take a look at the function documentation,
32 matches
Mail list logo
