---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115225/#review48735
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115225/
---
(Updated Feb. 1, 2014, 8:03 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115325/
---
(Updated Feb. 1, 2014, 9:30 a.m.)
Review request for KDE Frameworks.
On Dec. 8, 2013, 1:08 p.m., Bhushan Shah wrote:
plasma/generic/dataengines/mouse/mouseengine.cpp, line 34
https://git.reviewboard.kde.org/r/114260/diff/2/?file=222312#file222312line34
You should call init() here. Have a look at
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115415/#review48737
---
Ship it!
Oops, well spotted.
- David Faure
On Jan. 31,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115419/
---
(Updated Feb. 1, 2014, 11 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115419/
---
(Updated Feb. 1, 2014, 11:02 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/#review48742
---
Ship it!
Ship It!
- Alex Merry
On Feb. 1, 2014, 7:40
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115325/#review48743
---
Ship it!
Looks good, other than the one issue below:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115419/#review48744
---
If this is going to be split, I think the KCompletionMatches
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115421/
---
Review request for KDE Frameworks.
Repository: frameworkintegration
On Friday 24 January 2014 20:33:14 Valentin Rusu wrote:
On Saturday, January 25, 2014 01:49:51 AM Michael Palimaka wrote:
On 01/24/2014 09:21 AM, Alex Merry wrote:
On 23/01/14 21:50, Valentin Rusu wrote:
On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote:
On 01/23/2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/#review48745
---
This is the only framework that installs a config-foo.h file,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115415/#review48746
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115415/
---
(Updated Feb. 1, 2014, 3:18 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115416/
---
(Updated Feb. 1, 2014, 3:35 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115416/#review48747
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115423/
---
Review request for KDE Frameworks, Kevin Ottens and Jonathan Riddell.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115423/#review48748
---
README.md
On Feb. 1, 2014, 5:42 p.m., Michael Palimaka wrote:
Note that the listed license, and the actual file licenses are a little bit
murky in this (and most other frameworks). Here, we have some files that are
LGPL-2 or later, some are LGPL-2.1 or later, and some that just say LGPL
without any
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115423/
---
(Updated Feb. 1, 2014, 5:52 p.m.)
Review request for KDE Frameworks and
On Feb. 1, 2014, 5:42 p.m., Michael Palimaka wrote:
Michael Palimaka wrote:
Note that the listed license, and the actual file licenses are a little
bit murky in this (and most other frameworks). Here, we have some files that
are LGPL-2 or later, some are LGPL-2.1 or later, and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115426/
---
Review request for KDE Frameworks and John Layt.
Repository: kprintutils
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/#review48754
---
Build checked with 2.8.12.0, but see below.
On 02/01/2014 08:22 PM, Alex Merry wrote:
(CC'ing Stephen because this is relevant to the version of
find_dependency in CMake master)
Currently, the find_dependency() macro does not pass the QUIET argument
to find_package unless the parent package was being found quietly. This
means that
On 01/02/14 20:21, Stephen Kelly wrote:
On 02/01/2014 08:22 PM, Alex Merry wrote:
So, I think that find_dependency should pass QUIET to find_package
whether or not the parent package is being found quietly.
Do other people agree?
I agree with the problem statement, but not the solution
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115430/
---
Review request for KDE Frameworks.
Repository: kimageformats
See http://build.kde.org/job/kxmlgui_master_qt5/35/
--
Started by remote host 127.0.0.1 with note: Triggered by commit
Building remotely on LinuxSlave - 3 in workspace
http://build.kde.org/job/kxmlgui_master_qt5/ws/
Running Prebuild steps
On 02/02/2014 12:45 AM, Alex Merry wrote:
On 01/02/14 20:21, Stephen Kelly wrote:
On 02/01/2014 08:22 PM, Alex Merry wrote:
So, I think that find_dependency should pass QUIET to find_package
whether or not the parent package is being found quietly.
Do other people agree?
I agree with the
29 matches
Mail list logo
